[INFO] crate serdeconv 0.3.0 is already in cache [INFO] extracting crate serdeconv 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/serdeconv/0.3.0 [INFO] extracting crate serdeconv 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serdeconv/0.3.0 [INFO] validating manifest of serdeconv-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of serdeconv-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing serdeconv-0.3.0 [INFO] finished frobbing serdeconv-0.3.0 [INFO] frobbed toml for serdeconv-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/serdeconv/0.3.0/Cargo.toml [INFO] started frobbing serdeconv-0.3.0 [INFO] finished frobbing serdeconv-0.3.0 [INFO] frobbed toml for serdeconv-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serdeconv/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting serdeconv-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/serdeconv/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 617e44f2e5ea2da18f62414388f5cbcddddf430f3f2c50d1f262d03fe18b43b4 [INFO] running `"docker" "start" "-a" "617e44f2e5ea2da18f62414388f5cbcddddf430f3f2c50d1f262d03fe18b43b4"` [INFO] [stderr] Compiling trackable_derive v0.1.2 [INFO] [stderr] Checking trackable v0.2.21 [INFO] [stderr] Checking serdeconv v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let json =` [INFO] [stderr] --> src/convert_json.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | let json = track!(serde_json::to_writer(writer, value).map_err(Error::from))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/convert_json.rs:64:8 [INFO] [stderr] | [INFO] [stderr] 64 | Ok(json) [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 64 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let json =` [INFO] [stderr] --> src/convert_json.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | / let json = track!(serde_json::to_writer_pretty(writer, value).map_err( [INFO] [stderr] 74 | | Error::from, [INFO] [stderr] 75 | | ))?; [INFO] [stderr] | |________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/convert_json.rs:76:8 [INFO] [stderr] | [INFO] [stderr] 76 | Ok(json) [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 76 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let json =` [INFO] [stderr] --> src/convert_json.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | let json = track!(serde_json::to_writer(writer, value).map_err(Error::from))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/convert_json.rs:64:8 [INFO] [stderr] | [INFO] [stderr] 64 | Ok(json) [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 64 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let json =` [INFO] [stderr] --> src/convert_json.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | / let json = track!(serde_json::to_writer_pretty(writer, value).map_err( [INFO] [stderr] 74 | | Error::from, [INFO] [stderr] 75 | | ))?; [INFO] [stderr] | |________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/convert_json.rs:76:8 [INFO] [stderr] | [INFO] [stderr] 76 | Ok(json) [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 76 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.45s [INFO] running `"docker" "inspect" "617e44f2e5ea2da18f62414388f5cbcddddf430f3f2c50d1f262d03fe18b43b4"` [INFO] running `"docker" "rm" "-f" "617e44f2e5ea2da18f62414388f5cbcddddf430f3f2c50d1f262d03fe18b43b4"` [INFO] [stdout] 617e44f2e5ea2da18f62414388f5cbcddddf430f3f2c50d1f262d03fe18b43b4