[INFO] crate serde_urlencoded 0.5.4 is already in cache
[INFO] extracting crate serde_urlencoded 0.5.4 into work/ex/clippy-test-run/sources/stable/reg/serde_urlencoded/0.5.4
[INFO] extracting crate serde_urlencoded 0.5.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde_urlencoded/0.5.4
[INFO] validating manifest of serde_urlencoded-0.5.4 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of serde_urlencoded-0.5.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing serde_urlencoded-0.5.4
[INFO] finished frobbing serde_urlencoded-0.5.4
[INFO] frobbed toml for serde_urlencoded-0.5.4 written to work/ex/clippy-test-run/sources/stable/reg/serde_urlencoded/0.5.4/Cargo.toml
[INFO] started frobbing serde_urlencoded-0.5.4
[INFO] finished frobbing serde_urlencoded-0.5.4
[INFO] frobbed toml for serde_urlencoded-0.5.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde_urlencoded/0.5.4/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting serde_urlencoded-0.5.4 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/serde_urlencoded/0.5.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 5d36d8d5e6bc3fd33759af108103a7470186405df9b2fdad4f9a0170c5daf852
[INFO] running `"docker" "start" "-a" "5d36d8d5e6bc3fd33759af108103a7470186405df9b2fdad4f9a0170c5daf852"`
[INFO] [stderr]     Checking serde_urlencoded v0.5.4 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ser/key.rs:40:19
[INFO] [stderr]    |
[INFO] [stderr] 40 |         KeySink { end: end }
[INFO] [stderr]    |                   ^^^^^^^^ help: replace it with: `end`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ser/pair.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |             urlencoder: urlencoder,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `urlencoder`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/ser/pair.rs:222:63
[INFO] [stderr]     |
[INFO] [stderr] 222 |                     self.state = PairState::WaitingForValue { key: key };
[INFO] [stderr]     |                                                               ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ser/part.rs:13:26
[INFO] [stderr]    |
[INFO] [stderr] 13 |         PartSerializer { sink: sink }
[INFO] [stderr]    |                          ^^^^^^^^^^ help: replace it with: `sink`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ser/value.rs:22:13
[INFO] [stderr]    |
[INFO] [stderr] 22 |             urlencoder: urlencoder,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `urlencoder`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ser/value.rs:23:13
[INFO] [stderr]    |
[INFO] [stderr] 23 |             key: key,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ser/mod.rs:52:22
[INFO] [stderr]    |
[INFO] [stderr] 52 |         Serializer { urlencoder: urlencoder }
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `urlencoder`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ser/key.rs:40:19
[INFO] [stderr]    |
[INFO] [stderr] 40 |         KeySink { end: end }
[INFO] [stderr]    |                   ^^^^^^^^ help: replace it with: `end`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ser/pair.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |             urlencoder: urlencoder,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `urlencoder`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/ser/pair.rs:222:63
[INFO] [stderr]     |
[INFO] [stderr] 222 |                     self.state = PairState::WaitingForValue { key: key };
[INFO] [stderr]     |                                                               ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ser/part.rs:13:26
[INFO] [stderr]    |
[INFO] [stderr] 13 |         PartSerializer { sink: sink }
[INFO] [stderr]    |                          ^^^^^^^^^^ help: replace it with: `sink`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ser/value.rs:22:13
[INFO] [stderr]    |
[INFO] [stderr] 22 |             urlencoder: urlencoder,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `urlencoder`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ser/value.rs:23:13
[INFO] [stderr]    |
[INFO] [stderr] 23 |             key: key,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ser/mod.rs:52:22
[INFO] [stderr]    |
[INFO] [stderr] 52 |         Serializer { urlencoder: urlencoder }
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `urlencoder`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ser/part.rs:111:40
[INFO] [stderr]     |
[INFO] [stderr] 111 |         self.sink.serialize_static_str(name.into())
[INFO] [stderr]     |                                        ^^^^^^^^^^^ help: consider removing `.into()`: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ser/part.rs:119:40
[INFO] [stderr]     |
[INFO] [stderr] 119 |         self.sink.serialize_static_str(variant.into())
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^ help: consider removing `.into()`: `variant`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/ser/mod.rs:445:52
[INFO] [stderr]     |
[INFO] [stderr] 445 |             let key = self.key.as_ref().ok_or_else(|| Error::no_key())?;
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::no_key`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ser/part.rs:111:40
[INFO] [stderr]     |
[INFO] [stderr] 111 |         self.sink.serialize_static_str(name.into())
[INFO] [stderr]     |                                        ^^^^^^^^^^^ help: consider removing `.into()`: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ser/part.rs:119:40
[INFO] [stderr]     |
[INFO] [stderr] 119 |         self.sink.serialize_static_str(variant.into())
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^ help: consider removing `.into()`: `variant`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/ser/mod.rs:445:52
[INFO] [stderr]     |
[INFO] [stderr] 445 |             let key = self.key.as_ref().ok_or_else(|| Error::no_key())?;
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::no_key`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.34s
[INFO] running `"docker" "inspect" "5d36d8d5e6bc3fd33759af108103a7470186405df9b2fdad4f9a0170c5daf852"`
[INFO] running `"docker" "rm" "-f" "5d36d8d5e6bc3fd33759af108103a7470186405df9b2fdad4f9a0170c5daf852"`
[INFO] [stdout] 5d36d8d5e6bc3fd33759af108103a7470186405df9b2fdad4f9a0170c5daf852