[INFO] crate serde_scan 0.3.2 is already in cache [INFO] extracting crate serde_scan 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/serde_scan/0.3.2 [INFO] extracting crate serde_scan 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde_scan/0.3.2 [INFO] validating manifest of serde_scan-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of serde_scan-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing serde_scan-0.3.2 [INFO] finished frobbing serde_scan-0.3.2 [INFO] frobbed toml for serde_scan-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/serde_scan/0.3.2/Cargo.toml [INFO] started frobbing serde_scan-0.3.2 [INFO] finished frobbing serde_scan-0.3.2 [INFO] frobbed toml for serde_scan-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde_scan/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting serde_scan-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/serde_scan/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4d208054493935821ef0d7c2920a28a4549b7df114aa89aefd00df91c787a825 [INFO] running `"docker" "start" "-a" "4d208054493935821ef0d7c2920a28a4549b7df114aa89aefd00df91c787a825"` [INFO] [stderr] Checking serde_scan v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/de/mod.rs:10:11 [INFO] [stderr] | [INFO] [stderr] 10 | iter: Peekable, fn(&&str) -> bool>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/de/mod.rs:343:16 [INFO] [stderr] | [INFO] [stderr] 343 | if let None = self.de.peek(){ [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 344 | | // if we have no more data, stop [INFO] [stderr] 345 | | return Ok(None); [INFO] [stderr] 346 | | } [INFO] [stderr] | |_________- help: try this: `if self.de.peek().is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/de/mod.rs:375:16 [INFO] [stderr] | [INFO] [stderr] 375 | if let None = self.de.peek() { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 376 | | Ok(None) [INFO] [stderr] 377 | | } else { [INFO] [stderr] 378 | | seed.deserialize(&mut *self.de).map(Some) [INFO] [stderr] 379 | | } [INFO] [stderr] | |_________- help: try this: `if self.de.peek().is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/de/mod.rs:10:11 [INFO] [stderr] | [INFO] [stderr] 10 | iter: Peekable, fn(&&str) -> bool>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/de/mod.rs:343:16 [INFO] [stderr] | [INFO] [stderr] 343 | if let None = self.de.peek(){ [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 344 | | // if we have no more data, stop [INFO] [stderr] 345 | | return Ok(None); [INFO] [stderr] 346 | | } [INFO] [stderr] | |_________- help: try this: `if self.de.peek().is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/de/mod.rs:375:16 [INFO] [stderr] | [INFO] [stderr] 375 | if let None = self.de.peek() { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 376 | | Ok(None) [INFO] [stderr] 377 | | } else { [INFO] [stderr] 378 | | seed.deserialize(&mut *self.de).map(Some) [INFO] [stderr] 379 | | } [INFO] [stderr] | |_________- help: try this: `if self.de.peek().is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:223:9 [INFO] [stderr] | [INFO] [stderr] 223 | assert_eq!(a.0, 45.34); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:223:9 [INFO] [stderr] | [INFO] [stderr] 223 | assert_eq!(a.0, 45.34); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `serde_scan`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "4d208054493935821ef0d7c2920a28a4549b7df114aa89aefd00df91c787a825"` [INFO] running `"docker" "rm" "-f" "4d208054493935821ef0d7c2920a28a4549b7df114aa89aefd00df91c787a825"` [INFO] [stdout] 4d208054493935821ef0d7c2920a28a4549b7df114aa89aefd00df91c787a825