[INFO] crate serde_rusqlite 0.16.0 is already in cache [INFO] extracting crate serde_rusqlite 0.16.0 into work/ex/clippy-test-run/sources/stable/reg/serde_rusqlite/0.16.0 [INFO] extracting crate serde_rusqlite 0.16.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde_rusqlite/0.16.0 [INFO] validating manifest of serde_rusqlite-0.16.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of serde_rusqlite-0.16.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing serde_rusqlite-0.16.0 [INFO] finished frobbing serde_rusqlite-0.16.0 [INFO] frobbed toml for serde_rusqlite-0.16.0 written to work/ex/clippy-test-run/sources/stable/reg/serde_rusqlite/0.16.0/Cargo.toml [INFO] started frobbing serde_rusqlite-0.16.0 [INFO] finished frobbing serde_rusqlite-0.16.0 [INFO] frobbed toml for serde_rusqlite-0.16.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde_rusqlite/0.16.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting serde_rusqlite-0.16.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/serde_rusqlite/0.16.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a38885e030ca7da58f5660b82521715b1313b853f636cd9a159efe1937846b51 [INFO] running `"docker" "start" "-a" "a38885e030ca7da58f5660b82521715b1313b853f636cd9a159efe1937846b51"` [INFO] [stderr] Checking rusqlite v0.15.0 [INFO] [stderr] Checking serde_rusqlite v0.16.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:72:67 [INFO] [stderr] | [INFO] [stderr] 72 | test_value_same("INT CHECK(typeof(test_column) == 'integer')", &-18968298731236_i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `18_968_298_731_236_i64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:79:66 [INFO] [stderr] | [INFO] [stderr] 79 | test_value_same("INT CHECK(typeof(test_column) == 'integer')", &98172983_u32); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `98_172_983_u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:80:66 [INFO] [stderr] | [INFO] [stderr] 80 | test_value_same("INT CHECK(typeof(test_column) == 'integer')", &98169812698712987_u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `98_169_812_698_712_987_u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:219:72 [INFO] [stderr] | [INFO] [stderr] 219 | test_value_same("INT CHECK(typeof(test_column) == 'integer')", &Test(891287912)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `891_287_912` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/error.rs:26:3 [INFO] [stderr] | [INFO] [stderr] 26 | Error::Unsupported(err.into()).into() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::Unsupported(err.into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ser::named::NamedSliceSerializer` [INFO] [stderr] --> src/ser/named.rs:14:2 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 15 | | NamedSliceSerializer(NamedParamSlice::from(Vec::new())) [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | impl Default for ser::named::NamedSliceSerializer { [INFO] [stderr] 14 | fn default() -> Self { [INFO] [stderr] 15 | Self::new() [INFO] [stderr] 16 | } [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/ser/named.rs:47:3 [INFO] [stderr] | [INFO] [stderr] 47 | len.map(|len| self.0.reserve_exact(len)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(len) = len { self.0.reserve_exact(len) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ser::positional::PositionalSliceSerializer` [INFO] [stderr] --> src/ser/positional.rs:29:2 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 30 | | PositionalSliceSerializer(PositionalParamSlice::from(Vec::new())) [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | impl Default for ser::positional::PositionalSliceSerializer { [INFO] [stderr] 29 | fn default() -> Self { [INFO] [stderr] 30 | Self::new() [INFO] [stderr] 31 | } [INFO] [stderr] 32 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/ser/positional.rs:85:3 [INFO] [stderr] | [INFO] [stderr] 85 | len.map(|len| self.0.reserve_exact(len)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(len) = len { self.0.reserve_exact(len) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ser/tosql.rs:55:22 [INFO] [stderr] | [INFO] [stderr] 55 | self.serialize_f64(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:224:1 [INFO] [stderr] | [INFO] [stderr] 224 | / pub fn from_rows<'rows, D: serde::de::DeserializeOwned>(rows: rusqlite::Rows<'rows>) -> DeserRows<'rows, D, String> { [INFO] [stderr] 225 | | DeserRows { rows, columns: None, d: marker::PhantomData } [INFO] [stderr] 226 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/error.rs:26:3 [INFO] [stderr] | [INFO] [stderr] 26 | Error::Unsupported(err.into()).into() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::Unsupported(err.into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ser::named::NamedSliceSerializer` [INFO] [stderr] --> src/ser/named.rs:14:2 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 15 | | NamedSliceSerializer(NamedParamSlice::from(Vec::new())) [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | impl Default for ser::named::NamedSliceSerializer { [INFO] [stderr] 14 | fn default() -> Self { [INFO] [stderr] 15 | Self::new() [INFO] [stderr] 16 | } [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/ser/named.rs:47:3 [INFO] [stderr] | [INFO] [stderr] 47 | len.map(|len| self.0.reserve_exact(len)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(len) = len { self.0.reserve_exact(len) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ser::positional::PositionalSliceSerializer` [INFO] [stderr] --> src/ser/positional.rs:29:2 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 30 | | PositionalSliceSerializer(PositionalParamSlice::from(Vec::new())) [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | impl Default for ser::positional::PositionalSliceSerializer { [INFO] [stderr] 29 | fn default() -> Self { [INFO] [stderr] 30 | Self::new() [INFO] [stderr] 31 | } [INFO] [stderr] 32 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/ser/positional.rs:85:3 [INFO] [stderr] | [INFO] [stderr] 85 | len.map(|len| self.0.reserve_exact(len)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(len) = len { self.0.reserve_exact(len) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ser/tosql.rs:55:22 [INFO] [stderr] | [INFO] [stderr] 55 | self.serialize_f64(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:224:1 [INFO] [stderr] | [INFO] [stderr] 224 | / pub fn from_rows<'rows, D: serde::de::DeserializeOwned>(rows: rusqlite::Rows<'rows>) -> DeserRows<'rows, D, String> { [INFO] [stderr] 225 | | DeserRows { rows, columns: None, d: marker::PhantomData } [INFO] [stderr] 226 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.91s [INFO] running `"docker" "inspect" "a38885e030ca7da58f5660b82521715b1313b853f636cd9a159efe1937846b51"` [INFO] running `"docker" "rm" "-f" "a38885e030ca7da58f5660b82521715b1313b853f636cd9a159efe1937846b51"` [INFO] [stdout] a38885e030ca7da58f5660b82521715b1313b853f636cd9a159efe1937846b51