[INFO] crate serde_qs 0.4.1 is already in cache [INFO] extracting crate serde_qs 0.4.1 into work/ex/clippy-test-run/sources/stable/reg/serde_qs/0.4.1 [INFO] extracting crate serde_qs 0.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde_qs/0.4.1 [INFO] validating manifest of serde_qs-0.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of serde_qs-0.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing serde_qs-0.4.1 [INFO] finished frobbing serde_qs-0.4.1 [INFO] frobbed toml for serde_qs-0.4.1 written to work/ex/clippy-test-run/sources/stable/reg/serde_qs/0.4.1/Cargo.toml [INFO] started frobbing serde_qs-0.4.1 [INFO] finished frobbing serde_qs-0.4.1 [INFO] frobbed toml for serde_qs-0.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde_qs/0.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting serde_qs-0.4.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/serde_qs/0.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 97dbf04ae0270e68ff8bb7f4ee6926aa4f1cb5a5d79c27162be7ecb2c633f7e1 [INFO] running `"docker" "start" "-a" "97dbf04ae0270e68ff8bb7f4ee6926aa4f1cb5a5d79c27162be7ecb2c633f7e1"` [INFO] [stderr] Checking serde_qs v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: lint `private_no_mangle_fns` has been removed: `no longer an warning, #[no_mangle] functions always exported` [INFO] [stderr] --> src/lib.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | private_no_mangle_fns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint `private_no_mangle_statics` has been removed: `no longer an warning, #[no_mangle] statics always exported` [INFO] [stderr] --> src/lib.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | private_no_mangle_statics, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/parse.rs:214:13 [INFO] [stderr] | [INFO] [stderr] 214 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/parse.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | strict: strict, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/parse.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | max_depth: max_depth, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | strict: strict, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint `private_no_mangle_fns` has been removed: `no longer an warning, #[no_mangle] functions always exported` [INFO] [stderr] --> src/lib.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | private_no_mangle_fns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint `private_no_mangle_statics` has been removed: `no longer an warning, #[no_mangle] statics always exported` [INFO] [stderr] --> src/lib.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | private_no_mangle_statics, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/parse.rs:214:13 [INFO] [stderr] | [INFO] [stderr] 214 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/parse.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | strict: strict, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/parse.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | max_depth: max_depth, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | strict: strict, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> examples/introduction.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> examples/introduction.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> examples/introduction.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> examples/introduction.rs:162:5 [INFO] [stderr] | [INFO] [stderr] 162 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] error[E0463]: can't find crate for `serde_json` [INFO] [stderr] --> benches/bench.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | extern crate serde_json; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0463`. [INFO] [stderr] error: Could not compile `serde_qs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> tests/test_deserialize.rs:113:1 [INFO] [stderr] | [INFO] [stderr] 113 | / fn qs_test_simple() { [INFO] [stderr] 114 | | // test('parse()', function (t) { [INFO] [stderr] 115 | | // t.test('parses a simple string', function (st) { [INFO] [stderr] 116 | | // st.deepEqual(qs.parse('0=foo'), { 0: 'foo' }); [INFO] [stderr] ... | [INFO] [stderr] 178 | | // }); [INFO] [stderr] 179 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "97dbf04ae0270e68ff8bb7f4ee6926aa4f1cb5a5d79c27162be7ecb2c633f7e1"` [INFO] running `"docker" "rm" "-f" "97dbf04ae0270e68ff8bb7f4ee6926aa4f1cb5a5d79c27162be7ecb2c633f7e1"` [INFO] [stdout] 97dbf04ae0270e68ff8bb7f4ee6926aa4f1cb5a5d79c27162be7ecb2c633f7e1