[INFO] crate serde_mtproto 0.3.1 is already in cache [INFO] extracting crate serde_mtproto 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/serde_mtproto/0.3.1 [INFO] extracting crate serde_mtproto 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde_mtproto/0.3.1 [INFO] validating manifest of serde_mtproto-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of serde_mtproto-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing serde_mtproto-0.3.1 [INFO] removed path dependency serde_mtproto_derive from serde_mtproto-0.3.1 [INFO] finished frobbing serde_mtproto-0.3.1 [INFO] frobbed toml for serde_mtproto-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/serde_mtproto/0.3.1/Cargo.toml [INFO] started frobbing serde_mtproto-0.3.1 [INFO] removed path dependency serde_mtproto_derive from serde_mtproto-0.3.1 [INFO] finished frobbing serde_mtproto-0.3.1 [INFO] frobbed toml for serde_mtproto-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde_mtproto/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting serde_mtproto-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/serde_mtproto/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 19f4c4d16ce0732e0de41da76f43276e7d5689d93e928c784a393ddf8e8430ce [INFO] running `"docker" "start" "-a" "19f4c4d16ce0732e0de41da76f43276e7d5689d93e928c784a393ddf8e8430ce"` [INFO] [stderr] Compiling serde_mtproto_derive v0.3.1 [INFO] [stderr] Checking serde_mtproto v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boxed.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/helpers.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | byte_buf: byte_buf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `byte_buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/helpers.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:21:22 [INFO] [stderr] | [INFO] [stderr] 21 | Serializer { writer: writer } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:253:13 [INFO] [stderr] | [INFO] [stderr] 253 | ser: ser, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:254:13 [INFO] [stderr] | [INFO] [stderr] 254 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:406:13 [INFO] [stderr] | [INFO] [stderr] 406 | ser: ser, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:407:13 [INFO] [stderr] | [INFO] [stderr] 407 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | enum_variant_id: enum_variant_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `enum_variant_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:297:13 [INFO] [stderr] | [INFO] [stderr] 297 | de: de, [INFO] [stderr] | ^^^^^^ help: replace it with: `de` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:299:13 [INFO] [stderr] | [INFO] [stderr] 299 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:332:13 [INFO] [stderr] | [INFO] [stderr] 332 | de: de, [INFO] [stderr] | ^^^^^^ help: replace it with: `de` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:334:13 [INFO] [stderr] | [INFO] [stderr] 334 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:370:29 [INFO] [stderr] | [INFO] [stderr] 370 | EnumVariantAccess { de: de } [INFO] [stderr] | ^^^^^^ help: replace it with: `de` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/identifiable.rs:3:32 [INFO] [stderr] | [INFO] [stderr] 3 | pub const BOOL_TRUE_ID: i32 = -1720552011; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_720_552_011` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/identifiable.rs:4:33 [INFO] [stderr] | [INFO] [stderr] 4 | pub const BOOL_FALSE_ID: i32 = -1132882121; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_132_882_121` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/identifiable.rs:5:26 [INFO] [stderr] | [INFO] [stderr] 5 | pub const INT_ID: i32 = -1471112230; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_471_112_230` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/identifiable.rs:6:26 [INFO] [stderr] | [INFO] [stderr] 6 | pub const LONG_ID: i32 = 570911930; [INFO] [stderr] | ^^^^^^^^^ help: consider: `570_911_930` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/identifiable.rs:7:28 [INFO] [stderr] | [INFO] [stderr] 7 | pub const DOUBLE_ID: i32 = 571523412; [INFO] [stderr] | ^^^^^^^^^ help: consider: `571_523_412` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/identifiable.rs:8:29 [INFO] [stderr] | [INFO] [stderr] 8 | pub const STRING_ID: i32 = -1255641564; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_255_641_564` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/identifiable.rs:9:28 [INFO] [stderr] | [INFO] [stderr] 9 | pub const VECTOR_ID: i32 = 481674261; [INFO] [stderr] | ^^^^^^^^^ help: consider: `481_674_261` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boxed.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/helpers.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | byte_buf: byte_buf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `byte_buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/helpers.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:21:22 [INFO] [stderr] | [INFO] [stderr] 21 | Serializer { writer: writer } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:253:13 [INFO] [stderr] | [INFO] [stderr] 253 | ser: ser, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:254:13 [INFO] [stderr] | [INFO] [stderr] 254 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:406:13 [INFO] [stderr] | [INFO] [stderr] 406 | ser: ser, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:407:13 [INFO] [stderr] | [INFO] [stderr] 407 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | enum_variant_id: enum_variant_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `enum_variant_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:297:13 [INFO] [stderr] | [INFO] [stderr] 297 | de: de, [INFO] [stderr] | ^^^^^^ help: replace it with: `de` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:299:13 [INFO] [stderr] | [INFO] [stderr] 299 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:332:13 [INFO] [stderr] | [INFO] [stderr] 332 | de: de, [INFO] [stderr] | ^^^^^^ help: replace it with: `de` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:334:13 [INFO] [stderr] | [INFO] [stderr] 334 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:370:29 [INFO] [stderr] | [INFO] [stderr] 370 | EnumVariantAccess { de: de } [INFO] [stderr] | ^^^^^^ help: replace it with: `de` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/utils.rs:7:13 [INFO] [stderr] | [INFO] [stderr] 7 | cast(n).ok_or(ErrorKind::IntegerCast.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::IntegerCast.into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/helpers.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn from_bytes<'a>(bytes: Bytes<'a>) -> ByteBuf { [INFO] [stderr] 29 | | ByteBuf { [INFO] [stderr] 30 | | byte_buf: bytes.bytes.to_vec(), [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/helpers.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / pub fn as_bytes<'a>(&'a self) -> Bytes<'a> { [INFO] [stderr] 41 | | Bytes { [INFO] [stderr] 42 | | bytes: &self.byte_buf, [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/identifiable.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / match *self { [INFO] [stderr] 43 | | false => BOOL_FALSE_ID, [INFO] [stderr] 44 | | true => BOOL_TRUE_ID, [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if *self { BOOL_TRUE_ID } else { BOOL_FALSE_ID }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/identifiable.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | / match *self { [INFO] [stderr] 51 | | false => Some("false"), [INFO] [stderr] 52 | | true => Some("true"), [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if *self { Some("true") } else { Some("false") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/sized.rs:113:29 [INFO] [stderr] | [INFO] [stderr] 113 | impl MtProtoSized for HashMap [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 113 | impl MtProtoSized for HashMap [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:70:30 [INFO] [stderr] | [INFO] [stderr] 70 | self.$big_method(value as $big_type)?; // safe to cast from small to big [INFO] [stderr] | ^^^^^ help: try: `i32::from(value)` [INFO] [stderr] ... [INFO] [stderr] 118 | impl_serialize_small_int!(i8, serialize_i8, i32, serialize_i32); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:70:30 [INFO] [stderr] | [INFO] [stderr] 70 | self.$big_method(value as $big_type)?; // safe to cast from small to big [INFO] [stderr] | ^^^^^ help: try: `i32::from(value)` [INFO] [stderr] ... [INFO] [stderr] 119 | impl_serialize_small_int!(i16, serialize_i16, i32, serialize_i32); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:70:30 [INFO] [stderr] | [INFO] [stderr] 70 | self.$big_method(value as $big_type)?; // safe to cast from small to big [INFO] [stderr] | ^^^^^ help: try: `u32::from(value)` [INFO] [stderr] ... [INFO] [stderr] 123 | impl_serialize_small_int!(u8, serialize_u8, u32, serialize_u32); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:70:30 [INFO] [stderr] | [INFO] [stderr] 70 | self.$big_method(value as $big_type)?; // safe to cast from small to big [INFO] [stderr] | ^^^^^ help: try: `u32::from(value)` [INFO] [stderr] ... [INFO] [stderr] 124 | impl_serialize_small_int!(u16, serialize_u16, u32, serialize_u32); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/de.rs:147:44 [INFO] [stderr] | [INFO] [stderr] 147 | de::Unexpected::Signed(id_value as i64), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(id_value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/identifiable.rs:3:32 [INFO] [stderr] | [INFO] [stderr] 3 | pub const BOOL_TRUE_ID: i32 = -1720552011; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_720_552_011` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/identifiable.rs:4:33 [INFO] [stderr] | [INFO] [stderr] 4 | pub const BOOL_FALSE_ID: i32 = -1132882121; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_132_882_121` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/identifiable.rs:5:26 [INFO] [stderr] | [INFO] [stderr] 5 | pub const INT_ID: i32 = -1471112230; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_471_112_230` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/identifiable.rs:6:26 [INFO] [stderr] | [INFO] [stderr] 6 | pub const LONG_ID: i32 = 570911930; [INFO] [stderr] | ^^^^^^^^^ help: consider: `570_911_930` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/identifiable.rs:7:28 [INFO] [stderr] | [INFO] [stderr] 7 | pub const DOUBLE_ID: i32 = 571523412; [INFO] [stderr] | ^^^^^^^^^ help: consider: `571_523_412` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/identifiable.rs:8:29 [INFO] [stderr] | [INFO] [stderr] 8 | pub const STRING_ID: i32 = -1255641564; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_255_641_564` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/identifiable.rs:9:28 [INFO] [stderr] | [INFO] [stderr] 9 | pub const VECTOR_ID: i32 = 481674261; [INFO] [stderr] | ^^^^^^^^^ help: consider: `481_674_261` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/utils.rs:7:13 [INFO] [stderr] | [INFO] [stderr] 7 | cast(n).ok_or(ErrorKind::IntegerCast.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::IntegerCast.into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/helpers.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn from_bytes<'a>(bytes: Bytes<'a>) -> ByteBuf { [INFO] [stderr] 29 | | ByteBuf { [INFO] [stderr] 30 | | byte_buf: bytes.bytes.to_vec(), [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/helpers.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / pub fn as_bytes<'a>(&'a self) -> Bytes<'a> { [INFO] [stderr] 41 | | Bytes { [INFO] [stderr] 42 | | bytes: &self.byte_buf, [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/identifiable.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / match *self { [INFO] [stderr] 43 | | false => BOOL_FALSE_ID, [INFO] [stderr] 44 | | true => BOOL_TRUE_ID, [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if *self { BOOL_TRUE_ID } else { BOOL_FALSE_ID }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/identifiable.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | / match *self { [INFO] [stderr] 51 | | false => Some("false"), [INFO] [stderr] 52 | | true => Some("true"), [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if *self { Some("true") } else { Some("false") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/sized.rs:113:29 [INFO] [stderr] | [INFO] [stderr] 113 | impl MtProtoSized for HashMap [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 113 | impl MtProtoSized for HashMap [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:70:30 [INFO] [stderr] | [INFO] [stderr] 70 | self.$big_method(value as $big_type)?; // safe to cast from small to big [INFO] [stderr] | ^^^^^ help: try: `i32::from(value)` [INFO] [stderr] ... [INFO] [stderr] 118 | impl_serialize_small_int!(i8, serialize_i8, i32, serialize_i32); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:70:30 [INFO] [stderr] | [INFO] [stderr] 70 | self.$big_method(value as $big_type)?; // safe to cast from small to big [INFO] [stderr] | ^^^^^ help: try: `i32::from(value)` [INFO] [stderr] ... [INFO] [stderr] 119 | impl_serialize_small_int!(i16, serialize_i16, i32, serialize_i32); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:70:30 [INFO] [stderr] | [INFO] [stderr] 70 | self.$big_method(value as $big_type)?; // safe to cast from small to big [INFO] [stderr] | ^^^^^ help: try: `u32::from(value)` [INFO] [stderr] ... [INFO] [stderr] 123 | impl_serialize_small_int!(u8, serialize_u8, u32, serialize_u32); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:70:30 [INFO] [stderr] | [INFO] [stderr] 70 | self.$big_method(value as $big_type)?; // safe to cast from small to big [INFO] [stderr] | ^^^^^ help: try: `u32::from(value)` [INFO] [stderr] ... [INFO] [stderr] 124 | impl_serialize_small_int!(u16, serialize_u16, u32, serialize_u32); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/de.rs:147:44 [INFO] [stderr] | [INFO] [stderr] 147 | de::Unexpected::Signed(id_value as i64), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(id_value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test.rs:81:25 [INFO] [stderr] | [INFO] [stderr] 81 | position: (350, 142857), [INFO] [stderr] | ^^^^^^ help: consider: `142_857` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test.rs:99:41 [INFO] [stderr] | [INFO] [stderr] 99 | "QWERTY".to_owned() => -1048576, [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test.rs:102:35 [INFO] [stderr] | [INFO] [stderr] 102 | "こんにちは".to_owned() => 8024735636555, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `8_024_735_636_555` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.64s [INFO] running `"docker" "inspect" "19f4c4d16ce0732e0de41da76f43276e7d5689d93e928c784a393ddf8e8430ce"` [INFO] running `"docker" "rm" "-f" "19f4c4d16ce0732e0de41da76f43276e7d5689d93e928c784a393ddf8e8430ce"` [INFO] [stdout] 19f4c4d16ce0732e0de41da76f43276e7d5689d93e928c784a393ddf8e8430ce