[INFO] crate serde_millis 0.1.1 is already in cache [INFO] extracting crate serde_millis 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/serde_millis/0.1.1 [INFO] extracting crate serde_millis 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde_millis/0.1.1 [INFO] validating manifest of serde_millis-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of serde_millis-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing serde_millis-0.1.1 [INFO] finished frobbing serde_millis-0.1.1 [INFO] frobbed toml for serde_millis-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/serde_millis/0.1.1/Cargo.toml [INFO] started frobbing serde_millis-0.1.1 [INFO] finished frobbing serde_millis-0.1.1 [INFO] frobbed toml for serde_millis-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde_millis/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting serde_millis-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/serde_millis/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ab5e6a61572dd90cb5381c33233ff14a966ab177c8c8deea0a8cc82d2f96bdf9 [INFO] running `"docker" "start" "-a" "ab5e6a61572dd90cb5381c33233ff14a966ab177c8c8deea0a8cc82d2f96bdf9"` [INFO] [stderr] Checking serde_millis v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/impls.rs:42:12 [INFO] [stderr] | [INFO] [stderr] 42 | Ok((UNIX_EPOCH + val)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/impls.rs:42:12 [INFO] [stderr] | [INFO] [stderr] 42 | Ok((UNIX_EPOCH + val)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/impls.rs:16:27 [INFO] [stderr] | [INFO] [stderr] 16 | x.checked_add((self.subsec_nanos()/1_000_000) as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.subsec_nanos()/1_000_000)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/impls.rs:16:27 [INFO] [stderr] | [INFO] [stderr] 16 | x.checked_add((self.subsec_nanos()/1_000_000) as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/impls.rs:42:12 [INFO] [stderr] | [INFO] [stderr] 42 | Ok((UNIX_EPOCH + val)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/impls.rs:42:12 [INFO] [stderr] | [INFO] [stderr] 42 | Ok((UNIX_EPOCH + val)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/impls.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | return data.0 [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `data.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/impls.rs:169:44 [INFO] [stderr] | [INFO] [stderr] 169 | assert_eq!(encode(Duration::new(1, 2300000)), "1002"); [INFO] [stderr] | ^^^^^^^ help: consider: `2_300_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/impls.rs:170:65 [INFO] [stderr] | [INFO] [stderr] 170 | assert_eq!(decode::("1002"), Duration::new(1, 2000000)); [INFO] [stderr] | ^^^^^^^ help: consider: `2_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/impls.rs:177:62 [INFO] [stderr] | [INFO] [stderr] 177 | assert_eq!(encode(UNIX_EPOCH + Duration::from_millis(1511885454870)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_511_885_454_870` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/impls.rs:180:48 [INFO] [stderr] | [INFO] [stderr] 180 | UNIX_EPOCH + Duration::from_millis(1511885454870)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_511_885_454_870` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/impls.rs:185:62 [INFO] [stderr] | [INFO] [stderr] 185 | assert_eq!(encode(UNIX_EPOCH + Duration::from_millis(2147483647000)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `2_147_483_647_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/impls.rs:188:48 [INFO] [stderr] | [INFO] [stderr] 188 | UNIX_EPOCH + Duration::from_millis(2147483647000)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `2_147_483_647_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/impls.rs:219:48 [INFO] [stderr] | [INFO] [stderr] 219 | UNIX_EPOCH + Duration::from_millis(1511885454870))), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_511_885_454_870` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/impls.rs:224:53 [INFO] [stderr] | [INFO] [stderr] 224 | Some(UNIX_EPOCH + Duration::from_millis(1511885454870))); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_511_885_454_870` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/impls.rs:16:27 [INFO] [stderr] | [INFO] [stderr] 16 | x.checked_add((self.subsec_nanos()/1_000_000) as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.subsec_nanos()/1_000_000)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/impls.rs:16:27 [INFO] [stderr] | [INFO] [stderr] 16 | x.checked_add((self.subsec_nanos()/1_000_000) as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.28s [INFO] running `"docker" "inspect" "ab5e6a61572dd90cb5381c33233ff14a966ab177c8c8deea0a8cc82d2f96bdf9"` [INFO] running `"docker" "rm" "-f" "ab5e6a61572dd90cb5381c33233ff14a966ab177c8c8deea0a8cc82d2f96bdf9"` [INFO] [stdout] ab5e6a61572dd90cb5381c33233ff14a966ab177c8c8deea0a8cc82d2f96bdf9