[INFO] crate serde_fs 0.2.0 is already in cache [INFO] extracting crate serde_fs 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/serde_fs/0.2.0 [INFO] extracting crate serde_fs 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde_fs/0.2.0 [INFO] validating manifest of serde_fs-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of serde_fs-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing serde_fs-0.2.0 [INFO] finished frobbing serde_fs-0.2.0 [INFO] frobbed toml for serde_fs-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/serde_fs/0.2.0/Cargo.toml [INFO] started frobbing serde_fs-0.2.0 [INFO] finished frobbing serde_fs-0.2.0 [INFO] frobbed toml for serde_fs-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde_fs/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting serde_fs-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/serde_fs/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 558736a3d8a40cd79935191b4b915c16e8be59837b63ff7c9c39f58129eced09 [INFO] running `"docker" "start" "-a" "558736a3d8a40cd79935191b4b915c16e8be59837b63ff7c9c39f58129eced09"` [INFO] [stderr] Checking assert_matches v1.3.0 [INFO] [stderr] Checking serde_fs v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/de.rs:265:16 [INFO] [stderr] | [INFO] [stderr] 265 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 266 | | if self.len.is_some() && self.len.clone().unwrap() != self.counter { [INFO] [stderr] 267 | | Err(Error::InvalidLen { [INFO] [stderr] 268 | | expected: self.len.clone().unwrap(), [INFO] [stderr] ... | [INFO] [stderr] 273 | | } [INFO] [stderr] 274 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 265 | } else if self.len.is_some() && self.len.clone().unwrap() != self.counter { [INFO] [stderr] 266 | Err(Error::InvalidLen { [INFO] [stderr] 267 | expected: self.len.clone().unwrap(), [INFO] [stderr] 268 | got: self.counter, [INFO] [stderr] 269 | }) [INFO] [stderr] 270 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/ser.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | if let Ok(_) = file.file_name().to_str().unwrap().parse::() { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 49 | | fs::remove_file(file.path())?; [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________________- help: try this: `if file.file_name().to_str().unwrap().parse::().is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/ser.rs:362:5 [INFO] [stderr] | [INFO] [stderr] 362 | file.write(content.as_ref())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/de.rs:215:64 [INFO] [stderr] | [INFO] [stderr] 215 | visitor.visit_map(MapAccess::new_for(self.path, fields.into_iter().map(|f| Ok(String::from(*f))))?) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/de.rs:227:15 [INFO] [stderr] | [INFO] [stderr] 227 | if available_variant == &&variant { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^--------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `&variant` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/de.rs:266:38 [INFO] [stderr] | [INFO] [stderr] 266 | if self.len.is_some() && self.len.clone().unwrap() != self.counter { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/de.rs:268:31 [INFO] [stderr] | [INFO] [stderr] 268 | expected: self.len.clone().unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `serde_fs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/de.rs:265:16 [INFO] [stderr] | [INFO] [stderr] 265 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 266 | | if self.len.is_some() && self.len.clone().unwrap() != self.counter { [INFO] [stderr] 267 | | Err(Error::InvalidLen { [INFO] [stderr] 268 | | expected: self.len.clone().unwrap(), [INFO] [stderr] ... | [INFO] [stderr] 273 | | } [INFO] [stderr] 274 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 265 | } else if self.len.is_some() && self.len.clone().unwrap() != self.counter { [INFO] [stderr] 266 | Err(Error::InvalidLen { [INFO] [stderr] 267 | expected: self.len.clone().unwrap(), [INFO] [stderr] 268 | got: self.counter, [INFO] [stderr] 269 | }) [INFO] [stderr] 270 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/ser.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | if let Ok(_) = file.file_name().to_str().unwrap().parse::() { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 49 | | fs::remove_file(file.path())?; [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________________- help: try this: `if file.file_name().to_str().unwrap().parse::().is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/ser.rs:362:5 [INFO] [stderr] | [INFO] [stderr] 362 | file.write(content.as_ref())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/de.rs:215:64 [INFO] [stderr] | [INFO] [stderr] 215 | visitor.visit_map(MapAccess::new_for(self.path, fields.into_iter().map(|f| Ok(String::from(*f))))?) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/de.rs:227:15 [INFO] [stderr] | [INFO] [stderr] 227 | if available_variant == &&variant { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^--------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `&variant` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/de.rs:266:38 [INFO] [stderr] | [INFO] [stderr] 266 | if self.len.is_some() && self.len.clone().unwrap() != self.counter { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/de.rs:268:31 [INFO] [stderr] | [INFO] [stderr] 268 | expected: self.len.clone().unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/de.rs:438:9 [INFO] [stderr] | [INFO] [stderr] 438 | assert_eq!(f32::deserialize(deserializer.clone()).unwrap(), 1.3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/de.rs:438:9 [INFO] [stderr] | [INFO] [stderr] 438 | assert_eq!(f32::deserialize(deserializer.clone()).unwrap(), 1.3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/de.rs:440:9 [INFO] [stderr] | [INFO] [stderr] 440 | assert_eq!(f64::deserialize(deserializer.clone()).unwrap(), 1.31); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/de.rs:440:9 [INFO] [stderr] | [INFO] [stderr] 440 | assert_eq!(f64::deserialize(deserializer.clone()).unwrap(), 1.31); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/de.rs:467:9 [INFO] [stderr] | [INFO] [stderr] 467 | assert_eq!(f32::deserialize(deserializer.clone()).unwrap(), 1.3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/de.rs:467:9 [INFO] [stderr] | [INFO] [stderr] 467 | assert_eq!(f32::deserialize(deserializer.clone()).unwrap(), 1.3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/de.rs:469:9 [INFO] [stderr] | [INFO] [stderr] 469 | assert_eq!(f64::deserialize(deserializer.clone()).unwrap(), 1.31); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/de.rs:469:9 [INFO] [stderr] | [INFO] [stderr] 469 | assert_eq!(f64::deserialize(deserializer.clone()).unwrap(), 1.31); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `serde_fs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "558736a3d8a40cd79935191b4b915c16e8be59837b63ff7c9c39f58129eced09"` [INFO] running `"docker" "rm" "-f" "558736a3d8a40cd79935191b4b915c16e8be59837b63ff7c9c39f58129eced09"` [INFO] [stdout] 558736a3d8a40cd79935191b4b915c16e8be59837b63ff7c9c39f58129eced09