[INFO] crate serde_eetf 0.1.0 is already in cache [INFO] extracting crate serde_eetf 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/serde_eetf/0.1.0 [INFO] extracting crate serde_eetf 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde_eetf/0.1.0 [INFO] validating manifest of serde_eetf-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of serde_eetf-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing serde_eetf-0.1.0 [INFO] finished frobbing serde_eetf-0.1.0 [INFO] frobbed toml for serde_eetf-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/serde_eetf/0.1.0/Cargo.toml [INFO] started frobbing serde_eetf-0.1.0 [INFO] finished frobbing serde_eetf-0.1.0 [INFO] frobbed toml for serde_eetf-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde_eetf/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting serde_eetf-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/serde_eetf/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5d22c514a44c5881a5954a86f6917695d17cf7038fb0019dcab1ab46fcde4e5c [INFO] running `"docker" "start" "-a" "5d22c514a44c5881a5954a86f6917695d17cf7038fb0019dcab1ab46fcde4e5c"` [INFO] [stderr] Checking eetf v0.3.6 [INFO] [stderr] Checking serde_eetf v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | Deserializer { term: term } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `term` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:579:13 [INFO] [stderr] | [INFO] [stderr] 579 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:580:13 [INFO] [stderr] | [INFO] [stderr] 580 | term: term, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `term` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:650:35 [INFO] [stderr] | [INFO] [stderr] 650 | VariantNameDeserializer { term: term } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `term` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | Deserializer { term: term } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `term` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:579:13 [INFO] [stderr] | [INFO] [stderr] 579 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:580:13 [INFO] [stderr] | [INFO] [stderr] 580 | term: term, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `term` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:650:35 [INFO] [stderr] | [INFO] [stderr] 650 | VariantNameDeserializer { term: term } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `term` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:429:22 [INFO] [stderr] | [INFO] [stderr] 429 | _ => return Err(Error::MisSizedVariantTuple), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::MisSizedVariantTuple)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:429:22 [INFO] [stderr] | [INFO] [stderr] 429 | _ => return Err(Error::MisSizedVariantTuple), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::MisSizedVariantTuple)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: method is never used: `end` [INFO] [stderr] --> src/de.rs:469:5 [INFO] [stderr] | [INFO] [stderr] 469 | fn end(self) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/de.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | fn into_deserializer<'a>(&'a self) -> Deserializer<'a>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/de.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / fn into_deserializer<'a>(&'a self) -> Deserializer<'a> { [INFO] [stderr] 38 | | Deserializer::from_term(self) [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/de.rs:543:16 [INFO] [stderr] | [INFO] [stderr] 543 | if let Some(_) = self.current_value { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 544 | | panic!("MapDeserializer.next_key_seed was called twice in a row") [INFO] [stderr] 545 | | } [INFO] [stderr] | |_________- help: try this: `if self.current_value.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: method is never used: `end` [INFO] [stderr] --> src/de.rs:469:5 [INFO] [stderr] | [INFO] [stderr] 469 | fn end(self) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `AnotherOption` [INFO] [stderr] --> src/ser.rs:566:13 [INFO] [stderr] | [INFO] [stderr] 566 | AnotherOption, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/de.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | fn into_deserializer<'a>(&'a self) -> Deserializer<'a>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/de.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / fn into_deserializer<'a>(&'a self) -> Deserializer<'a> { [INFO] [stderr] 38 | | Deserializer::from_term(self) [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/de.rs:543:16 [INFO] [stderr] | [INFO] [stderr] 543 | if let Some(_) = self.current_value { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 544 | | panic!("MapDeserializer.next_key_seed was called twice in a row") [INFO] [stderr] 545 | | } [INFO] [stderr] | |_________- help: try this: `if self.current_value.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/de.rs:772:45 [INFO] [stderr] | [INFO] [stderr] 772 | Term::Binary(eetf::Binary::from("ABCD".as_bytes())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"ABCD"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/de.rs:817:45 [INFO] [stderr] | [INFO] [stderr] 817 | Term::Binary(eetf::Binary::from("test".as_bytes())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"test"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ser.rs:540:49 [INFO] [stderr] | [INFO] [stderr] 540 | Term::Binary(eetf::Binary::from("ABCD".as_bytes())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"ABCD"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ser.rs:589:49 [INFO] [stderr] | [INFO] [stderr] 589 | Term::Binary(eetf::Binary::from("test".as_bytes())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"test"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.11s [INFO] running `"docker" "inspect" "5d22c514a44c5881a5954a86f6917695d17cf7038fb0019dcab1ab46fcde4e5c"` [INFO] running `"docker" "rm" "-f" "5d22c514a44c5881a5954a86f6917695d17cf7038fb0019dcab1ab46fcde4e5c"` [INFO] [stdout] 5d22c514a44c5881a5954a86f6917695d17cf7038fb0019dcab1ab46fcde4e5c