[INFO] crate serde_dbor 1.0.2 is already in cache [INFO] extracting crate serde_dbor 1.0.2 into work/ex/clippy-test-run/sources/stable/reg/serde_dbor/1.0.2 [INFO] extracting crate serde_dbor 1.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde_dbor/1.0.2 [INFO] validating manifest of serde_dbor-1.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of serde_dbor-1.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing serde_dbor-1.0.2 [INFO] finished frobbing serde_dbor-1.0.2 [INFO] frobbed toml for serde_dbor-1.0.2 written to work/ex/clippy-test-run/sources/stable/reg/serde_dbor/1.0.2/Cargo.toml [INFO] started frobbing serde_dbor-1.0.2 [INFO] finished frobbing serde_dbor-1.0.2 [INFO] frobbed toml for serde_dbor-1.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde_dbor/1.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting serde_dbor-1.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/serde_dbor/1.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d4c42337021b734d7282b56ece12ff49a853a3c5852d620e2dfa9ca305340d0a [INFO] running `"docker" "start" "-a" "d4c42337021b734d7282b56ece12ff49a853a3c5852d620e2dfa9ca305340d0a"` [INFO] [stderr] Checking serde_dbor v1.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/de/read.rs:165:16 [INFO] [stderr] | [INFO] [stderr] 165 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 166 | | if bytes + self.index >= self.buf_len { [INFO] [stderr] 167 | | // Window requested requires us to read more bytes than we have buffered, so read [INFO] [stderr] 168 | | // in more [INFO] [stderr] ... | [INFO] [stderr] 247 | | } [INFO] [stderr] 248 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 165 | } else if bytes + self.index >= self.buf_len { [INFO] [stderr] 166 | // Window requested requires us to read more bytes than we have buffered, so read [INFO] [stderr] 167 | // in more [INFO] [stderr] 168 | [INFO] [stderr] 169 | let mut new_buffer = [0; MAX_BUF_LEN]; [INFO] [stderr] 170 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/de/read.rs:264:16 [INFO] [stderr] | [INFO] [stderr] 264 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 265 | | if bytes + self.index >= self.buf_len { [INFO] [stderr] 266 | | // Window requested requires us to read more bytes than we have buffered, so read [INFO] [stderr] 267 | | // in more [INFO] [stderr] ... | [INFO] [stderr] 311 | | } [INFO] [stderr] 312 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 264 | } else if bytes + self.index >= self.buf_len { [INFO] [stderr] 265 | // Window requested requires us to read more bytes than we have buffered, so read [INFO] [stderr] 266 | // in more [INFO] [stderr] 267 | [INFO] [stderr] 268 | let mut new_buffer = [0; MAX_BUF_LEN]; [INFO] [stderr] 269 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/de/read.rs:328:16 [INFO] [stderr] | [INFO] [stderr] 328 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 329 | | if bytes + self.index >= self.buf_len { [INFO] [stderr] 330 | | // Window requested requires us to read more bytes than we have buffered, so read [INFO] [stderr] 331 | | // in more [INFO] [stderr] ... | [INFO] [stderr] 375 | | } [INFO] [stderr] 376 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 328 | } else if bytes + self.index >= self.buf_len { [INFO] [stderr] 329 | // Window requested requires us to read more bytes than we have buffered, so read [INFO] [stderr] 330 | // in more [INFO] [stderr] 331 | [INFO] [stderr] 332 | let mut tmp_buffer = [0; MAX_BUF_LEN * 2]; [INFO] [stderr] 333 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/de/mod.rs:60:12 [INFO] [stderr] | [INFO] [stderr] 60 | byte & 0b00011111 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de/mod.rs:469:18 [INFO] [stderr] | [INFO] [stderr] 469 | _ => return Err(Error::NotAType), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::NotAType)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/de/mod.rs:644:16 [INFO] [stderr] | [INFO] [stderr] 644 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 645 | | if ty(byte) == Type::Misc { [INFO] [stderr] 646 | | Err(Error::UnexpectedValue(Type::Misc, val(byte))) [INFO] [stderr] 647 | | } else { [INFO] [stderr] 648 | | Err(Error::ExpectedType(vec![Type::Misc], byte)) [INFO] [stderr] 649 | | } [INFO] [stderr] 650 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 644 | } else if ty(byte) == Type::Misc { [INFO] [stderr] 645 | Err(Error::UnexpectedValue(Type::Misc, val(byte))) [INFO] [stderr] 646 | } else { [INFO] [stderr] 647 | Err(Error::ExpectedType(vec![Type::Misc], byte)) [INFO] [stderr] 648 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | const TYPE_UINT: u8 = 0b00000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | const TYPE_INT: u8 = 0b00100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:14:23 [INFO] [stderr] | [INFO] [stderr] 14 | const TYPE_MISC: u8 = 0b01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:15:26 [INFO] [stderr] | [INFO] [stderr] 15 | const TYPE_VARIANT: u8 = 0b01100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | const TYPE_SEQ: u8 = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:17:24 [INFO] [stderr] | [INFO] [stderr] 17 | const TYPE_BYTES: u8 = 0b10100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | const TYPE_MAP: u8 = 0b11000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:20:24 [INFO] [stderr] | [INFO] [stderr] 20 | const VALUE_MASK: u8 = 0b00011111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:135:14 [INFO] [stderr] | [INFO] [stderr] 135 | -0x80000000...-0x8001 | 0x8000...0x7fffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:135:46 [INFO] [stderr] | [INFO] [stderr] 135 | -0x80000000...-0x8001 | 0x8000...0x7fffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:163:14 [INFO] [stderr] | [INFO] [stderr] 163 | -0x80000000...-0x8001 | 0x8000...0x7fffffff => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:163:46 [INFO] [stderr] | [INFO] [stderr] 163 | -0x80000000...-0x8001 | 0x8000...0x7fffffff => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:170:14 [INFO] [stderr] | [INFO] [stderr] 170 | -0x8000000000000000...-0x80000001 | 0x80000000...0x7fffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x8000_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:170:36 [INFO] [stderr] | [INFO] [stderr] 170 | -0x8000000000000000...-0x80000001 | 0x80000000...0x7fffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:170:49 [INFO] [stderr] | [INFO] [stderr] 170 | -0x8000000000000000...-0x80000001 | 0x80000000...0x7fffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:170:62 [INFO] [stderr] | [INFO] [stderr] 170 | -0x8000000000000000...-0x80000001 | 0x80000000...0x7fffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x7fff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:224:23 [INFO] [stderr] | [INFO] [stderr] 224 | 0x10000...0xffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:249:23 [INFO] [stderr] | [INFO] [stderr] 249 | 0x10000...0xffffffff => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:256:13 [INFO] [stderr] | [INFO] [stderr] 256 | 0x100000000...0xffffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0001_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:256:27 [INFO] [stderr] | [INFO] [stderr] 256 | 0x100000000...0xffffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:320:13 [INFO] [stderr] | [INFO] [stderr] 320 | 0x00010000...0xffffffff => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:320:26 [INFO] [stderr] | [INFO] [stderr] 320 | 0x00010000...0xffffffff => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:328:13 [INFO] [stderr] | [INFO] [stderr] 328 | 0x0000000100000000...0xffffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0001_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:328:34 [INFO] [stderr] | [INFO] [stderr] 328 | 0x0000000100000000...0xffffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:401:23 [INFO] [stderr] | [INFO] [stderr] 401 | 0x10000...0xffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:433:17 [INFO] [stderr] | [INFO] [stderr] 433 | 0x00010000...0xffffffff => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:433:30 [INFO] [stderr] | [INFO] [stderr] 433 | 0x00010000...0xffffffff => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:441:17 [INFO] [stderr] | [INFO] [stderr] 441 | 0x0000000100000000...0xffffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0001_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:441:38 [INFO] [stderr] | [INFO] [stderr] 441 | 0x0000000100000000...0xffffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:487:23 [INFO] [stderr] | [INFO] [stderr] 487 | 0x10000...0xffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:512:13 [INFO] [stderr] | [INFO] [stderr] 512 | 0x00010000...0xffffffff => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:512:26 [INFO] [stderr] | [INFO] [stderr] 512 | 0x00010000...0xffffffff => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:520:13 [INFO] [stderr] | [INFO] [stderr] 520 | 0x0000000100000000...0xffffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0001_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:520:34 [INFO] [stderr] | [INFO] [stderr] 520 | 0x0000000100000000...0xffffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:553:17 [INFO] [stderr] | [INFO] [stderr] 553 | 0x00010000...0xffffffff => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:553:30 [INFO] [stderr] | [INFO] [stderr] 553 | 0x00010000...0xffffffff => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:561:17 [INFO] [stderr] | [INFO] [stderr] 561 | 0x0000000100000000...0xffffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0001_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:561:38 [INFO] [stderr] | [INFO] [stderr] 561 | 0x0000000100000000...0xffffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:602:23 [INFO] [stderr] | [INFO] [stderr] 602 | 0x10000...0xffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:627:13 [INFO] [stderr] | [INFO] [stderr] 627 | 0x00010000...0xffffffff => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:627:26 [INFO] [stderr] | [INFO] [stderr] 627 | 0x00010000...0xffffffff => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:635:13 [INFO] [stderr] | [INFO] [stderr] 635 | 0x0000000100000000...0xffffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0001_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:635:34 [INFO] [stderr] | [INFO] [stderr] 635 | 0x0000000100000000...0xffffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/de/read.rs:165:16 [INFO] [stderr] | [INFO] [stderr] 165 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 166 | | if bytes + self.index >= self.buf_len { [INFO] [stderr] 167 | | // Window requested requires us to read more bytes than we have buffered, so read [INFO] [stderr] 168 | | // in more [INFO] [stderr] ... | [INFO] [stderr] 247 | | } [INFO] [stderr] 248 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 165 | } else if bytes + self.index >= self.buf_len { [INFO] [stderr] 166 | // Window requested requires us to read more bytes than we have buffered, so read [INFO] [stderr] 167 | // in more [INFO] [stderr] 168 | [INFO] [stderr] 169 | let mut new_buffer = [0; MAX_BUF_LEN]; [INFO] [stderr] 170 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/de/read.rs:264:16 [INFO] [stderr] | [INFO] [stderr] 264 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 265 | | if bytes + self.index >= self.buf_len { [INFO] [stderr] 266 | | // Window requested requires us to read more bytes than we have buffered, so read [INFO] [stderr] 267 | | // in more [INFO] [stderr] ... | [INFO] [stderr] 311 | | } [INFO] [stderr] 312 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 264 | } else if bytes + self.index >= self.buf_len { [INFO] [stderr] 265 | // Window requested requires us to read more bytes than we have buffered, so read [INFO] [stderr] 266 | // in more [INFO] [stderr] 267 | [INFO] [stderr] 268 | let mut new_buffer = [0; MAX_BUF_LEN]; [INFO] [stderr] 269 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/de/read.rs:328:16 [INFO] [stderr] | [INFO] [stderr] 328 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 329 | | if bytes + self.index >= self.buf_len { [INFO] [stderr] 330 | | // Window requested requires us to read more bytes than we have buffered, so read [INFO] [stderr] 331 | | // in more [INFO] [stderr] ... | [INFO] [stderr] 375 | | } [INFO] [stderr] 376 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 328 | } else if bytes + self.index >= self.buf_len { [INFO] [stderr] 329 | // Window requested requires us to read more bytes than we have buffered, so read [INFO] [stderr] 330 | // in more [INFO] [stderr] 331 | [INFO] [stderr] 332 | let mut tmp_buffer = [0; MAX_BUF_LEN * 2]; [INFO] [stderr] 333 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/de/mod.rs:60:12 [INFO] [stderr] | [INFO] [stderr] 60 | byte & 0b00011111 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de/mod.rs:469:18 [INFO] [stderr] | [INFO] [stderr] 469 | _ => return Err(Error::NotAType), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::NotAType)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/de/mod.rs:644:16 [INFO] [stderr] | [INFO] [stderr] 644 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 645 | | if ty(byte) == Type::Misc { [INFO] [stderr] 646 | | Err(Error::UnexpectedValue(Type::Misc, val(byte))) [INFO] [stderr] 647 | | } else { [INFO] [stderr] 648 | | Err(Error::ExpectedType(vec![Type::Misc], byte)) [INFO] [stderr] 649 | | } [INFO] [stderr] 650 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 644 | } else if ty(byte) == Type::Misc { [INFO] [stderr] 645 | Err(Error::UnexpectedValue(Type::Misc, val(byte))) [INFO] [stderr] 646 | } else { [INFO] [stderr] 647 | Err(Error::ExpectedType(vec![Type::Misc], byte)) [INFO] [stderr] 648 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | const TYPE_UINT: u8 = 0b00000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | const TYPE_INT: u8 = 0b00100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:14:23 [INFO] [stderr] | [INFO] [stderr] 14 | const TYPE_MISC: u8 = 0b01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:15:26 [INFO] [stderr] | [INFO] [stderr] 15 | const TYPE_VARIANT: u8 = 0b01100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | const TYPE_SEQ: u8 = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:17:24 [INFO] [stderr] | [INFO] [stderr] 17 | const TYPE_BYTES: u8 = 0b10100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | const TYPE_MAP: u8 = 0b11000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:20:24 [INFO] [stderr] | [INFO] [stderr] 20 | const VALUE_MASK: u8 = 0b00011111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:135:14 [INFO] [stderr] | [INFO] [stderr] 135 | -0x80000000...-0x8001 | 0x8000...0x7fffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:135:46 [INFO] [stderr] | [INFO] [stderr] 135 | -0x80000000...-0x8001 | 0x8000...0x7fffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:163:14 [INFO] [stderr] | [INFO] [stderr] 163 | -0x80000000...-0x8001 | 0x8000...0x7fffffff => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:163:46 [INFO] [stderr] | [INFO] [stderr] 163 | -0x80000000...-0x8001 | 0x8000...0x7fffffff => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:170:14 [INFO] [stderr] | [INFO] [stderr] 170 | -0x8000000000000000...-0x80000001 | 0x80000000...0x7fffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x8000_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:170:36 [INFO] [stderr] | [INFO] [stderr] 170 | -0x8000000000000000...-0x80000001 | 0x80000000...0x7fffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:170:49 [INFO] [stderr] | [INFO] [stderr] 170 | -0x8000000000000000...-0x80000001 | 0x80000000...0x7fffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:170:62 [INFO] [stderr] | [INFO] [stderr] 170 | -0x8000000000000000...-0x80000001 | 0x80000000...0x7fffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x7fff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:224:23 [INFO] [stderr] | [INFO] [stderr] 224 | 0x10000...0xffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:249:23 [INFO] [stderr] | [INFO] [stderr] 249 | 0x10000...0xffffffff => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:256:13 [INFO] [stderr] | [INFO] [stderr] 256 | 0x100000000...0xffffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0001_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:256:27 [INFO] [stderr] | [INFO] [stderr] 256 | 0x100000000...0xffffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:320:13 [INFO] [stderr] | [INFO] [stderr] 320 | 0x00010000...0xffffffff => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:320:26 [INFO] [stderr] | [INFO] [stderr] 320 | 0x00010000...0xffffffff => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:328:13 [INFO] [stderr] | [INFO] [stderr] 328 | 0x0000000100000000...0xffffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0001_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:328:34 [INFO] [stderr] | [INFO] [stderr] 328 | 0x0000000100000000...0xffffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:401:23 [INFO] [stderr] | [INFO] [stderr] 401 | 0x10000...0xffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:433:17 [INFO] [stderr] | [INFO] [stderr] 433 | 0x00010000...0xffffffff => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:433:30 [INFO] [stderr] | [INFO] [stderr] 433 | 0x00010000...0xffffffff => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:441:17 [INFO] [stderr] | [INFO] [stderr] 441 | 0x0000000100000000...0xffffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0001_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:441:38 [INFO] [stderr] | [INFO] [stderr] 441 | 0x0000000100000000...0xffffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:487:23 [INFO] [stderr] | [INFO] [stderr] 487 | 0x10000...0xffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:512:13 [INFO] [stderr] | [INFO] [stderr] 512 | 0x00010000...0xffffffff => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:512:26 [INFO] [stderr] | [INFO] [stderr] 512 | 0x00010000...0xffffffff => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:520:13 [INFO] [stderr] | [INFO] [stderr] 520 | 0x0000000100000000...0xffffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0001_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:520:34 [INFO] [stderr] | [INFO] [stderr] 520 | 0x0000000100000000...0xffffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:553:17 [INFO] [stderr] | [INFO] [stderr] 553 | 0x00010000...0xffffffff => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:553:30 [INFO] [stderr] | [INFO] [stderr] 553 | 0x00010000...0xffffffff => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:561:17 [INFO] [stderr] | [INFO] [stderr] 561 | 0x0000000100000000...0xffffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0001_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:561:38 [INFO] [stderr] | [INFO] [stderr] 561 | 0x0000000100000000...0xffffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:602:23 [INFO] [stderr] | [INFO] [stderr] 602 | 0x10000...0xffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:627:13 [INFO] [stderr] | [INFO] [stderr] 627 | 0x00010000...0xffffffff => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:627:26 [INFO] [stderr] | [INFO] [stderr] 627 | 0x00010000...0xffffffff => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:635:13 [INFO] [stderr] | [INFO] [stderr] 635 | 0x0000000100000000...0xffffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0001_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ser/mod.rs:635:34 [INFO] [stderr] | [INFO] [stderr] 635 | 0x0000000100000000...0xffffffffffffffff | _ => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/de/read.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / match self { [INFO] [stderr] 15 | | &Borrowed::Transient(slice) => slice, [INFO] [stderr] 16 | | &Borrowed::Permanent(slice) => slice, [INFO] [stderr] 17 | | &Borrowed::Copied(ref vec) => vec.as_slice(), [INFO] [stderr] 18 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | match *self { [INFO] [stderr] 15 | Borrowed::Transient(slice) => slice, [INFO] [stderr] 16 | Borrowed::Permanent(slice) => slice, [INFO] [stderr] 17 | Borrowed::Copied(ref vec) => vec.as_slice(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/de/read.rs:22:21 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn into_vec(&self) -> Vec { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/de/read.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / match self { [INFO] [stderr] 24 | | &Borrowed::Transient(slice) => Vec::from(slice), [INFO] [stderr] 25 | | &Borrowed::Permanent(slice) => Vec::from(slice), [INFO] [stderr] 26 | | &Borrowed::Copied(ref vec) => vec.clone(), [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 23 | match *self { [INFO] [stderr] 24 | Borrowed::Transient(slice) => Vec::from(slice), [INFO] [stderr] 25 | Borrowed::Permanent(slice) => Vec::from(slice), [INFO] [stderr] 26 | Borrowed::Copied(ref vec) => vec.clone(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/de/read.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / match self { [INFO] [stderr] 33 | | &Borrowed::Transient(slice) => slice.len(), [INFO] [stderr] 34 | | &Borrowed::Permanent(slice) => slice.len(), [INFO] [stderr] 35 | | &Borrowed::Copied(ref vec) => vec.len(), [INFO] [stderr] 36 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | match *self { [INFO] [stderr] 33 | Borrowed::Transient(slice) => slice.len(), [INFO] [stderr] 34 | Borrowed::Permanent(slice) => slice.len(), [INFO] [stderr] 35 | Borrowed::Copied(ref vec) => vec.len(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u16`) [INFO] [stderr] --> src/de/mod.rs:180:27 [INFO] [stderr] | [INFO] [stderr] 180 | unsafe { *(self.must_read(2, true)?.as_slice().as_ptr() as *const u16) as usize } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/de/mod.rs:183:27 [INFO] [stderr] | [INFO] [stderr] 183 | unsafe { *(self.must_read(4, true)?.as_slice().as_ptr() as *const u32) as usize } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u64`) [INFO] [stderr] --> src/de/mod.rs:187:27 [INFO] [stderr] | [INFO] [stderr] 187 | unsafe { *(self.must_read(8, true)?.as_slice().as_ptr() as *const u64) as usize } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u16`) [INFO] [stderr] --> src/de/mod.rs:205:27 [INFO] [stderr] | [INFO] [stderr] 205 | unsafe { *(self.must_read(2, true)?.as_slice().as_ptr() as *const u16) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/de/mod.rs:208:27 [INFO] [stderr] | [INFO] [stderr] 208 | unsafe { *(self.must_read(4, true)?.as_slice().as_ptr() as *const u32) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u64`) [INFO] [stderr] --> src/de/mod.rs:211:27 [INFO] [stderr] | [INFO] [stderr] 211 | unsafe { *(self.must_read(8, true)?.as_slice().as_ptr() as *const u64) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const i16`) [INFO] [stderr] --> src/de/mod.rs:229:27 [INFO] [stderr] | [INFO] [stderr] 229 | unsafe { *(self.must_read(2, true)?.as_slice().as_ptr() as *const i16) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const i32`) [INFO] [stderr] --> src/de/mod.rs:232:27 [INFO] [stderr] | [INFO] [stderr] 232 | unsafe { *(self.must_read(4, true)?.as_slice().as_ptr() as *const i32) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const i64`) [INFO] [stderr] --> src/de/mod.rs:235:27 [INFO] [stderr] | [INFO] [stderr] 235 | unsafe { *(self.must_read(8, true)?.as_slice().as_ptr() as *const i64) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const f32`) [INFO] [stderr] --> src/de/mod.rs:248:27 [INFO] [stderr] | [INFO] [stderr] 248 | unsafe { *(self.must_read(4, true)?.as_slice().as_ptr() as *const f32) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const f64`) [INFO] [stderr] --> src/de/mod.rs:251:27 [INFO] [stderr] | [INFO] [stderr] 251 | unsafe { *(self.must_read(8, true)?.as_slice().as_ptr() as *const f64) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const f32`) [INFO] [stderr] --> src/de/mod.rs:415:31 [INFO] [stderr] | [INFO] [stderr] 415 | unsafe { *(self.must_read(4, true)?.as_slice().as_ptr() as *const f32) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const f64`) [INFO] [stderr] --> src/de/mod.rs:418:31 [INFO] [stderr] | [INFO] [stderr] 418 | unsafe { *(self.must_read(8, true)?.as_slice().as_ptr() as *const f64) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:521:43 [INFO] [stderr] | [INFO] [stderr] 521 | value @ 0...23 => value as u32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:522:31 [INFO] [stderr] | [INFO] [stderr] 522 | 24 => self.next()? as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.next()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:524:29 [INFO] [stderr] | [INFO] [stderr] 524 | *(self.must_read(2, true)?.as_slice().as_ptr() as *const u16) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(*(self.must_read(2, true)?.as_slice().as_ptr() as *const u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u16`) [INFO] [stderr] --> src/de/mod.rs:524:30 [INFO] [stderr] | [INFO] [stderr] 524 | *(self.must_read(2, true)?.as_slice().as_ptr() as *const u16) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/de/mod.rs:527:30 [INFO] [stderr] | [INFO] [stderr] 527 | *(self.must_read(4, true)?.as_slice().as_ptr() as *const u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:754:58 [INFO] [stderr] | [INFO] [stderr] 754 | value @ 0...23 => visitor.visit_enum((value as u32).into_deserializer()), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:755:46 [INFO] [stderr] | [INFO] [stderr] 755 | 24 => visitor.visit_enum((self.next()? as u32).into_deserializer()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.next()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:758:29 [INFO] [stderr] | [INFO] [stderr] 758 | *(self.must_read(2, true)?.as_slice().as_ptr() as *const u16) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(*(self.must_read(2, true)?.as_slice().as_ptr() as *const u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u16`) [INFO] [stderr] --> src/de/mod.rs:758:30 [INFO] [stderr] | [INFO] [stderr] 758 | *(self.must_read(2, true)?.as_slice().as_ptr() as *const u16) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/de/mod.rs:763:30 [INFO] [stderr] | [INFO] [stderr] 763 | *(self.must_read(4, true)?.as_slice().as_ptr() as *const u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:784:53 [INFO] [stderr] | [INFO] [stderr] 784 | value @ 0...23 => visitor.visit_u32(value as u32), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:785:41 [INFO] [stderr] | [INFO] [stderr] 785 | 24 => visitor.visit_u32(self.next()? as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.next()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:788:25 [INFO] [stderr] | [INFO] [stderr] 788 | *(self.must_read(2, true)?.as_slice().as_ptr() as *const u16) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(*(self.must_read(2, true)?.as_slice().as_ptr() as *const u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u16`) [INFO] [stderr] --> src/de/mod.rs:788:26 [INFO] [stderr] | [INFO] [stderr] 788 | *(self.must_read(2, true)?.as_slice().as_ptr() as *const u16) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/de/mod.rs:793:26 [INFO] [stderr] | [INFO] [stderr] 793 | *(self.must_read(4, true)?.as_slice().as_ptr() as *const u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u16`) [INFO] [stderr] --> src/de/mod.rs:802:34 [INFO] [stderr] | [INFO] [stderr] 802 | *(self.must_read(2, true)?.as_slice().as_ptr() as *const u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/de/mod.rs:807:34 [INFO] [stderr] | [INFO] [stderr] 807 | *(self.must_read(4, true)?.as_slice().as_ptr() as *const u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/ser/mod.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | -0x80...-8 | 16...0x7f | _ => { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/ser/mod.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | -8...-1 => self.put_byte(TYPE_INT | ((v + 24) as u8 & VALUE_MASK)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/ser/mod.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | -0x80...-8 | 16...0x7f => { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/ser/mod.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | -8...-1 => self.put_byte(TYPE_INT | ((v + 24) as u8 & VALUE_MASK)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/ser/mod.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | -0x80...-8 | 16...0x7f => { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/ser/mod.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | -8...-1 => self.put_byte(TYPE_INT | ((v + 24) as u8 & VALUE_MASK)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/ser/mod.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | -0x80...-8 | 16...0x7f => { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/ser/mod.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | -8...-1 => self.put_byte(TYPE_INT | ((v + 24) as u8 & VALUE_MASK)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] error: aborting due to 21 previous errors [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/de/read.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / match self { [INFO] [stderr] 15 | | &Borrowed::Transient(slice) => slice, [INFO] [stderr] 16 | | &Borrowed::Permanent(slice) => slice, [INFO] [stderr] 17 | | &Borrowed::Copied(ref vec) => vec.as_slice(), [INFO] [stderr] 18 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | match *self { [INFO] [stderr] 15 | Borrowed::Transient(slice) => slice, [INFO] [stderr] 16 | Borrowed::Permanent(slice) => slice, [INFO] [stderr] 17 | Borrowed::Copied(ref vec) => vec.as_slice(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/de/read.rs:22:21 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn into_vec(&self) -> Vec { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/de/read.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / match self { [INFO] [stderr] 24 | | &Borrowed::Transient(slice) => Vec::from(slice), [INFO] [stderr] 25 | | &Borrowed::Permanent(slice) => Vec::from(slice), [INFO] [stderr] 26 | | &Borrowed::Copied(ref vec) => vec.clone(), [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 23 | match *self { [INFO] [stderr] 24 | Borrowed::Transient(slice) => Vec::from(slice), [INFO] [stderr] 25 | Borrowed::Permanent(slice) => Vec::from(slice), [INFO] [stderr] 26 | Borrowed::Copied(ref vec) => vec.clone(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/de/read.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / match self { [INFO] [stderr] 33 | | &Borrowed::Transient(slice) => slice.len(), [INFO] [stderr] 34 | | &Borrowed::Permanent(slice) => slice.len(), [INFO] [stderr] 35 | | &Borrowed::Copied(ref vec) => vec.len(), [INFO] [stderr] 36 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | match *self { [INFO] [stderr] 33 | Borrowed::Transient(slice) => slice.len(), [INFO] [stderr] 34 | Borrowed::Permanent(slice) => slice.len(), [INFO] [stderr] 35 | Borrowed::Copied(ref vec) => vec.len(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: Could not compile `serde_dbor`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u16`) [INFO] [stderr] --> src/de/mod.rs:180:27 [INFO] [stderr] | [INFO] [stderr] 180 | unsafe { *(self.must_read(2, true)?.as_slice().as_ptr() as *const u16) as usize } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/de/mod.rs:183:27 [INFO] [stderr] | [INFO] [stderr] 183 | unsafe { *(self.must_read(4, true)?.as_slice().as_ptr() as *const u32) as usize } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u64`) [INFO] [stderr] --> src/de/mod.rs:187:27 [INFO] [stderr] | [INFO] [stderr] 187 | unsafe { *(self.must_read(8, true)?.as_slice().as_ptr() as *const u64) as usize } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u16`) [INFO] [stderr] --> src/de/mod.rs:205:27 [INFO] [stderr] | [INFO] [stderr] 205 | unsafe { *(self.must_read(2, true)?.as_slice().as_ptr() as *const u16) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/de/mod.rs:208:27 [INFO] [stderr] | [INFO] [stderr] 208 | unsafe { *(self.must_read(4, true)?.as_slice().as_ptr() as *const u32) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u64`) [INFO] [stderr] --> src/de/mod.rs:211:27 [INFO] [stderr] | [INFO] [stderr] 211 | unsafe { *(self.must_read(8, true)?.as_slice().as_ptr() as *const u64) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const i16`) [INFO] [stderr] --> src/de/mod.rs:229:27 [INFO] [stderr] | [INFO] [stderr] 229 | unsafe { *(self.must_read(2, true)?.as_slice().as_ptr() as *const i16) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const i32`) [INFO] [stderr] --> src/de/mod.rs:232:27 [INFO] [stderr] | [INFO] [stderr] 232 | unsafe { *(self.must_read(4, true)?.as_slice().as_ptr() as *const i32) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const i64`) [INFO] [stderr] --> src/de/mod.rs:235:27 [INFO] [stderr] | [INFO] [stderr] 235 | unsafe { *(self.must_read(8, true)?.as_slice().as_ptr() as *const i64) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const f32`) [INFO] [stderr] --> src/de/mod.rs:248:27 [INFO] [stderr] | [INFO] [stderr] 248 | unsafe { *(self.must_read(4, true)?.as_slice().as_ptr() as *const f32) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const f64`) [INFO] [stderr] --> src/de/mod.rs:251:27 [INFO] [stderr] | [INFO] [stderr] 251 | unsafe { *(self.must_read(8, true)?.as_slice().as_ptr() as *const f64) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const f32`) [INFO] [stderr] --> src/de/mod.rs:415:31 [INFO] [stderr] | [INFO] [stderr] 415 | unsafe { *(self.must_read(4, true)?.as_slice().as_ptr() as *const f32) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const f64`) [INFO] [stderr] --> src/de/mod.rs:418:31 [INFO] [stderr] | [INFO] [stderr] 418 | unsafe { *(self.must_read(8, true)?.as_slice().as_ptr() as *const f64) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:521:43 [INFO] [stderr] | [INFO] [stderr] 521 | value @ 0...23 => value as u32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:522:31 [INFO] [stderr] | [INFO] [stderr] 522 | 24 => self.next()? as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.next()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:524:29 [INFO] [stderr] | [INFO] [stderr] 524 | *(self.must_read(2, true)?.as_slice().as_ptr() as *const u16) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(*(self.must_read(2, true)?.as_slice().as_ptr() as *const u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u16`) [INFO] [stderr] --> src/de/mod.rs:524:30 [INFO] [stderr] | [INFO] [stderr] 524 | *(self.must_read(2, true)?.as_slice().as_ptr() as *const u16) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/de/mod.rs:527:30 [INFO] [stderr] | [INFO] [stderr] 527 | *(self.must_read(4, true)?.as_slice().as_ptr() as *const u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:754:58 [INFO] [stderr] | [INFO] [stderr] 754 | value @ 0...23 => visitor.visit_enum((value as u32).into_deserializer()), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:755:46 [INFO] [stderr] | [INFO] [stderr] 755 | 24 => visitor.visit_enum((self.next()? as u32).into_deserializer()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.next()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:758:29 [INFO] [stderr] | [INFO] [stderr] 758 | *(self.must_read(2, true)?.as_slice().as_ptr() as *const u16) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(*(self.must_read(2, true)?.as_slice().as_ptr() as *const u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u16`) [INFO] [stderr] --> src/de/mod.rs:758:30 [INFO] [stderr] | [INFO] [stderr] 758 | *(self.must_read(2, true)?.as_slice().as_ptr() as *const u16) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/de/mod.rs:763:30 [INFO] [stderr] | [INFO] [stderr] 763 | *(self.must_read(4, true)?.as_slice().as_ptr() as *const u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:784:53 [INFO] [stderr] | [INFO] [stderr] 784 | value @ 0...23 => visitor.visit_u32(value as u32), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:785:41 [INFO] [stderr] | [INFO] [stderr] 785 | 24 => visitor.visit_u32(self.next()? as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.next()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de/mod.rs:788:25 [INFO] [stderr] | [INFO] [stderr] 788 | *(self.must_read(2, true)?.as_slice().as_ptr() as *const u16) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(*(self.must_read(2, true)?.as_slice().as_ptr() as *const u16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u16`) [INFO] [stderr] --> src/de/mod.rs:788:26 [INFO] [stderr] | [INFO] [stderr] 788 | *(self.must_read(2, true)?.as_slice().as_ptr() as *const u16) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/de/mod.rs:793:26 [INFO] [stderr] | [INFO] [stderr] 793 | *(self.must_read(4, true)?.as_slice().as_ptr() as *const u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u16`) [INFO] [stderr] --> src/de/mod.rs:802:34 [INFO] [stderr] | [INFO] [stderr] 802 | *(self.must_read(2, true)?.as_slice().as_ptr() as *const u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u32`) [INFO] [stderr] --> src/de/mod.rs:807:34 [INFO] [stderr] | [INFO] [stderr] 807 | *(self.must_read(4, true)?.as_slice().as_ptr() as *const u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/ser/mod.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | -0x80...-8 | 16...0x7f | _ => { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/ser/mod.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | -8...-1 => self.put_byte(TYPE_INT | ((v + 24) as u8 & VALUE_MASK)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/ser/mod.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | -0x80...-8 | 16...0x7f => { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/ser/mod.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | -8...-1 => self.put_byte(TYPE_INT | ((v + 24) as u8 & VALUE_MASK)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/ser/mod.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | -0x80...-8 | 16...0x7f => { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/ser/mod.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | -8...-1 => self.put_byte(TYPE_INT | ((v + 24) as u8 & VALUE_MASK)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/ser/mod.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | -0x80...-8 | 16...0x7f => { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/ser/mod.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | -8...-1 => self.put_byte(TYPE_INT | ((v + 24) as u8 & VALUE_MASK)), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] error: aborting due to 21 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `serde_dbor`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d4c42337021b734d7282b56ece12ff49a853a3c5852d620e2dfa9ca305340d0a"` [INFO] running `"docker" "rm" "-f" "d4c42337021b734d7282b56ece12ff49a853a3c5852d620e2dfa9ca305340d0a"` [INFO] [stdout] d4c42337021b734d7282b56ece12ff49a853a3c5852d620e2dfa9ca305340d0a