[INFO] crate serde_db 0.5.1 is already in cache [INFO] extracting crate serde_db 0.5.1 into work/ex/clippy-test-run/sources/stable/reg/serde_db/0.5.1 [INFO] extracting crate serde_db 0.5.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde_db/0.5.1 [INFO] validating manifest of serde_db-0.5.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of serde_db-0.5.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing serde_db-0.5.1 [INFO] finished frobbing serde_db-0.5.1 [INFO] frobbed toml for serde_db-0.5.1 written to work/ex/clippy-test-run/sources/stable/reg/serde_db/0.5.1/Cargo.toml [INFO] started frobbing serde_db-0.5.1 [INFO] finished frobbing serde_db-0.5.1 [INFO] frobbed toml for serde_db-0.5.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde_db/0.5.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting serde_db-0.5.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/serde_db/0.5.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 206473a5be5ed5aa922d770b38c3f3d704fd28e97258316704a727db6f3b33b2 [INFO] running `"docker" "start" "-a" "206473a5be5ed5aa922d770b38c3f3d704fd28e97258316704a727db6f3b33b2"` [INFO] [stderr] Checking pulldown-cmark v0.1.2 [INFO] [stderr] Checking serde_db v0.5.1 (/opt/crater/workdir) [INFO] [stderr] Checking flexi_logger v0.6.14 [INFO] [stderr] Checking rust_decimal v0.7.2 [INFO] [stderr] warning: lint name `len_without_is_empty` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/de/deserializable_row.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | #[allow(len_without_is_empty)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::len_without_is_empty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `len_without_is_empty` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/de/deserializable_row.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | #[allow(len_without_is_empty)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::len_without_is_empty` [INFO] [stderr] [INFO] [stderr] Checking version-sync v0.5.0 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/mock_db/row.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/mock_db/row.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | values: values, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/mock_db/row.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/mock_db/row.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | values: values, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/mock_db/row.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/mock_db/row.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | values: values, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/mock_db/row.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/mock_db/row.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | values: values, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/mock_db/row.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/mock_db/row.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | values: values, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `len_without_is_empty` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/de/deserializable_row.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | #[allow(len_without_is_empty)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::len_without_is_empty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/mock_db/row.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/mock_db/row.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | values: values, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `len_without_is_empty` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/de/deserializable_row.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | #[allow(len_without_is_empty)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::len_without_is_empty` [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/test_resultset_1xn.rs:103:14 [INFO] [stderr] | [INFO] [stderr] 103 | for i in 1..len + 1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test_special_types.rs:114:46 [INFO] [stderr] | [INFO] [stderr] 114 | MValue::Double(10.0 * i as f64 + 3.456789), [INFO] [stderr] | ^^^^^^^^ help: consider: `3.456_789` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> tests/test_resultset_mxn.rs:192:11 [INFO] [stderr] | [INFO] [stderr] 192 | }) [INFO] [stderr] | ___________^ [INFO] [stderr] 193 | | .fold(0, |acc, i| acc + i); [INFO] [stderr] | |__________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/test_resultset_mxn.rs:240:14 [INFO] [stderr] | [INFO] [stderr] 240 | for i in 1..len + 1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.72s [INFO] running `"docker" "inspect" "206473a5be5ed5aa922d770b38c3f3d704fd28e97258316704a727db6f3b33b2"` [INFO] running `"docker" "rm" "-f" "206473a5be5ed5aa922d770b38c3f3d704fd28e97258316704a727db6f3b33b2"` [INFO] [stdout] 206473a5be5ed5aa922d770b38c3f3d704fd28e97258316704a727db6f3b33b2