[INFO] crate serde_codegen_internals 0.14.2 is already in cache [INFO] extracting crate serde_codegen_internals 0.14.2 into work/ex/clippy-test-run/sources/stable/reg/serde_codegen_internals/0.14.2 [INFO] extracting crate serde_codegen_internals 0.14.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde_codegen_internals/0.14.2 [INFO] validating manifest of serde_codegen_internals-0.14.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of serde_codegen_internals-0.14.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing serde_codegen_internals-0.14.2 [INFO] finished frobbing serde_codegen_internals-0.14.2 [INFO] frobbed toml for serde_codegen_internals-0.14.2 written to work/ex/clippy-test-run/sources/stable/reg/serde_codegen_internals/0.14.2/Cargo.toml [INFO] started frobbing serde_codegen_internals-0.14.2 [INFO] finished frobbing serde_codegen_internals-0.14.2 [INFO] frobbed toml for serde_codegen_internals-0.14.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde_codegen_internals/0.14.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting serde_codegen_internals-0.14.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/serde_codegen_internals/0.14.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0a6a607e4b6318be3f3149f35b5063ce972721f4d2c46e38dae7cee6b54762a5 [INFO] running `"docker" "start" "-a" "0a6a607e4b6318be3f3149f35b5063ce972721f4d2c46e38dae7cee6b54762a5"` [INFO] [stderr] Checking syn v0.11.11 [INFO] [stderr] Checking serde_codegen_internals v0.14.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | attrs: attrs, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `attrs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | style: style, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attr.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | cx: cx, [INFO] [stderr] | ^^^^^^ help: replace it with: `cx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attr.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attr.rs:323:37 [INFO] [stderr] | [INFO] [stderr] 323 | EnumTag::Internal { tag: tag } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attr.rs:339:21 [INFO] [stderr] | [INFO] [stderr] 339 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attr.rs:340:21 [INFO] [stderr] | [INFO] [stderr] 340 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attr.rs:359:13 [INFO] [stderr] | [INFO] [stderr] 359 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attr.rs:483:13 [INFO] [stderr] | [INFO] [stderr] 483 | ser_renamed: ser_renamed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ser_renamed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attr.rs:484:13 [INFO] [stderr] | [INFO] [stderr] 484 | de_renamed: de_renamed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `de_renamed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attr.rs:680:13 [INFO] [stderr] | [INFO] [stderr] 680 | ser_renamed: ser_renamed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ser_renamed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attr.rs:681:13 [INFO] [stderr] | [INFO] [stderr] 681 | de_renamed: de_renamed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `de_renamed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | attrs: attrs, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `attrs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | style: style, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attr.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | cx: cx, [INFO] [stderr] | ^^^^^^ help: replace it with: `cx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attr.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attr.rs:323:37 [INFO] [stderr] | [INFO] [stderr] 323 | EnumTag::Internal { tag: tag } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attr.rs:339:21 [INFO] [stderr] | [INFO] [stderr] 339 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attr.rs:340:21 [INFO] [stderr] | [INFO] [stderr] 340 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attr.rs:359:13 [INFO] [stderr] | [INFO] [stderr] 359 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attr.rs:483:13 [INFO] [stderr] | [INFO] [stderr] 483 | ser_renamed: ser_renamed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ser_renamed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attr.rs:484:13 [INFO] [stderr] | [INFO] [stderr] 484 | de_renamed: de_renamed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `de_renamed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attr.rs:680:13 [INFO] [stderr] | [INFO] [stderr] 680 | ser_renamed: ser_renamed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ser_renamed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attr.rs:681:13 [INFO] [stderr] | [INFO] [stderr] 681 | de_renamed: de_renamed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `de_renamed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/case.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/case.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/ast.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | for ref mut variant in variants { [INFO] [stderr] | ^^^^^^^^^^^^^^^ -------- help: try: `let variant = &mut variants;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/ast.rs:53:25 [INFO] [stderr] | [INFO] [stderr] 53 | for ref mut field in &mut variant.fields { [INFO] [stderr] | ^^^^^^^^^^^^^ ------------------- help: try: `let field = &mut &mut variant.fields;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 37 [INFO] [stderr] --> src/attr.rs:139:5 [INFO] [stderr] | [INFO] [stderr] 139 | / pub fn from_ast(cx: &Ctxt, item: &syn::MacroInput) -> Self { [INFO] [stderr] 140 | | let mut ser_name = Attr::none(cx, "rename"); [INFO] [stderr] 141 | | let mut de_name = Attr::none(cx, "rename"); [INFO] [stderr] 142 | | let mut deny_unknown_fields = BoolAttr::none(cx, "deny_unknown_fields"); [INFO] [stderr] ... | [INFO] [stderr] 362 | | } [INFO] [stderr] 363 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/attr.rs:393:22 [INFO] [stderr] | [INFO] [stderr] 393 | pub fn from_type(&self) -> Option<&syn::Ty> { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/attr.rs:397:22 [INFO] [stderr] | [INFO] [stderr] 397 | pub fn into_type(&self) -> Option<&syn::Ty> { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/attr.rs:546:5 [INFO] [stderr] | [INFO] [stderr] 546 | / pub fn from_ast(cx: &Ctxt, index: usize, field: &syn::Field) -> Self { [INFO] [stderr] 547 | | let mut ser_name = Attr::none(cx, "rename"); [INFO] [stderr] 548 | | let mut de_name = Attr::none(cx, "rename"); [INFO] [stderr] 549 | | let mut skip_serializing = BoolAttr::none(cx, "skip_serializing"); [INFO] [stderr] ... | [INFO] [stderr] 690 | | } [INFO] [stderr] 691 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/attr.rs:789:62 [INFO] [stderr] | [INFO] [stderr] 789 | List(ref name, ref items) if name == "serde" => Some(items.iter().cloned().collect()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/case.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/case.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/ast.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | for ref mut variant in variants { [INFO] [stderr] | ^^^^^^^^^^^^^^^ -------- help: try: `let variant = &mut variants;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/ast.rs:53:25 [INFO] [stderr] | [INFO] [stderr] 53 | for ref mut field in &mut variant.fields { [INFO] [stderr] | ^^^^^^^^^^^^^ ------------------- help: try: `let field = &mut &mut variant.fields;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 37 [INFO] [stderr] --> src/attr.rs:139:5 [INFO] [stderr] | [INFO] [stderr] 139 | / pub fn from_ast(cx: &Ctxt, item: &syn::MacroInput) -> Self { [INFO] [stderr] 140 | | let mut ser_name = Attr::none(cx, "rename"); [INFO] [stderr] 141 | | let mut de_name = Attr::none(cx, "rename"); [INFO] [stderr] 142 | | let mut deny_unknown_fields = BoolAttr::none(cx, "deny_unknown_fields"); [INFO] [stderr] ... | [INFO] [stderr] 362 | | } [INFO] [stderr] 363 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/attr.rs:393:22 [INFO] [stderr] | [INFO] [stderr] 393 | pub fn from_type(&self) -> Option<&syn::Ty> { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/attr.rs:397:22 [INFO] [stderr] | [INFO] [stderr] 397 | pub fn into_type(&self) -> Option<&syn::Ty> { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/attr.rs:546:5 [INFO] [stderr] | [INFO] [stderr] 546 | / pub fn from_ast(cx: &Ctxt, index: usize, field: &syn::Field) -> Self { [INFO] [stderr] 547 | | let mut ser_name = Attr::none(cx, "rename"); [INFO] [stderr] 548 | | let mut de_name = Attr::none(cx, "rename"); [INFO] [stderr] 549 | | let mut skip_serializing = BoolAttr::none(cx, "skip_serializing"); [INFO] [stderr] ... | [INFO] [stderr] 690 | | } [INFO] [stderr] 691 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/attr.rs:789:62 [INFO] [stderr] | [INFO] [stderr] 789 | List(ref name, ref items) if name == "serde" => Some(items.iter().cloned().collect()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.49s [INFO] running `"docker" "inspect" "0a6a607e4b6318be3f3149f35b5063ce972721f4d2c46e38dae7cee6b54762a5"` [INFO] running `"docker" "rm" "-f" "0a6a607e4b6318be3f3149f35b5063ce972721f4d2c46e38dae7cee6b54762a5"` [INFO] [stdout] 0a6a607e4b6318be3f3149f35b5063ce972721f4d2c46e38dae7cee6b54762a5