[INFO] crate serde_bencode 0.2.0 is already in cache [INFO] extracting crate serde_bencode 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/serde_bencode/0.2.0 [INFO] extracting crate serde_bencode 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde_bencode/0.2.0 [INFO] validating manifest of serde_bencode-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of serde_bencode-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing serde_bencode-0.2.0 [INFO] finished frobbing serde_bencode-0.2.0 [INFO] frobbed toml for serde_bencode-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/serde_bencode/0.2.0/Cargo.toml [INFO] started frobbing serde_bencode-0.2.0 [INFO] finished frobbing serde_bencode-0.2.0 [INFO] frobbed toml for serde_bencode-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde_bencode/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting serde_bencode-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/serde_bencode/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 67035602e2fee7a2ec329609883bb72f7cc73ea2367e74d4e41ead7587cb5922 [INFO] running `"docker" "start" "-a" "67035602e2fee7a2ec329609883bb72f7cc73ea2367e74d4e41ead7587cb5922"` [INFO] [stderr] Checking serde_bencode v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser/mod.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | ser: ser, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ser` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:13:25 [INFO] [stderr] | [INFO] [stderr] 13 | BencodeAccess { de: de, len: len } [INFO] [stderr] | ^^^^^^ help: replace it with: `de` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:13:33 [INFO] [stderr] | [INFO] [stderr] 13 | BencodeAccess { de: de, len: len } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser/mod.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | ser: ser, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ser` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:13:25 [INFO] [stderr] | [INFO] [stderr] 13 | BencodeAccess { de: de, len: len } [INFO] [stderr] | ^^^^^^ help: replace it with: `de` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:13:33 [INFO] [stderr] | [INFO] [stderr] 13 | BencodeAccess { de: de, len: len } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser/string.rs:38:28 [INFO] [stderr] | [INFO] [stderr] 38 | self.serialize_i64(value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser/string.rs:41:28 [INFO] [stderr] | [INFO] [stderr] 41 | self.serialize_i64(value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser/string.rs:44:28 [INFO] [stderr] | [INFO] [stderr] 44 | self.serialize_i64(value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser/string.rs:50:28 [INFO] [stderr] | [INFO] [stderr] 50 | self.serialize_u64(value as u64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser/string.rs:53:28 [INFO] [stderr] | [INFO] [stderr] 53 | self.serialize_u64(value as u64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser/string.rs:56:28 [INFO] [stderr] | [INFO] [stderr] 56 | self.serialize_u64(value as u64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ser/string.rs:62:28 [INFO] [stderr] | [INFO] [stderr] 62 | self.serialize_f64(value as f64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ser::Serializer` [INFO] [stderr] --> src/ser/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Serializer { [INFO] [stderr] 15 | | Serializer { buf: Vec::new() } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ser/mod.rs:123:14 [INFO] [stderr] | [INFO] [stderr] 123 | .ok_or(Error::InvalidValue("`serialize_value` called without calling `serialize_key`" [INFO] [stderr] | ______________^ [INFO] [stderr] 124 | | .to_string()))?; [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 123 | .ok_or_else(|| Error::InvalidValue("`serialize_value` called without calling `serialize_key`" [INFO] [stderr] 124 | .to_string()))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser/mod.rs:199:28 [INFO] [stderr] | [INFO] [stderr] 199 | self.serialize_i64(value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser/mod.rs:202:28 [INFO] [stderr] | [INFO] [stderr] 202 | self.serialize_i64(value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser/mod.rs:205:28 [INFO] [stderr] | [INFO] [stderr] 205 | self.serialize_i64(value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser/mod.rs:214:28 [INFO] [stderr] | [INFO] [stderr] 214 | self.serialize_i64(value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser/mod.rs:217:28 [INFO] [stderr] | [INFO] [stderr] 217 | self.serialize_i64(value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser/mod.rs:220:28 [INFO] [stderr] | [INFO] [stderr] 220 | self.serialize_i64(value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the `r @ _` pattern can be written as just `r` [INFO] [stderr] --> src/de.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | r @ _ => { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/de.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / match self.len { [INFO] [stderr] 31 | | Some(l) => { [INFO] [stderr] 32 | | let l = l - 1; [INFO] [stderr] 33 | | self.len = Some(l); [INFO] [stderr] ... | [INFO] [stderr] 38 | | None => (), [INFO] [stderr] 39 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | if let Some(l) = self.len { [INFO] [stderr] 31 | let l = l - 1; [INFO] [stderr] 32 | self.len = Some(l); [INFO] [stderr] 33 | if l == 0 && ParseResult::End != self.de.parse()? { [INFO] [stderr] 34 | return Err(Error::InvalidType("expected `e`".to_string())); [INFO] [stderr] 35 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the `r @ _` pattern can be written as just `r` [INFO] [stderr] --> src/de.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | r @ _ => { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `t @ _` pattern can be written as just `t` [INFO] [stderr] --> src/de.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | t @ _ => Err(Error::InvalidValue(format!("Expected bytes or map; got `{:?}`", t))), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `c @ _` pattern can be written as just `c` [INFO] [stderr] --> src/de.rs:226:13 [INFO] [stderr] | [INFO] [stderr] 226 | c @ _ => Err(Error::InvalidValue(format!("Invalid character `{}`", c as char))), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser/string.rs:38:28 [INFO] [stderr] | [INFO] [stderr] 38 | self.serialize_i64(value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser/string.rs:41:28 [INFO] [stderr] | [INFO] [stderr] 41 | self.serialize_i64(value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser/string.rs:44:28 [INFO] [stderr] | [INFO] [stderr] 44 | self.serialize_i64(value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser/string.rs:50:28 [INFO] [stderr] | [INFO] [stderr] 50 | self.serialize_u64(value as u64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser/string.rs:53:28 [INFO] [stderr] | [INFO] [stderr] 53 | self.serialize_u64(value as u64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser/string.rs:56:28 [INFO] [stderr] | [INFO] [stderr] 56 | self.serialize_u64(value as u64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ser/string.rs:62:28 [INFO] [stderr] | [INFO] [stderr] 62 | self.serialize_f64(value as f64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ser::Serializer` [INFO] [stderr] --> src/ser/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Serializer { [INFO] [stderr] 15 | | Serializer { buf: Vec::new() } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ser/mod.rs:123:14 [INFO] [stderr] | [INFO] [stderr] 123 | .ok_or(Error::InvalidValue("`serialize_value` called without calling `serialize_key`" [INFO] [stderr] | ______________^ [INFO] [stderr] 124 | | .to_string()))?; [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 123 | .ok_or_else(|| Error::InvalidValue("`serialize_value` called without calling `serialize_key`" [INFO] [stderr] 124 | .to_string()))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser/mod.rs:199:28 [INFO] [stderr] | [INFO] [stderr] 199 | self.serialize_i64(value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser/mod.rs:202:28 [INFO] [stderr] | [INFO] [stderr] 202 | self.serialize_i64(value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser/mod.rs:205:28 [INFO] [stderr] | [INFO] [stderr] 205 | self.serialize_i64(value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser/mod.rs:214:28 [INFO] [stderr] | [INFO] [stderr] 214 | self.serialize_i64(value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser/mod.rs:217:28 [INFO] [stderr] | [INFO] [stderr] 217 | self.serialize_i64(value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser/mod.rs:220:28 [INFO] [stderr] | [INFO] [stderr] 220 | self.serialize_i64(value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the `r @ _` pattern can be written as just `r` [INFO] [stderr] --> src/de.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | r @ _ => { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/de.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / match self.len { [INFO] [stderr] 31 | | Some(l) => { [INFO] [stderr] 32 | | let l = l - 1; [INFO] [stderr] 33 | | self.len = Some(l); [INFO] [stderr] ... | [INFO] [stderr] 38 | | None => (), [INFO] [stderr] 39 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | if let Some(l) = self.len { [INFO] [stderr] 31 | let l = l - 1; [INFO] [stderr] 32 | self.len = Some(l); [INFO] [stderr] 33 | if l == 0 && ParseResult::End != self.de.parse()? { [INFO] [stderr] 34 | return Err(Error::InvalidType("expected `e`".to_string())); [INFO] [stderr] 35 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the `r @ _` pattern can be written as just `r` [INFO] [stderr] --> src/de.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | r @ _ => { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `t @ _` pattern can be written as just `t` [INFO] [stderr] --> src/de.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | t @ _ => Err(Error::InvalidValue(format!("Expected bytes or map; got `{:?}`", t))), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `c @ _` pattern can be written as just `c` [INFO] [stderr] --> src/de.rs:226:13 [INFO] [stderr] | [INFO] [stderr] 226 | c @ _ => Err(Error::InvalidValue(format!("Invalid character `{}`", c as char))), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/benches.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `serde_bencode`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> examples/parse_torrent.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / if let &Some(ref al) = &torrent.announce_list { [INFO] [stderr] 72 | | for a in al { [INFO] [stderr] 73 | | println!("announce list:\t{}", a[0]); [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 71 | if let Some(ref al) = torrent.announce_list { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> examples/parse_torrent.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | / if let &Some(ref files) = &torrent.info.files { [INFO] [stderr] 87 | | for f in files { [INFO] [stderr] 88 | | println!("file path:\t{:?}", f.path); [INFO] [stderr] 89 | | println!("file length:\t{}", f.length); [INFO] [stderr] 90 | | println!("file md5sum:\t{:?}", f.md5sum); [INFO] [stderr] 91 | | } [INFO] [stderr] 92 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 86 | if let Some(ref files) = torrent.info.files { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "67035602e2fee7a2ec329609883bb72f7cc73ea2367e74d4e41ead7587cb5922"` [INFO] running `"docker" "rm" "-f" "67035602e2fee7a2ec329609883bb72f7cc73ea2367e74d4e41ead7587cb5922"` [INFO] [stdout] 67035602e2fee7a2ec329609883bb72f7cc73ea2367e74d4e41ead7587cb5922