[INFO] crate serde_any 0.5.0 is already in cache [INFO] extracting crate serde_any 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/serde_any/0.5.0 [INFO] extracting crate serde_any 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde_any/0.5.0 [INFO] validating manifest of serde_any-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of serde_any-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing serde_any-0.5.0 [INFO] finished frobbing serde_any-0.5.0 [INFO] frobbed toml for serde_any-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/serde_any/0.5.0/Cargo.toml [INFO] started frobbing serde_any-0.5.0 [INFO] finished frobbing serde_any-0.5.0 [INFO] frobbed toml for serde_any-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde_any/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting serde_any-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/serde_any/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] efd6676623bc3ea013248a1e65045e98eb0a41c52638919d585dcea84495cfe2 [INFO] running `"docker" "start" "-a" "efd6676623bc3ea013248a1e65045e98eb0a41c52638919d585dcea84495cfe2"` [INFO] [stderr] Checking serde v1.0.85 [INFO] [stderr] Checking toml v0.4.10 [INFO] [stderr] Checking serde_json v1.0.37 [INFO] [stderr] Checking ron v0.3.0 [INFO] [stderr] Checking serde_yaml v0.7.5 [INFO] [stderr] Checking serde_urlencoded v0.5.4 [INFO] [stderr] Checking serde-xml-any v0.0.3 [INFO] [stderr] Checking serde-value v0.5.3 [INFO] [stderr] Checking version-sync v0.5.0 [INFO] [stderr] Checking serde_any v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/format.rs:39:25 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn is_supported(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/ser.rs:324:28 [INFO] [stderr] | [INFO] [stderr] 324 | Format::Yaml => Ok(serde_yaml::to_writer(writer, value)?), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 324 | Format::Yaml => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/ser.rs:326:28 [INFO] [stderr] | [INFO] [stderr] 326 | Format::Json => Ok(serde_json::to_writer(writer, value)?), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 326 | Format::Json => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/ser.rs:330:13 [INFO] [stderr] | [INFO] [stderr] 330 | writer.write(&s)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/ser.rs:340:27 [INFO] [stderr] | [INFO] [stderr] 340 | Format::Xml => Ok(xml::to_writer(writer, value)?), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 340 | Format::Xml => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/ser.rs:406:28 [INFO] [stderr] | [INFO] [stderr] 406 | Format::Yaml => Ok(serde_yaml::to_writer(writer, value)?), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 406 | Format::Yaml => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/ser.rs:408:28 [INFO] [stderr] | [INFO] [stderr] 408 | Format::Json => Ok(serde_json::to_writer_pretty(writer, value)?), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 408 | Format::Json => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/ser.rs:422:27 [INFO] [stderr] | [INFO] [stderr] 422 | Format::Xml => Ok(xml::to_writer(writer, value)?), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 422 | Format::Xml => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/ser.rs:490:23 [INFO] [stderr] | [INFO] [stderr] 490 | let ext = path.as_ref() [INFO] [stderr] | _______________________^ [INFO] [stderr] 491 | | .extension() [INFO] [stderr] 492 | | .and_then(OsStr::to_str) [INFO] [stderr] 493 | | .map(String::from) [INFO] [stderr] 494 | | .unwrap_or(String::new()); [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 490 | let ext = path.as_ref() [INFO] [stderr] 491 | .extension() [INFO] [stderr] 492 | .and_then(OsStr::to_str) [INFO] [stderr] 493 | .map(String::from).unwrap_or_default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/ser.rs:561:23 [INFO] [stderr] | [INFO] [stderr] 561 | let ext = path.as_ref() [INFO] [stderr] | _______________________^ [INFO] [stderr] 562 | | .extension() [INFO] [stderr] 563 | | .and_then(OsStr::to_str) [INFO] [stderr] 564 | | .map(String::from) [INFO] [stderr] 565 | | .unwrap_or(String::new()); [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 561 | let ext = path.as_ref() [INFO] [stderr] 562 | .extension() [INFO] [stderr] 563 | .and_then(OsStr::to_str) [INFO] [stderr] 564 | .map(String::from).unwrap_or_default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `serde_any`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/format.rs:39:25 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn is_supported(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/ser.rs:324:28 [INFO] [stderr] | [INFO] [stderr] 324 | Format::Yaml => Ok(serde_yaml::to_writer(writer, value)?), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 324 | Format::Yaml => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/ser.rs:326:28 [INFO] [stderr] | [INFO] [stderr] 326 | Format::Json => Ok(serde_json::to_writer(writer, value)?), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 326 | Format::Json => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/ser.rs:330:13 [INFO] [stderr] | [INFO] [stderr] 330 | writer.write(&s)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/ser.rs:340:27 [INFO] [stderr] | [INFO] [stderr] 340 | Format::Xml => Ok(xml::to_writer(writer, value)?), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 340 | Format::Xml => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/ser.rs:406:28 [INFO] [stderr] | [INFO] [stderr] 406 | Format::Yaml => Ok(serde_yaml::to_writer(writer, value)?), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 406 | Format::Yaml => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/ser.rs:408:28 [INFO] [stderr] | [INFO] [stderr] 408 | Format::Json => Ok(serde_json::to_writer_pretty(writer, value)?), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 408 | Format::Json => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/ser.rs:422:27 [INFO] [stderr] | [INFO] [stderr] 422 | Format::Xml => Ok(xml::to_writer(writer, value)?), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 422 | Format::Xml => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/ser.rs:490:23 [INFO] [stderr] | [INFO] [stderr] 490 | let ext = path.as_ref() [INFO] [stderr] | _______________________^ [INFO] [stderr] 491 | | .extension() [INFO] [stderr] 492 | | .and_then(OsStr::to_str) [INFO] [stderr] 493 | | .map(String::from) [INFO] [stderr] 494 | | .unwrap_or(String::new()); [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 490 | let ext = path.as_ref() [INFO] [stderr] 491 | .extension() [INFO] [stderr] 492 | .and_then(OsStr::to_str) [INFO] [stderr] 493 | .map(String::from).unwrap_or_default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/ser.rs:561:23 [INFO] [stderr] | [INFO] [stderr] 561 | let ext = path.as_ref() [INFO] [stderr] | _______________________^ [INFO] [stderr] 562 | | .extension() [INFO] [stderr] 563 | | .and_then(OsStr::to_str) [INFO] [stderr] 564 | | .map(String::from) [INFO] [stderr] 565 | | .unwrap_or(String::new()); [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 561 | let ext = path.as_ref() [INFO] [stderr] 562 | .extension() [INFO] [stderr] 563 | .and_then(OsStr::to_str) [INFO] [stderr] 564 | .map(String::from).unwrap_or_default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/ser.rs:584:13 [INFO] [stderr] | [INFO] [stderr] 584 | let foo = Foo { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `serde_any`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "efd6676623bc3ea013248a1e65045e98eb0a41c52638919d585dcea84495cfe2"` [INFO] running `"docker" "rm" "-f" "efd6676623bc3ea013248a1e65045e98eb0a41c52638919d585dcea84495cfe2"` [INFO] [stdout] efd6676623bc3ea013248a1e65045e98eb0a41c52638919d585dcea84495cfe2