[INFO] crate serde-xml-rs 0.2.1 is already in cache
[INFO] extracting crate serde-xml-rs 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/serde-xml-rs/0.2.1
[INFO] extracting crate serde-xml-rs 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde-xml-rs/0.2.1
[INFO] validating manifest of serde-xml-rs-0.2.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of serde-xml-rs-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing serde-xml-rs-0.2.1
[INFO] finished frobbing serde-xml-rs-0.2.1
[INFO] frobbed toml for serde-xml-rs-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/serde-xml-rs/0.2.1/Cargo.toml
[INFO] started frobbing serde-xml-rs-0.2.1
[INFO] finished frobbing serde-xml-rs-0.2.1
[INFO] frobbed toml for serde-xml-rs-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde-xml-rs/0.2.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting serde-xml-rs-0.2.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/serde-xml-rs/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9f8e9bcaeb31aedff45f64b0b0ff1adcc54720bed4a2e5b448af98443d143b7e
[INFO] running `"docker" "start" "-a" "9f8e9bcaeb31aedff45f64b0b0ff1adcc54720bed4a2e5b448af98443d143b7e"`
[INFO] [stderr]     Checking serde-xml-rs v0.2.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/map.rs:20:13
[INFO] [stderr]    |
[INFO] [stderr] 20 |             de: de,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `de`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/map.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |             inner_value: inner_value,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `inner_value`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/seq.rs:22:13
[INFO] [stderr]    |
[INFO] [stderr] 22 |             de: de,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `de`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/seq.rs:23:13
[INFO] [stderr]    |
[INFO] [stderr] 23 |             max_size: max_size,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `max_size`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/seq.rs:24:13
[INFO] [stderr]    |
[INFO] [stderr] 24 |             expected_name: expected_name,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expected_name`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/var.rs:16:22
[INFO] [stderr]    |
[INFO] [stderr] 16 |         EnumAccess { de: de }
[INFO] [stderr]    |                      ^^^^^^ help: replace it with: `de`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/var.rs:47:25
[INFO] [stderr]    |
[INFO] [stderr] 47 |         VariantAccess { de: de }
[INFO] [stderr]    |                         ^^^^^^ help: replace it with: `de`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/serialize.rs:55:16
[INFO] [stderr]    |
[INFO] [stderr] 55 |         Self { writer: writer }
[INFO] [stderr]    |                ^^^^^^^^^^^^^^ help: replace it with: `writer`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/serialize.rs:210:13
[INFO] [stderr]     |
[INFO] [stderr] 210 |             name: name,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:46:13
[INFO] [stderr]    |
[INFO] [stderr] 46 |             reader: reader,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `reader`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/map.rs:20:13
[INFO] [stderr]    |
[INFO] [stderr] 20 |             de: de,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `de`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/map.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |             inner_value: inner_value,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `inner_value`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/seq.rs:22:13
[INFO] [stderr]    |
[INFO] [stderr] 22 |             de: de,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `de`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/seq.rs:23:13
[INFO] [stderr]    |
[INFO] [stderr] 23 |             max_size: max_size,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `max_size`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/seq.rs:24:13
[INFO] [stderr]    |
[INFO] [stderr] 24 |             expected_name: expected_name,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expected_name`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/var.rs:16:22
[INFO] [stderr]    |
[INFO] [stderr] 16 |         EnumAccess { de: de }
[INFO] [stderr]    |                      ^^^^^^ help: replace it with: `de`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/var.rs:47:25
[INFO] [stderr]    |
[INFO] [stderr] 47 |         VariantAccess { de: de }
[INFO] [stderr]    |                         ^^^^^^ help: replace it with: `de`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/serialize.rs:55:16
[INFO] [stderr]    |
[INFO] [stderr] 55 |         Self { writer: writer }
[INFO] [stderr]    |                ^^^^^^^^^^^^^^ help: replace it with: `writer`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/serialize.rs:210:13
[INFO] [stderr]     |
[INFO] [stderr] 210 |             name: name,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:46:13
[INFO] [stderr]    |
[INFO] [stderr] 46 |             reader: reader,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `reader`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/serialize.rs:89:23
[INFO] [stderr]    |
[INFO] [stderr] 89 |     fn serialize_bool(mut self, v: bool) -> Result<Self::Ok, Self::Error> {
[INFO] [stderr]    |                       ----^^^^
[INFO] [stderr]    |                       |
[INFO] [stderr]    |                       help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/map.rs:65:21
[INFO] [stderr]    |
[INFO] [stderr] 65 | /                     if let &XmlEvent::StartElement { .. } = self.de.peek()? {
[INFO] [stderr] 66 | |                         self.de.set_map_value();
[INFO] [stderr] 67 | |                     }
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 65 |                     if let XmlEvent::StartElement { .. } = *(self.de.peek()?) {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/var.rs:58:20
[INFO] [stderr]    |
[INFO] [stderr] 58 |                 if attributes.len() == 0 {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `attributes.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:151:42
[INFO] [stderr]     |
[INFO] [stderr] 151 |                 return Err(Error::Custom(format!("expected an integer")));
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"expected an integer".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/serialize.rs:89:23
[INFO] [stderr]    |
[INFO] [stderr] 89 |     fn serialize_bool(mut self, v: bool) -> Result<Self::Ok, Self::Error> {
[INFO] [stderr]    |                       ----^^^^
[INFO] [stderr]    |                       |
[INFO] [stderr]    |                       help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/map.rs:65:21
[INFO] [stderr]    |
[INFO] [stderr] 65 | /                     if let &XmlEvent::StartElement { .. } = self.de.peek()? {
[INFO] [stderr] 66 | |                         self.de.set_map_value();
[INFO] [stderr] 67 | |                     }
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 65 |                     if let XmlEvent::StartElement { .. } = *(self.de.peek()?) {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/var.rs:58:20
[INFO] [stderr]    |
[INFO] [stderr] 58 |                 if attributes.len() == 0 {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `attributes.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:151:42
[INFO] [stderr]     |
[INFO] [stderr] 151 |                 return Err(Error::Custom(format!("expected an integer")));
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"expected an integer".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 5.01s
[INFO] running `"docker" "inspect" "9f8e9bcaeb31aedff45f64b0b0ff1adcc54720bed4a2e5b448af98443d143b7e"`
[INFO] running `"docker" "rm" "-f" "9f8e9bcaeb31aedff45f64b0b0ff1adcc54720bed4a2e5b448af98443d143b7e"`
[INFO] [stdout] 9f8e9bcaeb31aedff45f64b0b0ff1adcc54720bed4a2e5b448af98443d143b7e