[INFO] crate serde-rlp 0.1.4 is already in cache [INFO] extracting crate serde-rlp 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/serde-rlp/0.1.4 [INFO] extracting crate serde-rlp 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde-rlp/0.1.4 [INFO] validating manifest of serde-rlp-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of serde-rlp-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing serde-rlp-0.1.4 [INFO] finished frobbing serde-rlp-0.1.4 [INFO] frobbed toml for serde-rlp-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/serde-rlp/0.1.4/Cargo.toml [INFO] started frobbing serde-rlp-0.1.4 [INFO] finished frobbing serde-rlp-0.1.4 [INFO] frobbed toml for serde-rlp-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde-rlp/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting serde-rlp-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/serde-rlp/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bac80a1ebf6e2b3c4fac4aa94ae52c566b3696d97e2b0039506ec557f10e0dca [INFO] running `"docker" "start" "-a" "bac80a1ebf6e2b3c4fac4aa94ae52c566b3696d97e2b0039506ec557f10e0dca"` [INFO] [stderr] Checking serde-rlp v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rlp.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | return Some(b[b.len() - 1] as u64 + to_integer(&b[0..b.len() - 1]).unwrap() * 256); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(b[b.len() - 1] as u64 + to_integer(&b[0..b.len() - 1]).unwrap() * 256)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rlp.rs:34:19 [INFO] [stderr] | [INFO] [stderr] 34 | to_binary(18446744073709551615u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_615u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rlp.rs:60:23 [INFO] [stderr] | [INFO] [stderr] 60 | encode_length(18446744073709551614u64, 0x80), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_614u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rlp.rs:68:19 [INFO] [stderr] | [INFO] [stderr] 68 | encode_length(18446744073709551615u64, 0x80); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_615u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rlp.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | return Some(b[b.len() - 1] as u64 + to_integer(&b[0..b.len() - 1]).unwrap() * 256); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(b[b.len() - 1] as u64 + to_integer(&b[0..b.len() - 1]).unwrap() * 256)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rlp.rs:117:51 [INFO] [stderr] | [INFO] [stderr] 117 | assert_eq!(to_integer(&[0xffu8; 4]).unwrap(), 4294967295u64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `4_294_967_295u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rlp.rs:122:51 [INFO] [stderr] | [INFO] [stderr] 122 | assert_eq!(to_integer(&[0xffu8; 8]).unwrap(), 18446744073709551615u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_615u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_bytes` [INFO] [stderr] --> src/de.rs:429:1 [INFO] [stderr] | [INFO] [stderr] 429 | fn get_bytes(b: &str) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/de.rs:32:8 [INFO] [stderr] | [INFO] [stderr] 32 | if deserializer.input.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `deserializer.input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/de.rs:347:12 [INFO] [stderr] | [INFO] [stderr] 347 | if self.de.input.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.de.input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rlp.rs:91:8 [INFO] [stderr] | [INFO] [stderr] 91 | if b.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `b.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/rlp.rs:94:14 [INFO] [stderr] | [INFO] [stderr] 94 | Some(b[0] as u64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(b[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/rlp.rs:96:21 [INFO] [stderr] | [INFO] [stderr] 96 | return Some(b[b.len() - 1] as u64 + to_integer(&b[0..b.len() - 1]).unwrap() * 256); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(b[b.len() - 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rlp.rs:142:8 [INFO] [stderr] | [INFO] [stderr] 142 | if input.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/rlp.rs:162:15 [INFO] [stderr] | [INFO] [stderr] 162 | > prefix as u64 - 0xb7u64 + to_integer(&input[1..prefix as usize - 0xb7 + 1]) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(prefix)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/rlp.rs:162:59 [INFO] [stderr] | [INFO] [stderr] 162 | > prefix as u64 - 0xb7u64 + to_integer(&input[1..prefix as usize - 0xb7 + 1]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=prefix as usize - 0xb7` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/rlp.rs:166:41 [INFO] [stderr] | [INFO] [stderr] 166 | let str_len = to_integer(&input[1..len_of_str_len + 1]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=len_of_str_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/rlp.rs:181:26 [INFO] [stderr] | [INFO] [stderr] 181 | input.len() as u64 > prefix as u64 - 0xf7 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(prefix)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/rlp.rs:183:15 [INFO] [stderr] | [INFO] [stderr] 183 | > prefix as u64 - 0xf7u64 + to_integer(&input[1..prefix as usize - 0xf7 + 1]) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(prefix)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/rlp.rs:183:59 [INFO] [stderr] | [INFO] [stderr] 183 | > prefix as u64 - 0xf7u64 + to_integer(&input[1..prefix as usize - 0xf7 + 1]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=prefix as usize - 0xf7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/rlp.rs:187:42 [INFO] [stderr] | [INFO] [stderr] 187 | let list_len = to_integer(&input[1..len_of_list_len + 1]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=len_of_list_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/de.rs:32:8 [INFO] [stderr] | [INFO] [stderr] 32 | if deserializer.input.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `deserializer.input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/de.rs:347:12 [INFO] [stderr] | [INFO] [stderr] 347 | if self.de.input.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.de.input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/de.rs:369:9 [INFO] [stderr] | [INFO] [stderr] 369 | let foo: String = from_bytes(&[0x61u8]).unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/de.rs:375:9 [INFO] [stderr] | [INFO] [stderr] 375 | let foo: String = from_bytes(&[0x83, 0x61, 0x62, 0x63]).unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/de.rs:381:9 [INFO] [stderr] | [INFO] [stderr] 381 | let foo: Vec = [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/de.rs:396:9 [INFO] [stderr] | [INFO] [stderr] 396 | let foo: Vec> = [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/de.rs:404:9 [INFO] [stderr] | [INFO] [stderr] 404 | let foo = from_bytes(&[0xc7, 0xc0, 0xc1, 0xc0, 0xc3, 0xc0, 0xc1, 0xc0]); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/de.rs:417:9 [INFO] [stderr] | [INFO] [stderr] 417 | let foo: Vec>> = from_bytes(&[ [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/de.rs:452:35 [INFO] [stderr] | [INFO] [stderr] 452 | let data: String = from_bytes(&vec![ [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 453 | | 0xb8, 0x38, 0x4c, 0x6f, 0x72, 0x65, 0x6d, 0x20, 0x69, 0x70, 0x73, 0x75, 0x6d, 0x20, 0x64, [INFO] [stderr] 454 | | 0x6f, 0x6c, 0x6f, 0x72, 0x20, 0x73, 0x69, 0x74, 0x20, 0x61, 0x6d, 0x65, 0x74, 0x2c, 0x20, [INFO] [stderr] 455 | | 0x63, 0x6f, 0x6e, 0x73, 0x65, 0x63, 0x74, 0x65, 0x74, 0x75, 0x72, 0x20, 0x61, 0x64, 0x69, [INFO] [stderr] 456 | | 0x70, 0x69, 0x73, 0x69, 0x63, 0x69, 0x6e, 0x67, 0x20, 0x65, 0x6c, 0x69, 0x74, [INFO] [stderr] 457 | | ]).unwrap(); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] help: you can use a slice directly [INFO] [stderr] | [INFO] [stderr] 452 | let data: String = from_bytes(&[0xb8, 0x38, 0x4c, 0x6f, 0x72, 0x65, 0x6d, 0x20, 0x69, 0x70, 0x73, 0x75, 0x6d, 0x20, 0x64, [INFO] [stderr] 453 | 0x6f, 0x6c, 0x6f, 0x72, 0x20, 0x73, 0x69, 0x74, 0x20, 0x61, 0x6d, 0x65, 0x74, 0x2c, 0x20, [INFO] [stderr] 454 | 0x63, 0x6f, 0x6e, 0x73, 0x65, 0x63, 0x74, 0x65, 0x74, 0x75, 0x72, 0x20, 0x61, 0x64, 0x69, [INFO] [stderr] 455 | 0x70, 0x69, 0x73, 0x69, 0x63, 0x69, 0x6e, 0x67, 0x20, 0x65, 0x6c, 0x69, 0x74]).unwrap(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rlp.rs:91:8 [INFO] [stderr] | [INFO] [stderr] 91 | if b.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `b.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/rlp.rs:94:14 [INFO] [stderr] | [INFO] [stderr] 94 | Some(b[0] as u64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(b[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/rlp.rs:96:21 [INFO] [stderr] | [INFO] [stderr] 96 | return Some(b[b.len() - 1] as u64 + to_integer(&b[0..b.len() - 1]).unwrap() * 256); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(b[b.len() - 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rlp.rs:142:8 [INFO] [stderr] | [INFO] [stderr] 142 | if input.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/rlp.rs:162:15 [INFO] [stderr] | [INFO] [stderr] 162 | > prefix as u64 - 0xb7u64 + to_integer(&input[1..prefix as usize - 0xb7 + 1]) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(prefix)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/rlp.rs:162:59 [INFO] [stderr] | [INFO] [stderr] 162 | > prefix as u64 - 0xb7u64 + to_integer(&input[1..prefix as usize - 0xb7 + 1]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=prefix as usize - 0xb7` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/rlp.rs:166:41 [INFO] [stderr] | [INFO] [stderr] 166 | let str_len = to_integer(&input[1..len_of_str_len + 1]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=len_of_str_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/rlp.rs:181:26 [INFO] [stderr] | [INFO] [stderr] 181 | input.len() as u64 > prefix as u64 - 0xf7 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(prefix)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/rlp.rs:183:15 [INFO] [stderr] | [INFO] [stderr] 183 | > prefix as u64 - 0xf7u64 + to_integer(&input[1..prefix as usize - 0xf7 + 1]) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(prefix)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/rlp.rs:183:59 [INFO] [stderr] | [INFO] [stderr] 183 | > prefix as u64 - 0xf7u64 + to_integer(&input[1..prefix as usize - 0xf7 + 1]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=prefix as usize - 0xf7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/rlp.rs:187:42 [INFO] [stderr] | [INFO] [stderr] 187 | let list_len = to_integer(&input[1..len_of_list_len + 1]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=len_of_list_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.50s [INFO] running `"docker" "inspect" "bac80a1ebf6e2b3c4fac4aa94ae52c566b3696d97e2b0039506ec557f10e0dca"` [INFO] running `"docker" "rm" "-f" "bac80a1ebf6e2b3c4fac4aa94ae52c566b3696d97e2b0039506ec557f10e0dca"` [INFO] [stdout] bac80a1ebf6e2b3c4fac4aa94ae52c566b3696d97e2b0039506ec557f10e0dca