[INFO] crate serde-redis 0.7.2 is already in cache [INFO] extracting crate serde-redis 0.7.2 into work/ex/clippy-test-run/sources/stable/reg/serde-redis/0.7.2 [INFO] extracting crate serde-redis 0.7.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde-redis/0.7.2 [INFO] validating manifest of serde-redis-0.7.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of serde-redis-0.7.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing serde-redis-0.7.2 [INFO] finished frobbing serde-redis-0.7.2 [INFO] frobbed toml for serde-redis-0.7.2 written to work/ex/clippy-test-run/sources/stable/reg/serde-redis/0.7.2/Cargo.toml [INFO] started frobbing serde-redis-0.7.2 [INFO] finished frobbing serde-redis-0.7.2 [INFO] frobbed toml for serde-redis-0.7.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde-redis/0.7.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting serde-redis-0.7.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/serde-redis/0.7.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c6c8eae1fd63b159f543abff497c9e5252fc7f9f7343dfd96aea24c458d0eb30 [INFO] running `"docker" "start" "-a" "c6c8eae1fd63b159f543abff497c9e5252fc7f9f7343dfd96aea24c458d0eb30"` [INFO] [stderr] Checking redis v0.8.0 [INFO] [stderr] Checking serde-redis v0.7.2 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/decode.rs:197:17 [INFO] [stderr] | [INFO] [stderr] 197 | return Err(Error::wrong_value(msg)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::wrong_value(msg))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/decode.rs:197:17 [INFO] [stderr] | [INFO] [stderr] 197 | return Err(Error::wrong_value(msg)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::wrong_value(msg))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/decode.rs:178:5 [INFO] [stderr] | [INFO] [stderr] 178 | / pub fn next(&mut self) -> Result { [INFO] [stderr] 179 | | match self.values.next() { [INFO] [stderr] 180 | | Some(value) => Ok(value), [INFO] [stderr] 181 | | None => Err(Error::EndOfStream) [INFO] [stderr] 182 | | } [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: the `v @ _` pattern can be written as just `v` [INFO] [stderr] --> src/decode.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | v @ _ => Err(Error::wrong_value(format!("expected bulk but got {:?}", v))) [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/decode.rs:410:35 [INFO] [stderr] | [INFO] [stderr] 410 | let msg = format!("Expected Data, Int, or Nil"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Expected Data, Int, or Nil".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/decode.rs:178:5 [INFO] [stderr] | [INFO] [stderr] 178 | / pub fn next(&mut self) -> Result { [INFO] [stderr] 179 | | match self.values.next() { [INFO] [stderr] 180 | | Some(value) => Ok(value), [INFO] [stderr] 181 | | None => Err(Error::EndOfStream) [INFO] [stderr] 182 | | } [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: the `v @ _` pattern can be written as just `v` [INFO] [stderr] --> src/decode.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | v @ _ => Err(Error::wrong_value(format!("expected bulk but got {:?}", v))) [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/decode.rs:410:35 [INFO] [stderr] | [INFO] [stderr] 410 | let msg = format!("Expected Data, Int, or Nil"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Expected Data, Int, or Nil".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/de.rs:445:27 [INFO] [stderr] | [INFO] [stderr] 445 | assert_eq!(nest.time, 1473359995); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_473_359_995` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> tests/de.rs:34:24 [INFO] [stderr] | [INFO] [stderr] 34 | let v = Value::Int(num as i64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(num)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/de.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | assert_eq!(actual, expected); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/de.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | assert_eq!(actual, expected); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/de.rs:443:16 [INFO] [stderr] | [INFO] [stderr] 443 | let nest = map.get("key").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map["key"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `serde-redis`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c6c8eae1fd63b159f543abff497c9e5252fc7f9f7343dfd96aea24c458d0eb30"` [INFO] running `"docker" "rm" "-f" "c6c8eae1fd63b159f543abff497c9e5252fc7f9f7343dfd96aea24c458d0eb30"` [INFO] [stdout] c6c8eae1fd63b159f543abff497c9e5252fc7f9f7343dfd96aea24c458d0eb30