[INFO] crate serde-protobuf 0.7.0 is already in cache [INFO] extracting crate serde-protobuf 0.7.0 into work/ex/clippy-test-run/sources/stable/reg/serde-protobuf/0.7.0 [INFO] extracting crate serde-protobuf 0.7.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde-protobuf/0.7.0 [INFO] validating manifest of serde-protobuf-0.7.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of serde-protobuf-0.7.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing serde-protobuf-0.7.0 [INFO] finished frobbing serde-protobuf-0.7.0 [INFO] frobbed toml for serde-protobuf-0.7.0 written to work/ex/clippy-test-run/sources/stable/reg/serde-protobuf/0.7.0/Cargo.toml [INFO] started frobbing serde-protobuf-0.7.0 [INFO] finished frobbing serde-protobuf-0.7.0 [INFO] frobbed toml for serde-protobuf-0.7.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde-protobuf/0.7.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting serde-protobuf-0.7.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/serde-protobuf/0.7.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9807fb9b821826503ec104a1b86b80fbe54823c411dea94e08bcd393ff89235e [INFO] running `"docker" "start" "-a" "9807fb9b821826503ec104a1b86b80fbe54823c411dea94e08bcd393ff89235e"` [INFO] [stderr] Checking serde-value v0.5.3 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking serde-protobuf v0.7.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | descriptors: descriptors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptors` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | descriptor: descriptor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | descriptors: descriptors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | descriptor: descriptor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:206:34 [INFO] [stderr] | [INFO] [stderr] 206 | MessageKeyDeserializer { descriptor: descriptor } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:234:13 [INFO] [stderr] | [INFO] [stderr] 234 | descriptors: descriptors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:235:13 [INFO] [stderr] | [INFO] [stderr] 235 | descriptor: descriptor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:286:13 [INFO] [stderr] | [INFO] [stderr] 286 | descriptors: descriptors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:287:13 [INFO] [stderr] | [INFO] [stderr] 287 | descriptor: descriptor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:288:13 [INFO] [stderr] | [INFO] [stderr] 288 | values: values, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:321:13 [INFO] [stderr] | [INFO] [stderr] 321 | descriptors: descriptors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:322:13 [INFO] [stderr] | [INFO] [stderr] 322 | descriptor: descriptor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor.rs:508:13 [INFO] [stderr] | [INFO] [stderr] 508 | number: number, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor.rs:621:13 [INFO] [stderr] | [INFO] [stderr] 621 | number: number, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor.rs:622:13 [INFO] [stderr] | [INFO] [stderr] 622 | field_label: field_label, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_label` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor.rs:623:13 [INFO] [stderr] | [INFO] [stderr] 623 | field_type: field_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor.rs:624:13 [INFO] [stderr] | [INFO] [stderr] 624 | default_value: default_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `default_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | descriptors: descriptors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptors` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | descriptor: descriptor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | descriptors: descriptors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | descriptor: descriptor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:206:34 [INFO] [stderr] | [INFO] [stderr] 206 | MessageKeyDeserializer { descriptor: descriptor } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:234:13 [INFO] [stderr] | [INFO] [stderr] 234 | descriptors: descriptors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:235:13 [INFO] [stderr] | [INFO] [stderr] 235 | descriptor: descriptor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:286:13 [INFO] [stderr] | [INFO] [stderr] 286 | descriptors: descriptors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:287:13 [INFO] [stderr] | [INFO] [stderr] 287 | descriptor: descriptor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:288:13 [INFO] [stderr] | [INFO] [stderr] 288 | values: values, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:321:13 [INFO] [stderr] | [INFO] [stderr] 321 | descriptors: descriptors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:322:13 [INFO] [stderr] | [INFO] [stderr] 322 | descriptor: descriptor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor.rs:508:13 [INFO] [stderr] | [INFO] [stderr] 508 | number: number, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor.rs:621:13 [INFO] [stderr] | [INFO] [stderr] 621 | number: number, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor.rs:622:13 [INFO] [stderr] | [INFO] [stderr] 622 | field_label: field_label, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_label` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor.rs:623:13 [INFO] [stderr] | [INFO] [stderr] 623 | field_type: field_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/descriptor.rs:624:13 [INFO] [stderr] | [INFO] [stderr] 624 | default_value: default_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `default_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `descriptor::Descriptors` [INFO] [stderr] --> src/descriptor.rs:282:5 [INFO] [stderr] | [INFO] [stderr] 282 | / pub fn new() -> Descriptors { [INFO] [stderr] 283 | | Descriptors { [INFO] [stderr] 284 | | messages: Vec::new(), [INFO] [stderr] 285 | | enums: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 289 | | } [INFO] [stderr] 290 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 160 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/descriptor.rs:368:13 [INFO] [stderr] | [INFO] [stderr] 368 | for ref mut m in &mut self.messages { [INFO] [stderr] | ^^^^^^^^^ ------------------ help: try: `let m = &mut &mut self.messages;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/descriptor.rs:539:24 [INFO] [stderr] | [INFO] [stderr] 539 | pub fn is_repeated(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/protobuf_unittest/unittest.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/protobuf_unittest/unittest_import.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/protobuf_unittest/unittest_import_public.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `descriptor::Descriptors` [INFO] [stderr] --> src/descriptor.rs:282:5 [INFO] [stderr] | [INFO] [stderr] 282 | / pub fn new() -> Descriptors { [INFO] [stderr] 283 | | Descriptors { [INFO] [stderr] 284 | | messages: Vec::new(), [INFO] [stderr] 285 | | enums: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 289 | | } [INFO] [stderr] 290 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 160 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/descriptor.rs:368:13 [INFO] [stderr] | [INFO] [stderr] 368 | for ref mut m in &mut self.messages { [INFO] [stderr] | ^^^^^^^^^ ------------------ help: try: `let m = &mut &mut self.messages;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/descriptor.rs:539:24 [INFO] [stderr] | [INFO] [stderr] 539 | pub fn is_repeated(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/protobuf_unittest/unittest.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 174 | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | _____________- [INFO] [stderr] 175 | | v.mut_optional_nested_message().set_bb(1); [INFO] [stderr] 176 | | }); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 187 | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | _____________- [INFO] [stderr] 188 | | v.set_optional_nested_enum(protobuf_unittest::unittest::TestAllTypes_NestedEnum::BAZ); [INFO] [stderr] 189 | | }); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 198 | let v = roundtrip!(protobuf_unittest::unittest::TestRequired, v, { [INFO] [stderr] | _____________- [INFO] [stderr] 199 | | v.set_a(1); [INFO] [stderr] 200 | | v.set_b(2); [INFO] [stderr] 201 | | v.set_c(3); [INFO] [stderr] 202 | | }); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 213 | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | _____________- [INFO] [stderr] 214 | | v.mut_repeated_nested_message().push_default().set_bb(1); [INFO] [stderr] 215 | | v.mut_repeated_nested_message().push_default().set_bb(2); [INFO] [stderr] 216 | | v.mut_repeated_nested_message().push_default().set_bb(3); [INFO] [stderr] 217 | | }); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 236 | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | _____________- [INFO] [stderr] 237 | | v.mut_repeated_nested_enum().push(protobuf_unittest::unittest::TestAllTypes_NestedEnum::BAZ); [INFO] [stderr] 238 | | v.mut_repeated_nested_enum().push(protobuf_unittest::unittest::TestAllTypes_NestedEnum::FOO); [INFO] [stderr] 239 | | v.mut_repeated_nested_enum().push(protobuf_unittest::unittest::TestAllTypes_NestedEnum::BAR); [INFO] [stderr] 240 | | }); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 250 | let v = roundtrip!(protobuf_unittest::unittest::TestRecursiveMessage, v, { [INFO] [stderr] | _____________- [INFO] [stderr] 251 | | v.mut_a().mut_a().set_i(3); [INFO] [stderr] 252 | | v.mut_a().mut_a().mut_a().mut_a().set_i(4); [INFO] [stderr] 253 | | }); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 272 | | fn $id() { [INFO] [stderr] 273 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 283 | check_roundtrip_singular!(roundtrip_optional_int32, optional_int32, set_optional_int32, 42, some i32); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 272 | | fn $id() { [INFO] [stderr] 273 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 284 | check_roundtrip_singular!(roundtrip_optional_int64, optional_int64, set_optional_int64, 42, some i64); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 272 | | fn $id() { [INFO] [stderr] 273 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 285 | check_roundtrip_singular!(roundtrip_optional_uint32, optional_uint32, set_optional_uint32, 42, some u32); [INFO] [stderr] | --------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 272 | | fn $id() { [INFO] [stderr] 273 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 286 | check_roundtrip_singular!(roundtrip_optional_uint64, optional_uint64, set_optional_uint64, 42, some u64); [INFO] [stderr] | --------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 272 | | fn $id() { [INFO] [stderr] 273 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 287 | check_roundtrip_singular!(roundtrip_optional_sint32, optional_sint32, set_optional_sint32, 42, some i32); [INFO] [stderr] | --------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 272 | | fn $id() { [INFO] [stderr] 273 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 288 | check_roundtrip_singular!(roundtrip_optional_sint64, optional_sint64, set_optional_sint64, 42, some i64); [INFO] [stderr] | --------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 272 | | fn $id() { [INFO] [stderr] 273 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 289 | check_roundtrip_singular!(roundtrip_optional_fixed32, optional_fixed32, set_optional_fixed32, 42, some u32); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 272 | | fn $id() { [INFO] [stderr] 273 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 290 | check_roundtrip_singular!(roundtrip_optional_fixed64, optional_fixed64, set_optional_fixed64, 42, some u64); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 272 | | fn $id() { [INFO] [stderr] 273 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 291 | check_roundtrip_singular!(roundtrip_optional_sfixed32, optional_sfixed32, set_optional_sfixed32, 42, some i32); [INFO] [stderr] | --------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 272 | | fn $id() { [INFO] [stderr] 273 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 292 | check_roundtrip_singular!(roundtrip_optional_sfixed64, optional_sfixed64, set_optional_sfixed64, 42, some i64); [INFO] [stderr] | --------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 272 | | fn $id() { [INFO] [stderr] 273 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 293 | check_roundtrip_singular!(roundtrip_optional_float, optional_float, set_optional_float, 0.4, some f32); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 272 | | fn $id() { [INFO] [stderr] 273 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 294 | check_roundtrip_singular!(roundtrip_optional_double, optional_double, set_optional_double, 0.4, some f64); [INFO] [stderr] | ---------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 272 | | fn $id() { [INFO] [stderr] 273 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 295 | check_roundtrip_singular!(roundtrip_optional_bool, optional_bool, set_optional_bool, true, some bool); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 272 | | fn $id() { [INFO] [stderr] 273 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 296 | check_roundtrip_singular!(roundtrip_optional_string, optional_string, set_optional_string, "hello".to_owned(), some string); [INFO] [stderr] | ---------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 272 | | fn $id() { [INFO] [stderr] 273 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 297 | check_roundtrip_singular!(roundtrip_optional_bytes, optional_bytes, set_optional_bytes, vec![1, 2, 3], some byte_buf); [INFO] [stderr] | ---------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 302 | | fn $id() { [INFO] [stderr] 303 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, {}); [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 311 | check_roundtrip_default!(roundtrip_default_int32, default_int32, 41, some i32); [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 302 | | fn $id() { [INFO] [stderr] 303 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, {}); [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 312 | check_roundtrip_default!(roundtrip_default_int64, default_int64, 42, some i64); [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 302 | | fn $id() { [INFO] [stderr] 303 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, {}); [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 313 | check_roundtrip_default!(roundtrip_default_uint32, default_uint32, 43, some u32); [INFO] [stderr] | --------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 302 | | fn $id() { [INFO] [stderr] 303 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, {}); [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 314 | check_roundtrip_default!(roundtrip_default_uint64, default_uint64, 44, some u64); [INFO] [stderr] | --------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 302 | | fn $id() { [INFO] [stderr] 303 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, {}); [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 315 | check_roundtrip_default!(roundtrip_default_sint32, default_sint32, -45, some i32); [INFO] [stderr] | ---------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 302 | | fn $id() { [INFO] [stderr] 303 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, {}); [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 316 | check_roundtrip_default!(roundtrip_default_sint64, default_sint64, 46, some i64); [INFO] [stderr] | --------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 302 | | fn $id() { [INFO] [stderr] 303 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, {}); [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 317 | check_roundtrip_default!(roundtrip_default_fixed32, default_fixed32, 47, some u32); [INFO] [stderr] | ----------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 302 | | fn $id() { [INFO] [stderr] 303 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, {}); [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 318 | check_roundtrip_default!(roundtrip_default_fixed64, default_fixed64, 48, some u64); [INFO] [stderr] | ----------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 302 | | fn $id() { [INFO] [stderr] 303 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, {}); [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 319 | check_roundtrip_default!(roundtrip_default_sfixed32, default_sfixed32, 49, some i32); [INFO] [stderr] | ------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 302 | | fn $id() { [INFO] [stderr] 303 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, {}); [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 320 | check_roundtrip_default!(roundtrip_default_sfixed64, default_sfixed64, -50, some i64); [INFO] [stderr] | -------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 302 | | fn $id() { [INFO] [stderr] 303 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, {}); [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 321 | check_roundtrip_default!(roundtrip_default_float, default_float, 51.5, some f32); [INFO] [stderr] | --------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 302 | | fn $id() { [INFO] [stderr] 303 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, {}); [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 322 | check_roundtrip_default!(roundtrip_default_double, default_double, 52e3, some f64); [INFO] [stderr] | ----------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 302 | | fn $id() { [INFO] [stderr] 303 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, {}); [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 323 | check_roundtrip_default!(roundtrip_default_bool, default_bool, true, some bool); [INFO] [stderr] | -------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 302 | | fn $id() { [INFO] [stderr] 303 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, {}); [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 324 | check_roundtrip_default!(roundtrip_default_string, default_string, "hello".to_owned(), some string); [INFO] [stderr] | ---------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 302 | | fn $id() { [INFO] [stderr] 303 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, {}); [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 325 | check_roundtrip_default!(roundtrip_default_bytes, default_bytes, "world".as_bytes().to_owned(), some byte_buf); [INFO] [stderr] | --------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/lib.rs:325:66 [INFO] [stderr] | [INFO] [stderr] 325 | check_roundtrip_default!(roundtrip_default_bytes, default_bytes, "world".as_bytes().to_owned(), some byte_buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"world"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 330 | | fn $id() { [INFO] [stderr] 331 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 343 | check_roundtrip_repeated!(roundtrip_repeated_int32, repeated_int32, mut_repeated_int32, [42, 21, 0], i32); [INFO] [stderr] | ---------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 330 | | fn $id() { [INFO] [stderr] 331 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 344 | check_roundtrip_repeated!(roundtrip_repeated_int64, repeated_int64, mut_repeated_int64, [42, 21, 0], i64); [INFO] [stderr] | ---------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 330 | | fn $id() { [INFO] [stderr] 331 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 345 | check_roundtrip_repeated!(roundtrip_repeated_uint32, repeated_uint32, mut_repeated_uint32, [42, 21, 0], u32); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 330 | | fn $id() { [INFO] [stderr] 331 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 346 | check_roundtrip_repeated!(roundtrip_repeated_uint64, repeated_uint64, mut_repeated_uint64, [42, 21, 0], u64); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 330 | | fn $id() { [INFO] [stderr] 331 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 347 | check_roundtrip_repeated!(roundtrip_repeated_sint32, repeated_sint32, mut_repeated_sint32, [42, 21, 0], i32); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 330 | | fn $id() { [INFO] [stderr] 331 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 348 | check_roundtrip_repeated!(roundtrip_repeated_sint64, repeated_sint64, mut_repeated_sint64, [42, 21, 0], i64); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 330 | | fn $id() { [INFO] [stderr] 331 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 349 | check_roundtrip_repeated!(roundtrip_repeated_fixed32, repeated_fixed32, mut_repeated_fixed32, [42, 21, 0], u32); [INFO] [stderr] | ---------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 330 | | fn $id() { [INFO] [stderr] 331 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 350 | check_roundtrip_repeated!(roundtrip_repeated_fixed64, repeated_fixed64, mut_repeated_fixed64, [42, 21, 0], u64); [INFO] [stderr] | ---------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 330 | | fn $id() { [INFO] [stderr] 331 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 351 | check_roundtrip_repeated!(roundtrip_repeated_sfixed32, repeated_sfixed32, mut_repeated_sfixed32, [42, 21, 0], i32); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 330 | | fn $id() { [INFO] [stderr] 331 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 352 | check_roundtrip_repeated!(roundtrip_repeated_sfixed64, repeated_sfixed64, mut_repeated_sfixed64, [42, 21, 0], i64); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 330 | | fn $id() { [INFO] [stderr] 331 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 353 | check_roundtrip_repeated!(roundtrip_repeated_float, repeated_float, mut_repeated_float, [0.4, 0.0, 1.0], f32); [INFO] [stderr] | -------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 330 | | fn $id() { [INFO] [stderr] 331 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 354 | check_roundtrip_repeated!(roundtrip_repeated_double, repeated_double, mut_repeated_double, [0.4, 0.0, 1.0], f64); [INFO] [stderr] | ----------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 330 | | fn $id() { [INFO] [stderr] 331 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 355 | check_roundtrip_repeated!(roundtrip_repeated_bool, repeated_bool, mut_repeated_bool, [true, true, false], bool); [INFO] [stderr] | ---------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 330 | | fn $id() { [INFO] [stderr] 331 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 356 | check_roundtrip_repeated!(roundtrip_repeated_string, repeated_string, mut_repeated_string, ["hello".to_owned(), "".to_owned()], string); [INFO] [stderr] | ---------------------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `protobuf::Message::write_to_bytes` doesn't need a mutable reference [INFO] [stderr] --> tests/lib.rs:161:59 [INFO] [stderr] | [INFO] [stderr] 161 | let bytes = protobuf::Message::write_to_bytes(&mut $v).unwrap(); [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 162 | | let input = protobuf::CodedInputStream::from_bytes(&bytes); [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | let message_name = format!(".{}", protobuf::Message::descriptor(&$v).full_name()); [INFO] [stderr] ... | [INFO] [stderr] 330 | | fn $id() { [INFO] [stderr] 331 | | let v = roundtrip!(protobuf_unittest::unittest::TestAllTypes, v, { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 357 | check_roundtrip_repeated!(roundtrip_repeated_bytes, repeated_bytes, mut_repeated_bytes, [vec![1, 2, 3], vec![2, 3, 4]], byte_buf); [INFO] [stderr] | ---------------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.77s [INFO] running `"docker" "inspect" "9807fb9b821826503ec104a1b86b80fbe54823c411dea94e08bcd393ff89235e"` [INFO] running `"docker" "rm" "-f" "9807fb9b821826503ec104a1b86b80fbe54823c411dea94e08bcd393ff89235e"` [INFO] [stdout] 9807fb9b821826503ec104a1b86b80fbe54823c411dea94e08bcd393ff89235e