[INFO] crate serde-odbc 0.1.2 is already in cache [INFO] extracting crate serde-odbc 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/serde-odbc/0.1.2 [INFO] extracting crate serde-odbc 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde-odbc/0.1.2 [INFO] validating manifest of serde-odbc-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of serde-odbc-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing serde-odbc-0.1.2 [INFO] finished frobbing serde-odbc-0.1.2 [INFO] frobbed toml for serde-odbc-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/serde-odbc/0.1.2/Cargo.toml [INFO] started frobbing serde-odbc-0.1.2 [INFO] finished frobbing serde-odbc-0.1.2 [INFO] frobbed toml for serde-odbc-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde-odbc/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting serde-odbc-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/serde-odbc/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a119e2d4230ef82b3b172cb0485bc28976cc5b1ae50affc690afa2318742c78a [INFO] running `"docker" "start" "-a" "a119e2d4230ef82b3b172cb0485bc28976cc5b1ae50affc690afa2318742c78a"` [INFO] [stderr] Checking serde-odbc v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:47:26 [INFO] [stderr] | [INFO] [stderr] 47 | pub const CONN_STR: &'static str = "Driver=Sqlite3;Database=:memory:;"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/string.rs:130:33 [INFO] [stderr] | [INFO] [stderr] 130 | let value: String = "foobar".as_bytes().into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"foobar"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/string.rs:131:25 [INFO] [stderr] | [INFO] [stderr] 131 | assert_eq!(Some("foobar".as_bytes()), value.as_slice()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"foobar"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/string.rs:141:30 [INFO] [stderr] | [INFO] [stderr] 141 | stmt.params().assign("foobarfoobar".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"foobarfoobar"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/string.rs:144:25 [INFO] [stderr] | [INFO] [stderr] 144 | assert_eq!(Some("foobarfo".as_bytes()), stmt.cols().as_slice()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"foobarfo"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.71s [INFO] running `"docker" "inspect" "a119e2d4230ef82b3b172cb0485bc28976cc5b1ae50affc690afa2318742c78a"` [INFO] running `"docker" "rm" "-f" "a119e2d4230ef82b3b172cb0485bc28976cc5b1ae50affc690afa2318742c78a"` [INFO] [stdout] a119e2d4230ef82b3b172cb0485bc28976cc5b1ae50affc690afa2318742c78a