[INFO] crate serde-hjson 0.8.2 is already in cache [INFO] extracting crate serde-hjson 0.8.2 into work/ex/clippy-test-run/sources/stable/reg/serde-hjson/0.8.2 [INFO] extracting crate serde-hjson 0.8.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde-hjson/0.8.2 [INFO] validating manifest of serde-hjson-0.8.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of serde-hjson-0.8.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing serde-hjson-0.8.2 [INFO] finished frobbing serde-hjson-0.8.2 [INFO] frobbed toml for serde-hjson-0.8.2 written to work/ex/clippy-test-run/sources/stable/reg/serde-hjson/0.8.2/Cargo.toml [INFO] started frobbing serde-hjson-0.8.2 [INFO] finished frobbing serde-hjson-0.8.2 [INFO] frobbed toml for serde-hjson-0.8.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde-hjson/0.8.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting serde-hjson-0.8.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/serde-hjson/0.8.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d5f0ce1a2bfc95fb8828acc51ea290145837bbde16c016b55263e8c49fdd1447 [INFO] running `"docker" "start" "-a" "d5f0ce1a2bfc95fb8828acc51ea290145837bbde16c016b55263e8c49fdd1447"` [INFO] [stderr] Checking serde-hjson v0.8.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:501:13 [INFO] [stderr] | [INFO] [stderr] 501 | de: de, [INFO] [stderr] | ^^^^^^ help: replace it with: `de` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:562:13 [INFO] [stderr] | [INFO] [stderr] 562 | de: de, [INFO] [stderr] | ^^^^^^ help: replace it with: `de` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:564:13 [INFO] [stderr] | [INFO] [stderr] 564 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | formatter: formatter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `formatter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:777:13 [INFO] [stderr] | [INFO] [stderr] 777 | indent: indent, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `indent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/value.rs:956:21 [INFO] [stderr] | [INFO] [stderr] 956 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/value.rs:965:21 [INFO] [stderr] | [INFO] [stderr] 965 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:501:13 [INFO] [stderr] | [INFO] [stderr] 501 | de: de, [INFO] [stderr] | ^^^^^^ help: replace it with: `de` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:562:13 [INFO] [stderr] | [INFO] [stderr] 562 | de: de, [INFO] [stderr] | ^^^^^^ help: replace it with: `de` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:564:13 [INFO] [stderr] | [INFO] [stderr] 564 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | formatter: formatter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `formatter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:777:13 [INFO] [stderr] | [INFO] [stderr] 777 | indent: indent, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `indent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/value.rs:956:21 [INFO] [stderr] | [INFO] [stderr] 956 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/value.rs:965:21 [INFO] [stderr] | [INFO] [stderr] 965 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/de.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | / macro_rules! try_or_invalid { [INFO] [stderr] 30 | | ($self_:expr, $e:expr) => { [INFO] [stderr] 31 | | match $e { [INFO] [stderr] 32 | | Some(v) => v, [INFO] [stderr] ... | [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:260:17 [INFO] [stderr] | [INFO] [stderr] 260 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:262:18 [INFO] [stderr] | [INFO] [stderr] 262 | _ => return Ok(false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/de.rs:821:5 [INFO] [stderr] | [INFO] [stderr] 821 | value [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/de.rs:797:17 [INFO] [stderr] | [INFO] [stderr] 797 | let value = match de::Deserialize::deserialize(&mut de) [INFO] [stderr] | _________________^ [INFO] [stderr] 798 | | .and_then(|x| { try!(de.end()); Ok(x) }) [INFO] [stderr] 799 | | { [INFO] [stderr] 800 | | Ok(v) => Ok(v), [INFO] [stderr] ... | [INFO] [stderr] 807 | | } [INFO] [stderr] 808 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/ser.rs:1023:12 [INFO] [stderr] | [INFO] [stderr] 1023 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 1024 | | if !f2.contains("e-") { f2.replace("e", "e+") } else { f2 } [INFO] [stderr] 1025 | | } [INFO] [stderr] | |_____^ help: try: `if !f2.contains("e-") { f2.replace("e", "e+") } else { f2 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/util.rs:147:1 [INFO] [stderr] | [INFO] [stderr] 147 | / macro_rules! try_or_invalid { [INFO] [stderr] 148 | | ($e:expr) => { [INFO] [stderr] 149 | | match $e { [INFO] [stderr] 150 | | Some(v) => v, [INFO] [stderr] ... | [INFO] [stderr] 153 | | } [INFO] [stderr] 154 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:187:25 [INFO] [stderr] | [INFO] [stderr] 187 | return Ok(res.parse::().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res.parse::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:189:28 [INFO] [stderr] | [INFO] [stderr] 189 | _ => { return Err(Error::Syntax(ErrorCode::InvalidNumber, 0, 0)); }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::Syntax(ErrorCode::InvalidNumber, 0, 0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/de.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | / macro_rules! try_or_invalid { [INFO] [stderr] 30 | | ($self_:expr, $e:expr) => { [INFO] [stderr] 31 | | match $e { [INFO] [stderr] 32 | | Some(v) => v, [INFO] [stderr] ... | [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:260:17 [INFO] [stderr] | [INFO] [stderr] 260 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:262:18 [INFO] [stderr] | [INFO] [stderr] 262 | _ => return Ok(false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/de.rs:821:5 [INFO] [stderr] | [INFO] [stderr] 821 | value [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/de.rs:797:17 [INFO] [stderr] | [INFO] [stderr] 797 | let value = match de::Deserialize::deserialize(&mut de) [INFO] [stderr] | _________________^ [INFO] [stderr] 798 | | .and_then(|x| { try!(de.end()); Ok(x) }) [INFO] [stderr] 799 | | { [INFO] [stderr] 800 | | Ok(v) => Ok(v), [INFO] [stderr] ... | [INFO] [stderr] 807 | | } [INFO] [stderr] 808 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/ser.rs:1023:12 [INFO] [stderr] | [INFO] [stderr] 1023 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 1024 | | if !f2.contains("e-") { f2.replace("e", "e+") } else { f2 } [INFO] [stderr] 1025 | | } [INFO] [stderr] | |_____^ help: try: `if !f2.contains("e-") { f2.replace("e", "e+") } else { f2 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/util.rs:147:1 [INFO] [stderr] | [INFO] [stderr] 147 | / macro_rules! try_or_invalid { [INFO] [stderr] 148 | | ($e:expr) => { [INFO] [stderr] 149 | | match $e { [INFO] [stderr] 150 | | Some(v) => v, [INFO] [stderr] ... | [INFO] [stderr] 153 | | } [INFO] [stderr] 154 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:187:25 [INFO] [stderr] | [INFO] [stderr] 187 | return Ok(res.parse::().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res.parse::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:189:28 [INFO] [stderr] | [INFO] [stderr] 189 | _ => { return Err(Error::Syntax(ErrorCode::InvalidNumber, 0, 0)); }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::Syntax(ErrorCode::InvalidNumber, 0, 0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `builder::ArrayBuilder` [INFO] [stderr] --> src/builder.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / pub fn new() -> ArrayBuilder { [INFO] [stderr] 48 | | ArrayBuilder { array: Vec::new() } [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 41 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `builder::ObjectBuilder` [INFO] [stderr] --> src/builder.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | / pub fn new() -> ObjectBuilder { [INFO] [stderr] 91 | | ObjectBuilder { object: Map::new() } [INFO] [stderr] 92 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/de.rs:72:27 [INFO] [stderr] | [INFO] [stderr] 72 | fn is_punctuator_char(&mut self, ch: u8) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/de.rs:92:18 [INFO] [stderr] | [INFO] [stderr] 92 | if self.str_buf.len()==0 { return Err(self.rdr.error(ErrorCode::Custom("Found ':' but no key name (for an empty key name use quotes)".to_string()))); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.str_buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `builder::ArrayBuilder` [INFO] [stderr] --> src/builder.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / pub fn new() -> ArrayBuilder { [INFO] [stderr] 48 | | ArrayBuilder { array: Vec::new() } [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 41 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `builder::ObjectBuilder` [INFO] [stderr] --> src/builder.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | / pub fn new() -> ObjectBuilder { [INFO] [stderr] 91 | | ObjectBuilder { object: Map::new() } [INFO] [stderr] 92 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/de.rs:209:59 [INFO] [stderr] | [INFO] [stderr] 209 | let mut pn = ParseNumber::new(self.str_buf.iter().map(|b| *b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.str_buf.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/de.rs:210:29 [INFO] [stderr] | [INFO] [stderr] 210 | / match pn.parse(false) { [INFO] [stderr] 211 | | Ok(v) => { self.rdr.uneat_char(ch); return visitor.visit_f64(v); }, [INFO] [stderr] 212 | | Err(_) => {} // not a number, continue [INFO] [stderr] 213 | | } [INFO] [stderr] | |_____________________________^ help: try this: `if let Ok(v) = pn.parse(false) { self.rdr.uneat_char(ch); return visitor.visit_f64(v); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/de.rs:235:52 [INFO] [stderr] | [INFO] [stderr] 235 | c @ b'0' ... b'9' => n * 16_u16 + ((c as u16) - (b'0' as u16)), [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(c)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/de.rs:235:65 [INFO] [stderr] | [INFO] [stderr] 235 | c @ b'0' ... b'9' => n * 16_u16 + ((c as u16) - (b'0' as u16)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/de.rs:72:27 [INFO] [stderr] | [INFO] [stderr] 72 | fn is_punctuator_char(&mut self, ch: u8) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/de.rs:92:18 [INFO] [stderr] | [INFO] [stderr] 92 | if self.str_buf.len()==0 { return Err(self.rdr.error(ErrorCode::Custom("Found ':' but no key name (for an empty key name use quotes)".to_string()))); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.str_buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de.rs:369:46 [INFO] [stderr] | [INFO] [stderr] 369 | let n = (((n1 - 0xD800) as u32) << 10 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(n1 - 0xD800)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de.rs:370:47 [INFO] [stderr] | [INFO] [stderr] 370 | (n2 - 0xDC00) as u32) + 0x1_0000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(n2 - 0xDC00)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de.rs:381:58 [INFO] [stderr] | [INFO] [stderr] 381 | match char::from_u32(n as u32) { [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/de.rs:428:9 [INFO] [stderr] | [INFO] [stderr] 428 | / match self.state { [INFO] [stderr] 429 | | State::Root => {} [INFO] [stderr] 430 | | _ => {} [INFO] [stderr] 431 | | }; [INFO] [stderr] | |_________^ help: try this: `if let State::Root = self.state {}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/de.rs:209:59 [INFO] [stderr] | [INFO] [stderr] 209 | let mut pn = ParseNumber::new(self.str_buf.iter().map(|b| *b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.str_buf.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/de.rs:210:29 [INFO] [stderr] | [INFO] [stderr] 210 | / match pn.parse(false) { [INFO] [stderr] 211 | | Ok(v) => { self.rdr.uneat_char(ch); return visitor.visit_f64(v); }, [INFO] [stderr] 212 | | Err(_) => {} // not a number, continue [INFO] [stderr] 213 | | } [INFO] [stderr] | |_____________________________^ help: try this: `if let Ok(v) = pn.parse(false) { self.rdr.uneat_char(ch); return visitor.visit_f64(v); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/de.rs:235:52 [INFO] [stderr] | [INFO] [stderr] 235 | c @ b'0' ... b'9' => n * 16_u16 + ((c as u16) - (b'0' as u16)), [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(c)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/de.rs:235:65 [INFO] [stderr] | [INFO] [stderr] 235 | c @ b'0' ... b'9' => n * 16_u16 + ((c as u16) - (b'0' as u16)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/de.rs:796:45 [INFO] [stderr] | [INFO] [stderr] 796 | let mut de = Deserializer::new_for_root(bytes.iter().map(|b| *b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `bytes.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/de.rs:802:45 [INFO] [stderr] | [INFO] [stderr] 802 | let mut de2 = Deserializer::new(bytes.iter().map(|b| *b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `bytes.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de.rs:369:46 [INFO] [stderr] | [INFO] [stderr] 369 | let n = (((n1 - 0xD800) as u32) << 10 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(n1 - 0xD800)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de.rs:370:47 [INFO] [stderr] | [INFO] [stderr] 370 | (n2 - 0xDC00) as u32) + 0x1_0000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(n2 - 0xDC00)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/de.rs:381:58 [INFO] [stderr] | [INFO] [stderr] 381 | match char::from_u32(n as u32) { [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/de.rs:428:9 [INFO] [stderr] | [INFO] [stderr] 428 | / match self.state { [INFO] [stderr] 429 | | State::Root => {} [INFO] [stderr] 430 | | _ => {} [INFO] [stderr] 431 | | }; [INFO] [stderr] | |_________^ help: try this: `if let State::Root = self.state {}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/de.rs:796:45 [INFO] [stderr] | [INFO] [stderr] 796 | let mut de = Deserializer::new_for_root(bytes.iter().map(|b| *b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `bytes.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/de.rs:802:45 [INFO] [stderr] | [INFO] [stderr] 802 | let mut de2 = Deserializer::new(bytes.iter().map(|b| *b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `bytes.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ser::HjsonFormatter<'a>` [INFO] [stderr] --> src/ser.rs:766:5 [INFO] [stderr] | [INFO] [stderr] 766 | / pub fn new() -> Self { [INFO] [stderr] 767 | | HjsonFormatter::with_indent(b" ") [INFO] [stderr] 768 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 755 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/ser.rs:813:9 [INFO] [stderr] | [INFO] [stderr] 813 | try!(writer.write(b"\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ser.rs:889:8 [INFO] [stderr] | [INFO] [stderr] 889 | if value.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/ser.rs:898:21 [INFO] [stderr] | [INFO] [stderr] 898 | let is_number = match pn.parse(true) { [INFO] [stderr] | _____________________^ [INFO] [stderr] 899 | | Ok(_) => true, [INFO] [stderr] 900 | | Err(_) => false, [INFO] [stderr] 901 | | }; [INFO] [stderr] | |_____^ help: try this: `pn.parse(true).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ser.rs:929:36 [INFO] [stderr] | [INFO] [stderr] 929 | let a: Vec<&str> = value.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ser.rs:943:43 [INFO] [stderr] | [INFO] [stderr] 943 | try!(formatter.newline(wr, if line.len() > 0 { 1 } else { -999 })); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | / match try!(self.rdr.peek_or_null()) { [INFO] [stderr] 208 | | b'0' ... b'9' => { [INFO] [stderr] 209 | | return Err(Error::Syntax(ErrorCode::InvalidNumber, 0, 0)); [INFO] [stderr] 210 | | } [INFO] [stderr] 211 | | _ => { } [INFO] [stderr] 212 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 207 | if let b'0' ... b'9' = match $ expr { [INFO] [stderr] 208 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 209 | :: Err ( err ) => { [INFO] [stderr] 210 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 211 | $ crate :: convert :: From :: from ( err ) ) } } { [INFO] [stderr] 212 | return Err(Error::Syntax(ErrorCode::InvalidNumber, 0, 0)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/util.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | / loop { [INFO] [stderr] 250 | | match try!(self.rdr.peek_or_null()) { [INFO] [stderr] 251 | | b'0' ... b'9' => { self.result.push(self.rdr.eat_char()); } [INFO] [stderr] 252 | | _ => { break; } [INFO] [stderr] 253 | | } [INFO] [stderr] 254 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 249 | while let b'0' ... b'9' = match $ expr { [INFO] [stderr] 250 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 251 | :: Err ( err ) => { [INFO] [stderr] 252 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 253 | $ crate :: convert :: From :: from ( err ) ) } } { .. } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/util.rs:278:9 [INFO] [stderr] | [INFO] [stderr] 278 | / loop { [INFO] [stderr] 279 | | match try!(self.rdr.peek_or_null()) { [INFO] [stderr] 280 | | b'0' ... b'9' => { self.result.push(self.rdr.eat_char()); } [INFO] [stderr] 281 | | _ => { break; } [INFO] [stderr] 282 | | } [INFO] [stderr] 283 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 278 | while let b'0' ... b'9' = match $ expr { [INFO] [stderr] 279 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 280 | :: Err ( err ) => { [INFO] [stderr] 281 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 282 | $ crate :: convert :: From :: from ( err ) ) } } { .. } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ser::HjsonFormatter<'a>` [INFO] [stderr] --> src/ser.rs:766:5 [INFO] [stderr] | [INFO] [stderr] 766 | / pub fn new() -> Self { [INFO] [stderr] 767 | | HjsonFormatter::with_indent(b" ") [INFO] [stderr] 768 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 755 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/ser.rs:813:9 [INFO] [stderr] | [INFO] [stderr] 813 | try!(writer.write(b"\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:565:28 [INFO] [stderr] | [INFO] [stderr] 565 | self.serialize_i64(value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:570:28 [INFO] [stderr] | [INFO] [stderr] 570 | self.serialize_i64(value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:575:28 [INFO] [stderr] | [INFO] [stderr] 575 | self.serialize_i64(value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:594:28 [INFO] [stderr] | [INFO] [stderr] 594 | self.serialize_u64(value as u64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ser.rs:889:8 [INFO] [stderr] | [INFO] [stderr] 889 | if value.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:599:28 [INFO] [stderr] | [INFO] [stderr] 599 | self.serialize_u64(value as u64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:604:28 [INFO] [stderr] | [INFO] [stderr] 604 | self.serialize_u64(value as u64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/ser.rs:898:21 [INFO] [stderr] | [INFO] [stderr] 898 | let is_number = match pn.parse(true) { [INFO] [stderr] | _____________________^ [INFO] [stderr] 899 | | Ok(_) => true, [INFO] [stderr] 900 | | Err(_) => false, [INFO] [stderr] 901 | | }; [INFO] [stderr] | |_____^ help: try this: `pn.parse(true).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:615:28 [INFO] [stderr] | [INFO] [stderr] 615 | self.serialize_f64(value as f64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ser.rs:929:36 [INFO] [stderr] | [INFO] [stderr] 929 | let a: Vec<&str> = value.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ser.rs:943:43 [INFO] [stderr] | [INFO] [stderr] 943 | try!(formatter.newline(wr, if line.len() > 0 { 1 } else { -999 })); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/util.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | / match try!(self.rdr.peek_or_null()) { [INFO] [stderr] 208 | | b'0' ... b'9' => { [INFO] [stderr] 209 | | return Err(Error::Syntax(ErrorCode::InvalidNumber, 0, 0)); [INFO] [stderr] 210 | | } [INFO] [stderr] 211 | | _ => { } [INFO] [stderr] 212 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 207 | if let b'0' ... b'9' = match $ expr { [INFO] [stderr] 208 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 209 | :: Err ( err ) => { [INFO] [stderr] 210 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 211 | $ crate :: convert :: From :: from ( err ) ) } } { [INFO] [stderr] 212 | return Err(Error::Syntax(ErrorCode::InvalidNumber, 0, 0)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/util.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | / loop { [INFO] [stderr] 250 | | match try!(self.rdr.peek_or_null()) { [INFO] [stderr] 251 | | b'0' ... b'9' => { self.result.push(self.rdr.eat_char()); } [INFO] [stderr] 252 | | _ => { break; } [INFO] [stderr] 253 | | } [INFO] [stderr] 254 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 249 | while let b'0' ... b'9' = match $ expr { [INFO] [stderr] 250 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 251 | :: Err ( err ) => { [INFO] [stderr] 252 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 253 | $ crate :: convert :: From :: from ( err ) ) } } { .. } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/util.rs:278:9 [INFO] [stderr] | [INFO] [stderr] 278 | / loop { [INFO] [stderr] 279 | | match try!(self.rdr.peek_or_null()) { [INFO] [stderr] 280 | | b'0' ... b'9' => { self.result.push(self.rdr.eat_char()); } [INFO] [stderr] 281 | | _ => { break; } [INFO] [stderr] 282 | | } [INFO] [stderr] 283 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 278 | while let b'0' ... b'9' = match $ expr { [INFO] [stderr] 279 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 280 | :: Err ( err ) => { [INFO] [stderr] 281 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 282 | $ crate :: convert :: From :: from ( err ) ) } } { .. } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:565:28 [INFO] [stderr] | [INFO] [stderr] 565 | self.serialize_i64(value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:570:28 [INFO] [stderr] | [INFO] [stderr] 570 | self.serialize_i64(value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:575:28 [INFO] [stderr] | [INFO] [stderr] 575 | self.serialize_i64(value as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:594:28 [INFO] [stderr] | [INFO] [stderr] 594 | self.serialize_u64(value as u64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:599:28 [INFO] [stderr] | [INFO] [stderr] 599 | self.serialize_u64(value as u64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:604:28 [INFO] [stderr] | [INFO] [stderr] 604 | self.serialize_u64(value as u64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:615:28 [INFO] [stderr] | [INFO] [stderr] 615 | self.serialize_f64(value as f64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `serde-hjson`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `serde-hjson`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d5f0ce1a2bfc95fb8828acc51ea290145837bbde16c016b55263e8c49fdd1447"` [INFO] running `"docker" "rm" "-f" "d5f0ce1a2bfc95fb8828acc51ea290145837bbde16c016b55263e8c49fdd1447"` [INFO] [stdout] d5f0ce1a2bfc95fb8828acc51ea290145837bbde16c016b55263e8c49fdd1447