[INFO] crate serde-fressian 0.1.1 is already in cache [INFO] extracting crate serde-fressian 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/serde-fressian/0.1.1 [INFO] extracting crate serde-fressian 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde-fressian/0.1.1 [INFO] validating manifest of serde-fressian-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of serde-fressian-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing serde-fressian-0.1.1 [INFO] finished frobbing serde-fressian-0.1.1 [INFO] frobbed toml for serde-fressian-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/serde-fressian/0.1.1/Cargo.toml [INFO] started frobbing serde-fressian-0.1.1 [INFO] finished frobbing serde-fressian-0.1.1 [INFO] frobbed toml for serde-fressian-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde-fressian/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting serde-fressian-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/serde-fressian/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8f93239cd400a4fde1df711fd16438c0f71d0992e01b352bbe340b868fdf7aac [INFO] running `"docker" "start" "-a" "8f93239cd400a4fde1df711fd16438c0f71d0992e01b352bbe340b868fdf7aac"` [INFO] [stderr] Checking ordered-float v0.5.2 [INFO] [stderr] Checking serde-fressian v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/imp/rawinput.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | let e = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/imp/rawinput.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | let f = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/imp/rawinput.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | let g = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/imp/rawinput.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | let h = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/imp/io.rs:122:14 [INFO] [stderr] | [INFO] [stderr] 122 | out: out [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:142:17 [INFO] [stderr] | [INFO] [stderr] 142 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:143:17 [INFO] [stderr] | [INFO] [stderr] 143 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:152:17 [INFO] [stderr] | [INFO] [stderr] 152 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:161:17 [INFO] [stderr] | [INFO] [stderr] 161 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:528:55 [INFO] [stderr] | [INFO] [stderr] 528 | value.serialize(CachingSerializer{ser: ser}) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:394:13 [INFO] [stderr] | [INFO] [stderr] 394 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/imp/rawinput.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | let e = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/imp/rawinput.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | let f = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/imp/rawinput.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | let g = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/imp/rawinput.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | let h = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/imp/io.rs:122:14 [INFO] [stderr] | [INFO] [stderr] 122 | out: out [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:142:17 [INFO] [stderr] | [INFO] [stderr] 142 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:143:17 [INFO] [stderr] | [INFO] [stderr] 143 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:152:17 [INFO] [stderr] | [INFO] [stderr] 152 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:161:17 [INFO] [stderr] | [INFO] [stderr] 161 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:528:55 [INFO] [stderr] | [INFO] [stderr] 528 | value.serialize(CachingSerializer{ser: ser}) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:394:13 [INFO] [stderr] | [INFO] [stderr] 394 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/codes.rs:29:31 [INFO] [stderr] | [INFO] [stderr] 29 | pub const FOOTER_MAGIC: i64 = 0xCFCFCFCF; //3486502863////////////////////////////////// [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xCFCF_CFCF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/ranges.rs:6:33 [INFO] [stderr] | [INFO] [stderr] 6 | pub const PACKED_2_START: u64 = 0xFFFFFFFFFFFFF000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_F000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/ranges.rs:7:31 [INFO] [stderr] | [INFO] [stderr] 7 | pub const PACKED_2_END: u64 = 0x0000000000001000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/ranges.rs:8:33 [INFO] [stderr] | [INFO] [stderr] 8 | pub const PACKED_3_START: u64 = 0xFFFFFFFFFFF80000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFF8_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/ranges.rs:9:31 [INFO] [stderr] | [INFO] [stderr] 9 | pub const PACKED_3_END: u64 = 0x0000000000080000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0008_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/ranges.rs:10:33 [INFO] [stderr] | [INFO] [stderr] 10 | pub const PACKED_4_START: u64 = 0xFFFFFFFFFE000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FE00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/ranges.rs:11:31 [INFO] [stderr] | [INFO] [stderr] 11 | pub const PACKED_4_END: u64 = 0x0000000002000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0200_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/ranges.rs:12:33 [INFO] [stderr] | [INFO] [stderr] 12 | pub const PACKED_5_START: u64 = 0xFFFFFFFE00000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFE_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/ranges.rs:13:31 [INFO] [stderr] | [INFO] [stderr] 13 | pub const PACKED_5_END: u64 = 0x0000000200000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0002_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/ranges.rs:14:33 [INFO] [stderr] | [INFO] [stderr] 14 | pub const PACKED_6_START: u64 = 0xFFFFFE0000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FE00_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/ranges.rs:15:31 [INFO] [stderr] | [INFO] [stderr] 15 | pub const PACKED_6_END: u64 = 0x0000020000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0200_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/ranges.rs:16:33 [INFO] [stderr] | [INFO] [stderr] 16 | pub const PACKED_7_START: u64 = 0xFFFE000000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFE_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/ranges.rs:17:31 [INFO] [stderr] | [INFO] [stderr] 17 | pub const PACKED_7_END: u64 = 0x0002000000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0002_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/imp/rawoutput.rs:335:9 [INFO] [stderr] | [INFO] [stderr] 335 | return 1; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/imp/rawoutput.rs:337:9 [INFO] [stderr] | [INFO] [stderr] 337 | return 3; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/imp/rawoutput.rs:339:9 [INFO] [stderr] | [INFO] [stderr] 339 | return 2; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/imp/io.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/imp/io.rs:170:12 [INFO] [stderr] | [INFO] [stderr] 170 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 171 | | if bytes_written < vec.len() { [INFO] [stderr] 172 | | vec[bytes_written] = byte; [INFO] [stderr] 173 | | } else { [INFO] [stderr] 174 | | vec.push(byte); [INFO] [stderr] 175 | | } [INFO] [stderr] 176 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 170 | } else if bytes_written < vec.len() { [INFO] [stderr] 171 | vec[bytes_written] = byte; [INFO] [stderr] 172 | } else { [INFO] [stderr] 173 | vec.push(byte); [INFO] [stderr] 174 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/codes.rs:29:31 [INFO] [stderr] | [INFO] [stderr] 29 | pub const FOOTER_MAGIC: i64 = 0xCFCFCFCF; //3486502863////////////////////////////////// [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xCFCF_CFCF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/ranges.rs:6:33 [INFO] [stderr] | [INFO] [stderr] 6 | pub const PACKED_2_START: u64 = 0xFFFFFFFFFFFFF000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_F000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/ranges.rs:7:31 [INFO] [stderr] | [INFO] [stderr] 7 | pub const PACKED_2_END: u64 = 0x0000000000001000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/ranges.rs:8:33 [INFO] [stderr] | [INFO] [stderr] 8 | pub const PACKED_3_START: u64 = 0xFFFFFFFFFFF80000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFF8_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/ranges.rs:9:31 [INFO] [stderr] | [INFO] [stderr] 9 | pub const PACKED_3_END: u64 = 0x0000000000080000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0008_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/ranges.rs:10:33 [INFO] [stderr] | [INFO] [stderr] 10 | pub const PACKED_4_START: u64 = 0xFFFFFFFFFE000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FE00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/ranges.rs:11:31 [INFO] [stderr] | [INFO] [stderr] 11 | pub const PACKED_4_END: u64 = 0x0000000002000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0200_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/ranges.rs:12:33 [INFO] [stderr] | [INFO] [stderr] 12 | pub const PACKED_5_START: u64 = 0xFFFFFFFE00000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFE_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/ranges.rs:13:31 [INFO] [stderr] | [INFO] [stderr] 13 | pub const PACKED_5_END: u64 = 0x0000000200000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0002_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/ranges.rs:14:33 [INFO] [stderr] | [INFO] [stderr] 14 | pub const PACKED_6_START: u64 = 0xFFFFFE0000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FE00_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/ranges.rs:15:31 [INFO] [stderr] | [INFO] [stderr] 15 | pub const PACKED_6_END: u64 = 0x0000020000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0200_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/ranges.rs:16:33 [INFO] [stderr] | [INFO] [stderr] 16 | pub const PACKED_7_START: u64 = 0xFFFE000000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFE_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/ranges.rs:17:31 [INFO] [stderr] | [INFO] [stderr] 17 | pub const PACKED_7_END: u64 = 0x0002000000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0002_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/imp/rawoutput.rs:335:9 [INFO] [stderr] | [INFO] [stderr] 335 | return 1; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/imp/rawoutput.rs:337:9 [INFO] [stderr] | [INFO] [stderr] 337 | return 3; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/imp/rawoutput.rs:339:9 [INFO] [stderr] | [INFO] [stderr] 339 | return 2; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/rawinput.rs:384:21 [INFO] [stderr] | [INFO] [stderr] 384 | assert_eq!(-16777216, RawInput.read_int(&mut rdr).unwrap()); [INFO] [stderr] | ^^^^^^^^ help: consider: `16_777_216` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/rawinput.rs:389:20 [INFO] [stderr] | [INFO] [stderr] 389 | assert_eq!(16777216, RawInput.read_int(&mut rdr).unwrap()); [INFO] [stderr] | ^^^^^^^^ help: consider: `16_777_216` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/rawinput.rs:394:21 [INFO] [stderr] | [INFO] [stderr] 394 | assert_eq!(-2147483648, RawInput.read_int(&mut rdr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/rawinput.rs:399:20 [INFO] [stderr] | [INFO] [stderr] 399 | assert_eq!(2147483647, RawInput.read_int(&mut rdr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/rawinput.rs:404:21 [INFO] [stderr] | [INFO] [stderr] 404 | assert_eq!(-549755813887, RawInput.read_int(&mut rdr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `549_755_813_887` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/rawinput.rs:409:20 [INFO] [stderr] | [INFO] [stderr] 409 | assert_eq!(549755813888, RawInput.read_int(&mut rdr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `549_755_813_888` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/rawinput.rs:414:20 [INFO] [stderr] | [INFO] [stderr] 414 | assert_eq!(140737490000000, RawInput.read_int(&mut rdr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `140_737_490_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/rawinput.rs:419:20 [INFO] [stderr] | [INFO] [stderr] 419 | assert_eq!(9007199254740991, RawInput.read_int(&mut rdr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `9_007_199_254_740_991` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/rawinput.rs:424:20 [INFO] [stderr] | [INFO] [stderr] 424 | assert_eq!(9007199254740992, RawInput.read_int(&mut rdr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `9_007_199_254_740_992` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/rawinput.rs:429:21 [INFO] [stderr] | [INFO] [stderr] 429 | assert_eq!(-9007199254740991, RawInput.read_int(&mut rdr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `9_007_199_254_740_991` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/rawinput.rs:434:21 [INFO] [stderr] | [INFO] [stderr] 434 | assert_eq!(-9007199254740993, RawInput.read_int(&mut rdr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `9_007_199_254_740_993` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/rawinput.rs:439:20 [INFO] [stderr] | [INFO] [stderr] 439 | assert_eq!(9223372036854775807, RawInput.read_int(&mut rdr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/rawinput.rs:444:21 [INFO] [stderr] | [INFO] [stderr] 444 | assert_eq!(-9223372036854775808, RawInput.read_int(&mut rdr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_808` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/rawinput.rs:463:20 [INFO] [stderr] | [INFO] [stderr] 463 | assert_eq!(3.4028235E38, RawInput.read_float(&mut rdr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `3.402_823_5E38` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/imp/rawinput.rs:474:28 [INFO] [stderr] | [INFO] [stderr] 474 | let control: f64 = 9.8461319849314E10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `9.846_131_984_931_4E10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/imp/io.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/imp/io.rs:170:12 [INFO] [stderr] | [INFO] [stderr] 170 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 171 | | if bytes_written < vec.len() { [INFO] [stderr] 172 | | vec[bytes_written] = byte; [INFO] [stderr] 173 | | } else { [INFO] [stderr] 174 | | vec.push(byte); [INFO] [stderr] 175 | | } [INFO] [stderr] 176 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 170 | } else if bytes_written < vec.len() { [INFO] [stderr] 171 | vec[bytes_written] = byte; [INFO] [stderr] 172 | } else { [INFO] [stderr] 173 | vec.push(byte); [INFO] [stderr] 174 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i` [INFO] [stderr] --> src/imp/rawoutput.rs:82:25 [INFO] [stderr] | [INFO] [stderr] 82 | writer.write_u8((i >> 0) as u8) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/imp/rawoutput.rs:179:19 [INFO] [stderr] | [INFO] [stderr] 179 | } else if f == 1.0 { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(f - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/imp/rawoutput.rs:179:19 [INFO] [stderr] | [INFO] [stderr] 179 | } else if f == 1.0 { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawoutput.rs:275:48 [INFO] [stderr] | [INFO] [stderr] 275 | write_char(utf16_bytes[0] as u32, &mut buffer, &mut buf_pos); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(utf16_bytes[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawoutput.rs:276:48 [INFO] [stderr] | [INFO] [stderr] 276 | write_char(utf16_bytes[1] as u32, &mut buffer, &mut buf_pos); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(utf16_bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ch as u32` [INFO] [stderr] --> src/imp/rawoutput.rs:363:56 [INFO] [stderr] | [INFO] [stderr] 363 | add_byte_at_index(buffer, buf_pos, (0x80 | ch as u32 >> 0 & 0x3f) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ch as u32` [INFO] [stderr] --> src/imp/rawoutput.rs:368:56 [INFO] [stderr] | [INFO] [stderr] 368 | add_byte_at_index(buffer, buf_pos, (0x80 | ch as u32 >> 0 & 0x3f) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | let high = *reader.read_u8()? as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | let low = *reader.read_u8()? as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | let a = *reader.read_u8()? as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | let b = *reader.read_u8()? as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | let c = *reader.read_u8()? as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | let a = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:41:45 [INFO] [stderr] | [INFO] [stderr] 41 | let a = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | let b = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:42:45 [INFO] [stderr] | [INFO] [stderr] 42 | let b = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | let c = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:43:45 [INFO] [stderr] | [INFO] [stderr] 43 | let c = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | let d = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:44:45 [INFO] [stderr] | [INFO] [stderr] 44 | let d = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:45:54 [INFO] [stderr] | [INFO] [stderr] 45 | Ok( ((a << 24) | (b << 16) | (c << 8) | d) & std::u32::MAX as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(std::u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:50:20 [INFO] [stderr] | [INFO] [stderr] 50 | let high = *reader.read_u8()? as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:57:20 [INFO] [stderr] | [INFO] [stderr] 57 | let high = *reader.read_u8()? as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | let a = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:64:45 [INFO] [stderr] | [INFO] [stderr] 64 | let a = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | let b = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:65:45 [INFO] [stderr] | [INFO] [stderr] 65 | let b = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | let c = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:66:45 [INFO] [stderr] | [INFO] [stderr] 66 | let c = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:67:17 [INFO] [stderr] | [INFO] [stderr] 67 | let d = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:67:45 [INFO] [stderr] | [INFO] [stderr] 67 | let d = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | let e = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:68:45 [INFO] [stderr] | [INFO] [stderr] 68 | let e = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | let f = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:69:45 [INFO] [stderr] | [INFO] [stderr] 69 | let f = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | let g = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:70:45 [INFO] [stderr] | [INFO] [stderr] 70 | let g = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | let h = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:71:45 [INFO] [stderr] | [INFO] [stderr] 71 | let h = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:88:20 [INFO] [stderr] | [INFO] [stderr] 88 | Ok((code & 0xFF) as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(code & 0xFF)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `code` [INFO] [stderr] --> src/imp/rawinput.rs:88:20 [INFO] [stderr] | [INFO] [stderr] 88 | Ok((code & 0xFF) as i64) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:92:31 [INFO] [stderr] | [INFO] [stderr] 92 | let packing = ((code - codes::INT_PACKED_2_ZERO as i8) as i64) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(code - codes::INT_PACKED_2_ZERO as i8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:93:25 [INFO] [stderr] | [INFO] [stderr] 93 | let r = *reader.read_u8()? as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:98:31 [INFO] [stderr] | [INFO] [stderr] 98 | let packing = ((code - codes::INT_PACKED_3_ZERO as i8) as i64) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(code - codes::INT_PACKED_3_ZERO as i8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:104:31 [INFO] [stderr] | [INFO] [stderr] 104 | let packing = ((code - codes::INT_PACKED_4_ZERO as i8) as i64) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(code - codes::INT_PACKED_4_ZERO as i8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:110:31 [INFO] [stderr] | [INFO] [stderr] 110 | let packing = ((code - codes::INT_PACKED_5_ZERO as i8) as i64) << 32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(code - codes::INT_PACKED_5_ZERO as i8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:116:31 [INFO] [stderr] | [INFO] [stderr] 116 | let packing = ((code - codes::INT_PACKED_6_ZERO as i8) as i64) << 40; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(code - codes::INT_PACKED_6_ZERO as i8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:122:31 [INFO] [stderr] | [INFO] [stderr] 122 | let packing = ((code - codes::INT_PACKED_7_ZERO as i8) as i64) << 48; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(code - codes::INT_PACKED_7_ZERO as i8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `bytes[pos]` [INFO] [stderr] --> src/imp/rawinput.rs:280:26 [INFO] [stderr] | [INFO] [stderr] 280 | let ch = bytes[pos] & 0xff; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:284:34 [INFO] [stderr] | [INFO] [stderr] 284 | buf.push(ch as u16) [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(ch)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:287:35 [INFO] [stderr] | [INFO] [stderr] 287 | let ch0 = ch as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(ch)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:288:35 [INFO] [stderr] | [INFO] [stderr] 288 | let ch1 = bytes[pos] as u32 & 0xff; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[pos])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:294:35 [INFO] [stderr] | [INFO] [stderr] 294 | let ch0 = ch as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(ch)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:295:35 [INFO] [stderr] | [INFO] [stderr] 295 | let ch1 = bytes[pos] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[pos])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:296:35 [INFO] [stderr] | [INFO] [stderr] 296 | let ch2 = bytes[pos + 1] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[pos + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/imp/rawinput.rs:308:16 [INFO] [stderr] | [INFO] [stderr] 308 | .or(Err(Error::syntax(ErrorCode::InvalidUTF8, length + bytes_read))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| Err(Error::syntax(ErrorCode::InvalidUTF8, length + bytes_read)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/imp/io.rs:23:24 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn from_vec(v: &'a Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/imp/io.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | &mut self.out.truncate(self.bytes_written); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.out.truncate(self.bytes_written);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/imp/io.rs:141:19 [INFO] [stderr] | [INFO] [stderr] 141 | pub fn to_vec(&mut self) -> Vec { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/imp/io.rs:165:12 [INFO] [stderr] | [INFO] [stderr] 165 | if vec.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/imp/cache.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | self.store.get(val).map(|code: &u8| *code ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.store.get(val).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/imp/cache.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / if self.store.contains_key(&val) { [INFO] [stderr] 30 | | None [INFO] [stderr] 31 | | } else { [INFO] [stderr] 32 | | match self.store.insert(val, index) { [INFO] [stderr] ... | [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ help: consider using: `self.store.entry(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/ser.rs:49:19 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn to_vec(&mut self) -> Vec { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/ser.rs:96:24 [INFO] [stderr] | [INFO] [stderr] 96 | let v: Value = Value::from(value.clone().into()); /////////////////////// need refd Vals [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Value::from()`: `value.clone().into()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:110:36 [INFO] [stderr] | [INFO] [stderr] 110 | self.write_int(code as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(code)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:721:28 [INFO] [stderr] | [INFO] [stderr] 721 | self.ser.write_int(_value as i64) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(_value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ser.rs:877:30 [INFO] [stderr] | [INFO] [stderr] 877 | if (_value == 0.0) | (_value == 1.0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(_value - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ser.rs:877:30 [INFO] [stderr] | [INFO] [stderr] 877 | if (_value == 0.0) | (_value == 1.0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ser.rs:886:30 [INFO] [stderr] | [INFO] [stderr] 886 | if (_value == 0.0) | (_value == 1.0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(_value - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ser.rs:886:30 [INFO] [stderr] | [INFO] [stderr] 886 | if (_value == 0.0) | (_value == 1.0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ser.rs:925:12 [INFO] [stderr] | [INFO] [stderr] 925 | if _value.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!_value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/de.rs:34:24 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn from_vec(v: &'de Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/de.rs:69:27 [INFO] [stderr] | [INFO] [stderr] 69 | pub fn from_vec<'a, T>(v: &'a Vec) -> Result [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/types.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | / pub fn from_str(s: &str) -> Result { [INFO] [stderr] 183 | | Ok(URI(s.to_string())) [INFO] [stderr] 184 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/types.rs:259:9 [INFO] [stderr] | [INFO] [stderr] 259 | / pub fn from_str(s: &str) -> Result { [INFO] [stderr] 260 | | Ok(REGEX(s.to_string())) [INFO] [stderr] 261 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types.rs:478:34 [INFO] [stderr] | [INFO] [stderr] 478 | pub fn serialize(vec: &Vec, serializer: S) -> Result [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types.rs:524:34 [INFO] [stderr] | [INFO] [stderr] 524 | pub fn serialize(vec: &Vec, serializer: S) -> Result [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/types.rs:540:53 [INFO] [stderr] | [INFO] [stderr] 540 | .map(|f: f32| OrderedFloat::from(f)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `OrderedFloat::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types.rs:575:34 [INFO] [stderr] | [INFO] [stderr] 575 | pub fn serialize(vec: &Vec, serializer: S) -> Result [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/types.rs:589:53 [INFO] [stderr] | [INFO] [stderr] 589 | .map(|f: f64| OrderedFloat::from(f)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `OrderedFloat::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types.rs:624:34 [INFO] [stderr] | [INFO] [stderr] 624 | pub fn serialize(vec: &Vec, serializer: S) -> Result [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types.rs:671:34 [INFO] [stderr] | [INFO] [stderr] 671 | pub fn serialize(vec: &Vec, serializer: S) -> Result [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[bool]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/wasm/mod.rs:50:29 [INFO] [stderr] | [INFO] [stderr] 50 | Vec::from_raw_parts(ptr, cap, cap) [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/wasm/mod.rs:77:36 [INFO] [stderr] | [INFO] [stderr] 77 | std::slice::from_raw_parts(ptr, len) [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `serde-fressian`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i` [INFO] [stderr] --> src/imp/rawoutput.rs:82:25 [INFO] [stderr] | [INFO] [stderr] 82 | writer.write_u8((i >> 0) as u8) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/imp/rawoutput.rs:179:19 [INFO] [stderr] | [INFO] [stderr] 179 | } else if f == 1.0 { [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(f - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/imp/rawoutput.rs:179:19 [INFO] [stderr] | [INFO] [stderr] 179 | } else if f == 1.0 { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawoutput.rs:275:48 [INFO] [stderr] | [INFO] [stderr] 275 | write_char(utf16_bytes[0] as u32, &mut buffer, &mut buf_pos); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(utf16_bytes[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawoutput.rs:276:48 [INFO] [stderr] | [INFO] [stderr] 276 | write_char(utf16_bytes[1] as u32, &mut buffer, &mut buf_pos); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(utf16_bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ch as u32` [INFO] [stderr] --> src/imp/rawoutput.rs:363:56 [INFO] [stderr] | [INFO] [stderr] 363 | add_byte_at_index(buffer, buf_pos, (0x80 | ch as u32 >> 0 & 0x3f) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ch as u32` [INFO] [stderr] --> src/imp/rawoutput.rs:368:56 [INFO] [stderr] | [INFO] [stderr] 368 | add_byte_at_index(buffer, buf_pos, (0x80 | ch as u32 >> 0 & 0x3f) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | let high = *reader.read_u8()? as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | let low = *reader.read_u8()? as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | let a = *reader.read_u8()? as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | let b = *reader.read_u8()? as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | let c = *reader.read_u8()? as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | let a = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:41:45 [INFO] [stderr] | [INFO] [stderr] 41 | let a = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | let b = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:42:45 [INFO] [stderr] | [INFO] [stderr] 42 | let b = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | let c = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:43:45 [INFO] [stderr] | [INFO] [stderr] 43 | let c = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | let d = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:44:45 [INFO] [stderr] | [INFO] [stderr] 44 | let d = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:45:54 [INFO] [stderr] | [INFO] [stderr] 45 | Ok( ((a << 24) | (b << 16) | (c << 8) | d) & std::u32::MAX as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(std::u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:50:20 [INFO] [stderr] | [INFO] [stderr] 50 | let high = *reader.read_u8()? as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:57:20 [INFO] [stderr] | [INFO] [stderr] 57 | let high = *reader.read_u8()? as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | let a = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:64:45 [INFO] [stderr] | [INFO] [stderr] 64 | let a = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | let b = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:65:45 [INFO] [stderr] | [INFO] [stderr] 65 | let b = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | let c = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:66:45 [INFO] [stderr] | [INFO] [stderr] 66 | let c = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:67:17 [INFO] [stderr] | [INFO] [stderr] 67 | let d = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:67:45 [INFO] [stderr] | [INFO] [stderr] 67 | let d = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | let e = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:68:45 [INFO] [stderr] | [INFO] [stderr] 68 | let e = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | let f = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:69:45 [INFO] [stderr] | [INFO] [stderr] 69 | let f = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | let g = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:70:45 [INFO] [stderr] | [INFO] [stderr] 70 | let g = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | let h = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:71:45 [INFO] [stderr] | [INFO] [stderr] 71 | let h = *reader.read_u8()? as i64 & std::u8::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:88:20 [INFO] [stderr] | [INFO] [stderr] 88 | Ok((code & 0xFF) as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(code & 0xFF)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `code` [INFO] [stderr] --> src/imp/rawinput.rs:88:20 [INFO] [stderr] | [INFO] [stderr] 88 | Ok((code & 0xFF) as i64) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:92:31 [INFO] [stderr] | [INFO] [stderr] 92 | let packing = ((code - codes::INT_PACKED_2_ZERO as i8) as i64) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(code - codes::INT_PACKED_2_ZERO as i8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:93:25 [INFO] [stderr] | [INFO] [stderr] 93 | let r = *reader.read_u8()? as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(*reader.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:98:31 [INFO] [stderr] | [INFO] [stderr] 98 | let packing = ((code - codes::INT_PACKED_3_ZERO as i8) as i64) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(code - codes::INT_PACKED_3_ZERO as i8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:104:31 [INFO] [stderr] | [INFO] [stderr] 104 | let packing = ((code - codes::INT_PACKED_4_ZERO as i8) as i64) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(code - codes::INT_PACKED_4_ZERO as i8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:110:31 [INFO] [stderr] | [INFO] [stderr] 110 | let packing = ((code - codes::INT_PACKED_5_ZERO as i8) as i64) << 32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(code - codes::INT_PACKED_5_ZERO as i8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:116:31 [INFO] [stderr] | [INFO] [stderr] 116 | let packing = ((code - codes::INT_PACKED_6_ZERO as i8) as i64) << 40; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(code - codes::INT_PACKED_6_ZERO as i8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:122:31 [INFO] [stderr] | [INFO] [stderr] 122 | let packing = ((code - codes::INT_PACKED_7_ZERO as i8) as i64) << 48; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(code - codes::INT_PACKED_7_ZERO as i8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `bytes[pos]` [INFO] [stderr] --> src/imp/rawinput.rs:280:26 [INFO] [stderr] | [INFO] [stderr] 280 | let ch = bytes[pos] & 0xff; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:284:34 [INFO] [stderr] | [INFO] [stderr] 284 | buf.push(ch as u16) [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(ch)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:287:35 [INFO] [stderr] | [INFO] [stderr] 287 | let ch0 = ch as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(ch)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:288:35 [INFO] [stderr] | [INFO] [stderr] 288 | let ch1 = bytes[pos] as u32 & 0xff; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[pos])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:294:35 [INFO] [stderr] | [INFO] [stderr] 294 | let ch0 = ch as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(ch)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:295:35 [INFO] [stderr] | [INFO] [stderr] 295 | let ch1 = bytes[pos] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[pos])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/imp/rawinput.rs:296:35 [INFO] [stderr] | [INFO] [stderr] 296 | let ch2 = bytes[pos + 1] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[pos + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/imp/rawinput.rs:308:16 [INFO] [stderr] | [INFO] [stderr] 308 | .or(Err(Error::syntax(ErrorCode::InvalidUTF8, length + bytes_read))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| Err(Error::syntax(ErrorCode::InvalidUTF8, length + bytes_read)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/imp/rawinput.rs:453:9 [INFO] [stderr] | [INFO] [stderr] 453 | assert_eq!(32.2, RawInput.read_float(&mut rdr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/imp/rawinput.rs:453:9 [INFO] [stderr] | [INFO] [stderr] 453 | assert_eq!(32.2, RawInput.read_float(&mut rdr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/imp/rawinput.rs:458:9 [INFO] [stderr] | [INFO] [stderr] 458 | assert_eq!(1.4E-45, RawInput.read_float(&mut rdr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/imp/rawinput.rs:458:9 [INFO] [stderr] | [INFO] [stderr] 458 | assert_eq!(1.4E-45, RawInput.read_float(&mut rdr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/imp/rawinput.rs:463:9 [INFO] [stderr] | [INFO] [stderr] 463 | assert_eq!(3.4028235E38, RawInput.read_float(&mut rdr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/imp/rawinput.rs:463:9 [INFO] [stderr] | [INFO] [stderr] 463 | assert_eq!(3.4028235E38, RawInput.read_float(&mut rdr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/imp/rawinput.rs:469:9 [INFO] [stderr] | [INFO] [stderr] 469 | assert_eq!(control, RawInput.read_double(&mut rdr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/imp/rawinput.rs:469:9 [INFO] [stderr] | [INFO] [stderr] 469 | assert_eq!(control, RawInput.read_double(&mut rdr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/imp/rawinput.rs:475:9 [INFO] [stderr] | [INFO] [stderr] 475 | assert_eq!(control, RawInput.read_double(&mut rdr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/imp/rawinput.rs:475:9 [INFO] [stderr] | [INFO] [stderr] 475 | assert_eq!(control, RawInput.read_double(&mut rdr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/imp/rawinput.rs:481:9 [INFO] [stderr] | [INFO] [stderr] 481 | assert_eq!(control, RawInput.read_double(&mut rdr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/imp/rawinput.rs:481:9 [INFO] [stderr] | [INFO] [stderr] 481 | assert_eq!(control, RawInput.read_double(&mut rdr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/imp/rawinput.rs:487:9 [INFO] [stderr] | [INFO] [stderr] 487 | assert_eq!(control, RawInput.read_double(&mut rdr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/imp/rawinput.rs:487:9 [INFO] [stderr] | [INFO] [stderr] 487 | assert_eq!(control, RawInput.read_double(&mut rdr).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/imp/io.rs:23:24 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn from_vec(v: &'a Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/imp/io.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | &mut self.out.truncate(self.bytes_written); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.out.truncate(self.bytes_written);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/imp/io.rs:141:19 [INFO] [stderr] | [INFO] [stderr] 141 | pub fn to_vec(&mut self) -> Vec { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/imp/io.rs:165:12 [INFO] [stderr] | [INFO] [stderr] 165 | if vec.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/imp/cache.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | self.store.get(val).map(|code: &u8| *code ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.store.get(val).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/imp/cache.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / if self.store.contains_key(&val) { [INFO] [stderr] 30 | | None [INFO] [stderr] 31 | | } else { [INFO] [stderr] 32 | | match self.store.insert(val, index) { [INFO] [stderr] ... | [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ help: consider using: `self.store.entry(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/ser.rs:49:19 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn to_vec(&mut self) -> Vec { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/ser.rs:96:24 [INFO] [stderr] | [INFO] [stderr] 96 | let v: Value = Value::from(value.clone().into()); /////////////////////// need refd Vals [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Value::from()`: `value.clone().into()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:110:36 [INFO] [stderr] | [INFO] [stderr] 110 | self.write_int(code as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(code)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:721:28 [INFO] [stderr] | [INFO] [stderr] 721 | self.ser.write_int(_value as i64) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(_value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ser.rs:877:30 [INFO] [stderr] | [INFO] [stderr] 877 | if (_value == 0.0) | (_value == 1.0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(_value - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ser.rs:877:30 [INFO] [stderr] | [INFO] [stderr] 877 | if (_value == 0.0) | (_value == 1.0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ser.rs:886:30 [INFO] [stderr] | [INFO] [stderr] 886 | if (_value == 0.0) | (_value == 1.0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(_value - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ser.rs:886:30 [INFO] [stderr] | [INFO] [stderr] 886 | if (_value == 0.0) | (_value == 1.0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ser.rs:925:12 [INFO] [stderr] | [INFO] [stderr] 925 | if _value.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!_value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/de.rs:34:24 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn from_vec(v: &'de Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/de.rs:69:27 [INFO] [stderr] | [INFO] [stderr] 69 | pub fn from_vec<'a, T>(v: &'a Vec) -> Result [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/types.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | / pub fn from_str(s: &str) -> Result { [INFO] [stderr] 183 | | Ok(URI(s.to_string())) [INFO] [stderr] 184 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/types.rs:259:9 [INFO] [stderr] | [INFO] [stderr] 259 | / pub fn from_str(s: &str) -> Result { [INFO] [stderr] 260 | | Ok(REGEX(s.to_string())) [INFO] [stderr] 261 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types.rs:478:34 [INFO] [stderr] | [INFO] [stderr] 478 | pub fn serialize(vec: &Vec, serializer: S) -> Result [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types.rs:524:34 [INFO] [stderr] | [INFO] [stderr] 524 | pub fn serialize(vec: &Vec, serializer: S) -> Result [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/types.rs:540:53 [INFO] [stderr] | [INFO] [stderr] 540 | .map(|f: f32| OrderedFloat::from(f)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `OrderedFloat::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types.rs:575:34 [INFO] [stderr] | [INFO] [stderr] 575 | pub fn serialize(vec: &Vec, serializer: S) -> Result [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/types.rs:589:53 [INFO] [stderr] | [INFO] [stderr] 589 | .map(|f: f64| OrderedFloat::from(f)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `OrderedFloat::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types.rs:624:34 [INFO] [stderr] | [INFO] [stderr] 624 | pub fn serialize(vec: &Vec, serializer: S) -> Result [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types.rs:671:34 [INFO] [stderr] | [INFO] [stderr] 671 | pub fn serialize(vec: &Vec, serializer: S) -> Result [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[bool]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/wasm/mod.rs:50:29 [INFO] [stderr] | [INFO] [stderr] 50 | Vec::from_raw_parts(ptr, cap, cap) [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/wasm/mod.rs:77:36 [INFO] [stderr] | [INFO] [stderr] 77 | std::slice::from_raw_parts(ptr, len) [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to 12 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `serde-fressian`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8f93239cd400a4fde1df711fd16438c0f71d0992e01b352bbe340b868fdf7aac"` [INFO] running `"docker" "rm" "-f" "8f93239cd400a4fde1df711fd16438c0f71d0992e01b352bbe340b868fdf7aac"` [INFO] [stdout] 8f93239cd400a4fde1df711fd16438c0f71d0992e01b352bbe340b868fdf7aac