[INFO] crate serde-avro 0.5.0 is already in cache [INFO] extracting crate serde-avro 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/serde-avro/0.5.0 [INFO] extracting crate serde-avro 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde-avro/0.5.0 [INFO] validating manifest of serde-avro-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of serde-avro-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing serde-avro-0.5.0 [INFO] finished frobbing serde-avro-0.5.0 [INFO] frobbed toml for serde-avro-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/serde-avro/0.5.0/Cargo.toml [INFO] started frobbing serde-avro-0.5.0 [INFO] finished frobbing serde-avro-0.5.0 [INFO] frobbed toml for serde-avro-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/serde-avro/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting serde-avro-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/serde-avro/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f3e18af7c887469af233705232bc8f125387e133007a161223d3f38f3855ad39 [INFO] running `"docker" "start" "-a" "f3e18af7c887469af233705232bc8f125387e133007a161223d3f38f3855ad39"` [INFO] [stderr] Compiling serde-avro v0.5.0 (/opt/crater/workdir) [INFO] [stderr] Checking snap v0.2.5 [INFO] [stderr] Checking ordered-float v0.4.0 [INFO] [stderr] Checking error-chain v0.9.0 [INFO] [stderr] Checking serde-value v0.4.1 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/read.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/read.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | remaining: remaining, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `remaining` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/read.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/read.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | codec: codec, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `codec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/read.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | sync_marker: sync_marker, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sync_marker` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | registry: registry, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `registry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | schema: schema, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `schema` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | registry: registry, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `registry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | schema: schema, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `schema` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | registry: registry, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `registry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:378:13 [INFO] [stderr] | [INFO] [stderr] 378 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:379:13 [INFO] [stderr] | [INFO] [stderr] 379 | registry: registry, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `registry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:380:13 [INFO] [stderr] | [INFO] [stderr] 380 | elem_schema: elem_schema, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `elem_schema` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:413:13 [INFO] [stderr] | [INFO] [stderr] 413 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:414:13 [INFO] [stderr] | [INFO] [stderr] 414 | registry: registry, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `registry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:415:13 [INFO] [stderr] | [INFO] [stderr] 415 | value_schema: value_schema, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value_schema` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schema.rs:245:13 [INFO] [stderr] | [INFO] [stderr] 245 | doc: doc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `doc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schema.rs:246:13 [INFO] [stderr] | [INFO] [stderr] 246 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schema.rs:280:13 [INFO] [stderr] | [INFO] [stderr] 280 | doc: doc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `doc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schema.rs:281:13 [INFO] [stderr] | [INFO] [stderr] 281 | symbols: symbols, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `symbols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schema.rs:335:13 [INFO] [stderr] | [INFO] [stderr] 335 | doc: doc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `doc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schema.rs:382:13 [INFO] [stderr] | [INFO] [stderr] 382 | doc: doc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `doc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schema.rs:383:13 [INFO] [stderr] | [INFO] [stderr] 383 | field_type: field_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/read.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/read.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | remaining: remaining, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `remaining` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/read.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/read.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | codec: codec, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `codec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/read.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | sync_marker: sync_marker, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sync_marker` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | registry: registry, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `registry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | schema: schema, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `schema` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | registry: registry, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `registry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | schema: schema, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `schema` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | registry: registry, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `registry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:378:13 [INFO] [stderr] | [INFO] [stderr] 378 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:379:13 [INFO] [stderr] | [INFO] [stderr] 379 | registry: registry, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `registry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:380:13 [INFO] [stderr] | [INFO] [stderr] 380 | elem_schema: elem_schema, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `elem_schema` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:413:13 [INFO] [stderr] | [INFO] [stderr] 413 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:414:13 [INFO] [stderr] | [INFO] [stderr] 414 | registry: registry, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `registry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de/mod.rs:415:13 [INFO] [stderr] | [INFO] [stderr] 415 | value_schema: value_schema, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value_schema` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schema.rs:245:13 [INFO] [stderr] | [INFO] [stderr] 245 | doc: doc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `doc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schema.rs:246:13 [INFO] [stderr] | [INFO] [stderr] 246 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schema.rs:280:13 [INFO] [stderr] | [INFO] [stderr] 280 | doc: doc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `doc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schema.rs:281:13 [INFO] [stderr] | [INFO] [stderr] 281 | symbols: symbols, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `symbols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schema.rs:335:13 [INFO] [stderr] | [INFO] [stderr] 335 | doc: doc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `doc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schema.rs:382:13 [INFO] [stderr] | [INFO] [stderr] 382 | doc: doc, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `doc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schema.rs:383:13 [INFO] [stderr] | [INFO] [stderr] 383 | field_type: field_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/de/read.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | let mut buffer = self.current_block.get_mut(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/de/util.rs:17:12 [INFO] [stderr] | [INFO] [stderr] 17 | if v < (i32::min_value() as i64) || v > (i32::max_value() as i64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i32::min_value())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/de/util.rs:17:45 [INFO] [stderr] | [INFO] [stderr] 17 | if v < (i32::min_value() as i64) || v > (i32::max_value() as i64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i32::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/de/util.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | num |= (byte as u64 & 0b0111_1111) << (i * 7); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/de/mod.rs:104:12 [INFO] [stderr] | [INFO] [stderr] 104 | if &[b'O', b'b', b'j', 1] != &*header.magic { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 104 | if [b'O', b'b', b'j', 1] != *header.magic { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de/mod.rs:110:18 [INFO] [stderr] | [INFO] [stderr] 110 | .ok_or(Error::from(ErrorKind::NoSchema))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::NoSchema))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de/mod.rs:116:18 [INFO] [stderr] | [INFO] [stderr] 116 | .ok_or(Error::from(ErrorKind::NoRootType))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::NoRootType))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `schema::SchemaRegistry` [INFO] [stderr] --> src/schema.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | / pub fn new() -> SchemaRegistry { [INFO] [stderr] 135 | | SchemaRegistry { [INFO] [stderr] 136 | | schemata: Vec::new(), [INFO] [stderr] 137 | | next_id: 0, [INFO] [stderr] 138 | | schemata_by_name: collections::HashMap::new(), [INFO] [stderr] 139 | | } [INFO] [stderr] 140 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/schema.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | / match json { [INFO] [stderr] 150 | | &serde_json::Value::Array(ref vs) => { [INFO] [stderr] 151 | | for v in vs { [INFO] [stderr] 152 | | self.create_schema_ref(None, v)?; [INFO] [stderr] ... | [INFO] [stderr] 156 | | _ => self.create_schema_ref(None, json).map(Some), [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 149 | match *json { [INFO] [stderr] 150 | serde_json::Value::Array(ref vs) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:182:22 [INFO] [stderr] | [INFO] [stderr] 182 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:219:14 [INFO] [stderr] | [INFO] [stderr] 219 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:223:22 [INFO] [stderr] | [INFO] [stderr] 223 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:237:22 [INFO] [stderr] | [INFO] [stderr] 237 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:264:22 [INFO] [stderr] | [INFO] [stderr] 264 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:271:14 [INFO] [stderr] | [INFO] [stderr] 271 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:275:14 [INFO] [stderr] | [INFO] [stderr] 275 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:292:14 [INFO] [stderr] | [INFO] [stderr] 292 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:304:14 [INFO] [stderr] | [INFO] [stderr] 304 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:323:22 [INFO] [stderr] | [INFO] [stderr] 323 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:330:14 [INFO] [stderr] | [INFO] [stderr] 330 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:364:14 [INFO] [stderr] | [INFO] [stderr] 364 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:371:22 [INFO] [stderr] | [INFO] [stderr] 371 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:376:14 [INFO] [stderr] | [INFO] [stderr] 376 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/schema.rs:499:10 [INFO] [stderr] | [INFO] [stderr] 499 | .unwrap_or(Ok(namespace))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ok(namespace))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:496:18 [INFO] [stderr] | [INFO] [stderr] 496 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:503:10 [INFO] [stderr] | [INFO] [stderr] 503 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/de/read.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | let mut buffer = self.current_block.get_mut(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/de/util.rs:17:12 [INFO] [stderr] | [INFO] [stderr] 17 | if v < (i32::min_value() as i64) || v > (i32::max_value() as i64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i32::min_value())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/de/util.rs:17:45 [INFO] [stderr] | [INFO] [stderr] 17 | if v < (i32::min_value() as i64) || v > (i32::max_value() as i64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(i32::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/de/util.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | num |= (byte as u64 & 0b0111_1111) << (i * 7); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/de/mod.rs:104:12 [INFO] [stderr] | [INFO] [stderr] 104 | if &[b'O', b'b', b'j', 1] != &*header.magic { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 104 | if [b'O', b'b', b'j', 1] != *header.magic { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de/mod.rs:110:18 [INFO] [stderr] | [INFO] [stderr] 110 | .ok_or(Error::from(ErrorKind::NoSchema))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::NoSchema))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de/mod.rs:116:18 [INFO] [stderr] | [INFO] [stderr] 116 | .ok_or(Error::from(ErrorKind::NoRootType))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::NoRootType))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `schema::SchemaRegistry` [INFO] [stderr] --> src/schema.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | / pub fn new() -> SchemaRegistry { [INFO] [stderr] 135 | | SchemaRegistry { [INFO] [stderr] 136 | | schemata: Vec::new(), [INFO] [stderr] 137 | | next_id: 0, [INFO] [stderr] 138 | | schemata_by_name: collections::HashMap::new(), [INFO] [stderr] 139 | | } [INFO] [stderr] 140 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/schema.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | / match json { [INFO] [stderr] 150 | | &serde_json::Value::Array(ref vs) => { [INFO] [stderr] 151 | | for v in vs { [INFO] [stderr] 152 | | self.create_schema_ref(None, v)?; [INFO] [stderr] ... | [INFO] [stderr] 156 | | _ => self.create_schema_ref(None, json).map(Some), [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 149 | match *json { [INFO] [stderr] 150 | serde_json::Value::Array(ref vs) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:182:22 [INFO] [stderr] | [INFO] [stderr] 182 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:219:14 [INFO] [stderr] | [INFO] [stderr] 219 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:223:22 [INFO] [stderr] | [INFO] [stderr] 223 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:237:22 [INFO] [stderr] | [INFO] [stderr] 237 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:264:22 [INFO] [stderr] | [INFO] [stderr] 264 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:271:14 [INFO] [stderr] | [INFO] [stderr] 271 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:275:14 [INFO] [stderr] | [INFO] [stderr] 275 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:292:14 [INFO] [stderr] | [INFO] [stderr] 292 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:304:14 [INFO] [stderr] | [INFO] [stderr] 304 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:323:22 [INFO] [stderr] | [INFO] [stderr] 323 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:330:14 [INFO] [stderr] | [INFO] [stderr] 330 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:364:14 [INFO] [stderr] | [INFO] [stderr] 364 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:371:22 [INFO] [stderr] | [INFO] [stderr] 371 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:376:14 [INFO] [stderr] | [INFO] [stderr] 376 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/schema.rs:499:10 [INFO] [stderr] | [INFO] [stderr] 499 | .unwrap_or(Ok(namespace))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ok(namespace))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:496:18 [INFO] [stderr] | [INFO] [stderr] 496 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/schema.rs:503:10 [INFO] [stderr] | [INFO] [stderr] 503 | .ok_or(Error::from(ErrorKind::InvalidSchema)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidSchema))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/schema.rs:701:17 [INFO] [stderr] | [INFO] [stderr] 701 | / match record.field_by_name("parent") [INFO] [stderr] 702 | | .unwrap() [INFO] [stderr] 703 | | .field_type() [INFO] [stderr] 704 | | .resolve(&schema_registry) { [INFO] [stderr] ... | [INFO] [stderr] 708 | | _ => unreachable!(), [INFO] [stderr] 709 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 701 | match *record.field_by_name("parent") [INFO] [stderr] 702 | .unwrap() [INFO] [stderr] 703 | .field_type() [INFO] [stderr] 704 | .resolve(&schema_registry) { [INFO] [stderr] 705 | Schema::Record(ref record) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/schema.rs:733:17 [INFO] [stderr] | [INFO] [stderr] 733 | / match record.field_by_name("parent") [INFO] [stderr] 734 | | .unwrap() [INFO] [stderr] 735 | | .field_type() [INFO] [stderr] 736 | | .resolve(&schema_registry) { [INFO] [stderr] ... | [INFO] [stderr] 740 | | _ => unreachable!(), [INFO] [stderr] 741 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 733 | match *record.field_by_name("parent") [INFO] [stderr] 734 | .unwrap() [INFO] [stderr] 735 | .field_type() [INFO] [stderr] 736 | .resolve(&schema_registry) { [INFO] [stderr] 737 | Schema::Record(ref record) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> tests/lib.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | / match e.kind() { [INFO] [stderr] 22 | | &serde_avro::error::ErrorKind::EndOfStream => { [INFO] [stderr] 23 | | break; [INFO] [stderr] 24 | | }, [INFO] [stderr] 25 | | _ => Err(e).unwrap(), [INFO] [stderr] 26 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *e.kind() { [INFO] [stderr] 22 | serde_avro::error::ErrorKind::EndOfStream => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.78s [INFO] running `"docker" "inspect" "f3e18af7c887469af233705232bc8f125387e133007a161223d3f38f3855ad39"` [INFO] running `"docker" "rm" "-f" "f3e18af7c887469af233705232bc8f125387e133007a161223d3f38f3855ad39"` [INFO] [stdout] f3e18af7c887469af233705232bc8f125387e133007a161223d3f38f3855ad39