[INFO] crate sequencefile 0.1.4 is already in cache
[INFO] extracting crate sequencefile 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/sequencefile/0.1.4
[INFO] extracting crate sequencefile 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sequencefile/0.1.4
[INFO] validating manifest of sequencefile-0.1.4 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of sequencefile-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing sequencefile-0.1.4
[INFO] finished frobbing sequencefile-0.1.4
[INFO] frobbed toml for sequencefile-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/sequencefile/0.1.4/Cargo.toml
[INFO] started frobbing sequencefile-0.1.4
[INFO] finished frobbing sequencefile-0.1.4
[INFO] frobbed toml for sequencefile-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sequencefile/0.1.4/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting sequencefile-0.1.4 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sequencefile/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 97a4b26691223153eb460a45b9458f9ded6ec09a1c57db244e06f36d43071d5d
[INFO] running `"docker" "start" "-a" "97a4b26691223153eb460a45b9458f9ded6ec09a1c57db244e06f36d43071d5d"`
[INFO] [stderr]     Checking bzip2 v0.2.4
[INFO] [stderr]     Checking sequencefile v0.1.4 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/reader.rs:42:13
[INFO] [stderr]    |
[INFO] [stderr] 42 |             header: header,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `header`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/reader.rs:111:9
[INFO] [stderr]     |
[INFO] [stderr] 111 |         version: version,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^ help: replace it with: `version`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/reader.rs:112:9
[INFO] [stderr]     |
[INFO] [stderr] 112 |         compression_type: compression_type,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compression_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/reader.rs:113:9
[INFO] [stderr]     |
[INFO] [stderr] 113 |         compression_codec: compression_codec,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compression_codec`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/reader.rs:114:9
[INFO] [stderr]     |
[INFO] [stderr] 114 |         key_class: key_class,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `key_class`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/reader.rs:115:9
[INFO] [stderr]     |
[INFO] [stderr] 115 |         value_class: value_class,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value_class`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/reader.rs:42:13
[INFO] [stderr]    |
[INFO] [stderr] 42 |             header: header,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `header`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/reader.rs:111:9
[INFO] [stderr]     |
[INFO] [stderr] 111 |         version: version,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^ help: replace it with: `version`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/reader.rs:112:9
[INFO] [stderr]     |
[INFO] [stderr] 112 |         compression_type: compression_type,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compression_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/reader.rs:113:9
[INFO] [stderr]     |
[INFO] [stderr] 113 |         compression_codec: compression_codec,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compression_codec`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/reader.rs:114:9
[INFO] [stderr]     |
[INFO] [stderr] 114 |         key_class: key_class,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `key_class`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/reader.rs:115:9
[INFO] [stderr]     |
[INFO] [stderr] 115 |         value_class: value_class,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value_class`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/compress.rs:8:27
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub const DEFAULT_CODEC: &'static str = "org.apache.hadoop.io.compress.DefaultCodec";
[INFO] [stderr]   |                          -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/compress.rs:9:24
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub const GZIP_CODEC: &'static str = "org.apache.hadoop.io.compress.GzipCodec";
[INFO] [stderr]   |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/compress.rs:10:25
[INFO] [stderr]    |
[INFO] [stderr] 10 | pub const BZIP2_CODEC: &'static str = "org.apache.hadoop.io.compress.BZip2Codec";
[INFO] [stderr]    |                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/reader.rs:15:15
[INFO] [stderr]    |
[INFO] [stderr] 15 | const MAGIC: &'static str = "SEQ";
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/compress.rs:8:27
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub const DEFAULT_CODEC: &'static str = "org.apache.hadoop.io.compress.DefaultCodec";
[INFO] [stderr]   |                          -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/compress.rs:9:24
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub const GZIP_CODEC: &'static str = "org.apache.hadoop.io.compress.GzipCodec";
[INFO] [stderr]   |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/compress.rs:10:25
[INFO] [stderr]    |
[INFO] [stderr] 10 | pub const BZIP2_CODEC: &'static str = "org.apache.hadoop.io.compress.BZip2Codec";
[INFO] [stderr]    |                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Read`
[INFO] [stderr]   --> src/util.rs:46:19
[INFO] [stderr]    |
[INFO] [stderr] 46 |     use std::io::{Read, Cursor};
[INFO] [stderr]    |                   ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/reader.rs:15:15
[INFO] [stderr]    |
[INFO] [stderr] 15 | const MAGIC: &'static str = "SEQ";
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::io::prelude`
[INFO] [stderr]  --> src/compress.rs:1:5
[INFO] [stderr]   |
[INFO] [stderr] 1 | use std::io::prelude::*;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `ByteOrder`
[INFO] [stderr]  --> src/reader.rs:3:28
[INFO] [stderr]   |
[INFO] [stderr] 3 | use byteorder::{BigEndian, ByteOrder, ReadBytesExt};
[INFO] [stderr]   |                            ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/compress.rs:36:21
[INFO] [stderr]    |
[INFO] [stderr] 36 | pub fn codec(codec: &String) -> Option<Codec> {
[INFO] [stderr]    |                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/compress.rs:45:28
[INFO] [stderr]    |
[INFO] [stderr] 45 | pub fn decompressor(codec: &Codec, buffer: &[u8]) -> Result<Vec<u8>> {
[INFO] [stderr]    |                            ^^^^^^ help: consider passing by value instead: `Codec`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/util.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 | /         let mut val = 0i64;
[INFO] [stderr] 21 | |         if len == 1 {
[INFO] [stderr] 22 | |             val = value as i64;
[INFO] [stderr] 23 | |         } else {
[INFO] [stderr] ...  |
[INFO] [stderr] 29 | |             }
[INFO] [stderr] 30 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let <mut> val = if len == 1 { value as i64 } else { ..; 0i64 };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/util.rs:22:19
[INFO] [stderr]    |
[INFO] [stderr] 22 |             val = value as i64;
[INFO] [stderr]    |                   ^^^^^^^^^^^^ help: try: `i64::from(value)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/util.rs:27:17
[INFO] [stderr]    |
[INFO] [stderr] 27 |                 val = val << 8;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^ help: replace it with: `val <<= 8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/util.rs:28:17
[INFO] [stderr]    |
[INFO] [stderr] 28 |                 val = val | (raw_buffer[0] as i64 & 0xFF)
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val |= (raw_buffer[0] as i64 & 0xFF)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/util.rs:28:30
[INFO] [stderr]    |
[INFO] [stderr] 28 |                 val = val | (raw_buffer[0] as i64 & 0xFF)
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(raw_buffer[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:59:19
[INFO] [stderr]    |
[INFO] [stderr] 59 |     let version = version[0] as u16;
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^ help: try: `u16::from(version[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead
[INFO] [stderr]    --> src/reader.rs:108:5
[INFO] [stderr]     |
[INFO] [stderr] 108 |     try!(reader.read(&mut sync_marker));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/reader.rs:145:8
[INFO] [stderr]     |
[INFO] [stderr] 145 |     if reader.block_buffer.len() == 0 || reader.header.compression_type != CompressionType::Block {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `reader.block_buffer.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/reader.rs:147:25
[INFO] [stderr]     |
[INFO] [stderr] 147 |         let kv_length = try!(reader.reader.read_i32::<BigEndian>()) as i64;
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 147 |         let kv_length = i64::from(match $ expr {
[INFO] [stderr] 148 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 149 | :: Err ( err ) => {
[INFO] [stderr] 150 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 151 | $ crate :: convert :: From :: from ( err ) ) } });
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/reader.rs:168:12
[INFO] [stderr]     |
[INFO] [stderr] 168 |         if reader.block_buffer.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `reader.block_buffer.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/reader.rs:175:46
[INFO] [stderr]     |
[INFO] [stderr] 175 |             let mut c = try!(key_lengths.map(|kl| io::Cursor::new(kl)));
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `io::Cursor::new`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/reader.rs:184:52
[INFO] [stderr]     |
[INFO] [stderr] 184 |             let mut c = try!(decompressed_keys.map(|kl| io::Cursor::new(kl)));
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `io::Cursor::new`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `lens`.
[INFO] [stderr]    --> src/reader.rs:186:22
[INFO] [stderr]     |
[INFO] [stderr] 186 |             for i in 0..kv_count {
[INFO] [stderr]     |                      ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 186 |             for <item> in lens.iter().take(kv_count) {
[INFO] [stderr]     |                 ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/reader.rs:195:59
[INFO] [stderr]     |
[INFO] [stderr] 195 |             let mut c = try!(decompressed_val_lengths.map(|kl| io::Cursor::new(kl)));
[INFO] [stderr]     |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `io::Cursor::new`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/reader.rs:205:52
[INFO] [stderr]     |
[INFO] [stderr] 205 |             let mut c = try!(decompressed_vals.map(|kl| io::Cursor::new(kl)));
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `io::Cursor::new`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `lens`.
[INFO] [stderr]    --> src/reader.rs:206:22
[INFO] [stderr]     |
[INFO] [stderr] 206 |             for i in 0..kv_count {
[INFO] [stderr]     |                      ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 206 |             for <item> in lens.iter().take(kv_count) {
[INFO] [stderr]     |                 ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `k_length`
[INFO] [stderr]    --> src/reader.rs:232:27
[INFO] [stderr]     |
[INFO] [stderr] 232 |     let k_end = k_start + (k_length - 0);
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead
[INFO] [stderr]    --> src/reader.rs:251:5
[INFO] [stderr]     |
[INFO] [stderr] 251 |     try!(reader.read(&mut buffer));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/reader.rs:276:59
[INFO] [stderr]     |
[INFO] [stderr] 276 |     str::from_utf8(&string).map(|v| v.to_owned()).map_err(|e| Error::BadEncoding(e))
[INFO] [stderr]     |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::BadEncoding`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `sequencefile`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: unused import: `std::io::prelude`
[INFO] [stderr]  --> src/compress.rs:1:5
[INFO] [stderr]   |
[INFO] [stderr] 1 | use std::io::prelude::*;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `ByteOrder`
[INFO] [stderr]  --> src/reader.rs:3:28
[INFO] [stderr]   |
[INFO] [stderr] 3 | use byteorder::{BigEndian, ByteOrder, ReadBytesExt};
[INFO] [stderr]   |                            ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/compress.rs:36:21
[INFO] [stderr]    |
[INFO] [stderr] 36 | pub fn codec(codec: &String) -> Option<Codec> {
[INFO] [stderr]    |                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/compress.rs:45:28
[INFO] [stderr]    |
[INFO] [stderr] 45 | pub fn decompressor(codec: &Codec, buffer: &[u8]) -> Result<Vec<u8>> {
[INFO] [stderr]    |                            ^^^^^^ help: consider passing by value instead: `Codec`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/util.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 | /         let mut val = 0i64;
[INFO] [stderr] 21 | |         if len == 1 {
[INFO] [stderr] 22 | |             val = value as i64;
[INFO] [stderr] 23 | |         } else {
[INFO] [stderr] ...  |
[INFO] [stderr] 29 | |             }
[INFO] [stderr] 30 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let <mut> val = if len == 1 { value as i64 } else { ..; 0i64 };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/util.rs:22:19
[INFO] [stderr]    |
[INFO] [stderr] 22 |             val = value as i64;
[INFO] [stderr]    |                   ^^^^^^^^^^^^ help: try: `i64::from(value)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/util.rs:27:17
[INFO] [stderr]    |
[INFO] [stderr] 27 |                 val = val << 8;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^ help: replace it with: `val <<= 8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/util.rs:28:17
[INFO] [stderr]    |
[INFO] [stderr] 28 |                 val = val | (raw_buffer[0] as i64 & 0xFF)
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `val |= (raw_buffer[0] as i64 & 0xFF)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/util.rs:28:30
[INFO] [stderr]    |
[INFO] [stderr] 28 |                 val = val | (raw_buffer[0] as i64 & 0xFF)
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(raw_buffer[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:59:19
[INFO] [stderr]    |
[INFO] [stderr] 59 |     let version = version[0] as u16;
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^ help: try: `u16::from(version[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead
[INFO] [stderr]    --> src/reader.rs:108:5
[INFO] [stderr]     |
[INFO] [stderr] 108 |     try!(reader.read(&mut sync_marker));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/reader.rs:145:8
[INFO] [stderr]     |
[INFO] [stderr] 145 |     if reader.block_buffer.len() == 0 || reader.header.compression_type != CompressionType::Block {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `reader.block_buffer.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/reader.rs:147:25
[INFO] [stderr]     |
[INFO] [stderr] 147 |         let kv_length = try!(reader.reader.read_i32::<BigEndian>()) as i64;
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 147 |         let kv_length = i64::from(match $ expr {
[INFO] [stderr] 148 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 149 | :: Err ( err ) => {
[INFO] [stderr] 150 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 151 | $ crate :: convert :: From :: from ( err ) ) } });
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/reader.rs:168:12
[INFO] [stderr]     |
[INFO] [stderr] 168 |         if reader.block_buffer.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `reader.block_buffer.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/reader.rs:175:46
[INFO] [stderr]     |
[INFO] [stderr] 175 |             let mut c = try!(key_lengths.map(|kl| io::Cursor::new(kl)));
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `io::Cursor::new`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/reader.rs:184:52
[INFO] [stderr]     |
[INFO] [stderr] 184 |             let mut c = try!(decompressed_keys.map(|kl| io::Cursor::new(kl)));
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `io::Cursor::new`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `lens`.
[INFO] [stderr]    --> src/reader.rs:186:22
[INFO] [stderr]     |
[INFO] [stderr] 186 |             for i in 0..kv_count {
[INFO] [stderr]     |                      ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 186 |             for <item> in lens.iter().take(kv_count) {
[INFO] [stderr]     |                 ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/reader.rs:195:59
[INFO] [stderr]     |
[INFO] [stderr] 195 |             let mut c = try!(decompressed_val_lengths.map(|kl| io::Cursor::new(kl)));
[INFO] [stderr]     |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `io::Cursor::new`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/reader.rs:205:52
[INFO] [stderr]     |
[INFO] [stderr] 205 |             let mut c = try!(decompressed_vals.map(|kl| io::Cursor::new(kl)));
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `io::Cursor::new`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `lens`.
[INFO] [stderr]    --> src/reader.rs:206:22
[INFO] [stderr]     |
[INFO] [stderr] 206 |             for i in 0..kv_count {
[INFO] [stderr]     |                      ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 206 |             for <item> in lens.iter().take(kv_count) {
[INFO] [stderr]     |                 ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `k_length`
[INFO] [stderr]    --> src/reader.rs:232:27
[INFO] [stderr]     |
[INFO] [stderr] 232 |     let k_end = k_start + (k_length - 0);
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead
[INFO] [stderr]    --> src/reader.rs:251:5
[INFO] [stderr]     |
[INFO] [stderr] 251 |     try!(reader.read(&mut buffer));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/reader.rs:276:59
[INFO] [stderr]     |
[INFO] [stderr] 276 |     str::from_utf8(&string).map(|v| v.to_owned()).map_err(|e| Error::BadEncoding(e))
[INFO] [stderr]     |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::BadEncoding`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/reader.rs:334:25
[INFO] [stderr]     |
[INFO] [stderr] 334 |         assert_eq!("b", sf.header.metadata.get("a").unwrap());
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&sf.header.metadata["a"]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/reader.rs:335:25
[INFO] [stderr]     |
[INFO] [stderr] 335 |         assert_eq!("z", sf.header.metadata.get("y").unwrap());
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&sf.header.metadata["y"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `sequencefile`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "97a4b26691223153eb460a45b9458f9ded6ec09a1c57db244e06f36d43071d5d"`
[INFO] running `"docker" "rm" "-f" "97a4b26691223153eb460a45b9458f9ded6ec09a1c57db244e06f36d43071d5d"`
[INFO] [stdout] 97a4b26691223153eb460a45b9458f9ded6ec09a1c57db244e06f36d43071d5d