[INFO] crate sentry-rs 2.2.0 is already in cache [INFO] extracting crate sentry-rs 2.2.0 into work/ex/clippy-test-run/sources/stable/reg/sentry-rs/2.2.0 [INFO] extracting crate sentry-rs 2.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sentry-rs/2.2.0 [INFO] validating manifest of sentry-rs-2.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sentry-rs-2.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sentry-rs-2.2.0 [INFO] finished frobbing sentry-rs-2.2.0 [INFO] frobbed toml for sentry-rs-2.2.0 written to work/ex/clippy-test-run/sources/stable/reg/sentry-rs/2.2.0/Cargo.toml [INFO] started frobbing sentry-rs-2.2.0 [INFO] finished frobbing sentry-rs-2.2.0 [INFO] frobbed toml for sentry-rs-2.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sentry-rs/2.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sentry-rs-2.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sentry-rs/2.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8e53670e336cfd39e7bf9a0d2fcbab77c956ba11ecf3eba79e4d29257cf79ef6 [INFO] running `"docker" "start" "-a" "8e53670e336cfd39e7bf9a0d2fcbab77c956ba11ecf3eba79e4d29257cf79ef6"` [INFO] [stderr] Checking yyid v0.2.4 [INFO] [stderr] Checking sentry-rs v2.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models.rs:229:7 [INFO] [stderr] | [INFO] [stderr] 229 | stacktrace: stacktrace, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stacktrace` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reactor.rs:68:18 [INFO] [stderr] | [INFO] [stderr] 68 | Ok(Reactor { remote: remote }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `remote` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reactor.rs:91:41 [INFO] [stderr] | [INFO] [stderr] 91 | .map(|sender| RequestDispatcher { sender: sender }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:194:7 [INFO] [stderr] | [INFO] [stderr] 194 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:211:7 [INFO] [stderr] | [INFO] [stderr] 211 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/workers/single.rs:29:7 [INFO] [stderr] | [INFO] [stderr] 29 | parameters: parameters, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parameters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:89:7 [INFO] [stderr] | [INFO] [stderr] 89 | server_name: server_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `server_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:90:7 [INFO] [stderr] | [INFO] [stderr] 90 | release: release, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `release` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:91:7 [INFO] [stderr] | [INFO] [stderr] 91 | environment: environment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `environment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:233:13 [INFO] [stderr] | [INFO] [stderr] 233 | lineno: lineno, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `lineno` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:234:13 [INFO] [stderr] | [INFO] [stderr] 234 | pre_context: pre_context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pre_context` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:235:13 [INFO] [stderr] | [INFO] [stderr] 235 | post_context: post_context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `post_context` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | context_line: context_line, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `context_line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | in_app: in_app, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `in_app` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models.rs:229:7 [INFO] [stderr] | [INFO] [stderr] 229 | stacktrace: stacktrace, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stacktrace` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reactor.rs:68:18 [INFO] [stderr] | [INFO] [stderr] 68 | Ok(Reactor { remote: remote }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `remote` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reactor.rs:91:41 [INFO] [stderr] | [INFO] [stderr] 91 | .map(|sender| RequestDispatcher { sender: sender }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:194:7 [INFO] [stderr] | [INFO] [stderr] 194 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:211:7 [INFO] [stderr] | [INFO] [stderr] 211 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/workers/single.rs:29:7 [INFO] [stderr] | [INFO] [stderr] 29 | parameters: parameters, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parameters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:89:7 [INFO] [stderr] | [INFO] [stderr] 89 | server_name: server_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `server_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:90:7 [INFO] [stderr] | [INFO] [stderr] 90 | release: release, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `release` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:91:7 [INFO] [stderr] | [INFO] [stderr] 91 | environment: environment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `environment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:233:13 [INFO] [stderr] | [INFO] [stderr] 233 | lineno: lineno, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `lineno` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:234:13 [INFO] [stderr] | [INFO] [stderr] 234 | pre_context: pre_context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pre_context` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:235:13 [INFO] [stderr] | [INFO] [stderr] 235 | post_context: post_context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `post_context` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | context_line: context_line, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `context_line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | in_app: in_app, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `in_app` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/models.rs:107:3 [INFO] [stderr] | [INFO] [stderr] 107 | / if to_prep != "" { [INFO] [stderr] 108 | | if to_prep.starts_with("\"") { [INFO] [stderr] 109 | | let tlen = to_return.len(); [INFO] [stderr] 110 | | to_return.remove(0); [INFO] [stderr] 111 | | to_return.truncate(tlen - 2); [INFO] [stderr] 112 | | } [INFO] [stderr] 113 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 107 | if to_prep != "" && to_prep.starts_with("\"") { [INFO] [stderr] 108 | let tlen = to_return.len(); [INFO] [stderr] 109 | to_return.remove(0); [INFO] [stderr] 110 | to_return.truncate(tlen - 2); [INFO] [stderr] 111 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:274:18 [INFO] [stderr] | [INFO] [stderr] 274 | } else { [INFO] [stderr] | __________________^ [INFO] [stderr] 275 | | if recived_id.unwrap() == event_id { [INFO] [stderr] 276 | | break; [INFO] [stderr] 277 | | } [INFO] [stderr] 278 | | } [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 274 | } else if recived_id.unwrap() == event_id { [INFO] [stderr] 275 | break; [INFO] [stderr] 276 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/models.rs:107:3 [INFO] [stderr] | [INFO] [stderr] 107 | / if to_prep != "" { [INFO] [stderr] 108 | | if to_prep.starts_with("\"") { [INFO] [stderr] 109 | | let tlen = to_return.len(); [INFO] [stderr] 110 | | to_return.remove(0); [INFO] [stderr] 111 | | to_return.truncate(tlen - 2); [INFO] [stderr] 112 | | } [INFO] [stderr] 113 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 107 | if to_prep != "" && to_prep.starts_with("\"") { [INFO] [stderr] 108 | let tlen = to_return.len(); [INFO] [stderr] 109 | to_return.remove(0); [INFO] [stderr] 110 | to_return.truncate(tlen - 2); [INFO] [stderr] 111 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:274:18 [INFO] [stderr] | [INFO] [stderr] 274 | } else { [INFO] [stderr] | __________________^ [INFO] [stderr] 275 | | if recived_id.unwrap() == event_id { [INFO] [stderr] 276 | | break; [INFO] [stderr] 277 | | } [INFO] [stderr] 278 | | } [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 274 | } else if recived_id.unwrap() == event_id { [INFO] [stderr] 275 | break; [INFO] [stderr] 276 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/models.rs:108:28 [INFO] [stderr] | [INFO] [stderr] 108 | if to_prep.starts_with("\"") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\"'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/models.rs:199:3 [INFO] [stderr] | [INFO] [stderr] 199 | / pub fn new( [INFO] [stderr] 200 | | logger: &str, [INFO] [stderr] 201 | | level: &str, [INFO] [stderr] 202 | | message: &str, [INFO] [stderr] ... | [INFO] [stderr] 236 | | } [INFO] [stderr] 237 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/models.rs:235:32 [INFO] [stderr] | [INFO] [stderr] 235 | fingerprint: fingerprint.unwrap_or(vec![]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/reactor.rs:49:18 [INFO] [stderr] | [INFO] [stderr] 49 | if let Err(_) = init_tx.send(Ok(core.remote())) { [INFO] [stderr] | ___________- ^^^^^^ [INFO] [stderr] 50 | | panic!("failed to send init back to caller"); [INFO] [stderr] 51 | | } [INFO] [stderr] | |___________- help: try this: `if init_tx.send(Ok(core.remote())).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/reactor.rs:55:18 [INFO] [stderr] | [INFO] [stderr] 55 | if let Err(_) = init_tx.send(Err(err)) { [INFO] [stderr] | ___________- ^^^^^^ [INFO] [stderr] 56 | | panic!("failed to send init back to caller"); [INFO] [stderr] 57 | | } [INFO] [stderr] | |___________- help: try this: `if init_tx.send(Err(err)).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/reactor.rs:107:8 [INFO] [stderr] | [INFO] [stderr] 107 | ) -> Result>)>, E> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/reactor.rs:124:18 [INFO] [stderr] | [INFO] [stderr] 124 | if let Err(_) = init_tx.send(Ok(tx)) { [INFO] [stderr] | ___________- ^^^^^^ [INFO] [stderr] 125 | | panic!("failed to send back reactor"); [INFO] [stderr] 126 | | } [INFO] [stderr] | |___________- help: try this: `if init_tx.send(Ok(tx)).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/reactor.rs:130:18 [INFO] [stderr] | [INFO] [stderr] 130 | if let Err(_) = init_tx.send(Err(err)) { [INFO] [stderr] | ___________- ^^^^^^ [INFO] [stderr] 131 | | panic!("failed to send back reactor"); [INFO] [stderr] 132 | | } [INFO] [stderr] | |___________- help: try this: `if init_tx.send(Err(err)).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/reactor.rs:156:11 [INFO] [stderr] | [INFO] [stderr] 156 | sender: mpsc::UnboundedSender< [INFO] [stderr] | ___________^ [INFO] [stderr] 157 | | ( [INFO] [stderr] 158 | | (HyperRequest, Option), [INFO] [stderr] 159 | | oneshot::Sender>, [INFO] [stderr] 160 | | ), [INFO] [stderr] 161 | | >, [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/request.rs:229:44 [INFO] [stderr] | [INFO] [stderr] 229 | let inner = match Timeout::new(timeout.unwrap_or(Duration::new(5, 0)), &self.handle) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Duration::new(5, 0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/request.rs:245:44 [INFO] [stderr] | [INFO] [stderr] 245 | let inner = match Timeout::new(timeout.unwrap_or(Duration::new(5, 0)), &self.handle) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Duration::new(5, 0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:114:32 [INFO] [stderr] | [INFO] [stderr] 114 | credentials.host.clone().unwrap_or("sentry.io".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "sentry.io".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:175:10 [INFO] [stderr] | [INFO] [stderr] 175 | .unwrap_or("Unknown".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "Unknown".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:338:40 [INFO] [stderr] | [INFO] [stderr] 338 | culprit.map(|c| c.to_string()).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/models_test.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/models_test.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | modules: modules, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `modules` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/models.rs:108:28 [INFO] [stderr] | [INFO] [stderr] 108 | if to_prep.starts_with("\"") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\"'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/models.rs:199:3 [INFO] [stderr] | [INFO] [stderr] 199 | / pub fn new( [INFO] [stderr] 200 | | logger: &str, [INFO] [stderr] 201 | | level: &str, [INFO] [stderr] 202 | | message: &str, [INFO] [stderr] ... | [INFO] [stderr] 236 | | } [INFO] [stderr] 237 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/models.rs:235:32 [INFO] [stderr] | [INFO] [stderr] 235 | fingerprint: fingerprint.unwrap_or(vec![]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/reactor.rs:49:18 [INFO] [stderr] | [INFO] [stderr] 49 | if let Err(_) = init_tx.send(Ok(core.remote())) { [INFO] [stderr] | ___________- ^^^^^^ [INFO] [stderr] 50 | | panic!("failed to send init back to caller"); [INFO] [stderr] 51 | | } [INFO] [stderr] | |___________- help: try this: `if init_tx.send(Ok(core.remote())).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/reactor.rs:55:18 [INFO] [stderr] | [INFO] [stderr] 55 | if let Err(_) = init_tx.send(Err(err)) { [INFO] [stderr] | ___________- ^^^^^^ [INFO] [stderr] 56 | | panic!("failed to send init back to caller"); [INFO] [stderr] 57 | | } [INFO] [stderr] | |___________- help: try this: `if init_tx.send(Err(err)).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/reactor.rs:107:8 [INFO] [stderr] | [INFO] [stderr] 107 | ) -> Result>)>, E> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/reactor.rs:124:18 [INFO] [stderr] | [INFO] [stderr] 124 | if let Err(_) = init_tx.send(Ok(tx)) { [INFO] [stderr] | ___________- ^^^^^^ [INFO] [stderr] 125 | | panic!("failed to send back reactor"); [INFO] [stderr] 126 | | } [INFO] [stderr] | |___________- help: try this: `if init_tx.send(Ok(tx)).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/reactor.rs:130:18 [INFO] [stderr] | [INFO] [stderr] 130 | if let Err(_) = init_tx.send(Err(err)) { [INFO] [stderr] | ___________- ^^^^^^ [INFO] [stderr] 131 | | panic!("failed to send back reactor"); [INFO] [stderr] 132 | | } [INFO] [stderr] | |___________- help: try this: `if init_tx.send(Err(err)).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/reactor.rs:156:11 [INFO] [stderr] | [INFO] [stderr] 156 | sender: mpsc::UnboundedSender< [INFO] [stderr] | ___________^ [INFO] [stderr] 157 | | ( [INFO] [stderr] 158 | | (HyperRequest, Option), [INFO] [stderr] 159 | | oneshot::Sender>, [INFO] [stderr] 160 | | ), [INFO] [stderr] 161 | | >, [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/request.rs:229:44 [INFO] [stderr] | [INFO] [stderr] 229 | let inner = match Timeout::new(timeout.unwrap_or(Duration::new(5, 0)), &self.handle) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Duration::new(5, 0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/request.rs:245:44 [INFO] [stderr] | [INFO] [stderr] 245 | let inner = match Timeout::new(timeout.unwrap_or(Duration::new(5, 0)), &self.handle) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Duration::new(5, 0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:114:32 [INFO] [stderr] | [INFO] [stderr] 114 | credentials.host.clone().unwrap_or("sentry.io".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "sentry.io".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:175:10 [INFO] [stderr] | [INFO] [stderr] 175 | .unwrap_or("Unknown".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "Unknown".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:338:40 [INFO] [stderr] | [INFO] [stderr] 338 | culprit.map(|c| c.to_string()).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> examples/panic-handler-demo.rs:11:39 [INFO] [stderr] | [INFO] [stderr] 11 | scheme: env::var("SENTRY_SCHEME").unwrap_or("https".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "https".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> examples/panic-handler-demo.rs:12:33 [INFO] [stderr] | [INFO] [stderr] 12 | key: env::var("SENTRY_KEY").unwrap_or("XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> examples/panic-handler-demo.rs:13:39 [INFO] [stderr] | [INFO] [stderr] 13 | secret: env::var("SENTRY_SECRET").unwrap_or("YYYYYYYYYYYYYYYYYYYYYYYYYYYYYYY".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "YYYYYYYYYYYYYYYYYYYYYYYYYYYYYYY".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> examples/panic-handler-demo.rs:14:40 [INFO] [stderr] | [INFO] [stderr] 14 | host: Some(env::var("SENTRY_HOST").unwrap_or("app.getsentry.com".to_owned())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "app.getsentry.com".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> examples/panic-handler-demo.rs:15:47 [INFO] [stderr] | [INFO] [stderr] 15 | project_id: env::var("SENTRY_PROJECT_ID").unwrap_or("XX".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "XX".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> examples/cross-threads.rs:13:39 [INFO] [stderr] | [INFO] [stderr] 13 | scheme: env::var("SENTRY_SCHEME").unwrap_or("https".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "https".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> examples/cross-threads.rs:14:33 [INFO] [stderr] | [INFO] [stderr] 14 | key: env::var("SENTRY_KEY").unwrap_or("XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> examples/cross-threads.rs:15:39 [INFO] [stderr] | [INFO] [stderr] 15 | secret: env::var("SENTRY_SECRET").unwrap_or("YYYYYYYYYYYYYYYYYYYYYYYYYYYYYYY".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "YYYYYYYYYYYYYYYYYYYYYYYYYYYYYYY".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> examples/cross-threads.rs:16:40 [INFO] [stderr] | [INFO] [stderr] 16 | host: Some(env::var("SENTRY_HOST").unwrap_or("app.getsentry.com".to_owned())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "app.getsentry.com".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> examples/cross-threads.rs:17:47 [INFO] [stderr] | [INFO] [stderr] 17 | project_id: env::var("SENTRY_PROJECT_ID").unwrap_or("XX".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "XX".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> examples/logger-demo.rs:11:39 [INFO] [stderr] | [INFO] [stderr] 11 | scheme: env::var("SENTRY_SCHEME").unwrap_or("https".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "https".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> examples/logger-demo.rs:12:33 [INFO] [stderr] | [INFO] [stderr] 12 | key: env::var("SENTRY_KEY").unwrap_or("XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> examples/logger-demo.rs:13:39 [INFO] [stderr] | [INFO] [stderr] 13 | secret: env::var("SENTRY_SECRET").unwrap_or("YYYYYYYYYYYYYYYYYYYYYYYYYYYYYYY".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "YYYYYYYYYYYYYYYYYYYYYYYYYYYYYYY".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> examples/logger-demo.rs:14:40 [INFO] [stderr] | [INFO] [stderr] 14 | host: Some(env::var("SENTRY_HOST").unwrap_or("app.getsentry.com".to_owned())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "app.getsentry.com".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> examples/logger-demo.rs:15:47 [INFO] [stderr] | [INFO] [stderr] 15 | project_id: env::var("SENTRY_PROJECT_ID").unwrap_or("XX".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "XX".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 34.35s [INFO] running `"docker" "inspect" "8e53670e336cfd39e7bf9a0d2fcbab77c956ba11ecf3eba79e4d29257cf79ef6"` [INFO] running `"docker" "rm" "-f" "8e53670e336cfd39e7bf9a0d2fcbab77c956ba11ecf3eba79e4d29257cf79ef6"` [INFO] [stdout] 8e53670e336cfd39e7bf9a0d2fcbab77c956ba11ecf3eba79e4d29257cf79ef6