[INFO] crate sensorlog 0.1.0 is already in cache [INFO] extracting crate sensorlog 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/sensorlog/0.1.0 [INFO] extracting crate sensorlog 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sensorlog/0.1.0 [INFO] validating manifest of sensorlog-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sensorlog-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sensorlog-0.1.0 [INFO] finished frobbing sensorlog-0.1.0 [INFO] frobbed toml for sensorlog-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/sensorlog/0.1.0/Cargo.toml [INFO] started frobbing sensorlog-0.1.0 [INFO] finished frobbing sensorlog-0.1.0 [INFO] frobbed toml for sensorlog-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sensorlog/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sensorlog-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sensorlog/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 17e465782a5044b62a4094c9797a29a906c5136433c85c7230557bbe0cadddc9 [INFO] running `"docker" "start" "-a" "17e465782a5044b62a4094c9797a29a906c5136433c85c7230557bbe0cadddc9"` [INFO] [stderr] Checking cookie v0.2.5 [INFO] [stderr] Checking hyper v0.9.18 [INFO] [stderr] Checking iron v0.4.0 [INFO] [stderr] Checking sensorlog v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:47:4 [INFO] [stderr] | [INFO] [stderr] 47 | code: code [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:47:4 [INFO] [stderr] | [INFO] [stderr] 47 | code: code [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/error.rs:45:3 [INFO] [stderr] | [INFO] [stderr] 45 | return Error { [INFO] [stderr] | _________^ [INFO] [stderr] 46 | | message: message.to_owned(), [INFO] [stderr] 47 | | code: code [INFO] [stderr] 48 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 45 | Error { [INFO] [stderr] 46 | message: message.to_owned(), [INFO] [stderr] 47 | code: code [INFO] [stderr] 48 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/http.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs` [INFO] [stderr] --> src/http.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use std::fs; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `PathBuf`, `Path` [INFO] [stderr] --> src/http.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | use std::path::{Path,PathBuf}; [INFO] [stderr] | ^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Arc`, `Mutex` [INFO] [stderr] --> src/http.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | use std::sync::{Arc,Mutex}; [INFO] [stderr] | ^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:45:2 [INFO] [stderr] | [INFO] [stderr] 45 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:69:3 [INFO] [stderr] | [INFO] [stderr] 69 | return Ok(Response::with(iron::status::NotFound)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Response::with(iron::status::NotFound))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:117:3 [INFO] [stderr] | [INFO] [stderr] 117 | return Ok(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Deserialize`, `Serialize` [INFO] [stderr] --> src/api.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | use serde::{Serialize, Deserialize}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api.rs:38:2 [INFO] [stderr] | [INFO] [stderr] 38 | return Ok(StoreMeasurementResponse{ [INFO] [stderr] | _____^ [INFO] [stderr] 39 | | success: true [INFO] [stderr] 40 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 38 | Ok(StoreMeasurementResponse{ [INFO] [stderr] 39 | success: true [INFO] [stderr] 40 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `Deserialize` [INFO] [stderr] --> src/api_json.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | use serde::{Serialize, Deserialize}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api_json.rs:37:2 [INFO] [stderr] | [INFO] [stderr] 37 | return Ok(res_json); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res_json)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api_json.rs:43:2 [INFO] [stderr] | [INFO] [stderr] 43 | return match method { [INFO] [stderr] | _____^ [INFO] [stderr] 44 | | "store_measurement" => call(&::api::store_measurement, req), [INFO] [stderr] 45 | | _ => Err(err_user!("invalid API method")) [INFO] [stderr] 46 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 43 | match method { [INFO] [stderr] 44 | "store_measurement" => call(&::api::store_measurement, req), [INFO] [stderr] 45 | _ => Err(err_user!("invalid API method")) [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api_json.rs:57:2 [INFO] [stderr] | [INFO] [stderr] 57 | return match method(req) { [INFO] [stderr] | _____^ [INFO] [stderr] 58 | | Ok(r) => Ok(json::to_value(r).unwrap()), [INFO] [stderr] 59 | | Err(e) => Err(e) [INFO] [stderr] 60 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 57 | match method(req) { [INFO] [stderr] 58 | Ok(r) => Ok(json::to_value(r).unwrap()), [INFO] [stderr] 59 | Err(e) => Err(e) [INFO] [stderr] 60 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/server.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/server.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | const VERSION : &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/server.rs:40:27 [INFO] [stderr] | [INFO] [stderr] 40 | const LOGLEVEL_DEFAULT : &'static str = "info"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/server.rs:42:16 [INFO] [stderr] | [INFO] [stderr] 42 | const USAGE : &'static str = "\ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused variable: `datadir` [INFO] [stderr] --> src/server.rs:101:6 [INFO] [stderr] | [INFO] [stderr] 101 | let datadir = match flags.opt_str("datadir") { [INFO] [stderr] | ^^^^^^^ help: consider using `_datadir` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/error.rs:63:10 [INFO] [stderr] | [INFO] [stderr] 63 | fn from(e: ()) -> Error { [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `NotFound` [INFO] [stderr] --> src/error.rs:24:43 [INFO] [stderr] | [INFO] [stderr] 24 | pub enum ErrorCode { InternalServerError, NotFound, BadRequest } [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/server.rs:84:3 [INFO] [stderr] | [INFO] [stderr] 84 | std::io::stdout().write(USAGE.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/server.rs:93:32 [INFO] [stderr] | [INFO] [stderr] 93 | flags.opt_str("loglevel").unwrap_or(LOGLEVEL_DEFAULT.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| LOGLEVEL_DEFAULT.into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/server.rs:94:32 [INFO] [stderr] | [INFO] [stderr] 94 | std::env::var("RUST_LOG").unwrap_or("".into()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `sensorlog`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/error.rs:45:3 [INFO] [stderr] | [INFO] [stderr] 45 | return Error { [INFO] [stderr] | _________^ [INFO] [stderr] 46 | | message: message.to_owned(), [INFO] [stderr] 47 | | code: code [INFO] [stderr] 48 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 45 | Error { [INFO] [stderr] 46 | message: message.to_owned(), [INFO] [stderr] 47 | code: code [INFO] [stderr] 48 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/http.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs` [INFO] [stderr] --> src/http.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use std::fs; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `PathBuf`, `Path` [INFO] [stderr] --> src/http.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | use std::path::{Path,PathBuf}; [INFO] [stderr] | ^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Arc`, `Mutex` [INFO] [stderr] --> src/http.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | use std::sync::{Arc,Mutex}; [INFO] [stderr] | ^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:45:2 [INFO] [stderr] | [INFO] [stderr] 45 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:69:3 [INFO] [stderr] | [INFO] [stderr] 69 | return Ok(Response::with(iron::status::NotFound)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Response::with(iron::status::NotFound))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:117:3 [INFO] [stderr] | [INFO] [stderr] 117 | return Ok(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Deserialize`, `Serialize` [INFO] [stderr] --> src/api.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | use serde::{Serialize, Deserialize}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api.rs:38:2 [INFO] [stderr] | [INFO] [stderr] 38 | return Ok(StoreMeasurementResponse{ [INFO] [stderr] | _____^ [INFO] [stderr] 39 | | success: true [INFO] [stderr] 40 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 38 | Ok(StoreMeasurementResponse{ [INFO] [stderr] 39 | success: true [INFO] [stderr] 40 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `Deserialize` [INFO] [stderr] --> src/api_json.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | use serde::{Serialize, Deserialize}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api_json.rs:37:2 [INFO] [stderr] | [INFO] [stderr] 37 | return Ok(res_json); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res_json)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api_json.rs:43:2 [INFO] [stderr] | [INFO] [stderr] 43 | return match method { [INFO] [stderr] | _____^ [INFO] [stderr] 44 | | "store_measurement" => call(&::api::store_measurement, req), [INFO] [stderr] 45 | | _ => Err(err_user!("invalid API method")) [INFO] [stderr] 46 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 43 | match method { [INFO] [stderr] 44 | "store_measurement" => call(&::api::store_measurement, req), [INFO] [stderr] 45 | _ => Err(err_user!("invalid API method")) [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api_json.rs:57:2 [INFO] [stderr] | [INFO] [stderr] 57 | return match method(req) { [INFO] [stderr] | _____^ [INFO] [stderr] 58 | | Ok(r) => Ok(json::to_value(r).unwrap()), [INFO] [stderr] 59 | | Err(e) => Err(e) [INFO] [stderr] 60 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 57 | match method(req) { [INFO] [stderr] 58 | Ok(r) => Ok(json::to_value(r).unwrap()), [INFO] [stderr] 59 | Err(e) => Err(e) [INFO] [stderr] 60 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/server.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/server.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | const VERSION : &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/server.rs:40:27 [INFO] [stderr] | [INFO] [stderr] 40 | const LOGLEVEL_DEFAULT : &'static str = "info"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/server.rs:42:16 [INFO] [stderr] | [INFO] [stderr] 42 | const USAGE : &'static str = "\ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused variable: `datadir` [INFO] [stderr] --> src/server.rs:101:6 [INFO] [stderr] | [INFO] [stderr] 101 | let datadir = match flags.opt_str("datadir") { [INFO] [stderr] | ^^^^^^^ help: consider using `_datadir` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/error.rs:63:10 [INFO] [stderr] | [INFO] [stderr] 63 | fn from(e: ()) -> Error { [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `NotFound` [INFO] [stderr] --> src/error.rs:24:43 [INFO] [stderr] | [INFO] [stderr] 24 | pub enum ErrorCode { InternalServerError, NotFound, BadRequest } [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/server.rs:84:3 [INFO] [stderr] | [INFO] [stderr] 84 | std::io::stdout().write(USAGE.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/server.rs:93:32 [INFO] [stderr] | [INFO] [stderr] 93 | flags.opt_str("loglevel").unwrap_or(LOGLEVEL_DEFAULT.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| LOGLEVEL_DEFAULT.into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/server.rs:94:32 [INFO] [stderr] | [INFO] [stderr] 94 | std::env::var("RUST_LOG").unwrap_or("".into()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `sensorlog`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "17e465782a5044b62a4094c9797a29a906c5136433c85c7230557bbe0cadddc9"` [INFO] running `"docker" "rm" "-f" "17e465782a5044b62a4094c9797a29a906c5136433c85c7230557bbe0cadddc9"` [INFO] [stdout] 17e465782a5044b62a4094c9797a29a906c5136433c85c7230557bbe0cadddc9