[INFO] crate sendgrid 0.7.2 is already in cache [INFO] extracting crate sendgrid 0.7.2 into work/ex/clippy-test-run/sources/stable/reg/sendgrid/0.7.2 [INFO] extracting crate sendgrid 0.7.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sendgrid/0.7.2 [INFO] validating manifest of sendgrid-0.7.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sendgrid-0.7.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sendgrid-0.7.2 [INFO] finished frobbing sendgrid-0.7.2 [INFO] frobbed toml for sendgrid-0.7.2 written to work/ex/clippy-test-run/sources/stable/reg/sendgrid/0.7.2/Cargo.toml [INFO] started frobbing sendgrid-0.7.2 [INFO] finished frobbing sendgrid-0.7.2 [INFO] frobbed toml for sendgrid-0.7.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sendgrid/0.7.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sendgrid-0.7.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sendgrid/0.7.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a34542d4eb08aa1853cec0e8bde3e9fb4e9b58533dcecbdc4b1a07836609e902 [INFO] running `"docker" "start" "-a" "a34542d4eb08aa1853cec0e8bde3e9fb4e9b58533dcecbdc4b1a07836609e902"` [INFO] [stderr] Checking sendgrid v0.7.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v3.rs:104:20 [INFO] [stderr] | [INFO] [stderr] 104 | V3Sender { api_key: api_key } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `api_key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v3.rs:104:20 [INFO] [stderr] | [INFO] [stderr] 104 | V3Sender { api_key: api_key } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `api_key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/v3.rs:14:20 [INFO] [stderr] | [INFO] [stderr] 14 | const V3_API_URL: &'static str = "https://api.sendgrid.com/v3/mail/send"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/v3.rs:14:20 [INFO] [stderr] | [INFO] [stderr] 14 | const V3_API_URL: &'static str = "https://api.sendgrid.com/v3/mail/send"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `mail::Mail` [INFO] [stderr] --> src/mail.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> Mail { [INFO] [stderr] 35 | | Mail { [INFO] [stderr] 36 | | to: Vec::new(), [INFO] [stderr] 37 | | to_names: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `mail::Mail` [INFO] [stderr] --> src/mail.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> Mail { [INFO] [stderr] 35 | | Mail { [INFO] [stderr] 36 | | to: Vec::new(), [INFO] [stderr] 37 | | to_names: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `v3::SGMailV3` [INFO] [stderr] --> src/v3.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | / pub fn new() -> SGMailV3 { [INFO] [stderr] 130 | | SGMailV3 { [INFO] [stderr] 131 | | from: Email::new(), [INFO] [stderr] 132 | | subject: String::new(), [INFO] [stderr] ... | [INFO] [stderr] 136 | | } [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 127 | impl Default for v3::SGMailV3 { [INFO] [stderr] 128 | fn default() -> Self { [INFO] [stderr] 129 | Self::new() [INFO] [stderr] 130 | } [INFO] [stderr] 131 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `v3::Email` [INFO] [stderr] --> src/v3.rs:178:5 [INFO] [stderr] | [INFO] [stderr] 178 | / pub fn new() -> Email { [INFO] [stderr] 179 | | Email { [INFO] [stderr] 180 | | email: String::new(), [INFO] [stderr] 181 | | name: None, [INFO] [stderr] 182 | | } [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 39 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `v3::Content` [INFO] [stderr] --> src/v3.rs:198:5 [INFO] [stderr] | [INFO] [stderr] 198 | / pub fn new() -> Content { [INFO] [stderr] 199 | | Content { [INFO] [stderr] 200 | | content_type: String::new(), [INFO] [stderr] 201 | | value: String::new(), [INFO] [stderr] 202 | | } [INFO] [stderr] 203 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `v3::Personalization` [INFO] [stderr] --> src/v3.rs:218:5 [INFO] [stderr] | [INFO] [stderr] 218 | / pub fn new() -> Personalization { [INFO] [stderr] 219 | | Personalization { [INFO] [stderr] 220 | | to: Vec::new(), [INFO] [stderr] 221 | | cc: None, [INFO] [stderr] ... | [INFO] [stderr] 228 | | } [INFO] [stderr] 229 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 57 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `v3::Attachment` [INFO] [stderr] --> src/v3.rs:283:5 [INFO] [stderr] | [INFO] [stderr] 283 | / pub fn new() -> Attachment { [INFO] [stderr] 284 | | Attachment { [INFO] [stderr] 285 | | content: String::new(), [INFO] [stderr] 286 | | filename: String::new(), [INFO] [stderr] ... | [INFO] [stderr] 290 | | } [INFO] [stderr] 291 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 86 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `v3::SGMailV3` [INFO] [stderr] --> src/v3.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | / pub fn new() -> SGMailV3 { [INFO] [stderr] 130 | | SGMailV3 { [INFO] [stderr] 131 | | from: Email::new(), [INFO] [stderr] 132 | | subject: String::new(), [INFO] [stderr] ... | [INFO] [stderr] 136 | | } [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 127 | impl Default for v3::SGMailV3 { [INFO] [stderr] 128 | fn default() -> Self { [INFO] [stderr] 129 | Self::new() [INFO] [stderr] 130 | } [INFO] [stderr] 131 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `v3::Email` [INFO] [stderr] --> src/v3.rs:178:5 [INFO] [stderr] | [INFO] [stderr] 178 | / pub fn new() -> Email { [INFO] [stderr] 179 | | Email { [INFO] [stderr] 180 | | email: String::new(), [INFO] [stderr] 181 | | name: None, [INFO] [stderr] 182 | | } [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 39 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `v3::Content` [INFO] [stderr] --> src/v3.rs:198:5 [INFO] [stderr] | [INFO] [stderr] 198 | / pub fn new() -> Content { [INFO] [stderr] 199 | | Content { [INFO] [stderr] 200 | | content_type: String::new(), [INFO] [stderr] 201 | | value: String::new(), [INFO] [stderr] 202 | | } [INFO] [stderr] 203 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `v3::Personalization` [INFO] [stderr] --> src/v3.rs:218:5 [INFO] [stderr] | [INFO] [stderr] 218 | / pub fn new() -> Personalization { [INFO] [stderr] 219 | | Personalization { [INFO] [stderr] 220 | | to: Vec::new(), [INFO] [stderr] 221 | | cc: None, [INFO] [stderr] ... | [INFO] [stderr] 228 | | } [INFO] [stderr] 229 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 57 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `v3::Attachment` [INFO] [stderr] --> src/v3.rs:283:5 [INFO] [stderr] | [INFO] [stderr] 283 | / pub fn new() -> Attachment { [INFO] [stderr] 284 | | Attachment { [INFO] [stderr] 285 | | content: String::new(), [INFO] [stderr] 286 | | filename: String::new(), [INFO] [stderr] ... | [INFO] [stderr] 290 | | } [INFO] [stderr] 291 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 86 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.79s [INFO] running `"docker" "inspect" "a34542d4eb08aa1853cec0e8bde3e9fb4e9b58533dcecbdc4b1a07836609e902"` [INFO] running `"docker" "rm" "-f" "a34542d4eb08aa1853cec0e8bde3e9fb4e9b58533dcecbdc4b1a07836609e902"` [INFO] [stdout] a34542d4eb08aa1853cec0e8bde3e9fb4e9b58533dcecbdc4b1a07836609e902