[INFO] crate selva 0.2.0 is already in cache [INFO] extracting crate selva 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/selva/0.2.0 [INFO] extracting crate selva 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/selva/0.2.0 [INFO] validating manifest of selva-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of selva-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing selva-0.2.0 [INFO] finished frobbing selva-0.2.0 [INFO] frobbed toml for selva-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/selva/0.2.0/Cargo.toml [INFO] started frobbing selva-0.2.0 [INFO] finished frobbing selva-0.2.0 [INFO] frobbed toml for selva-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/selva/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting selva-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/selva/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 56c0ac6a1f630723311917d239a97e192e2311010bcd2885ae1b5ab9cc5c2ab7 [INFO] running `"docker" "start" "-a" "56c0ac6a1f630723311917d239a97e192e2311010bcd2885ae1b5ab9cc5c2ab7"` [INFO] [stderr] Compiling glutin v0.14.0 [INFO] [stderr] Compiling glium v0.21.0 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Checking glsl-include v0.2.3 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking glslwatch v0.1.3 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking winit v0.12.0 [INFO] [stderr] Checking selva v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `glium::backend::glutin::headless::Headless` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use glium::backend::glutin::headless::Headless; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `glium::glutin::HeadlessRendererBuilder` [INFO] [stderr] --> src/main.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use glium::glutin::HeadlessRendererBuilder; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `glium::backend::glutin::headless::Headless` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use glium::backend::glutin::headless::Headless; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `glium::glutin::HeadlessRendererBuilder` [INFO] [stderr] --> src/main.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use glium::glutin::HeadlessRendererBuilder; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `itertools::Itertools` [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | use itertools::Itertools; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `itertools::Itertools` [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | use itertools::Itertools; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:157:34 [INFO] [stderr] | [INFO] [stderr] 157 | src_r.and_then(|src| match src.expired()? { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 158 | | true => Ok((src.refresh()?, true)), // Should make new program. [INFO] [stderr] 159 | | false => Ok((src, false)), // Should not make new progam. [INFO] [stderr] 160 | | }), [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if src.expired()? { Ok((src.refresh()?, true)) } else { Ok((src, false)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `row_buffer`. [INFO] [stderr] --> src/main.rs:289:26 [INFO] [stderr] | [INFO] [stderr] 289 | for j in 0..tiles_wide { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 289 | for in row_buffer.iter().take(tiles_wide) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:157:34 [INFO] [stderr] | [INFO] [stderr] 157 | src_r.and_then(|src| match src.expired()? { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 158 | | true => Ok((src.refresh()?, true)), // Should make new program. [INFO] [stderr] 159 | | false => Ok((src, false)), // Should not make new progam. [INFO] [stderr] 160 | | }), [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if src.expired()? { Ok((src.refresh()?, true)) } else { Ok((src, false)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `row_buffer`. [INFO] [stderr] --> src/main.rs:289:26 [INFO] [stderr] | [INFO] [stderr] 289 | for j in 0..tiles_wide { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 289 | for in row_buffer.iter().take(tiles_wide) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 52.16s [INFO] running `"docker" "inspect" "56c0ac6a1f630723311917d239a97e192e2311010bcd2885ae1b5ab9cc5c2ab7"` [INFO] running `"docker" "rm" "-f" "56c0ac6a1f630723311917d239a97e192e2311010bcd2885ae1b5ab9cc5c2ab7"` [INFO] [stdout] 56c0ac6a1f630723311917d239a97e192e2311010bcd2885ae1b5ab9cc5c2ab7