[INFO] crate self_update 0.5.0 is already in cache [INFO] extracting crate self_update 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/self_update/0.5.0 [INFO] extracting crate self_update 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/self_update/0.5.0 [INFO] validating manifest of self_update-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of self_update-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing self_update-0.5.0 [INFO] finished frobbing self_update-0.5.0 [INFO] frobbed toml for self_update-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/self_update/0.5.0/Cargo.toml [INFO] started frobbing self_update-0.5.0 [INFO] finished frobbing self_update-0.5.0 [INFO] frobbed toml for self_update-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/self_update/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting self_update-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/self_update/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0d33d62d375b302c7e42019b3a561a4f76c86756ff4857a1554741ec7082b459 [INFO] running `"docker" "start" "-a" "0d33d62d375b302c7e42019b3a561a4f76c86756ff4857a1554741ec7082b459"` [INFO] [stderr] Checking hyper-old-types v0.11.0 [INFO] [stderr] Checking zip v0.5.0 [INFO] [stderr] Checking self_update v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backends/github.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | assets: assets, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `assets` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:283:13 [INFO] [stderr] | [INFO] [stderr] 283 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:430:13 [INFO] [stderr] | [INFO] [stderr] 430 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backends/github.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | assets: assets, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `assets` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:283:13 [INFO] [stderr] | [INFO] [stderr] 283 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:430:13 [INFO] [stderr] | [INFO] [stderr] 430 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/backends/github.rs:421:69 [INFO] [stderr] | [INFO] [stderr] 421 | let release_tag = release.tag.trim_left_matches("v"); [INFO] [stderr] | ^^^ help: try using a char instead: `'v'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/backends/github.rs:456:14 [INFO] [stderr] | [INFO] [stderr] 456 | .expect(&format!("Failed to determine parent dir of `bin_install_path`: {:?}", self.bin_install_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Failed to determine parent dir of `bin_install_path`: {:?}", self.bin_install_path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:297:22 [INFO] [stderr] | [INFO] [stderr] 297 | compression: &Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/lib.rs:385:41 [INFO] [stderr] | [INFO] [stderr] 385 | let mut entry = archive [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 386 | | .entries()? [INFO] [stderr] 387 | | .filter_map(|e| e.ok()) [INFO] [stderr] 388 | | .filter(|e| e.path().ok().filter(|p| p == file_to_extract).is_some()) [INFO] [stderr] 389 | | .next() [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|e| e.path().ok().filter(|p| p == file_to_extract).is_some()).next()` with `find(|e| e.path().ok().filter(|p| p == file_to_extract).is_some())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/backends/github.rs:421:69 [INFO] [stderr] | [INFO] [stderr] 421 | let release_tag = release.tag.trim_left_matches("v"); [INFO] [stderr] | ^^^ help: try using a char instead: `'v'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/backends/github.rs:456:14 [INFO] [stderr] | [INFO] [stderr] 456 | .expect(&format!("Failed to determine parent dir of `bin_install_path`: {:?}", self.bin_install_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Failed to determine parent dir of `bin_install_path`: {:?}", self.bin_install_path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:458:21 [INFO] [stderr] | [INFO] [stderr] 458 | / match fs::rename(self.source, dest) { [INFO] [stderr] 459 | | Err(e) => { [INFO] [stderr] 460 | | fs::rename(temp, dest)?; [INFO] [stderr] 461 | | return Err(Error::from(e)) [INFO] [stderr] 462 | | } [INFO] [stderr] 463 | | Ok(_) => (), [INFO] [stderr] 464 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 458 | if let Err(e) = fs::rename(self.source, dest) { [INFO] [stderr] 459 | fs::rename(temp, dest)?; [INFO] [stderr] 460 | return Err(Error::from(e)) [INFO] [stderr] 461 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/lib.rs:522:21 [INFO] [stderr] | [INFO] [stderr] 522 | let mut bar = pbr::ProgressBar::new(size); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/lib.rs:521:17 [INFO] [stderr] | [INFO] [stderr] 521 | let mut bar = if show_progress { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: The function/method `write_all` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:530:32 [INFO] [stderr] | [INFO] [stderr] 530 | dest.write_all(&mut buf)?; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/lib.rs:535:33 [INFO] [stderr] | [INFO] [stderr] 535 | if let Some(ref mut bar) = bar { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:297:22 [INFO] [stderr] | [INFO] [stderr] 297 | compression: &Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/lib.rs:385:41 [INFO] [stderr] | [INFO] [stderr] 385 | let mut entry = archive [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 386 | | .entries()? [INFO] [stderr] 387 | | .filter_map(|e| e.ok()) [INFO] [stderr] 388 | | .filter(|e| e.path().ok().filter(|p| p == file_to_extract).is_some()) [INFO] [stderr] 389 | | .next() [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|e| e.path().ok().filter(|p| p == file_to_extract).is_some()).next()` with `find(|e| e.path().ok().filter(|p| p == file_to_extract).is_some())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:458:21 [INFO] [stderr] | [INFO] [stderr] 458 | / match fs::rename(self.source, dest) { [INFO] [stderr] 459 | | Err(e) => { [INFO] [stderr] 460 | | fs::rename(temp, dest)?; [INFO] [stderr] 461 | | return Err(Error::from(e)) [INFO] [stderr] 462 | | } [INFO] [stderr] 463 | | Ok(_) => (), [INFO] [stderr] 464 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 458 | if let Err(e) = fs::rename(self.source, dest) { [INFO] [stderr] 459 | fs::rename(temp, dest)?; [INFO] [stderr] 460 | return Err(Error::from(e)) [INFO] [stderr] 461 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/lib.rs:522:21 [INFO] [stderr] | [INFO] [stderr] 522 | let mut bar = pbr::ProgressBar::new(size); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/lib.rs:521:17 [INFO] [stderr] | [INFO] [stderr] 521 | let mut bar = if show_progress { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: The function/method `write_all` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:530:32 [INFO] [stderr] | [INFO] [stderr] 530 | dest.write_all(&mut buf)?; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/lib.rs:535:33 [INFO] [stderr] | [INFO] [stderr] 535 | if let Some(ref mut bar) = bar { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:730:9 [INFO] [stderr] | [INFO] [stderr] 730 | zip.write(b"This is a test!").expect("failed writing to zip"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:732:9 [INFO] [stderr] | [INFO] [stderr] 732 | zip.write(b"This is a second test!").expect("failed writing to second zip"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:757:9 [INFO] [stderr] | [INFO] [stderr] 757 | zip.write(b"This is a test!").expect("failed writing to zip"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:759:9 [INFO] [stderr] | [INFO] [stderr] 759 | zip.write(b"This is a second test!").expect("failed writing to second zip"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `self_update`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "0d33d62d375b302c7e42019b3a561a4f76c86756ff4857a1554741ec7082b459"` [INFO] running `"docker" "rm" "-f" "0d33d62d375b302c7e42019b3a561a4f76c86756ff4857a1554741ec7082b459"` [INFO] [stdout] 0d33d62d375b302c7e42019b3a561a4f76c86756ff4857a1554741ec7082b459