[INFO] crate selectors 0.20.0 is already in cache [INFO] extracting crate selectors 0.20.0 into work/ex/clippy-test-run/sources/stable/reg/selectors/0.20.0 [INFO] extracting crate selectors 0.20.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/selectors/0.20.0 [INFO] validating manifest of selectors-0.20.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of selectors-0.20.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing selectors-0.20.0 [INFO] finished frobbing selectors-0.20.0 [INFO] frobbed toml for selectors-0.20.0 written to work/ex/clippy-test-run/sources/stable/reg/selectors/0.20.0/Cargo.toml [INFO] started frobbing selectors-0.20.0 [INFO] finished frobbing selectors-0.20.0 [INFO] frobbed toml for selectors-0.20.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/selectors/0.20.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting selectors-0.20.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/selectors/0.20.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c1c9c0299e1bb0bfcbf1775f4fee8b23eac4cf692cc00b47a905f01ed7a7de35 [INFO] running `"docker" "start" "-a" "c1c9c0299e1bb0bfcbf1775f4fee8b23eac4cf692cc00b47a905f01ed7a7de35"` [INFO] [stderr] Compiling syn v0.15.26 [INFO] [stderr] Compiling selectors v0.20.0 (/opt/crater/workdir) [INFO] [stderr] Compiling cssparser-macros v0.3.5 [INFO] [stderr] Checking cssparser v0.24.1 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> matching.rs:715:21 [INFO] [stderr] | [INFO] [stderr] 715 | operator: operator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `operator` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> matching.rs:744:25 [INFO] [stderr] | [INFO] [stderr] 744 | operator: operator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `operator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> matching.rs:746:25 [INFO] [stderr] | [INFO] [stderr] 746 | expected_value: expected_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expected_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:586:13 [INFO] [stderr] | [INFO] [stderr] 586 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:1645:25 [INFO] [stderr] | [INFO] [stderr] 1645 | local_name: local_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `local_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:1646:25 [INFO] [stderr] | [INFO] [stderr] 1646 | local_name_lower: local_name_lower, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `local_name_lower` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:1653:21 [INFO] [stderr] | [INFO] [stderr] 1653 | local_name: local_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `local_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:1654:21 [INFO] [stderr] | [INFO] [stderr] 1654 | local_name_lower: local_name_lower, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `local_name_lower` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:1726:21 [INFO] [stderr] | [INFO] [stderr] 1726 | operator: operator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `operator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:1727:21 [INFO] [stderr] | [INFO] [stderr] 1727 | case_sensitivity: case_sensitivity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `case_sensitivity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:1734:13 [INFO] [stderr] | [INFO] [stderr] 1734 | local_name: local_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `local_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:1735:13 [INFO] [stderr] | [INFO] [stderr] 1735 | operator: operator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `operator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:1736:13 [INFO] [stderr] | [INFO] [stderr] 1736 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:1737:13 [INFO] [stderr] | [INFO] [stderr] 1737 | case_sensitivity: case_sensitivity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `case_sensitivity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:1738:13 [INFO] [stderr] | [INFO] [stderr] 1738 | never_matches: never_matches, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `never_matches` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> matching.rs:715:21 [INFO] [stderr] | [INFO] [stderr] 715 | operator: operator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `operator` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> matching.rs:744:25 [INFO] [stderr] | [INFO] [stderr] 744 | operator: operator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `operator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> matching.rs:746:25 [INFO] [stderr] | [INFO] [stderr] 746 | expected_value: expected_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expected_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:586:13 [INFO] [stderr] | [INFO] [stderr] 586 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:1645:25 [INFO] [stderr] | [INFO] [stderr] 1645 | local_name: local_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `local_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:1646:25 [INFO] [stderr] | [INFO] [stderr] 1646 | local_name_lower: local_name_lower, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `local_name_lower` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:1653:21 [INFO] [stderr] | [INFO] [stderr] 1653 | local_name: local_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `local_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:1654:21 [INFO] [stderr] | [INFO] [stderr] 1654 | local_name_lower: local_name_lower, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `local_name_lower` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:1726:21 [INFO] [stderr] | [INFO] [stderr] 1726 | operator: operator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `operator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:1727:21 [INFO] [stderr] | [INFO] [stderr] 1727 | case_sensitivity: case_sensitivity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `case_sensitivity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:1734:13 [INFO] [stderr] | [INFO] [stderr] 1734 | local_name: local_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `local_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:1735:13 [INFO] [stderr] | [INFO] [stderr] 1735 | operator: operator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `operator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:1736:13 [INFO] [stderr] | [INFO] [stderr] 1736 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:1737:13 [INFO] [stderr] | [INFO] [stderr] 1737 | case_sensitivity: case_sensitivity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `case_sensitivity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:1738:13 [INFO] [stderr] | [INFO] [stderr] 1738 | never_matches: never_matches, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `never_matches` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> bloom.rs:12:34 [INFO] [stderr] | [INFO] [stderr] 12 | pub const BLOOM_HASH_MASK: u32 = 0x00ffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> bloom.rs:12:34 [INFO] [stderr] | [INFO] [stderr] 12 | pub const BLOOM_HASH_MASK: u32 = 0x00ffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> parser.rs:336:36 [INFO] [stderr] | [INFO] [stderr] 336 | hashes[0] |= (fourth & 0x000000ff) << 24; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> parser.rs:337:36 [INFO] [stderr] | [INFO] [stderr] 337 | hashes[1] |= (fourth & 0x0000ff00) << 16; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_ff00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> parser.rs:338:36 [INFO] [stderr] | [INFO] [stderr] 338 | hashes[2] |= (fourth & 0x00ff0000) << 8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> parser.rs:348:35 [INFO] [stderr] | [INFO] [stderr] 348 | ((self.packed_hashes[0] & 0xff000000) >> 24) | [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> parser.rs:349:39 [INFO] [stderr] | [INFO] [stderr] 349 | ((self.packed_hashes[1] & 0xff000000) >> 16) | [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> parser.rs:350:39 [INFO] [stderr] | [INFO] [stderr] 350 | ((self.packed_hashes[2] & 0xff000000) >> 8) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Namespace` [INFO] [stderr] --> parser.rs:1484:1 [INFO] [stderr] | [INFO] [stderr] 1484 | / enum QNamePrefix { [INFO] [stderr] 1485 | | ImplicitNoNamespace, // `foo` in attr selectors [INFO] [stderr] 1486 | | ImplicitAnyNamespace, // `foo` in type selectors, without a default ns [INFO] [stderr] 1487 | | ImplicitDefaultNamespace(Impl::NamespaceUrl), // `foo` in type selectors, with a default ns [INFO] [stderr] ... | [INFO] [stderr] 1490 | | ExplicitNamespace(Impl::NamespacePrefix, Impl::NamespaceUrl), // `prefix|foo` [INFO] [stderr] 1491 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/selectors-ac3d2f4e0e40dba6/out/ascii_case_insensitive_html_attributes.rs:2:10 [INFO] [stderr] | [INFO] [stderr] 2 | key: 17577996893838306539, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `17_577_996_893_838_306_539` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> parser.rs:336:36 [INFO] [stderr] | [INFO] [stderr] 336 | hashes[0] |= (fourth & 0x000000ff) << 24; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> parser.rs:337:36 [INFO] [stderr] | [INFO] [stderr] 337 | hashes[1] |= (fourth & 0x0000ff00) << 16; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_ff00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> parser.rs:338:36 [INFO] [stderr] | [INFO] [stderr] 338 | hashes[2] |= (fourth & 0x00ff0000) << 8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> parser.rs:348:35 [INFO] [stderr] | [INFO] [stderr] 348 | ((self.packed_hashes[0] & 0xff000000) >> 24) | [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> parser.rs:349:39 [INFO] [stderr] | [INFO] [stderr] 349 | ((self.packed_hashes[1] & 0xff000000) >> 16) | [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> parser.rs:350:39 [INFO] [stderr] | [INFO] [stderr] 350 | ((self.packed_hashes[2] & 0xff000000) >> 8) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> parser.rs:2356:20 [INFO] [stderr] | [INFO] [stderr] 2356 | const MATHML: &'static str = "http://www.w3.org/1998/Math/MathML"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> parser.rs:2357:17 [INFO] [stderr] | [INFO] [stderr] 2357 | const SVG: &'static str = "http://www.w3.org/2000/svg"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Namespace` [INFO] [stderr] --> parser.rs:1484:1 [INFO] [stderr] | [INFO] [stderr] 1484 | / enum QNamePrefix { [INFO] [stderr] 1485 | | ImplicitNoNamespace, // `foo` in attr selectors [INFO] [stderr] 1486 | | ImplicitAnyNamespace, // `foo` in type selectors, without a default ns [INFO] [stderr] 1487 | | ImplicitDefaultNamespace(Impl::NamespaceUrl), // `foo` in type selectors, with a default ns [INFO] [stderr] ... | [INFO] [stderr] 1490 | | ExplicitNamespace(Impl::NamespacePrefix, Impl::NamespaceUrl), // `prefix|foo` [INFO] [stderr] 1491 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/selectors-ac3d2f4e0e40dba6/out/ascii_case_insensitive_html_attributes.rs:2:10 [INFO] [stderr] | [INFO] [stderr] 2 | key: 17577996893838306539, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `17_577_996_893_838_306_539` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `bloom::CountingBloomFilter` [INFO] [stderr] --> bloom.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | / pub fn new() -> Self { [INFO] [stderr] 87 | | CountingBloomFilter { [INFO] [stderr] 88 | | storage: Default::default(), [INFO] [stderr] 89 | | } [INFO] [stderr] 90 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 73 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> builder.rs:207:24 [INFO] [stderr] | [INFO] [stderr] 207 | pub fn specificity(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> builder.rs:212:31 [INFO] [stderr] | [INFO] [stderr] 212 | pub fn has_pseudo_element(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> builder.rs:217:23 [INFO] [stderr] | [INFO] [stderr] 217 | pub fn is_slotted(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> context.rs:53:28 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn matches_visited(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> context.rs:62:30 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn matches_unvisited(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> matching.rs:28:35 [INFO] [stderr] | [INFO] [stderr] 28 | const HAS_SLOW_SELECTOR = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> matching.rs:277:89 [INFO] [stderr] | [INFO] [stderr] 277 | if !matches_simple_selector(component, element, &mut local_context, &mut |_, _| {}) { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> matching.rs:421:13 [INFO] [stderr] | [INFO] [stderr] 421 | / match element.parent_element() { [INFO] [stderr] 422 | | Some(e) => return Some(e), [INFO] [stderr] 423 | | None => {}, [INFO] [stderr] 424 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(e) = element.parent_element() { return Some(e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> matching.rs:873:9 [INFO] [stderr] | [INFO] [stderr] 873 | cache.as_mut().map(|c| c.insert(element.opaque(), i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(c) = cache.as_mut() { c.insert(element.opaque(), i) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> nth_index_cache.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | self.0.get(&el).map(|x| *x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.0.get(&el).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `hashes`. [INFO] [stderr] --> parser.rs:325:18 [INFO] [stderr] | [INFO] [stderr] 325 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 325 | for in &mut hashes { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: item `parser::Selector` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> parser.rs:499:1 [INFO] [stderr] | [INFO] [stderr] 499 | / impl Selector { [INFO] [stderr] 500 | | #[inline] [INFO] [stderr] 501 | | pub fn specificity(&self) -> u32 { [INFO] [stderr] 502 | | self.0.header.header.specificity() [INFO] [stderr] ... | [INFO] [stderr] 655 | | } [INFO] [stderr] 656 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> parser.rs:675:48 [INFO] [stderr] | [INFO] [stderr] 675 | pub(crate) fn is_featureless_host_selector(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> parser.rs:735:56 [INFO] [stderr] | [INFO] [stderr] 735 | if self.0.next_sequence().map_or(true, |x| { [INFO] [stderr] | ________________________________________________________^ [INFO] [stderr] 736 | | matches!(x, Combinator::Child | Combinator::Descendant) [INFO] [stderr] 737 | | }) { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> parser.rs:785:24 [INFO] [stderr] | [INFO] [stderr] 785 | pub fn is_ancestor(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> parser.rs:795:30 [INFO] [stderr] | [INFO] [stderr] 795 | pub fn is_pseudo_element(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> parser.rs:801:23 [INFO] [stderr] | [INFO] [stderr] 801 | pub fn is_sibling(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `bloom::CountingBloomFilter` [INFO] [stderr] --> bloom.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | / pub fn new() -> Self { [INFO] [stderr] 87 | | CountingBloomFilter { [INFO] [stderr] 88 | | storage: Default::default(), [INFO] [stderr] 89 | | } [INFO] [stderr] 90 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 73 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a type (`[u8; 0]`) to itself [INFO] [stderr] --> bloom.rs:310:9 [INFO] [stderr] | [INFO] [stderr] 310 | transmute::<[u8; ARRAY_SIZE % 8], [u8; 0]>([]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> builder.rs:207:24 [INFO] [stderr] | [INFO] [stderr] 207 | pub fn specificity(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> builder.rs:212:31 [INFO] [stderr] | [INFO] [stderr] 212 | pub fn has_pseudo_element(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> builder.rs:217:23 [INFO] [stderr] | [INFO] [stderr] 217 | pub fn is_slotted(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> context.rs:53:28 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn matches_visited(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> context.rs:62:30 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn matches_unvisited(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> matching.rs:28:35 [INFO] [stderr] | [INFO] [stderr] 28 | const HAS_SLOW_SELECTOR = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> parser.rs:1546:38 [INFO] [stderr] | [INFO] [stderr] 1546 | let url = result.ok_or( [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 1547 | | after_ident [INFO] [stderr] 1548 | | .source_location() [INFO] [stderr] 1549 | | .new_custom_error(SelectorParseErrorKind::ExpectedNamespace(value)), [INFO] [stderr] 1550 | | )?; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1546 | let url = result.ok_or_else(|| after_ident [INFO] [stderr] 1547 | .source_location() [INFO] [stderr] 1548 | .new_custom_error(SelectorParseErrorKind::ExpectedNamespace(value)))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> matching.rs:277:89 [INFO] [stderr] | [INFO] [stderr] 277 | if !matches_simple_selector(component, element, &mut local_context, &mut |_, _| {}) { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> matching.rs:421:13 [INFO] [stderr] | [INFO] [stderr] 421 | / match element.parent_element() { [INFO] [stderr] 422 | | Some(e) => return Some(e), [INFO] [stderr] 423 | | None => {}, [INFO] [stderr] 424 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(e) = element.parent_element() { return Some(e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> matching.rs:873:9 [INFO] [stderr] | [INFO] [stderr] 873 | cache.as_mut().map(|c| c.insert(element.opaque(), i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(c) = cache.as_mut() { c.insert(element.opaque(), i) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> nth_index_cache.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | self.0.get(&el).map(|x| *x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.0.get(&el).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `hashes`. [INFO] [stderr] --> parser.rs:325:18 [INFO] [stderr] | [INFO] [stderr] 325 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 325 | for in &mut hashes { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: item `parser::Selector` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> parser.rs:499:1 [INFO] [stderr] | [INFO] [stderr] 499 | / impl Selector { [INFO] [stderr] 500 | | #[inline] [INFO] [stderr] 501 | | pub fn specificity(&self) -> u32 { [INFO] [stderr] 502 | | self.0.header.header.specificity() [INFO] [stderr] ... | [INFO] [stderr] 655 | | } [INFO] [stderr] 656 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> parser.rs:675:48 [INFO] [stderr] | [INFO] [stderr] 675 | pub(crate) fn is_featureless_host_selector(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> parser.rs:735:56 [INFO] [stderr] | [INFO] [stderr] 735 | if self.0.next_sequence().map_or(true, |x| { [INFO] [stderr] | ________________________________________________________^ [INFO] [stderr] 736 | | matches!(x, Combinator::Child | Combinator::Descendant) [INFO] [stderr] 737 | | }) { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> parser.rs:785:24 [INFO] [stderr] | [INFO] [stderr] 785 | pub fn is_ancestor(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> parser.rs:795:30 [INFO] [stderr] | [INFO] [stderr] 795 | pub fn is_pseudo_element(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> parser.rs:801:23 [INFO] [stderr] | [INFO] [stderr] 801 | pub fn is_sibling(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> parser.rs:1546:38 [INFO] [stderr] | [INFO] [stderr] 1546 | let url = result.ok_or( [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 1547 | | after_ident [INFO] [stderr] 1548 | | .source_location() [INFO] [stderr] 1549 | | .new_custom_error(SelectorParseErrorKind::ExpectedNamespace(value)), [INFO] [stderr] 1550 | | )?; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1546 | let url = result.ok_or_else(|| after_ident [INFO] [stderr] 1547 | .source_location() [INFO] [stderr] 1548 | .new_custom_error(SelectorParseErrorKind::ExpectedNamespace(value)))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 59 [INFO] [stderr] --> parser.rs:2360:5 [INFO] [stderr] | [INFO] [stderr] 2360 | / fn test_parsing() { [INFO] [stderr] 2361 | | assert!(parse("").is_err()); [INFO] [stderr] 2362 | | assert!(parse(":lang(4)").is_err()); [INFO] [stderr] 2363 | | assert!(parse(":lang(en US)").is_err()); [INFO] [stderr] ... | [INFO] [stderr] 2884 | | assert!(parse("slot::slotted(div,foo)").is_err()); [INFO] [stderr] 2885 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(1 << 20) + (1 << 10)` [INFO] [stderr] --> parser.rs:2771:21 [INFO] [stderr] | [INFO] [stderr] 2771 | (1 << 20) + (1 << 10) + (0 << 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `0` [INFO] [stderr] --> parser.rs:2771:45 [INFO] [stderr] | [INFO] [stderr] 2771 | (1 << 20) + (1 << 10) + (0 << 0), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 26.40s [INFO] running `"docker" "inspect" "c1c9c0299e1bb0bfcbf1775f4fee8b23eac4cf692cc00b47a905f01ed7a7de35"` [INFO] running `"docker" "rm" "-f" "c1c9c0299e1bb0bfcbf1775f4fee8b23eac4cf692cc00b47a905f01ed7a7de35"` [INFO] [stdout] c1c9c0299e1bb0bfcbf1775f4fee8b23eac4cf692cc00b47a905f01ed7a7de35