[INFO] crate select_color 0.17.0 is already in cache [INFO] extracting crate select_color 0.17.0 into work/ex/clippy-test-run/sources/stable/reg/select_color/0.17.0 [INFO] extracting crate select_color 0.17.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/select_color/0.17.0 [INFO] validating manifest of select_color-0.17.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of select_color-0.17.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing select_color-0.17.0 [INFO] finished frobbing select_color-0.17.0 [INFO] frobbed toml for select_color-0.17.0 written to work/ex/clippy-test-run/sources/stable/reg/select_color/0.17.0/Cargo.toml [INFO] started frobbing select_color-0.17.0 [INFO] finished frobbing select_color-0.17.0 [INFO] frobbed toml for select_color-0.17.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/select_color/0.17.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting select_color-0.17.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/select_color/0.17.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 09e828ec877fb4fd2f60113a06d1d902c6232b56df46959f1e00ad406227af32 [INFO] running `"docker" "start" "-a" "09e828ec877fb4fd2f60113a06d1d902c6232b56df46959f1e00ad406227af32"` [INFO] [stderr] Checking select_color v0.17.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/hue_saturation.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | let p = (255.0 * (1.0 - saturation)) as u8; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/hue_saturation.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | let q = (255.0 * (1.0 - f * saturation)) as u8; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/hue_saturation.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | let t = (255.0 * (1.0 - (1.0 - f) * saturation)) as u8; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/hue_saturation.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | let t = (255.0 * (1.0 - (1.0 - f) * saturation)) as u8; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/hue_saturation.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | let p = (255.0 * (1.0 - saturation)) as u8; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/hue_saturation.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | let q = (255.0 * (1.0 - f * saturation)) as u8; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/hue_saturation.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | let t = (255.0 * (1.0 - (1.0 - f) * saturation)) as u8; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/hue_saturation.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | let t = (255.0 * (1.0 - (1.0 - f) * saturation)) as u8; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hue_saturation.rs:11:36 [INFO] [stderr] | [INFO] [stderr] 11 | let inv_rect_width = 1.0_f64 / rect[2] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(rect[2])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hue_saturation.rs:12:42 [INFO] [stderr] | [INFO] [stderr] 12 | let half_inv_rect_height = 0.5_f64 / rect[3] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(rect[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hue_saturation.rs:15:14 [INFO] [stderr] | [INFO] [stderr] 15 | let fx = (x - rect[0]) as f64 * inv_rect_width; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(x - rect[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hue_saturation.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | let saturation = (y - rect[1]) as f64 * half_inv_rect_height; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(y - rect[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hue_saturation.rs:57:36 [INFO] [stderr] | [INFO] [stderr] 57 | let inv_rect_width = 1.0_f64 / rect[2] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(rect[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hue_saturation.rs:58:42 [INFO] [stderr] | [INFO] [stderr] 58 | let half_inv_rect_height = 0.5_f64 / rect[3] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(rect[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hue_saturation.rs:62:22 [INFO] [stderr] | [INFO] [stderr] 62 | let fx = (x - rect[0]) as f64 * inv_rect_width; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(x - rect[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hue_saturation.rs:65:30 [INFO] [stderr] | [INFO] [stderr] 65 | let saturation = (y - rect[1]) as f64 * half_inv_rect_height; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(y - rect[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hue_saturation.rs:11:36 [INFO] [stderr] | [INFO] [stderr] 11 | let inv_rect_width = 1.0_f64 / rect[2] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(rect[2])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hue_saturation.rs:12:42 [INFO] [stderr] | [INFO] [stderr] 12 | let half_inv_rect_height = 0.5_f64 / rect[3] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(rect[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hue_saturation.rs:15:14 [INFO] [stderr] | [INFO] [stderr] 15 | let fx = (x - rect[0]) as f64 * inv_rect_width; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(x - rect[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hue_saturation.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | let saturation = (y - rect[1]) as f64 * half_inv_rect_height; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(y - rect[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hue_saturation.rs:57:36 [INFO] [stderr] | [INFO] [stderr] 57 | let inv_rect_width = 1.0_f64 / rect[2] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(rect[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hue_saturation.rs:58:42 [INFO] [stderr] | [INFO] [stderr] 58 | let half_inv_rect_height = 0.5_f64 / rect[3] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(rect[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hue_saturation.rs:62:22 [INFO] [stderr] | [INFO] [stderr] 62 | let fx = (x - rect[0]) as f64 * inv_rect_width; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(x - rect[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/hue_saturation.rs:65:30 [INFO] [stderr] | [INFO] [stderr] 65 | let saturation = (y - rect[1]) as f64 * half_inv_rect_height; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(y - rect[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.97s [INFO] running `"docker" "inspect" "09e828ec877fb4fd2f60113a06d1d902c6232b56df46959f1e00ad406227af32"` [INFO] running `"docker" "rm" "-f" "09e828ec877fb4fd2f60113a06d1d902c6232b56df46959f1e00ad406227af32"` [INFO] [stdout] 09e828ec877fb4fd2f60113a06d1d902c6232b56df46959f1e00ad406227af32