[INFO] crate sedregex 0.2.2 is already in cache [INFO] extracting crate sedregex 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/sedregex/0.2.2 [INFO] extracting crate sedregex 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sedregex/0.2.2 [INFO] validating manifest of sedregex-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sedregex-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sedregex-0.2.2 [INFO] finished frobbing sedregex-0.2.2 [INFO] frobbed toml for sedregex-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/sedregex/0.2.2/Cargo.toml [INFO] started frobbing sedregex-0.2.2 [INFO] finished frobbing sedregex-0.2.2 [INFO] frobbed toml for sedregex-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sedregex/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sedregex-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sedregex/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 23ae7fdd32505e579fd131e6abf8fe7183af15e9bc6a55ffe60bcec9ba0cfa6c [INFO] running `"docker" "start" "-a" "23ae7fdd32505e579fd131e6abf8fe7183af15e9bc6a55ffe60bcec9ba0cfa6c"` [INFO] [stderr] Checking sedregex v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/splitting_iter.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / fn split_escape<'a>(string: &'a str, begin: usize) -> (Cow<'a, str>, usize) { [INFO] [stderr] 16 | | let mut buf = CowAppender::new(string, begin); [INFO] [stderr] 17 | | let mut shift = begin; [INFO] [stderr] 18 | | while shift < string.len() { [INFO] [stderr] ... | [INFO] [stderr] 35 | | (buf.into_inner(), string.len()) [INFO] [stderr] 36 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:130:1 [INFO] [stderr] | [INFO] [stderr] 130 | / pub fn find_and_replace<'a, I>(text: &'a str, commands: I) -> Result, ErrorKind> [INFO] [stderr] 131 | | where [INFO] [stderr] 132 | | I: IntoIterator, [INFO] [stderr] 133 | | I::Item: AsRef, [INFO] [stderr] ... | [INFO] [stderr] 146 | | }) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:150:1 [INFO] [stderr] | [INFO] [stderr] 150 | / fn regex_cow<'a, R, F>(s: Cow<'a, str>, re: Regex, f: F, rep: R) -> Cow<'a, str> [INFO] [stderr] 151 | | where [INFO] [stderr] 152 | | for<'r, 't> F: FnOnce(&'r Regex, &'t str, R) -> Cow<'t, str>, [INFO] [stderr] 153 | | R: regex::Replacer, [INFO] [stderr] ... | [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: using a reference to `Cow` is not recommended. [INFO] [stderr] --> src/cow_appender.rs:86:27 [INFO] [stderr] | [INFO] [stderr] 86 | fn is_borrowed<'a>(s: &Cow<'a, str>) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cow_appender.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | / match s { [INFO] [stderr] 88 | | &Cow::Borrowed(_) => true, [INFO] [stderr] 89 | | &Cow::Owned(_) => false, [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 87 | match *s { [INFO] [stderr] 88 | Cow::Borrowed(_) => true, [INFO] [stderr] 89 | Cow::Owned(_) => false, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/splitting_iter.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / fn split_escape<'a>(string: &'a str, begin: usize) -> (Cow<'a, str>, usize) { [INFO] [stderr] 16 | | let mut buf = CowAppender::new(string, begin); [INFO] [stderr] 17 | | let mut shift = begin; [INFO] [stderr] 18 | | while shift < string.len() { [INFO] [stderr] ... | [INFO] [stderr] 35 | | (buf.into_inner(), string.len()) [INFO] [stderr] 36 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:130:1 [INFO] [stderr] | [INFO] [stderr] 130 | / pub fn find_and_replace<'a, I>(text: &'a str, commands: I) -> Result, ErrorKind> [INFO] [stderr] 131 | | where [INFO] [stderr] 132 | | I: IntoIterator, [INFO] [stderr] 133 | | I::Item: AsRef, [INFO] [stderr] ... | [INFO] [stderr] 146 | | }) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:150:1 [INFO] [stderr] | [INFO] [stderr] 150 | / fn regex_cow<'a, R, F>(s: Cow<'a, str>, re: Regex, f: F, rep: R) -> Cow<'a, str> [INFO] [stderr] 151 | | where [INFO] [stderr] 152 | | for<'r, 't> F: FnOnce(&'r Regex, &'t str, R) -> Cow<'t, str>, [INFO] [stderr] 153 | | R: regex::Replacer, [INFO] [stderr] ... | [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.30s [INFO] running `"docker" "inspect" "23ae7fdd32505e579fd131e6abf8fe7183af15e9bc6a55ffe60bcec9ba0cfa6c"` [INFO] running `"docker" "rm" "-f" "23ae7fdd32505e579fd131e6abf8fe7183af15e9bc6a55ffe60bcec9ba0cfa6c"` [INFO] [stdout] 23ae7fdd32505e579fd131e6abf8fe7183af15e9bc6a55ffe60bcec9ba0cfa6c