[INFO] crate secstr 0.3.1 is already in cache [INFO] extracting crate secstr 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/secstr/0.3.1 [INFO] extracting crate secstr 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/secstr/0.3.1 [INFO] validating manifest of secstr-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of secstr-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing secstr-0.3.1 [INFO] finished frobbing secstr-0.3.1 [INFO] frobbed toml for secstr-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/secstr/0.3.1/Cargo.toml [INFO] started frobbing secstr-0.3.1 [INFO] finished frobbing secstr-0.3.1 [INFO] frobbed toml for secstr-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/secstr/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting secstr-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/secstr/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 40451796e37e10ce07afb61ca91cbb1f5cf450c92210f59e301a8dc7d36d80a2 [INFO] running `"docker" "start" "-a" "40451796e37e10ce07afb61ca91cbb1f5cf450c92210f59e301a8dc7d36d80a2"` [INFO] [stderr] Checking secstr v0.3.1 (/opt/crater/workdir) [INFO] [stderr] Checking serde_cbor v0.6.1 [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:20:38 [INFO] [stderr] | [INFO] [stderr] 20 | fn box_as_slice(reference: &Box) -> &[T] { [INFO] [stderr] | ^^^^^^^ help: try: `&T` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:27:49 [INFO] [stderr] | [INFO] [stderr] 27 | fn box_as_slice_mut(reference: &mut Box) -> &mut [T] { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `&mut T` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:92:42 [INFO] [stderr] | [INFO] [stderr] 92 | std::ptr::write_volatile(ptr.offset(i as isize), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:109:28 [INFO] [stderr] | [INFO] [stderr] 109 | result |= *(ptr_us.offset(i as isize)) ^ *(ptr_them.offset(i as isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr_us.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:109:59 [INFO] [stderr] | [INFO] [stderr] 109 | result |= *(ptr_us.offset(i as isize)) ^ *(ptr_them.offset(i as isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr_them.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:20:38 [INFO] [stderr] | [INFO] [stderr] 20 | fn box_as_slice(reference: &Box) -> &[T] { [INFO] [stderr] | ^^^^^^^ help: try: `&T` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:27:49 [INFO] [stderr] | [INFO] [stderr] 27 | fn box_as_slice_mut(reference: &mut Box) -> &mut [T] { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `&mut T` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:92:42 [INFO] [stderr] | [INFO] [stderr] 92 | std::ptr::write_volatile(ptr.offset(i as isize), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:109:28 [INFO] [stderr] | [INFO] [stderr] 109 | result |= *(ptr_us.offset(i as isize)) ^ *(ptr_them.offset(i as isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr_us.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:109:59 [INFO] [stderr] | [INFO] [stderr] 109 | result |= *(ptr_us.offset(i as isize)) ^ *(ptr_them.offset(i as isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr_them.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:398:37 [INFO] [stderr] | [INFO] [stderr] 398 | assert_eq!(string[0], 'h' as u8); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'h' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:399:37 [INFO] [stderr] | [INFO] [stderr] 399 | assert_eq!(&string[3 .. 5], "lo".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"lo"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> src/lib.rs:450:17 [INFO] [stderr] | [INFO] [stderr] 450 | assert!(key_1 == key_1); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `secstr`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "40451796e37e10ce07afb61ca91cbb1f5cf450c92210f59e301a8dc7d36d80a2"` [INFO] running `"docker" "rm" "-f" "40451796e37e10ce07afb61ca91cbb1f5cf450c92210f59e301a8dc7d36d80a2"` [INFO] [stdout] 40451796e37e10ce07afb61ca91cbb1f5cf450c92210f59e301a8dc7d36d80a2