[INFO] crate secp256k1-test 0.7.2 is already in cache
[INFO] extracting crate secp256k1-test 0.7.2 into work/ex/clippy-test-run/sources/stable/reg/secp256k1-test/0.7.2
[INFO] extracting crate secp256k1-test 0.7.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/secp256k1-test/0.7.2
[INFO] validating manifest of secp256k1-test-0.7.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of secp256k1-test-0.7.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing secp256k1-test-0.7.2
[INFO] finished frobbing secp256k1-test-0.7.2
[INFO] frobbed toml for secp256k1-test-0.7.2 written to work/ex/clippy-test-run/sources/stable/reg/secp256k1-test/0.7.2/Cargo.toml
[INFO] started frobbing secp256k1-test-0.7.2
[INFO] finished frobbing secp256k1-test-0.7.2
[INFO] frobbed toml for secp256k1-test-0.7.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/secp256k1-test/0.7.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting secp256k1-test-0.7.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/secp256k1-test/0.7.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c3315fd07502694bde3b719c02eda40c08f60fbc231268a4b3ebb34de95aa384
[INFO] running `"docker" "start" "-a" "c3315fd07502694bde3b719c02eda40c08f60fbc231268a4b3ebb34de95aa384"`
[INFO] [stderr]    Compiling secp256k1-test v0.7.2 (/opt/crater/workdir)
[INFO] [stderr] warning: use of deprecated item 'gcc::Config': gcc::Config has been renamed to gcc::Build
[INFO] [stderr]   --> build.rs:27:27
[INFO] [stderr]    |
[INFO] [stderr] 27 |     let mut base_config = gcc::Config::new();
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'gcc::Build::new': crate has been renamed to `cc`, the `gcc` name is not maintained
[INFO] [stderr]   --> build.rs:27:27
[INFO] [stderr]    |
[INFO] [stderr] 27 |     let mut base_config = gcc::Config::new();
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: In file included from depend/secp256k1/src/secp256k1.c:15:0:
[INFO] [stderr] warning: depend/secp256k1/src/group_impl.h:219:12: warning: 'secp256k1_gej_is_valid_var' defined but not used [-Wunused-function]
[INFO] [stderr] warning:  static int secp256k1_gej_is_valid_var(const secp256k1_gej *a) {
[INFO] [stderr] warning:             ^~~~~~~~~~~~~~~~~~~~~~~~~~
[INFO] [stderr] warning: In file included from depend/secp256k1/src/field_impl.h:17:0,
[INFO] [stderr] warning:                  from depend/secp256k1/src/secp256k1.c:13:
[INFO] [stderr] warning: depend/secp256k1/src/field_10x26_impl.h:44:13: warning: 'secp256k1_fe_verify' defined but not used [-Wunused-function]
[INFO] [stderr] warning:  static void secp256k1_fe_verify(const secp256k1_fe *a) {
[INFO] [stderr] warning:              ^~~~~~~~~~~~~~~~~~~
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:513:74
[INFO] [stderr]    --> src/lib.rs:513:74
[INFO] [stderr]     |
[INFO] [stderr]     |
[INFO] [stderr] 513 |         Secp256k1 { ctx: unsafe { ffi::secp256k1_context_create(flag) }, caps: caps }
[INFO] [stderr] 513 |         Secp256k1 { ctx: unsafe { ffi::secp256k1_context_create(flag) }, caps: caps }
[INFO] [stderr]     |                                                                          ^^^^^^^^^^ help: replace it with: `caps`
[INFO] [stderr]     |
[INFO] [stderr]     |                                                                          ^^^^^^^^^^ help: replace it with: `caps`
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr] 
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(1 << 0)`
[INFO] [stderr]   --> src/ffi.rs:25:42
[INFO] [stderr]    |
[INFO] [stderr] 25 | pub const SECP256K1_START_NONE: c_uint = (1 << 0) | 0;
[INFO] [stderr]    |                                          ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]   --> src/ffi.rs:25:42
[INFO] [stderr]    |
[INFO] [stderr] 25 | pub const SECP256K1_START_NONE: c_uint = (1 << 0) | 0;
[INFO] [stderr]    |                                          ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]   --> src/ffi.rs:27:44
[INFO] [stderr]    |
[INFO] [stderr] 27 | pub const SECP256K1_START_VERIFY: c_uint = (1 << 0) | (1 << 8);
[INFO] [stderr]    |                                            ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]   --> src/ffi.rs:29:42
[INFO] [stderr]    |
[INFO] [stderr] 29 | pub const SECP256K1_START_SIGN: c_uint = (1 << 0) | (1 << 9);
[INFO] [stderr]    |                                          ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(1 << 1)`
[INFO] [stderr]   --> src/ffi.rs:31:48
[INFO] [stderr]    |
[INFO] [stderr] 31 | pub const SECP256K1_SER_UNCOMPRESSED: c_uint = (1 << 1) | 0;
[INFO] [stderr]    |                                                ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `ffi::PublicKey`
[INFO] [stderr]   --> src/ffi.rs:65:5
[INFO] [stderr]    |
[INFO] [stderr] 65 |     pub fn new() -> PublicKey { PublicKey([0; 64]) }
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 63 | impl Default for ffi::PublicKey {
[INFO] [stderr] 64 |     fn default() -> Self {
[INFO] [stderr] 65 |         Self::new()
[INFO] [stderr] 66 |     }
[INFO] [stderr] 67 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `ffi::Signature`
[INFO] [stderr]   --> src/ffi.rs:90:5
[INFO] [stderr]    |
[INFO] [stderr] 90 |     pub fn new() -> Signature { Signature([0; 64]) }
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 88 | impl Default for ffi::Signature {
[INFO] [stderr] 89 |     fn default() -> Self {
[INFO] [stderr] 90 |         Self::new()
[INFO] [stderr] 91 |     }
[INFO] [stderr] 92 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `ffi::RecoverableSignature`
[INFO] [stderr]   --> src/ffi.rs:97:5
[INFO] [stderr]    |
[INFO] [stderr] 97 |     pub fn new() -> RecoverableSignature { RecoverableSignature([0; 65]) }
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 95 | impl Default for ffi::RecoverableSignature {
[INFO] [stderr] 96 |     fn default() -> Self {
[INFO] [stderr] 97 |         Self::new()
[INFO] [stderr] 98 |     }
[INFO] [stderr] 99 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ffi::SharedSecret`
[INFO] [stderr]    --> src/ffi.rs:110:5
[INFO] [stderr]     |
[INFO] [stderr] 110 |     pub fn new() -> SharedSecret { SharedSecret([0; 32]) }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 104 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `key::PublicKey`
[INFO] [stderr]    --> src/key.rs:126:5
[INFO] [stderr]     |
[INFO] [stderr] 126 | /     pub fn new() -> PublicKey {
[INFO] [stderr] 127 | |         PublicKey(ffi::PublicKey::new())
[INFO] [stderr] 128 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 123 | impl Default for key::PublicKey {
[INFO] [stderr] 124 |     fn default() -> Self {
[INFO] [stderr] 125 |         Self::new()
[INFO] [stderr] 126 |     }
[INFO] [stderr] 127 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `ret`
[INFO] [stderr]    --> src/key.rs:240:30
[INFO] [stderr]     |
[INFO] [stderr] 240 |                     for i in 0..len {
[INFO] [stderr]     |                              ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 240 |                     for (i, <item>) in ret.iter_mut().enumerate().take(len) {
[INFO] [stderr]     |                         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `ret`
[INFO] [stderr]    --> src/key.rs:249:30
[INFO] [stderr]     |
[INFO] [stderr] 249 |                     for i in 0..len {
[INFO] [stderr]     |                              ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 249 |                     for (i, <item>) in ret.iter_mut().enumerate().take(len) {
[INFO] [stderr]     |                         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/lib.rs:86:19
[INFO] [stderr]    |
[INFO] [stderr] 86 |     pub fn to_i32(&self) -> i32 {
[INFO] [stderr]    |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `ret`
[INFO] [stderr]    --> src/lib.rs:234:30
[INFO] [stderr]     |
[INFO] [stderr] 234 |                     for i in 0..constants::COMPACT_SIGNATURE_SIZE {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 234 |                     for (i, <item>) in ret.iter_mut().enumerate().take(constants::COMPACT_SIGNATURE_SIZE) {
[INFO] [stderr]     |                         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `Secp256k1`
[INFO] [stderr]    --> src/lib.rs:501:5
[INFO] [stderr]     |
[INFO] [stderr] 501 | /     pub fn new() -> Secp256k1 {
[INFO] [stderr] 502 | |         Secp256k1::with_caps(ContextFlag::Full)
[INFO] [stderr] 503 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 498 | impl Default for Secp256k1 {
[INFO] [stderr] 499 |     fn default() -> Self {
[INFO] [stderr] 500 |         Self::new()
[INFO] [stderr] 501 |     }
[INFO] [stderr] 502 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(1 << 0)`
[INFO] [stderr]   --> src/ffi.rs:25:42
[INFO] [stderr]    |
[INFO] [stderr] 25 | pub const SECP256K1_START_NONE: c_uint = (1 << 0) | 0;
[INFO] [stderr]    |                                          ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]   --> src/ffi.rs:25:42
[INFO] [stderr]    |
[INFO] [stderr] 25 | pub const SECP256K1_START_NONE: c_uint = (1 << 0) | 0;
[INFO] [stderr]    |                                          ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]   --> src/ffi.rs:27:44
[INFO] [stderr]    |
[INFO] [stderr] 27 | pub const SECP256K1_START_VERIFY: c_uint = (1 << 0) | (1 << 8);
[INFO] [stderr]    |                                            ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]   --> src/ffi.rs:29:42
[INFO] [stderr]    |
[INFO] [stderr] 29 | pub const SECP256K1_START_SIGN: c_uint = (1 << 0) | (1 << 9);
[INFO] [stderr]    |                                          ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(1 << 1)`
[INFO] [stderr]   --> src/ffi.rs:31:48
[INFO] [stderr]    |
[INFO] [stderr] 31 | pub const SECP256K1_SER_UNCOMPRESSED: c_uint = (1 << 1) | 0;
[INFO] [stderr]    |                                                ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `ffi::PublicKey`
[INFO] [stderr]   --> src/ffi.rs:65:5
[INFO] [stderr]    |
[INFO] [stderr] 65 |     pub fn new() -> PublicKey { PublicKey([0; 64]) }
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 63 | impl Default for ffi::PublicKey {
[INFO] [stderr] 64 |     fn default() -> Self {
[INFO] [stderr] 65 |         Self::new()
[INFO] [stderr] 66 |     }
[INFO] [stderr] 67 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `ffi::Signature`
[INFO] [stderr]   --> src/ffi.rs:90:5
[INFO] [stderr]    |
[INFO] [stderr] 90 |     pub fn new() -> Signature { Signature([0; 64]) }
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 88 | impl Default for ffi::Signature {
[INFO] [stderr] 89 |     fn default() -> Self {
[INFO] [stderr] 90 |         Self::new()
[INFO] [stderr] 91 |     }
[INFO] [stderr] 92 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `ffi::RecoverableSignature`
[INFO] [stderr]   --> src/ffi.rs:97:5
[INFO] [stderr]    |
[INFO] [stderr] 97 |     pub fn new() -> RecoverableSignature { RecoverableSignature([0; 65]) }
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 95 | impl Default for ffi::RecoverableSignature {
[INFO] [stderr] 96 |     fn default() -> Self {
[INFO] [stderr] 97 |         Self::new()
[INFO] [stderr] 98 |     }
[INFO] [stderr] 99 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ffi::SharedSecret`
[INFO] [stderr]    --> src/ffi.rs:110:5
[INFO] [stderr]     |
[INFO] [stderr] 110 |     pub fn new() -> SharedSecret { SharedSecret([0; 32]) }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 104 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `key::PublicKey`
[INFO] [stderr]    --> src/key.rs:126:5
[INFO] [stderr]     |
[INFO] [stderr] 126 | /     pub fn new() -> PublicKey {
[INFO] [stderr] 127 | |         PublicKey(ffi::PublicKey::new())
[INFO] [stderr] 128 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 123 | impl Default for key::PublicKey {
[INFO] [stderr] 124 |     fn default() -> Self {
[INFO] [stderr] 125 |         Self::new()
[INFO] [stderr] 126 |     }
[INFO] [stderr] 127 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `ret`
[INFO] [stderr]    --> src/key.rs:240:30
[INFO] [stderr]     |
[INFO] [stderr] 240 |                     for i in 0..len {
[INFO] [stderr]     |                              ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 240 |                     for (i, <item>) in ret.iter_mut().enumerate().take(len) {
[INFO] [stderr]     |                         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `ret`
[INFO] [stderr]    --> src/key.rs:249:30
[INFO] [stderr]     |
[INFO] [stderr] 249 |                     for i in 0..len {
[INFO] [stderr]     |                              ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 249 |                     for (i, <item>) in ret.iter_mut().enumerate().take(len) {
[INFO] [stderr]     |                         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/key.rs:447:22
[INFO] [stderr]     |
[INFO] [stderr] 447 |         let zero31 = "[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0]".as_bytes();
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0]"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/key.rs:449:22
[INFO] [stderr]     |
[INFO] [stderr] 449 |         let zero32 = "[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0]".as_bytes();
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0]"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/key.rs:451:22
[INFO] [stderr]     |
[INFO] [stderr] 451 |         let zero65 = "[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0]".as_bytes();
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0]"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/lib.rs:86:19
[INFO] [stderr]    |
[INFO] [stderr] 86 |     pub fn to_i32(&self) -> i32 {
[INFO] [stderr]    |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `ret`
[INFO] [stderr]    --> src/lib.rs:234:30
[INFO] [stderr]     |
[INFO] [stderr] 234 |                     for i in 0..constants::COMPACT_SIGNATURE_SIZE {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 234 |                     for (i, <item>) in ret.iter_mut().enumerate().take(constants::COMPACT_SIGNATURE_SIZE) {
[INFO] [stderr]     |                         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `Secp256k1`
[INFO] [stderr]    --> src/lib.rs:501:5
[INFO] [stderr]     |
[INFO] [stderr] 501 | /     pub fn new() -> Secp256k1 {
[INFO] [stderr] 502 | |         Secp256k1::with_caps(ContextFlag::Full)
[INFO] [stderr] 503 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 498 | impl Default for Secp256k1 {
[INFO] [stderr] 499 |     fn default() -> Self {
[INFO] [stderr] 500 |         Self::new()
[INFO] [stderr] 501 |     }
[INFO] [stderr] 502 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 27
[INFO] [stderr]    --> src/lib.rs:645:5
[INFO] [stderr]     |
[INFO] [stderr] 645 | /     fn capabilities() {
[INFO] [stderr] 646 | |         let none = Secp256k1::with_caps(ContextFlag::None);
[INFO] [stderr] 647 | |         let sign = Secp256k1::with_caps(ContextFlag::SignOnly);
[INFO] [stderr] 648 | |         let vrfy = Secp256k1::with_caps(ContextFlag::VerifyOnly);
[INFO] [stderr] ...   |
[INFO] [stderr] 697 | |         assert_eq!(pk, new_pk);
[INFO] [stderr] 698 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:703:25
[INFO] [stderr]     |
[INFO] [stderr] 703 |         assert_eq!(one, one.clone());
[INFO] [stderr]     |                         ^^^^^^^^^^^ help: try removing the `clone` call: `one`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.69s
[INFO] running `"docker" "inspect" "c3315fd07502694bde3b719c02eda40c08f60fbc231268a4b3ebb34de95aa384"`
[INFO] running `"docker" "rm" "-f" "c3315fd07502694bde3b719c02eda40c08f60fbc231268a4b3ebb34de95aa384"`
[INFO] [stdout] c3315fd07502694bde3b719c02eda40c08f60fbc231268a4b3ebb34de95aa384