[INFO] crate secp256k1 0.12.0 is already in cache
[INFO] extracting crate secp256k1 0.12.0 into work/ex/clippy-test-run/sources/stable/reg/secp256k1/0.12.0
[INFO] extracting crate secp256k1 0.12.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/secp256k1/0.12.0
[INFO] validating manifest of secp256k1-0.12.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of secp256k1-0.12.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing secp256k1-0.12.0
[INFO] finished frobbing secp256k1-0.12.0
[INFO] frobbed toml for secp256k1-0.12.0 written to work/ex/clippy-test-run/sources/stable/reg/secp256k1/0.12.0/Cargo.toml
[INFO] started frobbing secp256k1-0.12.0
[INFO] finished frobbing secp256k1-0.12.0
[INFO] frobbed toml for secp256k1-0.12.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/secp256k1/0.12.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting secp256k1-0.12.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/secp256k1/0.12.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 88b1705d7a2d7003746b7ccd36d6489b5f0bc499bb898affa4c1a8ca9c8a55b9
[INFO] running `"docker" "start" "-a" "88b1705d7a2d7003746b7ccd36d6489b5f0bc499bb898affa4c1a8ca9c8a55b9"`
[INFO] [stderr]    Compiling secp256k1 v0.12.0 (/opt/crater/workdir)
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(1 << 0)`
[INFO] [stderr]   --> src/ffi.rs:25:42
[INFO] [stderr]    |
[INFO] [stderr] 25 | pub const SECP256K1_START_NONE: c_uint = (1 << 0) | 0;
[INFO] [stderr]    |                                          ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]   --> src/ffi.rs:25:42
[INFO] [stderr]    |
[INFO] [stderr] 25 | pub const SECP256K1_START_NONE: c_uint = (1 << 0) | 0;
[INFO] [stderr]    |                                          ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]   --> src/ffi.rs:27:44
[INFO] [stderr]    |
[INFO] [stderr] 27 | pub const SECP256K1_START_VERIFY: c_uint = (1 << 0) | (1 << 8);
[INFO] [stderr]    |                                            ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]   --> src/ffi.rs:29:42
[INFO] [stderr]    |
[INFO] [stderr] 29 | pub const SECP256K1_START_SIGN: c_uint = (1 << 0) | (1 << 9);
[INFO] [stderr]    |                                          ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(1 << 1)`
[INFO] [stderr]   --> src/ffi.rs:31:48
[INFO] [stderr]    |
[INFO] [stderr] 31 | pub const SECP256K1_SER_UNCOMPRESSED: c_uint = (1 << 1) | 0;
[INFO] [stderr]    |                                                ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `ffi::PublicKey`
[INFO] [stderr]   --> src/ffi.rs:73:5
[INFO] [stderr]    |
[INFO] [stderr] 73 |     pub fn new() -> PublicKey { PublicKey([0; 64]) }
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 71 | impl Default for ffi::PublicKey {
[INFO] [stderr] 72 |     fn default() -> Self {
[INFO] [stderr] 73 |         Self::new()
[INFO] [stderr] 74 |     }
[INFO] [stderr] 75 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `ffi::Signature`
[INFO] [stderr]   --> src/ffi.rs:98:5
[INFO] [stderr]    |
[INFO] [stderr] 98 |     pub fn new() -> Signature { Signature([0; 64]) }
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 96 | impl Default for ffi::Signature {
[INFO] [stderr] 97 |     fn default() -> Self {
[INFO] [stderr] 98 |         Self::new()
[INFO] [stderr] 99 |     }
[INFO] [stderr] 100| }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `ffi::RecoverableSignature`
[INFO] [stderr]    --> src/ffi.rs:105:5
[INFO] [stderr]     |
[INFO] [stderr] 105 |     pub fn new() -> RecoverableSignature { RecoverableSignature([0; 65]) }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 103 | impl Default for ffi::RecoverableSignature {
[INFO] [stderr] 104 |     fn default() -> Self {
[INFO] [stderr] 105 |         Self::new()
[INFO] [stderr] 106 |     }
[INFO] [stderr] 107 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ffi::SharedSecret`
[INFO] [stderr]    --> src/ffi.rs:118:5
[INFO] [stderr]     |
[INFO] [stderr] 118 |     pub fn new() -> SharedSecret { SharedSecret([0; 32]) }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 112 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:228:15
[INFO] [stderr]     |
[INFO] [stderr] 228 | pub fn to_i32(&self) -> i32 {
[INFO] [stderr]     |               ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]    --> src/lib.rs:479:12
[INFO] [stderr]     |
[INFO] [stderr] 479 |         if data == &[0; constants::MESSAGE_SIZE] {
[INFO] [stderr]     |            ^^^^^^^^-----------------------------
[INFO] [stderr]     |                    |
[INFO] [stderr]     |                    help: use the right value directly: `[0; constants::MESSAGE_SIZE]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `Secp256k1<All>`
[INFO] [stderr]    --> src/lib.rs:617:5
[INFO] [stderr]     |
[INFO] [stderr] 617 | /     pub fn new() -> Secp256k1<All> {
[INFO] [stderr] 618 | |         Secp256k1 { ctx: unsafe { ffi::secp256k1_context_create(ffi::SECP256K1_START_SIGN | ffi::SECP256K1_START_VERIFY) }, phantom: PhantomData }
[INFO] [stderr] 619 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 615 | impl Default for Secp256k1<All> {
[INFO] [stderr] 616 |     fn default() -> Self {
[INFO] [stderr] 617 |         Self::new()
[INFO] [stderr] 618 |     }
[INFO] [stderr] 619 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(1 << 0)`
[INFO] [stderr]   --> src/ffi.rs:25:42
[INFO] [stderr]    |
[INFO] [stderr] 25 | pub const SECP256K1_START_NONE: c_uint = (1 << 0) | 0;
[INFO] [stderr]    |                                          ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]   --> src/ffi.rs:25:42
[INFO] [stderr]    |
[INFO] [stderr] 25 | pub const SECP256K1_START_NONE: c_uint = (1 << 0) | 0;
[INFO] [stderr]    |                                          ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]   --> src/ffi.rs:27:44
[INFO] [stderr]    |
[INFO] [stderr] 27 | pub const SECP256K1_START_VERIFY: c_uint = (1 << 0) | (1 << 8);
[INFO] [stderr]    |                                            ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]   --> src/ffi.rs:29:42
[INFO] [stderr]    |
[INFO] [stderr] 29 | pub const SECP256K1_START_SIGN: c_uint = (1 << 0) | (1 << 9);
[INFO] [stderr]    |                                          ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(1 << 1)`
[INFO] [stderr]   --> src/ffi.rs:31:48
[INFO] [stderr]    |
[INFO] [stderr] 31 | pub const SECP256K1_SER_UNCOMPRESSED: c_uint = (1 << 1) | 0;
[INFO] [stderr]    |                                                ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `ffi::PublicKey`
[INFO] [stderr]   --> src/ffi.rs:73:5
[INFO] [stderr]    |
[INFO] [stderr] 73 |     pub fn new() -> PublicKey { PublicKey([0; 64]) }
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 71 | impl Default for ffi::PublicKey {
[INFO] [stderr] 72 |     fn default() -> Self {
[INFO] [stderr] 73 |         Self::new()
[INFO] [stderr] 74 |     }
[INFO] [stderr] 75 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `ffi::Signature`
[INFO] [stderr]   --> src/ffi.rs:98:5
[INFO] [stderr]    |
[INFO] [stderr] 98 |     pub fn new() -> Signature { Signature([0; 64]) }
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 96 | impl Default for ffi::Signature {
[INFO] [stderr] 97 |     fn default() -> Self {
[INFO] [stderr] 98 |         Self::new()
[INFO] [stderr] 99 |     }
[INFO] [stderr] 100| }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `ffi::RecoverableSignature`
[INFO] [stderr]    --> src/ffi.rs:105:5
[INFO] [stderr]     |
[INFO] [stderr] 105 |     pub fn new() -> RecoverableSignature { RecoverableSignature([0; 65]) }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 103 | impl Default for ffi::RecoverableSignature {
[INFO] [stderr] 104 |     fn default() -> Self {
[INFO] [stderr] 105 |         Self::new()
[INFO] [stderr] 106 |     }
[INFO] [stderr] 107 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ffi::SharedSecret`
[INFO] [stderr]    --> src/ffi.rs:118:5
[INFO] [stderr]     |
[INFO] [stderr] 118 |     pub fn new() -> SharedSecret { SharedSecret([0; 32]) }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 112 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/key.rs:691:19
[INFO] [stderr]     |
[INFO] [stderr] 691 |         let pk2 = pk1.clone();
[INFO] [stderr]     |                   ^^^^^^^^^^^ help: try removing the `clone` call: `pk1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:228:15
[INFO] [stderr]     |
[INFO] [stderr] 228 | pub fn to_i32(&self) -> i32 {
[INFO] [stderr]     |               ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]    --> src/lib.rs:479:12
[INFO] [stderr]     |
[INFO] [stderr] 479 |         if data == &[0; constants::MESSAGE_SIZE] {
[INFO] [stderr]     |            ^^^^^^^^-----------------------------
[INFO] [stderr]     |                    |
[INFO] [stderr]     |                    help: use the right value directly: `[0; constants::MESSAGE_SIZE]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `Secp256k1<All>`
[INFO] [stderr]    --> src/lib.rs:617:5
[INFO] [stderr]     |
[INFO] [stderr] 617 | /     pub fn new() -> Secp256k1<All> {
[INFO] [stderr] 618 | |         Secp256k1 { ctx: unsafe { ffi::secp256k1_context_create(ffi::SECP256K1_START_SIGN | ffi::SECP256K1_START_VERIFY) }, phantom: PhantomData }
[INFO] [stderr] 619 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 615 | impl Default for Secp256k1<All> {
[INFO] [stderr] 616 |     fn default() -> Self {
[INFO] [stderr] 617 |         Self::new()
[INFO] [stderr] 618 |     }
[INFO] [stderr] 619 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:843:25
[INFO] [stderr]     |
[INFO] [stderr] 843 |         assert_eq!(one, one.clone());
[INFO] [stderr]     |                         ^^^^^^^^^^^ help: try removing the `clone` call: `one`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.29s
[INFO] running `"docker" "inspect" "88b1705d7a2d7003746b7ccd36d6489b5f0bc499bb898affa4c1a8ca9c8a55b9"`
[INFO] running `"docker" "rm" "-f" "88b1705d7a2d7003746b7ccd36d6489b5f0bc499bb898affa4c1a8ca9c8a55b9"`
[INFO] [stdout] 88b1705d7a2d7003746b7ccd36d6489b5f0bc499bb898affa4c1a8ca9c8a55b9