[INFO] crate second_order_ode 0.1.0 is already in cache [INFO] extracting crate second_order_ode 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/second_order_ode/0.1.0 [INFO] extracting crate second_order_ode 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/second_order_ode/0.1.0 [INFO] validating manifest of second_order_ode-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of second_order_ode-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing second_order_ode-0.1.0 [INFO] finished frobbing second_order_ode-0.1.0 [INFO] frobbed toml for second_order_ode-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/second_order_ode/0.1.0/Cargo.toml [INFO] started frobbing second_order_ode-0.1.0 [INFO] finished frobbing second_order_ode-0.1.0 [INFO] frobbed toml for second_order_ode-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/second_order_ode/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting second_order_ode-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/second_order_ode/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3d557260be100e77acd8283e3b3242b92c3936957a6ac2e66b2abe590f321539 [INFO] running `"docker" "start" "-a" "3d557260be100e77acd8283e3b3242b92c3936957a6ac2e66b2abe590f321539"` [INFO] [stderr] Checking second_order_ode v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking approx v0.2.1 [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:14:21 [INFO] [stderr] | [INFO] [stderr] 14 | fn thomas_algorithm<'a, Id>( [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | solve_v[index]=solve_v[index]-cprime*solve_v[index+1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `solve_v[index] -= cprime*solve_v[index+1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:60:1 [INFO] [stderr] | [INFO] [stderr] 60 | / pub fn solve_ode( [INFO] [stderr] 61 | | second_deriv_coef:&Fn(f64)->f64, [INFO] [stderr] 62 | | first_deriv_coef:&Fn(f64)->f64, [INFO] [stderr] 63 | | fn_coef:&Fn(f64)->f64, [INFO] [stderr] ... | [INFO] [stderr] 112 | | [INFO] [stderr] 113 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:85:14 [INFO] [stderr] | [INFO] [stderr] 85 | let diag=(1..num_steps+1).map(|index|{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `(1..=num_steps)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:125:14 [INFO] [stderr] | [INFO] [stderr] 125 | -1.5714286, [INFO] [stderr] | ^^^^^^^^^ help: consider: `1.571_428_6` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | 0.8571429, [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.857_142_9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:127:14 [INFO] [stderr] | [INFO] [stderr] 127 | -1.0714286 [INFO] [stderr] | ^^^^^^^^^ help: consider: `1.071_428_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:131:50 [INFO] [stderr] | [INFO] [stderr] 131 | assert_abs_diff_eq!(res, ex, epsilon=0.000001); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:14:21 [INFO] [stderr] | [INFO] [stderr] 14 | fn thomas_algorithm<'a, Id>( [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | solve_v[index]=solve_v[index]-cprime*solve_v[index+1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `solve_v[index] -= cprime*solve_v[index+1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:60:1 [INFO] [stderr] | [INFO] [stderr] 60 | / pub fn solve_ode( [INFO] [stderr] 61 | | second_deriv_coef:&Fn(f64)->f64, [INFO] [stderr] 62 | | first_deriv_coef:&Fn(f64)->f64, [INFO] [stderr] 63 | | fn_coef:&Fn(f64)->f64, [INFO] [stderr] ... | [INFO] [stderr] 112 | | [INFO] [stderr] 113 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:85:14 [INFO] [stderr] | [INFO] [stderr] 85 | let diag=(1..num_steps+1).map(|index|{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `(1..=num_steps)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:129:37 [INFO] [stderr] | [INFO] [stderr] 129 | let result=thomas_algorithm(diag.iter().map(|v|*v)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `diag.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.53s [INFO] running `"docker" "inspect" "3d557260be100e77acd8283e3b3242b92c3936957a6ac2e66b2abe590f321539"` [INFO] running `"docker" "rm" "-f" "3d557260be100e77acd8283e3b3242b92c3936957a6ac2e66b2abe590f321539"` [INFO] [stdout] 3d557260be100e77acd8283e3b3242b92c3936957a6ac2e66b2abe590f321539