[INFO] crate sdoc 0.8.3 is already in cache [INFO] extracting crate sdoc 0.8.3 into work/ex/clippy-test-run/sources/stable/reg/sdoc/0.8.3 [INFO] extracting crate sdoc 0.8.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sdoc/0.8.3 [INFO] validating manifest of sdoc-0.8.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sdoc-0.8.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sdoc-0.8.3 [INFO] finished frobbing sdoc-0.8.3 [INFO] frobbed toml for sdoc-0.8.3 written to work/ex/clippy-test-run/sources/stable/reg/sdoc/0.8.3/Cargo.toml [INFO] started frobbing sdoc-0.8.3 [INFO] finished frobbing sdoc-0.8.3 [INFO] frobbed toml for sdoc-0.8.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sdoc/0.8.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sdoc-0.8.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sdoc/0.8.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fcd94345220e1ddaba6bbe6a791ed9faf8a9575df7a28d45023cce11575d47db [INFO] running `"docker" "start" "-a" "fcd94345220e1ddaba6bbe6a791ed9faf8a9575df7a28d45023cce11575d47db"` [INFO] [stderr] Checking sdoc v0.8.3 (/opt/crater/workdir) [INFO] [stderr] Compiling assert_cli v0.5.4 [INFO] [stderr] Checking tempfile v3.0.5 [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/commands/edit.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | let s = format!("{}", context.get_commands().iter() [INFO] [stderr] | _________________________^ [INFO] [stderr] 32 | | .filter(|c| { [INFO] [stderr] 33 | | if let Some(ref a) = c.value { [INFO] [stderr] 34 | | if let Value::Script(_) = *a { [INFO] [stderr] ... | [INFO] [stderr] 39 | | }) [INFO] [stderr] 40 | | .fold(s!(), |a, b| format!("{}{}\n", a, &b.name))); [INFO] [stderr] | |______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 2 | $ crate :: fmt :: format ( context.get_commands().iter() [INFO] [stderr] 3 | .filter(|c| { [INFO] [stderr] 4 | if let Some(ref a) = c.value { [INFO] [stderr] 5 | if let Value::Script(_) = *a { [INFO] [stderr] 6 | return true; [INFO] [stderr] 7 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/commands/help.rs:56:35 [INFO] [stderr] | [INFO] [stderr] 56 | fn format_help(resolved_commands: &Vec, sections: &Vec<&Section>) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/commands/help.rs:56:59 [INFO] [stderr] | [INFO] [stderr] 56 | fn format_help(resolved_commands: &Vec, sections: &Vec<&Section>) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[&Section]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/commands/init.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | fn ask(question: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/commands/init.rs:63:16 [INFO] [stderr] | [INFO] [stderr] 63 | if v.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/commands/init.rs:93:10 [INFO] [stderr] | [INFO] [stderr] 93 | .unwrap_or(env::current_dir().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| env::current_dir().unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/commands/shell.rs:5:29 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn execute_shell(shell: &String, args: &[String], directory: &PathBuf) -> Work { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/commands/view.rs:23:37 [INFO] [stderr] | [INFO] [stderr] 23 | Display(format!("{}", content), Response::Ok) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `content.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/commands/view.rs:25:56 [INFO] [stderr] | [INFO] [stderr] 25 | Value::Shell(ref b) => Display(format!("{}", b), Response::Ok), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `b.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/commands/view.rs:41:25 [INFO] [stderr] | [INFO] [stderr] 41 | let s = format!("{}", context.get_commands().iter() [INFO] [stderr] | _________________________^ [INFO] [stderr] 42 | | .filter(|c| { [INFO] [stderr] 43 | | if let Some(ref a) = c.value { [INFO] [stderr] 44 | | return match *a { [INFO] [stderr] ... | [INFO] [stderr] 51 | | }) [INFO] [stderr] 52 | | .fold(s!(), |a, b| format!("{}{}\n", a, &b.name))); [INFO] [stderr] | |______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 2 | $ crate :: fmt :: format ( context.get_commands().iter() [INFO] [stderr] 3 | .filter(|c| { [INFO] [stderr] 4 | if let Some(ref a) = c.value { [INFO] [stderr] 5 | return match *a { [INFO] [stderr] 6 | Value::Script(_) => true, [INFO] [stderr] 7 | Value::Shell(_) => true, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/model/mod.rs:47:46 [INFO] [stderr] | [INFO] [stderr] 47 | fn matches_alias(&self, request_command: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/model/mod.rs:51:48 [INFO] [stderr] | [INFO] [stderr] 51 | fn matches_command(&self, request_command: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/model/mod.rs:55:44 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn matches(&self, request_command: &String, match_alias: bool) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/model/mod.rs:59:48 [INFO] [stderr] | [INFO] [stderr] 59 | fn dependency_checks(&self, command_chain: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/model/mod.rs:75:57 [INFO] [stderr] | [INFO] [stderr] 75 | fn build_command_usage_action(&self, command_chain: &String, response: Response) -> Instruction { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/model/mod.rs:79:54 [INFO] [stderr] | [INFO] [stderr] 79 | pub fn build_command_usage(&self, command_chain: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/model/mod.rs:80:28 [INFO] [stderr] | [INFO] [stderr] 80 | let dependencies = self.dependencies.as_ref() [INFO] [stderr] | ____________________________^ [INFO] [stderr] 81 | | .map(|d| [INFO] [stderr] 82 | | format!("\nDependencies:{}\n", [INFO] [stderr] 83 | | d.iter().fold(s!(), |a, b| { [INFO] [stderr] ... | [INFO] [stderr] 90 | | }))) [INFO] [stderr] 91 | | .unwrap_or(s!()); [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 80 | let dependencies = self.dependencies.as_ref() [INFO] [stderr] 81 | .map(|d| [INFO] [stderr] 82 | format!("\nDependencies:{}\n", [INFO] [stderr] 83 | d.iter().fold(s!(), |a, b| { [INFO] [stderr] 84 | let dep_value = match b.value { [INFO] [stderr] 85 | DependencyType::Envar(ref c) => c, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/model/mod.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | self.usage.as_ref().map(|u| format!(" {}", u)).unwrap_or(s!()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.usage.as_ref().map(|u| format!(" {}", u)).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/config/mod.rs:28:41 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn find(&self, request_command: &String, match_alias: bool) -> Option<&Command> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/config/mod.rs:38:41 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn next(&self, request_command: &String) -> Context { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/dto/mod.rs:14:22 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn new(args: &Vec, completed: Option) -> Request { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/dto/mod.rs:22:64 [INFO] [stderr] | [INFO] [stderr] 22 | fn build(shift: usize, completed: Option, all_args: &Vec) -> Request { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/dto/mod.rs:24:12 [INFO] [stderr] | [INFO] [stderr] 24 | if u - shift <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using u - shift == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/util/mod.rs:7:36 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn run_system_command(command: &String, output: bool) -> Response { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/util/mod.rs:12:45 [INFO] [stderr] | [INFO] [stderr] 12 | fn _run_system_command_with_output(command: &String, stdio: Stdio) -> Response { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/workflow/mod.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | .unwrap_or(Response::Err(error)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Response::Err(error))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cli.rs:24:24 [INFO] [stderr] | [INFO] [stderr] 24 | fn build_request(args: &Vec) -> Request { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `sdoc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "fcd94345220e1ddaba6bbe6a791ed9faf8a9575df7a28d45023cce11575d47db"` [INFO] running `"docker" "rm" "-f" "fcd94345220e1ddaba6bbe6a791ed9faf8a9575df7a28d45023cce11575d47db"` [INFO] [stdout] fcd94345220e1ddaba6bbe6a791ed9faf8a9575df7a28d45023cce11575d47db