[INFO] crate sdl2-extras 0.1.4 is already in cache [INFO] extracting crate sdl2-extras 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/sdl2-extras/0.1.4 [INFO] extracting crate sdl2-extras 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sdl2-extras/0.1.4 [INFO] validating manifest of sdl2-extras-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sdl2-extras-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sdl2-extras-0.1.4 [INFO] finished frobbing sdl2-extras-0.1.4 [INFO] frobbed toml for sdl2-extras-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/sdl2-extras/0.1.4/Cargo.toml [INFO] started frobbing sdl2-extras-0.1.4 [INFO] finished frobbing sdl2-extras-0.1.4 [INFO] frobbed toml for sdl2-extras-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sdl2-extras/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sdl2-extras-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sdl2-extras/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6e2eb012651621a094590dd16302a9b88145fc68813b90c7a9fe7f085dc7d8cb [INFO] running `"docker" "start" "-a" "6e2eb012651621a094590dd16302a9b88145fc68813b90c7a9fe7f085dc7d8cb"` [INFO] [stderr] Checking floating-duration v0.1.2 [INFO] [stderr] Checking sdl2 v0.31.0 [INFO] [stderr] Checking sdl2-extras v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/adapters/canvas_adapter.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | canvas: canvas [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `canvas` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/managers/resource_manager.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | loader: loader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `loader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/adapters/canvas_adapter.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | canvas: canvas [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `canvas` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/managers/resource_manager.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | loader: loader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `loader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/adapters/canvas_adapter.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return self.canvas.as_mut(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.canvas.as_mut()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/adapters/canvas_adapter.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return self.canvas.as_mut(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.canvas.as_mut()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.88s [INFO] running `"docker" "inspect" "6e2eb012651621a094590dd16302a9b88145fc68813b90c7a9fe7f085dc7d8cb"` [INFO] running `"docker" "rm" "-f" "6e2eb012651621a094590dd16302a9b88145fc68813b90c7a9fe7f085dc7d8cb"` [INFO] [stdout] 6e2eb012651621a094590dd16302a9b88145fc68813b90c7a9fe7f085dc7d8cb