[INFO] crate scuttlebutt 0.2.0 is already in cache [INFO] extracting crate scuttlebutt 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/scuttlebutt/0.2.0 [INFO] extracting crate scuttlebutt 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/scuttlebutt/0.2.0 [INFO] validating manifest of scuttlebutt-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of scuttlebutt-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing scuttlebutt-0.2.0 [INFO] finished frobbing scuttlebutt-0.2.0 [INFO] frobbed toml for scuttlebutt-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/scuttlebutt/0.2.0/Cargo.toml [INFO] started frobbing scuttlebutt-0.2.0 [INFO] finished frobbing scuttlebutt-0.2.0 [INFO] frobbed toml for scuttlebutt-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/scuttlebutt/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting scuttlebutt-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/scuttlebutt/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 08089bbc919c517427b23da71dc57c35ba99333e6f4359b4949b5c2e6aa6e7f4 [INFO] running `"docker" "start" "-a" "08089bbc919c517427b23da71dc57c35ba99333e6f4359b4949b5c2e6aa6e7f4"` [INFO] [stderr] Checking scuttlebutt v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:165:22 [INFO] [stderr] | [INFO] [stderr] 165 | const DEFAULT_HOST: &'static str = "http://localhost:8001"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:165:22 [INFO] [stderr] | [INFO] [stderr] 165 | const DEFAULT_HOST: &'static str = "http://localhost:8001"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Cluster` [INFO] [stderr] --> src/lib.rs:221:5 [INFO] [stderr] | [INFO] [stderr] 221 | / pub fn new() -> Cluster { [INFO] [stderr] 222 | | Cluster { host: Url::parse(DEFAULT_HOST).unwrap() } [INFO] [stderr] 223 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 220 | impl Default for Cluster { [INFO] [stderr] 221 | fn default() -> Self { [INFO] [stderr] 222 | Self::new() [INFO] [stderr] 223 | } [INFO] [stderr] 224 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Cluster` [INFO] [stderr] --> src/lib.rs:221:5 [INFO] [stderr] | [INFO] [stderr] 221 | / pub fn new() -> Cluster { [INFO] [stderr] 222 | | Cluster { host: Url::parse(DEFAULT_HOST).unwrap() } [INFO] [stderr] 223 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 220 | impl Default for Cluster { [INFO] [stderr] 221 | fn default() -> Self { [INFO] [stderr] 222 | Self::new() [INFO] [stderr] 223 | } [INFO] [stderr] 224 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:245:61 [INFO] [stderr] | [INFO] [stderr] 245 | self.generator(self.bytes().into_iter().map(|b| Ok(b))) [INFO] [stderr] | ^^^^^^^^^ help: remove closure as shown: `Ok` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:245:32 [INFO] [stderr] | [INFO] [stderr] 245 | self.generator(self.bytes().into_iter().map(|b| Ok(b))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `self.bytes()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.04s [INFO] running `"docker" "inspect" "08089bbc919c517427b23da71dc57c35ba99333e6f4359b4949b5c2e6aa6e7f4"` [INFO] running `"docker" "rm" "-f" "08089bbc919c517427b23da71dc57c35ba99333e6f4359b4949b5c2e6aa6e7f4"` [INFO] [stdout] 08089bbc919c517427b23da71dc57c35ba99333e6f4359b4949b5c2e6aa6e7f4