[INFO] crate scule 1.0.0 is already in cache
[INFO] extracting crate scule 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/scule/1.0.0
[INFO] extracting crate scule 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/scule/1.0.0
[INFO] validating manifest of scule-1.0.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of scule-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing scule-1.0.0
[INFO] finished frobbing scule-1.0.0
[INFO] frobbed toml for scule-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/scule/1.0.0/Cargo.toml
[INFO] started frobbing scule-1.0.0
[INFO] finished frobbing scule-1.0.0
[INFO] frobbed toml for scule-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/scule/1.0.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting scule-1.0.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/scule/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b0e568131a2ee1e7786fc512936409e69cee82f50d274ee5d57457e80a337977
[INFO] running `"docker" "start" "-a" "b0e568131a2ee1e7786fc512936409e69cee82f50d274ee5d57457e80a337977"`
[INFO] [stderr]     Checking docopt v0.6.86
[INFO] [stderr]     Checking scule v1.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:14:15
[INFO] [stderr]    |
[INFO] [stderr] 14 | const USAGE: &'static str = "
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:39:25
[INFO] [stderr]    |
[INFO] [stderr] 39 |         const VERSION: &'static str = env!("CARGO_PKG_VERSION");
[INFO] [stderr]    |                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:82:5
[INFO] [stderr]    |
[INFO] [stderr] 82 |     return false;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:93:9
[INFO] [stderr]    |
[INFO] [stderr] 93 |         return string.to_lowercase();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `string.to_lowercase()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:96:9
[INFO] [stderr]    |
[INFO] [stderr] 96 |         return string.to_uppercase();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `string.to_uppercase()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:107:5
[INFO] [stderr]     |
[INFO] [stderr] 107 | /     return match reader.read_to_end(&mut bytes) {
[INFO] [stderr] 108 | |         Ok(x) => bytes, 
[INFO] [stderr] 109 | |         Err(_) => panic!("Failed to read the file!"),
[INFO] [stderr] 110 | |     };
[INFO] [stderr]     | |______^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 107 |     match reader.read_to_end(&mut bytes) {
[INFO] [stderr] 108 |         Ok(x) => bytes, 
[INFO] [stderr] 109 |         Err(_) => panic!("Failed to read the file!"),
[INFO] [stderr] 110 |     }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::process::Command`
[INFO] [stderr]    --> src/main.rs:115:9
[INFO] [stderr]     |
[INFO] [stderr] 115 |     use std::process::Command; 
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::str`
[INFO] [stderr]    --> src/main.rs:116:9
[INFO] [stderr]     |
[INFO] [stderr] 116 |     use std::str; 
[INFO] [stderr]     |         ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/main.rs:154:25
[INFO] [stderr]     |
[INFO] [stderr] 154 |         assert_eq!(sum, 1603466);
[INFO] [stderr]     |                         ^^^^^^^ help: consider: `1_603_466`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `err`
[INFO] [stderr]   --> src/main.rs:89:13
[INFO] [stderr]    |
[INFO] [stderr] 89 |         Err(err) => "",
[INFO] [stderr]    |             ^^^ help: consider using `_err` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `x`
[INFO] [stderr]    --> src/main.rs:108:12
[INFO] [stderr]     |
[INFO] [stderr] 108 |         Ok(x) => bytes, 
[INFO] [stderr]     |            ^ help: consider using `_x` instead
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/main.rs:44:5
[INFO] [stderr]    |
[INFO] [stderr] 44 | /     let mut upperCase = false;
[INFO] [stderr] 45 | |
[INFO] [stderr] 46 | |     if args.flag_upper {
[INFO] [stderr] 47 | |         upperCase = true;
[INFO] [stderr] 48 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let <mut> upperCase = if args.flag_upper { true } else { false };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:58:8
[INFO] [stderr]    |
[INFO] [stderr] 58 |     if filename.len() == 0 { 
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `filename.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]    --> src/main.rs:103:9
[INFO] [stderr]     |
[INFO] [stderr] 103 |         Err(_) => panic!("Failed to open the file!"),
[INFO] [stderr]     |         ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_wild_err_arm)] on by default
[INFO] [stderr]     = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]    --> src/main.rs:109:9
[INFO] [stderr]     |
[INFO] [stderr] 109 |         Err(_) => panic!("Failed to read the file!"),
[INFO] [stderr]     |         ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:152:20
[INFO] [stderr]     |
[INFO] [stderr] 152 |             sum += byte as u32;
[INFO] [stderr]     |                    ^^^^^^^^^^^ help: try: `u32::from(byte)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:14:15
[INFO] [stderr]    |
[INFO] [stderr] 14 | const USAGE: &'static str = "
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:39:25
[INFO] [stderr]    |
[INFO] [stderr] 39 |         const VERSION: &'static str = env!("CARGO_PKG_VERSION");
[INFO] [stderr]    |                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:82:5
[INFO] [stderr]    |
[INFO] [stderr] 82 |     return false;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:93:9
[INFO] [stderr]    |
[INFO] [stderr] 93 |         return string.to_lowercase();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `string.to_lowercase()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:96:9
[INFO] [stderr]    |
[INFO] [stderr] 96 |         return string.to_uppercase();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `string.to_uppercase()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:107:5
[INFO] [stderr]     |
[INFO] [stderr] 107 | /     return match reader.read_to_end(&mut bytes) {
[INFO] [stderr] 108 | |         Ok(x) => bytes, 
[INFO] [stderr] 109 | |         Err(_) => panic!("Failed to read the file!"),
[INFO] [stderr] 110 | |     };
[INFO] [stderr]     | |______^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 107 |     match reader.read_to_end(&mut bytes) {
[INFO] [stderr] 108 |         Ok(x) => bytes, 
[INFO] [stderr] 109 |         Err(_) => panic!("Failed to read the file!"),
[INFO] [stderr] 110 |     }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `err`
[INFO] [stderr]   --> src/main.rs:89:13
[INFO] [stderr]    |
[INFO] [stderr] 89 |         Err(err) => "",
[INFO] [stderr]    |             ^^^ help: consider using `_err` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `x`
[INFO] [stderr]    --> src/main.rs:108:12
[INFO] [stderr]     |
[INFO] [stderr] 108 |         Ok(x) => bytes, 
[INFO] [stderr]     |            ^ help: consider using `_x` instead
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/main.rs:44:5
[INFO] [stderr]    |
[INFO] [stderr] 44 | /     let mut upperCase = false;
[INFO] [stderr] 45 | |
[INFO] [stderr] 46 | |     if args.flag_upper {
[INFO] [stderr] 47 | |         upperCase = true;
[INFO] [stderr] 48 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let <mut> upperCase = if args.flag_upper { true } else { false };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:58:8
[INFO] [stderr]    |
[INFO] [stderr] 58 |     if filename.len() == 0 { 
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `filename.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]    --> src/main.rs:103:9
[INFO] [stderr]     |
[INFO] [stderr] 103 |         Err(_) => panic!("Failed to open the file!"),
[INFO] [stderr]     |         ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_wild_err_arm)] on by default
[INFO] [stderr]     = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]    --> src/main.rs:109:9
[INFO] [stderr]     |
[INFO] [stderr] 109 |         Err(_) => panic!("Failed to read the file!"),
[INFO] [stderr]     |         ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.46s
[INFO] running `"docker" "inspect" "b0e568131a2ee1e7786fc512936409e69cee82f50d274ee5d57457e80a337977"`
[INFO] running `"docker" "rm" "-f" "b0e568131a2ee1e7786fc512936409e69cee82f50d274ee5d57457e80a337977"`
[INFO] [stdout] b0e568131a2ee1e7786fc512936409e69cee82f50d274ee5d57457e80a337977