[INFO] crate scrypt 0.2.0 is already in cache [INFO] extracting crate scrypt 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/scrypt/0.2.0 [INFO] extracting crate scrypt 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/scrypt/0.2.0 [INFO] validating manifest of scrypt-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of scrypt-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing scrypt-0.2.0 [INFO] finished frobbing scrypt-0.2.0 [INFO] frobbed toml for scrypt-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/scrypt/0.2.0/Cargo.toml [INFO] started frobbing scrypt-0.2.0 [INFO] finished frobbing scrypt-0.2.0 [INFO] frobbed toml for scrypt-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/scrypt/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting scrypt-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/scrypt/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 69f009f1459e45de27a67c1947413095c928f3cc87b8ed7e0bee6388fe77809a [INFO] running `"docker" "start" "-a" "69f009f1459e45de27a67c1947413095c928f3cc87b8ed7e0bee6388fe77809a"` [INFO] [stderr] Checking digest v0.8.0 [INFO] [stderr] Checking pbkdf2 v0.3.0 [INFO] [stderr] Checking hmac v0.7.0 [INFO] [stderr] Checking sha2 v0.8.0 [INFO] [stderr] Checking scrypt v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/romix.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | let j = integerify(b, n); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/romix.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | let j = integerify(b, n); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/params.rs:60:22 [INFO] [stderr] | [INFO] [stderr] 60 | if !(r * p < 0x40000000) { Err(InvalidParams)?; } [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/romix.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/romix.rs:98:22 [INFO] [stderr] | [INFO] [stderr] 98 | let result = (LittleEndian::read_u32(&x[x.len() - 64..x.len() - 60]) as usize) & mask; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:83:51 [INFO] [stderr] | [INFO] [stderr] 83 | if !(output.len() > 0 && output.len() / 32 <= 0xffffffff) { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/params.rs:60:22 [INFO] [stderr] | [INFO] [stderr] 60 | if !(r * p < 0x40000000) { Err(InvalidParams)?; } [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/romix.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/romix.rs:98:22 [INFO] [stderr] | [INFO] [stderr] 98 | let result = (LittleEndian::read_u32(&x[x.len() - 64..x.len() - 60]) as usize) & mask; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:83:51 [INFO] [stderr] | [INFO] [stderr] 83 | if !(output.len() > 0 && output.len() / 32 <= 0xffffffff) { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/params.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | if !((log_n as usize) < r * 16) { Err(InvalidParams)?; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(log_n as usize) >= r * 16` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/params.rs:60:12 [INFO] [stderr] | [INFO] [stderr] 60 | if !(r * p < 0x40000000) { Err(InvalidParams)?; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `r * p >= 0x40000000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/simple.rs:110:21 [INFO] [stderr] | [INFO] [stderr] 110 | let r = pvec[1] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(pvec[1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/simple.rs:111:21 [INFO] [stderr] | [INFO] [stderr] 111 | let p = pvec[2] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(pvec[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:83:10 [INFO] [stderr] | [INFO] [stderr] 83 | if !(output.len() > 0 && output.len() / 32 <= 0xffffffff) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/params.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | if !((log_n as usize) < r * 16) { Err(InvalidParams)?; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(log_n as usize) >= r * 16` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/params.rs:60:12 [INFO] [stderr] | [INFO] [stderr] 60 | if !(r * p < 0x40000000) { Err(InvalidParams)?; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `r * p >= 0x40000000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/simple.rs:110:21 [INFO] [stderr] | [INFO] [stderr] 110 | let r = pvec[1] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(pvec[1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/simple.rs:111:21 [INFO] [stderr] | [INFO] [stderr] 111 | let p = pvec[2] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(pvec[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:83:10 [INFO] [stderr] | [INFO] [stderr] 83 | if !(output.len() > 0 && output.len() / 32 <= 0xffffffff) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.64s [INFO] running `"docker" "inspect" "69f009f1459e45de27a67c1947413095c928f3cc87b8ed7e0bee6388fe77809a"` [INFO] running `"docker" "rm" "-f" "69f009f1459e45de27a67c1947413095c928f3cc87b8ed7e0bee6388fe77809a"` [INFO] [stdout] 69f009f1459e45de27a67c1947413095c928f3cc87b8ed7e0bee6388fe77809a