[INFO] crate scroll_derive 0.9.5 is already in cache [INFO] extracting crate scroll_derive 0.9.5 into work/ex/clippy-test-run/sources/stable/reg/scroll_derive/0.9.5 [INFO] extracting crate scroll_derive 0.9.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/scroll_derive/0.9.5 [INFO] validating manifest of scroll_derive-0.9.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of scroll_derive-0.9.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing scroll_derive-0.9.5 [INFO] finished frobbing scroll_derive-0.9.5 [INFO] frobbed toml for scroll_derive-0.9.5 written to work/ex/clippy-test-run/sources/stable/reg/scroll_derive/0.9.5/Cargo.toml [INFO] started frobbing scroll_derive-0.9.5 [INFO] finished frobbing scroll_derive-0.9.5 [INFO] frobbed toml for scroll_derive-0.9.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/scroll_derive/0.9.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting scroll_derive-0.9.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/scroll_derive/0.9.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0486bdcf8352f09ea052f7c812bb60e93fdbd60eb482860dbac07dd3dfca9011 [INFO] running `"docker" "start" "-a" "0486bdcf8352f09ea052f7c812bb60e93fdbd60eb482860dbac07dd3dfca9011"` [INFO] [stderr] Compiling scroll v0.9.2 [INFO] [stderr] Compiling scroll_derive v0.9.5 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / match ty { [INFO] [stderr] 16 | | &syn::Type::Array(ref array) => { [INFO] [stderr] 17 | | match array.len { [INFO] [stderr] 18 | | syn::Expr::Lit(syn::ExprLit { lit: syn::Lit::Int(ref int), ..}) => { [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 15 | match *ty { [INFO] [stderr] 16 | syn::Type::Array(ref array) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | / match ty { [INFO] [stderr] 79 | | &syn::Type::Array(_) => { [INFO] [stderr] 80 | | quote! { [INFO] [stderr] 81 | | for i in 0..self.#ident.len() { [INFO] [stderr] ... | [INFO] [stderr] 90 | | } [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 78 | match *ty { [INFO] [stderr] 79 | syn::Type::Array(_) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | / match ty { [INFO] [stderr] 146 | | &syn::Type::Array(ref array) => { [INFO] [stderr] 147 | | let elem = &array.elem; [INFO] [stderr] 148 | | match array.len { [INFO] [stderr] ... | [INFO] [stderr] 162 | | } [INFO] [stderr] 163 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 145 | match *ty { [INFO] [stderr] 146 | syn::Type::Array(ref array) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | / match ty { [INFO] [stderr] 205 | | &syn::Type::Array(ref array) => { [INFO] [stderr] 206 | | let arrty = &array.elem; [INFO] [stderr] 207 | | match array.len { [INFO] [stderr] ... | [INFO] [stderr] 230 | | } [INFO] [stderr] 231 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 204 | match *ty { [INFO] [stderr] 205 | syn::Type::Array(ref array) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:276:9 [INFO] [stderr] | [INFO] [stderr] 276 | / match ty { [INFO] [stderr] 277 | | &syn::Type::Array(ref array) => { [INFO] [stderr] 278 | | let arrty = &array.elem; [INFO] [stderr] 279 | | quote! { [INFO] [stderr] ... | [INFO] [stderr] 292 | | } [INFO] [stderr] 293 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 276 | match *ty { [INFO] [stderr] 277 | syn::Type::Array(ref array) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/main.rs:19:25 [INFO] [stderr] | [INFO] [stderr] 19 | assert_eq!(data.id, 0xdeadbeefu32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xdead_beefu32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/tests.rs:19:25 [INFO] [stderr] | [INFO] [stderr] 19 | assert_eq!(data.id, 0xdeadbeefu32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xdead_beefu32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/tests.rs:65:27 [INFO] [stderr] | [INFO] [stderr] 65 | assert_eq!(data.name, 50462976); [INFO] [stderr] | ^^^^^^^^ help: consider: `50_462_976` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/tests.rs:75:27 [INFO] [stderr] | [INFO] [stderr] 75 | assert_eq!(data.name, 50462976); [INFO] [stderr] | ^^^^^^^^ help: consider: `50_462_976` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/tests.rs:106:27 [INFO] [stderr] | [INFO] [stderr] 106 | assert_eq!(data.name, 50462976); [INFO] [stderr] | ^^^^^^^^ help: consider: `50_462_976` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/tests.rs:112:27 [INFO] [stderr] | [INFO] [stderr] 112 | assert_eq!(data.name, 50462976); [INFO] [stderr] | ^^^^^^^^ help: consider: `50_462_976` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/tests.rs:133:25 [INFO] [stderr] | [INFO] [stderr] 133 | assert_eq!(data.id, 0xbeefedde); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xbeef_edde` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/tests.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | assert_eq!(data.timestamp, 0.5f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/tests.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | assert_eq!(data.timestamp, 0.5f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `scroll_derive`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / match ty { [INFO] [stderr] 16 | | &syn::Type::Array(ref array) => { [INFO] [stderr] 17 | | match array.len { [INFO] [stderr] 18 | | syn::Expr::Lit(syn::ExprLit { lit: syn::Lit::Int(ref int), ..}) => { [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 15 | match *ty { [INFO] [stderr] 16 | syn::Type::Array(ref array) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | / match ty { [INFO] [stderr] 79 | | &syn::Type::Array(_) => { [INFO] [stderr] 80 | | quote! { [INFO] [stderr] 81 | | for i in 0..self.#ident.len() { [INFO] [stderr] ... | [INFO] [stderr] 90 | | } [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 78 | match *ty { [INFO] [stderr] 79 | syn::Type::Array(_) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | / match ty { [INFO] [stderr] 146 | | &syn::Type::Array(ref array) => { [INFO] [stderr] 147 | | let elem = &array.elem; [INFO] [stderr] 148 | | match array.len { [INFO] [stderr] ... | [INFO] [stderr] 162 | | } [INFO] [stderr] 163 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 145 | match *ty { [INFO] [stderr] 146 | syn::Type::Array(ref array) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | / match ty { [INFO] [stderr] 205 | | &syn::Type::Array(ref array) => { [INFO] [stderr] 206 | | let arrty = &array.elem; [INFO] [stderr] 207 | | match array.len { [INFO] [stderr] ... | [INFO] [stderr] 230 | | } [INFO] [stderr] 231 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 204 | match *ty { [INFO] [stderr] 205 | syn::Type::Array(ref array) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:276:9 [INFO] [stderr] | [INFO] [stderr] 276 | / match ty { [INFO] [stderr] 277 | | &syn::Type::Array(ref array) => { [INFO] [stderr] 278 | | let arrty = &array.elem; [INFO] [stderr] 279 | | quote! { [INFO] [stderr] ... | [INFO] [stderr] 292 | | } [INFO] [stderr] 293 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 276 | match *ty { [INFO] [stderr] 277 | syn::Type::Array(ref array) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "0486bdcf8352f09ea052f7c812bb60e93fdbd60eb482860dbac07dd3dfca9011"` [INFO] running `"docker" "rm" "-f" "0486bdcf8352f09ea052f7c812bb60e93fdbd60eb482860dbac07dd3dfca9011"` [INFO] [stdout] 0486bdcf8352f09ea052f7c812bb60e93fdbd60eb482860dbac07dd3dfca9011