[INFO] crate screenprints 0.1.1 is already in cache [INFO] extracting crate screenprints 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/screenprints/0.1.1 [INFO] extracting crate screenprints 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/screenprints/0.1.1 [INFO] validating manifest of screenprints-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of screenprints-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing screenprints-0.1.1 [INFO] finished frobbing screenprints-0.1.1 [INFO] frobbed toml for screenprints-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/screenprints/0.1.1/Cargo.toml [INFO] started frobbing screenprints-0.1.1 [INFO] finished frobbing screenprints-0.1.1 [INFO] frobbed toml for screenprints-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/screenprints/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting screenprints-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/screenprints/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8c8ba89354cfa8ba6ded1bb8f61ac9f726ed86189e6dc983c96134dfb7e10e5b [INFO] running `"docker" "start" "-a" "8c8ba89354cfa8ba6ded1bb8f61ac9f726ed86189e6dc983c96134dfb7e10e5b"` [INFO] [stderr] Checking screenprints v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:44:24 [INFO] [stderr] | [INFO] [stderr] 44 | if let Ok(_) = closing.try_recv() { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 45 | | return; [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________________- help: try this: `if closing.try_recv().is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: You appear to be counting bytes the naive way [INFO] [stderr] --> src/lib.rs:76:37 [INFO] [stderr] | [INFO] [stderr] 76 | lines = buffer.iter().filter(|&b| *b == b'\n').count(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider using the bytecount crate: `bytecount::count(buffer, b'\n')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::naive_bytecount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#naive_bytecount [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> examples/progress.rs:12:70 [INFO] [stderr] | [INFO] [stderr] 12 | let _ = write!(p, "Downloading {}.. ({}/{}) GB\n", f, i, 50); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> examples/progress.rs:12:21 [INFO] [stderr] | [INFO] [stderr] 12 | let _ = write!(p, "Downloading {}.. ({}/{}) GB\n", f, i, 50); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:44:24 [INFO] [stderr] | [INFO] [stderr] 44 | if let Ok(_) = closing.try_recv() { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 45 | | return; [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________________- help: try this: `if closing.try_recv().is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: You appear to be counting bytes the naive way [INFO] [stderr] --> src/lib.rs:76:37 [INFO] [stderr] | [INFO] [stderr] 76 | lines = buffer.iter().filter(|&b| *b == b'\n').count(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider using the bytecount crate: `bytecount::count(buffer, b'\n')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::naive_bytecount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#naive_bytecount [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.64s [INFO] running `"docker" "inspect" "8c8ba89354cfa8ba6ded1bb8f61ac9f726ed86189e6dc983c96134dfb7e10e5b"` [INFO] running `"docker" "rm" "-f" "8c8ba89354cfa8ba6ded1bb8f61ac9f726ed86189e6dc983c96134dfb7e10e5b"` [INFO] [stdout] 8c8ba89354cfa8ba6ded1bb8f61ac9f726ed86189e6dc983c96134dfb7e10e5b