[INFO] crate scrapyard-converter 0.1.0 is already in cache [INFO] extracting crate scrapyard-converter 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/scrapyard-converter/0.1.0 [INFO] extracting crate scrapyard-converter 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/scrapyard-converter/0.1.0 [INFO] validating manifest of scrapyard-converter-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of scrapyard-converter-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing scrapyard-converter-0.1.0 [INFO] finished frobbing scrapyard-converter-0.1.0 [INFO] frobbed toml for scrapyard-converter-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/scrapyard-converter/0.1.0/Cargo.toml [INFO] started frobbing scrapyard-converter-0.1.0 [INFO] finished frobbing scrapyard-converter-0.1.0 [INFO] frobbed toml for scrapyard-converter-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/scrapyard-converter/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting scrapyard-converter-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/scrapyard-converter/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b73e46f7eb1d8b26dab9c0aa074e2595976e48a3525b46ac18dadc4a8071ff9c [INFO] running `"docker" "start" "-a" "b73e46f7eb1d8b26dab9c0aa074e2595976e48a3525b46ac18dadc4a8071ff9c"` [INFO] [stderr] Compiling scrapyard-core v0.1.0 [INFO] [stderr] Checking serde-xml-rs v0.2.1 [INFO] [stderr] Checking either v1.5.0 [INFO] [stderr] Checking scrapyard-converter v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stm32/mcu.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | frequency: frequency, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frequency` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stm32/mcu.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | core: core, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `core` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stm32/mcu.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | package: package, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `package` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stm32/mcu.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | ips: ips, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ips` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stm32/mcu.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | pins: pins, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stm32/nvic.rs:46:19 [INFO] [stderr] | [INFO] [stderr] 46 | Ok(IRQS { irqs: irqs }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `irqs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stm32/mcu.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | frequency: frequency, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frequency` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stm32/mcu.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | core: core, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `core` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stm32/mcu.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | package: package, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `package` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stm32/mcu.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | ips: ips, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ips` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stm32/mcu.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | pins: pins, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stm32/nvic.rs:46:19 [INFO] [stderr] | [INFO] [stderr] 46 | Ok(IRQS { irqs: irqs }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `irqs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stm32/mcu.rs:166:24 [INFO] [stderr] | [INFO] [stderr] 166 | start: 0x08000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0800_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stm32/mcu.rs:178:24 [INFO] [stderr] | [INFO] [stderr] 178 | start: 0x20000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stm32/mcu.rs:192:28 [INFO] [stderr] | [INFO] [stderr] 192 | start: 0x00000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stm32/mcu.rs:166:24 [INFO] [stderr] | [INFO] [stderr] 166 | start: 0x08000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0800_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stm32/mcu.rs:178:24 [INFO] [stderr] | [INFO] [stderr] 178 | start: 0x20000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/stm32/mcu.rs:192:28 [INFO] [stderr] | [INFO] [stderr] 192 | start: 0x00000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/stm32/mcu.rs:187:9 [INFO] [stderr] | [INFO] [stderr] 187 | / match self.E2prom { [INFO] [stderr] 188 | | Some(ref v) => { [INFO] [stderr] 189 | | let eeprom_val = v.parse::().unwrap(); [INFO] [stderr] 190 | | let ram = Memory::Eeprom { [INFO] [stderr] ... | [INFO] [stderr] 198 | | None => (), [INFO] [stderr] 199 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 187 | if let Some(ref v) = self.E2prom { [INFO] [stderr] 188 | let eeprom_val = v.parse::().unwrap(); [INFO] [stderr] 189 | let ram = Memory::Eeprom { [INFO] [stderr] 190 | // TODO: Set correct addr [INFO] [stderr] 191 | start: 0x00000000, [INFO] [stderr] 192 | size: eeprom_val, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/stm32/nvic.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | / match param.PossibleValue { [INFO] [stderr] 34 | | Some(value) => for v in value.into_iter() { [INFO] [stderr] 35 | | println!("{} ||| {}", v.Comment, v.Value); [INFO] [stderr] 36 | | irqs.push(IRQ { [INFO] [stderr] ... | [INFO] [stderr] 41 | | None => (), [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | if let Some(value) = param.PossibleValue for v in value.into_iter() { [INFO] [stderr] 34 | println!("{} ||| {}", v.Comment, v.Value); [INFO] [stderr] 35 | irqs.push(IRQ { [INFO] [stderr] 36 | desc: v.Comment, [INFO] [stderr] 37 | value: v.Value, [INFO] [stderr] 38 | }); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/stm32/dma.rs:59:23 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn to_pegasus(self) {} [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/stm32/mcu.rs:187:9 [INFO] [stderr] | [INFO] [stderr] 187 | / match self.E2prom { [INFO] [stderr] 188 | | Some(ref v) => { [INFO] [stderr] 189 | | let eeprom_val = v.parse::().unwrap(); [INFO] [stderr] 190 | | let ram = Memory::Eeprom { [INFO] [stderr] ... | [INFO] [stderr] 198 | | None => (), [INFO] [stderr] 199 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 187 | if let Some(ref v) = self.E2prom { [INFO] [stderr] 188 | let eeprom_val = v.parse::().unwrap(); [INFO] [stderr] 189 | let ram = Memory::Eeprom { [INFO] [stderr] 190 | // TODO: Set correct addr [INFO] [stderr] 191 | start: 0x00000000, [INFO] [stderr] 192 | size: eeprom_val, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | / match output_dir.exists() { [INFO] [stderr] 78 | | false => { [INFO] [stderr] 79 | | println!("Creating output directory"); [INFO] [stderr] 80 | | std::fs::create_dir_all(output_dir.as_path())? [INFO] [stderr] 81 | | } [INFO] [stderr] 82 | | true => println!("Output directory exists"), [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 77 | if output_dir.exists() { println!("Output directory exists") } else { [INFO] [stderr] 78 | println!("Creating output directory"); [INFO] [stderr] 79 | std::fs::create_dir_all(output_dir.as_path())? [INFO] [stderr] 80 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: for loop over `caps`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/main.rs:97:24 [INFO] [stderr] | [INFO] [stderr] 97 | for cap in caps { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::for_loop_over_option)] on by default [INFO] [stderr] = help: consider replacing `for cap in caps` with `if let Some(cap) = caps` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | / match e.kind() { [INFO] [stderr] 170 | | &ErrorKind::Msg(ref s) => println!("Msg: {}", s), [INFO] [stderr] 171 | | &ErrorKind::Io(ref s) => println!("Io: {}", s), [INFO] [stderr] 172 | | &ErrorKind::SerdeXML(ref s) => println!("Serde XML: {}", s), [INFO] [stderr] ... | [INFO] [stderr] 175 | | _ => panic!("Unknown error"), [INFO] [stderr] 176 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 169 | match *e.kind() { [INFO] [stderr] 170 | ErrorKind::Msg(ref s) => println!("Msg: {}", s), [INFO] [stderr] 171 | ErrorKind::Io(ref s) => println!("Io: {}", s), [INFO] [stderr] 172 | ErrorKind::SerdeXML(ref s) => println!("Serde XML: {}", s), [INFO] [stderr] 173 | ErrorKind::SerdeJSON(ref s) => println!("Serde JSON: {}", s), [INFO] [stderr] 174 | ErrorKind::Parse(ref s) => println!("Parse: {}", s), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `scrapyard-converter`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/stm32/nvic.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | / match param.PossibleValue { [INFO] [stderr] 34 | | Some(value) => for v in value.into_iter() { [INFO] [stderr] 35 | | println!("{} ||| {}", v.Comment, v.Value); [INFO] [stderr] 36 | | irqs.push(IRQ { [INFO] [stderr] ... | [INFO] [stderr] 41 | | None => (), [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | if let Some(value) = param.PossibleValue for v in value.into_iter() { [INFO] [stderr] 34 | println!("{} ||| {}", v.Comment, v.Value); [INFO] [stderr] 35 | irqs.push(IRQ { [INFO] [stderr] 36 | desc: v.Comment, [INFO] [stderr] 37 | value: v.Value, [INFO] [stderr] 38 | }); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/stm32/dma.rs:59:23 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn to_pegasus(self) {} [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | / match output_dir.exists() { [INFO] [stderr] 78 | | false => { [INFO] [stderr] 79 | | println!("Creating output directory"); [INFO] [stderr] 80 | | std::fs::create_dir_all(output_dir.as_path())? [INFO] [stderr] 81 | | } [INFO] [stderr] 82 | | true => println!("Output directory exists"), [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 77 | if output_dir.exists() { println!("Output directory exists") } else { [INFO] [stderr] 78 | println!("Creating output directory"); [INFO] [stderr] 79 | std::fs::create_dir_all(output_dir.as_path())? [INFO] [stderr] 80 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: for loop over `caps`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/main.rs:97:24 [INFO] [stderr] | [INFO] [stderr] 97 | for cap in caps { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::for_loop_over_option)] on by default [INFO] [stderr] = help: consider replacing `for cap in caps` with `if let Some(cap) = caps` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | / match e.kind() { [INFO] [stderr] 170 | | &ErrorKind::Msg(ref s) => println!("Msg: {}", s), [INFO] [stderr] 171 | | &ErrorKind::Io(ref s) => println!("Io: {}", s), [INFO] [stderr] 172 | | &ErrorKind::SerdeXML(ref s) => println!("Serde XML: {}", s), [INFO] [stderr] ... | [INFO] [stderr] 175 | | _ => panic!("Unknown error"), [INFO] [stderr] 176 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 169 | match *e.kind() { [INFO] [stderr] 170 | ErrorKind::Msg(ref s) => println!("Msg: {}", s), [INFO] [stderr] 171 | ErrorKind::Io(ref s) => println!("Io: {}", s), [INFO] [stderr] 172 | ErrorKind::SerdeXML(ref s) => println!("Serde XML: {}", s), [INFO] [stderr] 173 | ErrorKind::SerdeJSON(ref s) => println!("Serde JSON: {}", s), [INFO] [stderr] 174 | ErrorKind::Parse(ref s) => println!("Parse: {}", s), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `scrapyard-converter`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "b73e46f7eb1d8b26dab9c0aa074e2595976e48a3525b46ac18dadc4a8071ff9c"` [INFO] running `"docker" "rm" "-f" "b73e46f7eb1d8b26dab9c0aa074e2595976e48a3525b46ac18dadc4a8071ff9c"` [INFO] [stdout] b73e46f7eb1d8b26dab9c0aa074e2595976e48a3525b46ac18dadc4a8071ff9c