[INFO] crate scoped-pool 1.0.0 is already in cache [INFO] extracting crate scoped-pool 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/scoped-pool/1.0.0 [INFO] extracting crate scoped-pool 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/scoped-pool/1.0.0 [INFO] validating manifest of scoped-pool-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of scoped-pool-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing scoped-pool-1.0.0 [INFO] finished frobbing scoped-pool-1.0.0 [INFO] frobbed toml for scoped-pool-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/scoped-pool/1.0.0/Cargo.toml [INFO] started frobbing scoped-pool-1.0.0 [INFO] finished frobbing scoped-pool-1.0.0 [INFO] frobbed toml for scoped-pool-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/scoped-pool/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting scoped-pool-1.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/scoped-pool/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ad4dedbbcaf40c4eb484c5238fee5227ecb907ba315f7ae9924371f32258e7d1 [INFO] running `"docker" "start" "-a" "ad4dedbbcaf40c4eb484c5238fee5227ecb907ba315f7ae9924371f32258e7d1"` [INFO] [stderr] Checking scopeguard v0.1.2 [INFO] [stderr] Checking variance v0.1.3 [INFO] [stderr] Checking scoped-pool v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:201:21 [INFO] [stderr] | [INFO] [stderr] 201 | PoolInner { thread_config: thread_config, ..Self::default() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `thread_config` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:282:13 [INFO] [stderr] | [INFO] [stderr] 282 | pool: pool, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:201:21 [INFO] [stderr] | [INFO] [stderr] 201 | PoolInner { thread_config: thread_config, ..Self::default() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `thread_config` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:1:24 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_field_names)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:282:13 [INFO] [stderr] | [INFO] [stderr] 282 | pool: pool, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: cannot specify lifetime arguments explicitly if late bound lifetime parameters are present [INFO] [stderr] --> src/lib.rs:325:44 [INFO] [stderr] | [INFO] [stderr] 325 | let scope = unsafe { self.refine::<'smaller>() }; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 355 | unsafe fn refine<'other>(&self) -> Scope<'other> where 'scope: 'other { [INFO] [stderr] | - the late bound lifetime parameter is introduced here [INFO] [stderr] | [INFO] [stderr] = note: #[warn(late_bound_lifetime_arguments)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #42868 [INFO] [stderr] [INFO] [stderr] error: cannot specify lifetime arguments explicitly if late bound lifetime parameters are present [INFO] [stderr] --> src/lib.rs:325:44 [INFO] [stderr] | [INFO] [stderr] 325 | let scope = unsafe { self.refine::<'smaller>() }; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 355 | unsafe fn refine<'other>(&self) -> Scope<'other> where 'scope: 'other { [INFO] [stderr] | - the late bound lifetime parameter is introduced here [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:1:24 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(late_bound_lifetime_arguments)] implied by #[deny(warnings)] [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #42868 [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/lib.rs:469:9 [INFO] [stderr] | [INFO] [stderr] 469 | self.1.take().map(|wait| wait.complete()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(wait) = self.1.take() { wait.complete() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/lib.rs:475:9 [INFO] [stderr] | [INFO] [stderr] 475 | self.1.take().map(|wait| wait.poison()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(wait) = self.1.take() { wait.poison() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/lib.rs:483:9 [INFO] [stderr] | [INFO] [stderr] 483 | self.0.take().map(|pool| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 484 | || pool.wait.complete(); [INFO] [stderr] 485 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(pool) = self.0.take() { pool.wait.complete(); }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/lib.rs:491:9 [INFO] [stderr] | [INFO] [stderr] 491 | self.0.take().map(|pool| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 492 | || // NOTE: We restart the thread first so we don't accidentally [INFO] [stderr] 493 | || // hit zero threads before restarting. [INFO] [stderr] 494 | || [INFO] [stderr] ... || [INFO] [stderr] 499 | || pool.wait.poison(); [INFO] [stderr] 500 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(pool) = self.0.take() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `scoped-pool`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/quicksort.rs:50:34 [INFO] [stderr] | [INFO] [stderr] 50 | let n = rng.gen_range(1, 10000000); [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> examples/quicksort.rs:26:37 [INFO] [stderr] | [INFO] [stderr] 26 | let mut iter = data.into_iter(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> examples/quicksort.rs:30:50 [INFO] [stderr] | [INFO] [stderr] 30 | itertools::partition(iter, |val| &*val <= &pivot) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 30 | itertools::partition(iter, |val| *val <= pivot) [INFO] [stderr] | ^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "ad4dedbbcaf40c4eb484c5238fee5227ecb907ba315f7ae9924371f32258e7d1"` [INFO] running `"docker" "rm" "-f" "ad4dedbbcaf40c4eb484c5238fee5227ecb907ba315f7ae9924371f32258e7d1"` [INFO] [stdout] ad4dedbbcaf40c4eb484c5238fee5227ecb907ba315f7ae9924371f32258e7d1