[INFO] crate scl 0.0.1 is already in cache [INFO] extracting crate scl 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/scl/0.0.1 [INFO] extracting crate scl 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/scl/0.0.1 [INFO] validating manifest of scl-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of scl-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing scl-0.0.1 [INFO] finished frobbing scl-0.0.1 [INFO] frobbed toml for scl-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/scl/0.0.1/Cargo.toml [INFO] started frobbing scl-0.0.1 [INFO] finished frobbing scl-0.0.1 [INFO] frobbed toml for scl-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/scl/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting scl-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/scl/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 71dd1b2889828b6bb18f32965092b3f91b1d67da7750a02208e79a526ce5f71e [INFO] running `"docker" "start" "-a" "71dd1b2889828b6bb18f32965092b3f91b1d67da7750a02208e79a526ce5f71e"` [INFO] [stderr] Checking scl v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/value.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / pub fn from_str(input: &str) -> Date { [INFO] [stderr] 56 | | // TODO: error handling [INFO] [stderr] 57 | | let parts: Vec<&str> = input.split('-').collect(); [INFO] [stderr] 58 | | Date { [INFO] [stderr] ... | [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/value.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / pub fn from_str(input: &str) -> Date { [INFO] [stderr] 56 | | // TODO: error handling [INFO] [stderr] 57 | | let parts: Vec<&str> = input.split('-').collect(); [INFO] [stderr] 58 | | Date { [INFO] [stderr] ... | [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/valid.rs:42:45 [INFO] [stderr] | [INFO] [stderr] 42 | "max_upload_size" => V::Integer(10000000), [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/valid.rs:62:41 [INFO] [stderr] | [INFO] [stderr] 62 | "max_upload_size" => V::Integer(1000000000), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> tests/valid.rs:104:60 [INFO] [stderr] | [INFO] [stderr] 104 | "dob" => V::Date(Date { year: 1979, month: 05, day: 27}), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 104 | "dob" => V::Date(Date { year: 1979, month: 5, day: 27}), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 104 | "dob" => V::Date(Date { year: 1979, month: 0o5, day: 27}), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.09s [INFO] running `"docker" "inspect" "71dd1b2889828b6bb18f32965092b3f91b1d67da7750a02208e79a526ce5f71e"` [INFO] running `"docker" "rm" "-f" "71dd1b2889828b6bb18f32965092b3f91b1d67da7750a02208e79a526ce5f71e"` [INFO] [stdout] 71dd1b2889828b6bb18f32965092b3f91b1d67da7750a02208e79a526ce5f71e