[INFO] crate sciter-serde 0.3.1 is already in cache [INFO] extracting crate sciter-serde 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/sciter-serde/0.3.1 [INFO] extracting crate sciter-serde 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sciter-serde/0.3.1 [INFO] validating manifest of sciter-serde-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sciter-serde-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sciter-serde-0.3.1 [INFO] finished frobbing sciter-serde-0.3.1 [INFO] frobbed toml for sciter-serde-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/sciter-serde/0.3.1/Cargo.toml [INFO] started frobbing sciter-serde-0.3.1 [INFO] finished frobbing sciter-serde-0.3.1 [INFO] frobbed toml for sciter-serde-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sciter-serde/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sciter-serde-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/sciter-serde/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dd4444d60ee833e667fd35f153622353f42aac60e66efb743494c2c621e4f17b [INFO] running `"docker" "start" "-a" "dd4444d60ee833e667fd35f153622353f42aac60e66efb743494c2c621e4f17b"` [INFO] [stderr] Checking sciter-rs v0.5.45 [INFO] [stderr] Checking serde_bytes v0.10.4 [INFO] [stderr] Checking sciter-serde v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:32:4 [INFO] [stderr] | [INFO] [stderr] 32 | ser: ser, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ser` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:41:4 [INFO] [stderr] | [INFO] [stderr] 41 | ser: ser, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | Deserializer { input: input } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:175:4 [INFO] [stderr] | [INFO] [stderr] 175 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:32:4 [INFO] [stderr] | [INFO] [stderr] 32 | ser: ser, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ser` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ser.rs:41:4 [INFO] [stderr] | [INFO] [stderr] 41 | ser: ser, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | Deserializer { input: input } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/de.rs:175:4 [INFO] [stderr] | [INFO] [stderr] 175 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:189:23 [INFO] [stderr] | [INFO] [stderr] 189 | self.serialize_i32(v as i32) [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:193:23 [INFO] [stderr] | [INFO] [stderr] 193 | self.serialize_i32(v as i32) [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:202:23 [INFO] [stderr] | [INFO] [stderr] 202 | self.serialize_i32(v as i32) [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:206:23 [INFO] [stderr] | [INFO] [stderr] 206 | self.serialize_i32(v as i32) [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:213:24 [INFO] [stderr] | [INFO] [stderr] 213 | self.serialize_f64(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:227:23 [INFO] [stderr] | [INFO] [stderr] 227 | self.serialize_f64(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> tests/deserialization.rs:74:2 [INFO] [stderr] | [INFO] [stderr] 74 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:189:23 [INFO] [stderr] | [INFO] [stderr] 189 | self.serialize_i32(v as i32) [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:193:23 [INFO] [stderr] | [INFO] [stderr] 193 | self.serialize_i32(v as i32) [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:202:23 [INFO] [stderr] | [INFO] [stderr] 202 | self.serialize_i32(v as i32) [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:206:23 [INFO] [stderr] | [INFO] [stderr] 206 | self.serialize_i32(v as i32) [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:213:24 [INFO] [stderr] | [INFO] [stderr] 213 | self.serialize_f64(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:227:23 [INFO] [stderr] | [INFO] [stderr] 227 | self.serialize_f64(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/deserialization.rs:30:2 [INFO] [stderr] | [INFO] [stderr] 30 | assert_eq!(v, 7.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/deserialization.rs:30:2 [INFO] [stderr] | [INFO] [stderr] 30 | assert_eq!(v, 7.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/deserialization.rs:33:2 [INFO] [stderr] | [INFO] [stderr] 33 | assert_eq!(v, 7.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/deserialization.rs:33:2 [INFO] [stderr] | [INFO] [stderr] 33 | assert_eq!(v, 7.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sciter-serde`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/both.rs:19:29 [INFO] [stderr] | [INFO] [stderr] 19 | let sv = to_value(&actual).expect(&format!("to_value({})", expr)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("to_value({})", expr))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/both.rs:20:27 [INFO] [stderr] | [INFO] [stderr] 20 | let dv = from_value(&sv).expect(&format!("from_value({})", expr)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("from_value({})", expr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "dd4444d60ee833e667fd35f153622353f42aac60e66efb743494c2c621e4f17b"` [INFO] running `"docker" "rm" "-f" "dd4444d60ee833e667fd35f153622353f42aac60e66efb743494c2c621e4f17b"` [INFO] [stdout] dd4444d60ee833e667fd35f153622353f42aac60e66efb743494c2c621e4f17b