[INFO] crate schroedinger_box 0.0.2 is already in cache [INFO] extracting crate schroedinger_box 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/schroedinger_box/0.0.2 [INFO] extracting crate schroedinger_box 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/schroedinger_box/0.0.2 [INFO] validating manifest of schroedinger_box-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of schroedinger_box-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing schroedinger_box-0.0.2 [INFO] finished frobbing schroedinger_box-0.0.2 [INFO] frobbed toml for schroedinger_box-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/schroedinger_box/0.0.2/Cargo.toml [INFO] started frobbing schroedinger_box-0.0.2 [INFO] finished frobbing schroedinger_box-0.0.2 [INFO] frobbed toml for schroedinger_box-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/schroedinger_box/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting schroedinger_box-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/schroedinger_box/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 92ca508c5416c2685f84a801f25dc96b03b87249d87bc0390a830a4b9ef7051f [INFO] running `"docker" "start" "-a" "92ca508c5416c2685f84a801f25dc96b03b87249d87bc0390a830a4b9ef7051f"` [INFO] [stderr] Checking schroedinger_box v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:67:17 [INFO] [stderr] | [INFO] [stderr] 67 | assert!(states.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!states.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:82:50 [INFO] [stderr] | [INFO] [stderr] 82 | let len = vec.iter().map(|&(f, _)| f).fold(0, |a, b| a + b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:201:19 [INFO] [stderr] | [INFO] [stderr] 201 | vec![(100000, 1), (500000, 2), (500000, 3), (1, 4)]); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:201:32 [INFO] [stderr] | [INFO] [stderr] 201 | vec![(100000, 1), (500000, 2), (500000, 3), (1, 4)]); [INFO] [stderr] | ^^^^^^ help: consider: `500_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:201:45 [INFO] [stderr] | [INFO] [stderr] 201 | vec![(100000, 1), (500000, 2), (500000, 3), (1, 4)]); [INFO] [stderr] | ^^^^^^ help: consider: `500_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:67:17 [INFO] [stderr] | [INFO] [stderr] 67 | assert!(states.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!states.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:82:50 [INFO] [stderr] | [INFO] [stderr] 82 | let len = vec.iter().map(|&(f, _)| f).fold(0, |a, b| a + b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/lib.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | let foo = SchroedingerBox::from_probabilities( [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/lib.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | let foo = SchroedingerBox::new(vec![1, 2, 3]); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/lib.rs:226:13 [INFO] [stderr] | [INFO] [stderr] 226 | let foo = SchroedingerBox::new(vec![1, 2, 3]); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.53s [INFO] running `"docker" "inspect" "92ca508c5416c2685f84a801f25dc96b03b87249d87bc0390a830a4b9ef7051f"` [INFO] running `"docker" "rm" "-f" "92ca508c5416c2685f84a801f25dc96b03b87249d87bc0390a830a4b9ef7051f"` [INFO] [stdout] 92ca508c5416c2685f84a801f25dc96b03b87249d87bc0390a830a4b9ef7051f