[INFO] crate schnorr 0.0.3 is already in cache
[INFO] extracting crate schnorr 0.0.3 into work/ex/clippy-test-run/sources/stable/reg/schnorr/0.0.3
[INFO] extracting crate schnorr 0.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/schnorr/0.0.3
[INFO] validating manifest of schnorr-0.0.3 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of schnorr-0.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing schnorr-0.0.3
[INFO] finished frobbing schnorr-0.0.3
[INFO] frobbed toml for schnorr-0.0.3 written to work/ex/clippy-test-run/sources/stable/reg/schnorr/0.0.3/Cargo.toml
[INFO] started frobbing schnorr-0.0.3
[INFO] finished frobbing schnorr-0.0.3
[INFO] frobbed toml for schnorr-0.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/schnorr/0.0.3/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded curve25519-dalek v1.0.3
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting schnorr-0.0.3 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/schnorr/0.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 223740dbe673a320df0865187a76743470a60836b7055cac3deb1cd77e666b2a
[INFO] running `"docker" "start" "-a" "223740dbe673a320df0865187a76743470a60836b7055cac3deb1cd77e666b2a"`
[INFO] [stderr]    Compiling byteorder v1.3.1
[INFO] [stderr]    Compiling subtle v2.0.0
[INFO] [stderr]    Compiling rand v0.6.5
[INFO] [stderr]    Compiling clear_on_drop v0.2.3
[INFO] [stderr]    Compiling generic-array v0.12.0
[INFO] [stderr]     Checking blake2 v0.8.0
[INFO] [stderr]    Compiling digest v0.8.0
[INFO] [stderr]     Checking criterion-plot v0.3.0
[INFO] [stderr]     Checking rand_xoshiro v0.1.0
[INFO] [stderr]    Compiling curve25519-dalek v1.0.3
[INFO] [stderr]     Checking criterion v0.2.9
[INFO] [stderr]     Checking schnorr v0.0.3 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/schnorr.rs:600:21
[INFO] [stderr]     |
[INFO] [stderr] 600 |         Ok(Keypair{ secret: secret, public: public })
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^ help: replace it with: `secret`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/schnorr.rs:600:37
[INFO] [stderr]     |
[INFO] [stderr] 600 |         Ok(Keypair{ secret: secret, public: public })
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^ help: replace it with: `public`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/schnorr.rs:600:21
[INFO] [stderr]     |
[INFO] [stderr] 600 |         Ok(Keypair{ secret: secret, public: public })
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^ help: replace it with: `secret`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/schnorr.rs:600:37
[INFO] [stderr]     |
[INFO] [stderr] 600 |         Ok(Keypair{ secret: secret, public: public })
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^ help: replace it with: `public`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: All variants have the same postfix: `Error`
[INFO] [stderr]   --> src/errors.rs:36:1
[INFO] [stderr]    |
[INFO] [stderr] 36 | / pub (crate) enum InternalError {
[INFO] [stderr] 37 | |     PointDecompressionError,
[INFO] [stderr] 38 | |     ScalarFormatError,
[INFO] [stderr] 39 | |     /// An error in the length of bytes handed to a constructor.
[INFO] [stderr] ...  |
[INFO] [stderr] 46 | |     VerifyError,
[INFO] [stderr] 47 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::enum_variant_names)] on by default
[INFO] [stderr]    = help: remove the postfixes and use full paths to the variants instead of glob imports
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/schnorr.rs:510:24
[INFO] [stderr]     |
[INFO] [stderr] 510 |             Some(x) => return Ok(x),
[INFO] [stderr]     |                        ^^^^^^^^^^^^ help: remove `return` as shown: `Ok(x)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/schnorr.rs:511:24
[INFO] [stderr]     |
[INFO] [stderr] 511 |             None    => return Err(SignatureError(InternalError::PointDecompressionError)),
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(SignatureError(InternalError::PointDecompressionError))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: All variants have the same postfix: `Error`
[INFO] [stderr]   --> src/errors.rs:36:1
[INFO] [stderr]    |
[INFO] [stderr] 36 | / pub (crate) enum InternalError {
[INFO] [stderr] 37 | |     PointDecompressionError,
[INFO] [stderr] 38 | |     ScalarFormatError,
[INFO] [stderr] 39 | |     /// An error in the length of bytes handed to a constructor.
[INFO] [stderr] ...  |
[INFO] [stderr] 46 | |     VerifyError,
[INFO] [stderr] 47 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::enum_variant_names)] on by default
[INFO] [stderr]    = help: remove the postfixes and use full paths to the variants instead of glob imports
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/schnorr.rs:510:24
[INFO] [stderr]     |
[INFO] [stderr] 510 |             Some(x) => return Ok(x),
[INFO] [stderr]     |                        ^^^^^^^^^^^^ help: remove `return` as shown: `Ok(x)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/schnorr.rs:511:24
[INFO] [stderr]     |
[INFO] [stderr] 511 |             None    => return Err(SignatureError(InternalError::PointDecompressionError)),
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(SignatureError(InternalError::PointDecompressionError))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]    --> src/schnorr.rs:148:46
[INFO] [stderr]     |
[INFO] [stderr] 148 |                 Signature::from_bytes(bytes).or(Err(SerdeError::invalid_length(bytes.len(), &self)))
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| Err(SerdeError::invalid_length(bytes.len(), &self)))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/schnorr.rs:184:5
[INFO] [stderr]     |
[INFO] [stderr] 184 | /     pub fn as_bytes<'a>(&'a self) -> &'a [u8; SECRET_KEY_LENGTH] {
[INFO] [stderr] 185 | |         &self.0
[INFO] [stderr] 186 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/schnorr.rs:320:24
[INFO] [stderr]     |
[INFO] [stderr] 320 |         let mut bits = self.0.clone();
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.0`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/schnorr.rs:328:17
[INFO] [stderr]     |
[INFO] [stderr] 328 |         let s = &r + &(&c * &sk_as_scalar);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 328 |         let s = r + (&c * &sk_as_scalar);
[INFO] [stderr]     |                 ^   ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/schnorr.rs:328:23
[INFO] [stderr]     |
[INFO] [stderr] 328 |         let s = &r + &(&c * &sk_as_scalar);
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 328 |         let s = &r + &(c * sk_as_scalar);
[INFO] [stderr]     |                        ^   ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]    --> src/schnorr.rs:356:46
[INFO] [stderr]     |
[INFO] [stderr] 356 |                 SecretKey::from_bytes(bytes).or(Err(SerdeError::invalid_length(bytes.len(), &self)))
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| Err(SerdeError::invalid_length(bytes.len(), &self)))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/schnorr.rs:384:5
[INFO] [stderr]     |
[INFO] [stderr] 384 | /     pub fn as_bytes<'a>(&'a self) -> &'a [u8; PUBLIC_KEY_LENGTH] {
[INFO] [stderr] 385 | |         &(self.0).0
[INFO] [stderr] 386 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> src/schnorr.rs:498:21
[INFO] [stderr]     |
[INFO] [stderr] 498 |         let right = &R + (&X * &c);
[INFO] [stderr]     |                     --^^^^^^^^^^^^
[INFO] [stderr]     |                     |
[INFO] [stderr]     |                     help: use the left value directly: `R`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/schnorr.rs:498:26
[INFO] [stderr]     |
[INFO] [stderr] 498 |         let right = &R + (&X * &c);
[INFO] [stderr]     |                          ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 498 |         let right = &R + (X * c);
[INFO] [stderr]     |                           ^   ^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]    --> src/schnorr.rs:539:46
[INFO] [stderr]     |
[INFO] [stderr] 539 |                 PublicKey::from_bytes(bytes).or(Err(SerdeError::invalid_length(bytes.len(), &self)))
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| Err(SerdeError::invalid_length(bytes.len(), &self)))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/schnorr.rs:592:5
[INFO] [stderr]     |
[INFO] [stderr] 592 | /     pub fn from_bytes<'a>(bytes: &'a [u8]) -> Result<Keypair, SignatureError> {
[INFO] [stderr] 593 | |         if bytes.len() != KEYPAIR_LENGTH {
[INFO] [stderr] 594 | |             return Err(SignatureError(InternalError::BytesLengthError{
[INFO] [stderr] 595 | |                 name: "Keypair", length: KEYPAIR_LENGTH}));
[INFO] [stderr] ...   |
[INFO] [stderr] 600 | |         Ok(Keypair{ secret: secret, public: public })
[INFO] [stderr] 601 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]    --> src/schnorr.rs:148:46
[INFO] [stderr]     |
[INFO] [stderr] 148 |                 Signature::from_bytes(bytes).or(Err(SerdeError::invalid_length(bytes.len(), &self)))
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| Err(SerdeError::invalid_length(bytes.len(), &self)))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/schnorr.rs:184:5
[INFO] [stderr]     |
[INFO] [stderr] 184 | /     pub fn as_bytes<'a>(&'a self) -> &'a [u8; SECRET_KEY_LENGTH] {
[INFO] [stderr] 185 | |         &self.0
[INFO] [stderr] 186 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/schnorr.rs:320:24
[INFO] [stderr]     |
[INFO] [stderr] 320 |         let mut bits = self.0.clone();
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.0`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/schnorr.rs:328:17
[INFO] [stderr]     |
[INFO] [stderr] 328 |         let s = &r + &(&c * &sk_as_scalar);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 328 |         let s = r + (&c * &sk_as_scalar);
[INFO] [stderr]     |                 ^   ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/schnorr.rs:328:23
[INFO] [stderr]     |
[INFO] [stderr] 328 |         let s = &r + &(&c * &sk_as_scalar);
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 328 |         let s = &r + &(c * sk_as_scalar);
[INFO] [stderr]     |                        ^   ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]    --> src/schnorr.rs:356:46
[INFO] [stderr]     |
[INFO] [stderr] 356 |                 SecretKey::from_bytes(bytes).or(Err(SerdeError::invalid_length(bytes.len(), &self)))
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| Err(SerdeError::invalid_length(bytes.len(), &self)))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/schnorr.rs:384:5
[INFO] [stderr]     |
[INFO] [stderr] 384 | /     pub fn as_bytes<'a>(&'a self) -> &'a [u8; PUBLIC_KEY_LENGTH] {
[INFO] [stderr] 385 | |         &(self.0).0
[INFO] [stderr] 386 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> src/schnorr.rs:498:21
[INFO] [stderr]     |
[INFO] [stderr] 498 |         let right = &R + (&X * &c);
[INFO] [stderr]     |                     --^^^^^^^^^^^^
[INFO] [stderr]     |                     |
[INFO] [stderr]     |                     help: use the left value directly: `R`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/schnorr.rs:498:26
[INFO] [stderr]     |
[INFO] [stderr] 498 |         let right = &R + (&X * &c);
[INFO] [stderr]     |                          ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 498 |         let right = &R + (X * c);
[INFO] [stderr]     |                           ^   ^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]    --> src/schnorr.rs:539:46
[INFO] [stderr]     |
[INFO] [stderr] 539 |                 PublicKey::from_bytes(bytes).or(Err(SerdeError::invalid_length(bytes.len(), &self)))
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| Err(SerdeError::invalid_length(bytes.len(), &self)))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/schnorr.rs:592:5
[INFO] [stderr]     |
[INFO] [stderr] 592 | /     pub fn from_bytes<'a>(bytes: &'a [u8]) -> Result<Keypair, SignatureError> {
[INFO] [stderr] 593 | |         if bytes.len() != KEYPAIR_LENGTH {
[INFO] [stderr] 594 | |             return Err(SignatureError(InternalError::BytesLengthError{
[INFO] [stderr] 595 | |                 name: "Keypair", length: KEYPAIR_LENGTH}));
[INFO] [stderr] ...   |
[INFO] [stderr] 600 | |         Ok(Keypair{ secret: secret, public: public })
[INFO] [stderr] 601 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/schnorr.rs:707:27
[INFO] [stderr]     |
[INFO] [stderr] 707 |         let good: &[u8] = "test message".as_bytes();
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"test message"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/schnorr.rs:708:27
[INFO] [stderr]     |
[INFO] [stderr] 708 |         let bad:  &[u8] = "wrong message".as_bytes();
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"wrong message"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 19.05s
[INFO] running `"docker" "inspect" "223740dbe673a320df0865187a76743470a60836b7055cac3deb1cd77e666b2a"`
[INFO] running `"docker" "rm" "-f" "223740dbe673a320df0865187a76743470a60836b7055cac3deb1cd77e666b2a"`
[INFO] [stdout] 223740dbe673a320df0865187a76743470a60836b7055cac3deb1cd77e666b2a