[INFO] crate schedule_recv 0.1.0 is already in cache [INFO] extracting crate schedule_recv 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/schedule_recv/0.1.0 [INFO] extracting crate schedule_recv 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/schedule_recv/0.1.0 [INFO] validating manifest of schedule_recv-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of schedule_recv-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing schedule_recv-0.1.0 [INFO] finished frobbing schedule_recv-0.1.0 [INFO] frobbed toml for schedule_recv-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/schedule_recv/0.1.0/Cargo.toml [INFO] started frobbing schedule_recv-0.1.0 [INFO] finished frobbing schedule_recv-0.1.0 [INFO] frobbed toml for schedule_recv-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/schedule_recv/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting schedule_recv-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/schedule_recv/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0d23cfa2aef3d6e5575b6d1eb54fdf9835eb793c84121c7f07df8ed0e865fa69 [INFO] running `"docker" "start" "-a" "0d23cfa2aef3d6e5575b6d1eb54fdf9835eb793c84121c7f07df8ed0e865fa69"` [INFO] [stderr] Checking schedule_recv v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduler.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | trigger: trigger, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `trigger` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduler.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | request_source: request_source, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `request_source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduler.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | period: period [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `period` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduler.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | trigger: trigger, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `trigger` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduler.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | request_source: request_source, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `request_source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduler.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | period: period [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `period` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/scheduler.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | / match evt.completion_sink.send( () ) { [INFO] [stderr] 72 | | Ok( () ) => { [INFO] [stderr] 73 | | if let Some(period) = evt.period { [INFO] [stderr] 74 | | self.schedule.push(ScheduledEvent{ [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 71 | if let Ok( () ) = evt.completion_sink.send( () ) { [INFO] [stderr] 72 | if let Some(period) = evt.period { [INFO] [stderr] 73 | self.schedule.push(ScheduledEvent{ [INFO] [stderr] 74 | when: evt.when + period, [INFO] [stderr] 75 | period: evt.period, [INFO] [stderr] 76 | completion_sink: evt.completion_sink, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/scheduler.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | let m = Mutex::new(false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/scheduler.rs:101:21 [INFO] [stderr] | [INFO] [stderr] 101 | let mut g = m.lock().unwrap(); // The mutex isn't poisoned, since we just made it [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/scheduler.rs:145:21 [INFO] [stderr] | [INFO] [stderr] 145 | let interface = SCHEDULER_INTERFACE.lock().ok().expect("Failed to acquire the global scheduling worker"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/scheduler.rs:146:5 [INFO] [stderr] | [INFO] [stderr] 146 | / interface.adder.send(ScheduledEvent { [INFO] [stderr] 147 | | when: Instant::now() + duration, [INFO] [stderr] 148 | | completion_sink: sender, [INFO] [stderr] 149 | | period: period [INFO] [stderr] 150 | | }).ok().expect("Failed to send a request to the global scheduling worker"); [INFO] [stderr] | |______________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/scheduler.rs:160:35 [INFO] [stderr] | [INFO] [stderr] 160 | oneshot(Duration::from_millis(ms as u64)) [INFO] [stderr] | ^^^^^^^^^ help: try: `u64::from(ms)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/scheduler.rs:166:36 [INFO] [stderr] | [INFO] [stderr] 166 | periodic(Duration::from_millis(ms as u64)) [INFO] [stderr] | ^^^^^^^^^ help: try: `u64::from(ms)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/scheduler.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | / match evt.completion_sink.send( () ) { [INFO] [stderr] 72 | | Ok( () ) => { [INFO] [stderr] 73 | | if let Some(period) = evt.period { [INFO] [stderr] 74 | | self.schedule.push(ScheduledEvent{ [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 71 | if let Ok( () ) = evt.completion_sink.send( () ) { [INFO] [stderr] 72 | if let Some(period) = evt.period { [INFO] [stderr] 73 | self.schedule.push(ScheduledEvent{ [INFO] [stderr] 74 | when: evt.when + period, [INFO] [stderr] 75 | period: evt.period, [INFO] [stderr] 76 | completion_sink: evt.completion_sink, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/scheduler.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | let m = Mutex::new(false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/scheduler.rs:101:21 [INFO] [stderr] | [INFO] [stderr] 101 | let mut g = m.lock().unwrap(); // The mutex isn't poisoned, since we just made it [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/scheduler.rs:145:21 [INFO] [stderr] | [INFO] [stderr] 145 | let interface = SCHEDULER_INTERFACE.lock().ok().expect("Failed to acquire the global scheduling worker"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/scheduler.rs:146:5 [INFO] [stderr] | [INFO] [stderr] 146 | / interface.adder.send(ScheduledEvent { [INFO] [stderr] 147 | | when: Instant::now() + duration, [INFO] [stderr] 148 | | completion_sink: sender, [INFO] [stderr] 149 | | period: period [INFO] [stderr] 150 | | }).ok().expect("Failed to send a request to the global scheduling worker"); [INFO] [stderr] | |______________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/scheduler.rs:160:35 [INFO] [stderr] | [INFO] [stderr] 160 | oneshot(Duration::from_millis(ms as u64)) [INFO] [stderr] | ^^^^^^^^^ help: try: `u64::from(ms)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/scheduler.rs:166:36 [INFO] [stderr] | [INFO] [stderr] 166 | periodic(Duration::from_millis(ms as u64)) [INFO] [stderr] | ^^^^^^^^^ help: try: `u64::from(ms)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.79s [INFO] running `"docker" "inspect" "0d23cfa2aef3d6e5575b6d1eb54fdf9835eb793c84121c7f07df8ed0e865fa69"` [INFO] running `"docker" "rm" "-f" "0d23cfa2aef3d6e5575b6d1eb54fdf9835eb793c84121c7f07df8ed0e865fa69"` [INFO] [stdout] 0d23cfa2aef3d6e5575b6d1eb54fdf9835eb793c84121c7f07df8ed0e865fa69