[INFO] crate scarecrow 0.1.0 is already in cache [INFO] extracting crate scarecrow 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/scarecrow/0.1.0 [INFO] extracting crate scarecrow 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/scarecrow/0.1.0 [INFO] validating manifest of scarecrow-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of scarecrow-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing scarecrow-0.1.0 [INFO] finished frobbing scarecrow-0.1.0 [INFO] frobbed toml for scarecrow-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/scarecrow/0.1.0/Cargo.toml [INFO] started frobbing scarecrow-0.1.0 [INFO] finished frobbing scarecrow-0.1.0 [INFO] frobbed toml for scarecrow-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/scarecrow/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting scarecrow-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/scarecrow/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 085b19f992064d5e041b72c1445ac131aa26dc60fb8f9a91c52f0276f3b23654 [INFO] running `"docker" "start" "-a" "085b19f992064d5e041b72c1445ac131aa26dc60fb8f9a91c52f0276f3b23654"` [INFO] [stderr] Checking scarecrow v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sgd.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | rate: rate, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sgd.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | epochs: epochs, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `epochs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sgd.rs:22:13 [INFO] [stderr] --> src/sgd.rs:64:50 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 64 | updates.push_back(LayerUpdates { ws: ws, bs: bs }); [INFO] [stderr] 22 | rate: rate, [INFO] [stderr] | ^^^^^^ help: replace it with: `ws` [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rate` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] --> src/sgd.rs:64:58 [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sgd.rs:23:13 [INFO] [stderr] 64 | updates.push_back(LayerUpdates { ws: ws, bs: bs }); [INFO] [stderr] | [INFO] [stderr] | ^^^^^^ help: replace it with: `bs` [INFO] [stderr] 23 | epochs: epochs, [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `epochs` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] --> src/sgd.rs:74:25 [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] 74 | inputs: inputs, [INFO] [stderr] --> src/sgd.rs:64:50 [INFO] [stderr] | [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inputs` [INFO] [stderr] | [INFO] [stderr] 64 | updates.push_back(LayerUpdates { ws: ws, bs: bs }); [INFO] [stderr] | ^^^^^^ help: replace it with: `ws` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sgd.rs:64:58 [INFO] [stderr] | [INFO] [stderr] 64 | updates.push_back(LayerUpdates { ws: ws, bs: bs }); [INFO] [stderr] | ^^^^^^ help: replace it with: `bs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sgd.rs:74:25 [INFO] [stderr] | [INFO] [stderr] 74 | inputs: inputs, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inputs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/layers.rs:314:36 [INFO] [stderr] | [INFO] [stderr] 314 | let expected = vec![-1.0, -0.7615942, 0.0, 0.7615942, 1.0]; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.761_594_2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/layers.rs:314:52 [INFO] [stderr] | [INFO] [stderr] 314 | let expected = vec![-1.0, -0.7615942, 0.0, 0.7615942, 1.0]; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.761_594_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/layers.rs:316:36 [INFO] [stderr] | [INFO] [stderr] 316 | assert_eq!(l.output(&vec![-999999.0, -1.0, 0.0, 1.0, 999999.0]), [INFO] [stderr] | ^^^^^^^^ help: consider: `999_999.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/layers.rs:316:62 [INFO] [stderr] | [INFO] [stderr] 316 | assert_eq!(l.output(&vec![-999999.0, -1.0, 0.0, 1.0, 999999.0]), [INFO] [stderr] | ^^^^^^^^ help: consider: `999_999.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/layers.rs:332:34 [INFO] [stderr] | [INFO] [stderr] 332 | let expected = vec![0.0, 0.26894143, 0.5, 0.7310586, 1.0]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.268_941_43` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/layers.rs:332:51 [INFO] [stderr] | [INFO] [stderr] 332 | let expected = vec![0.0, 0.26894143, 0.5, 0.7310586, 1.0]; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.731_058_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/layers.rs:334:36 [INFO] [stderr] | [INFO] [stderr] 334 | assert_eq!(l.output(&vec![-999999.0, -1.0, 0.0, 1.0, 999999.0]), [INFO] [stderr] | ^^^^^^^^ help: consider: `999_999.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/layers.rs:334:62 [INFO] [stderr] | [INFO] [stderr] 334 | assert_eq!(l.output(&vec![-999999.0, -1.0, 0.0, 1.0, 999999.0]), [INFO] [stderr] | ^^^^^^^^ help: consider: `999_999.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/layers.rs:352:36 [INFO] [stderr] | [INFO] [stderr] 352 | assert_eq!(l.output(&vec![-999999.0, -1.0, 0.0, 1.0, 999.0]), expected); [INFO] [stderr] | ^^^^^^^^ help: consider: `999_999.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/layers.rs:358:34 [INFO] [stderr] | [INFO] [stderr] 358 | let expected = vec![0.0, 0.26894143, 0.5, 0.7310586, 1.0]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.268_941_43` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/layers.rs:358:51 [INFO] [stderr] | [INFO] [stderr] 358 | let expected = vec![0.0, 0.26894143, 0.5, 0.7310586, 1.0]; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.731_058_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/layers.rs:361:47 [INFO] [stderr] | [INFO] [stderr] 361 | &vec![-999999.0, -1.0, 0.0, 1.0, 999.0]), [INFO] [stderr] | ^^^^^^^^ help: consider: `999_999.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/traits.rs:44:49 [INFO] [stderr] | [INFO] [stderr] 44 | self.delta_from_outputs(delta, outputs).or(self.delta_from_inputs(delta, inputs)).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.delta_from_inputs(delta, inputs))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/sgd.rs:28:34 [INFO] [stderr] | [INFO] [stderr] 28 | fn weight_step(&self, layer: &Box, inputs: &[f32], delta: &[f32]) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&WeightedLayer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/sgd.rs:44:32 [INFO] [stderr] | [INFO] [stderr] 44 | fn bias_step(&self, layer: &Box, delta: &[f32]) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&WeightedLayer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/traits.rs:44:49 [INFO] [stderr] | [INFO] [stderr] 44 | self.delta_from_outputs(delta, outputs).or(self.delta_from_inputs(delta, inputs)).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.delta_from_inputs(delta, inputs))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/layers.rs:279:29 [INFO] [stderr] | [INFO] [stderr] 279 | assert_eq!(l.output(&vec![1.0, -1.0]), vec![-1.4, -1.3, -0.7]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1.0, -1.0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/layers.rs:293:40 [INFO] [stderr] | [INFO] [stderr] 293 | assert_eq!(l.delta_from_inputs(&vec![1.0, 1.0, 1.0], &x), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1.0, 1.0, 1.0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/layers.rs:316:29 [INFO] [stderr] | [INFO] [stderr] 316 | assert_eq!(l.output(&vec![-999999.0, -1.0, 0.0, 1.0, 999999.0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[-999999.0, -1.0, 0.0, 1.0, 999999.0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/layers.rs:325:41 [INFO] [stderr] | [INFO] [stderr] 325 | assert_eq!(l.delta_from_outputs(&vec![1.0, 1.0, 1.0], &vec![0.0, 1.0, 2.0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1.0, 1.0, 1.0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/layers.rs:325:63 [INFO] [stderr] | [INFO] [stderr] 325 | assert_eq!(l.delta_from_outputs(&vec![1.0, 1.0, 1.0], &vec![0.0, 1.0, 2.0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0.0, 1.0, 2.0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/layers.rs:334:29 [INFO] [stderr] | [INFO] [stderr] 334 | assert_eq!(l.output(&vec![-999999.0, -1.0, 0.0, 1.0, 999999.0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[-999999.0, -1.0, 0.0, 1.0, 999999.0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/layers.rs:343:41 [INFO] [stderr] | [INFO] [stderr] 343 | assert_eq!(l.delta_from_outputs(&vec![1.0, 1.0, 1.0], &vec![0.0, 0.5, 1.0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1.0, 1.0, 1.0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/layers.rs:343:63 [INFO] [stderr] | [INFO] [stderr] 343 | assert_eq!(l.delta_from_outputs(&vec![1.0, 1.0, 1.0], &vec![0.0, 0.5, 1.0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0.0, 0.5, 1.0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/layers.rs:352:29 [INFO] [stderr] | [INFO] [stderr] 352 | assert_eq!(l.output(&vec![-999999.0, -1.0, 0.0, 1.0, 999.0]), expected); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[-999999.0, -1.0, 0.0, 1.0, 999.0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/layers.rs:360:40 [INFO] [stderr] | [INFO] [stderr] 360 | assert_eq!(l.delta_from_inputs(&vec![1.0, 1.0, 1.0, 1.0, 1.0], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1.0, 1.0, 1.0, 1.0, 1.0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/layers.rs:361:40 [INFO] [stderr] | [INFO] [stderr] 361 | &vec![-999999.0, -1.0, 0.0, 1.0, 999.0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[-999999.0, -1.0, 0.0, 1.0, 999.0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/sgd.rs:28:34 [INFO] [stderr] | [INFO] [stderr] 28 | fn weight_step(&self, layer: &Box, inputs: &[f32], delta: &[f32]) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&WeightedLayer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/sgd.rs:44:32 [INFO] [stderr] | [INFO] [stderr] 44 | fn bias_step(&self, layer: &Box, delta: &[f32]) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&WeightedLayer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.34s [INFO] running `"docker" "inspect" "085b19f992064d5e041b72c1445ac131aa26dc60fb8f9a91c52f0276f3b23654"` [INFO] running `"docker" "rm" "-f" "085b19f992064d5e041b72c1445ac131aa26dc60fb8f9a91c52f0276f3b23654"` [INFO] [stdout] 085b19f992064d5e041b72c1445ac131aa26dc60fb8f9a91c52f0276f3b23654